77429 2012-01-31 06:09:58 -0800 [Chromium] ChromeClientImpl::dispatchViewportPropertiesDidChange is repeatedly called in Google News 2012-01-31 14:42:48 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 70559 1 fsamuel fsamuel aelias fishd rjkroege webkit.review.bot oldest_to_newest 545985 0 fsamuel 2012-01-31 06:09:58 -0800 m_webView->isPageScaleFactorSet() is tested in ChromeClientImpl::layoutUpdated, and it is never true, because WebViewImpl::setPageScaleFactorPreservingScrollOffset is called repeatedly and exits early and thus never calls WebViewImpl::setPageScaleFactor which sets the flag. The simplest solution is to simply get rid of the early return in WebViewImpl::setPageScaleFactorPreservingScrollOffset. 545995 1 124718 fsamuel 2012-01-31 06:30:24 -0800 Created attachment 124718 Patch 545996 2 webkit.review.bot 2012-01-31 06:32:33 -0800 Attachment 124718 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource From git://git.webkit.org/WebKit baf92d92..7fbc464 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 106356 = baf92d9262faea6b0ee0b2ada47f821fc179c331 r106357 = 7fbc464108a336b4b5cc9d5561e013ca51529334 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style. 546401 3 124718 fishd 2012-01-31 13:00:20 -0800 Comment on attachment 124718 Patch Is there a way to write a regression test for this bug? 546433 4 fsamuel 2012-01-31 13:27:50 -0800 (In reply to comment #3) > (From update of attachment 124718 [details]) > Is there a way to write a regression test for this bug? I'm not sure how, the viewport gets recomputed but nothing changes from the perspective of the webpage so I don't know how to write a layout test for this. The problem is unnecessary work is being done that just burns cycles. 546514 5 124718 webkit.review.bot 2012-01-31 14:42:42 -0800 Comment on attachment 124718 Patch Clearing flags on attachment: 124718 Committed r106395: <http://trac.webkit.org/changeset/106395> 546515 6 webkit.review.bot 2012-01-31 14:42:48 -0800 All reviewed patches have been landed. Closing bug. 124718 2012-01-31 06:30:24 -0800 2012-01-31 14:42:42 -0800 Patch bug-77429-20120131093023.patch text/plain 1969 fsamuel U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDk1ZTIxNDI5NzI5NWNiNzE2YTI2ODA5NDBkNDI4NzZjODMwMjFmN2EuLjNhZjEzNTNmMmU0NjMy YjUxYjIyZDRjNWMyYWM2ZTU1M2Y3YTMzMmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTItMDEtMzEgIEZhZHkgU2FtdWVsICA8ZnNhbXVlbEBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBDaHJvbWVDbGllbnRJbXBsOjpkaXNwYXRjaFZp ZXdwb3J0UHJvcGVydGllc0RpZENoYW5nZSBpcyByZXBlYXRlZGx5IGNhbGxlZCBpbiBHb29nbGUg TmV3cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc0 MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBtX3dl YlZpZXctPmlzUGFnZVNjYWxlRmFjdG9yU2V0KCkgaXMgdGVzdGVkIGluIENocm9tZUNsaWVudElt cGw6OmxheW91dFVwZGF0ZWQsIGFuZCBpdCBpcyBuZXZlciB0cnVlLCAKKyAgICAgICAgYmVjYXVz ZSBXZWJWaWV3SW1wbDo6c2V0UGFnZVNjYWxlRmFjdG9yUHJlc2VydmluZ1Njcm9sbE9mZnNldCBp cyBjYWxsZWQgcmVwZWF0ZWRseSBhbmQgZXhpdHMgZWFybHkgCisgICAgICAgIGFuZCB0aHVzIG5l dmVyIGNhbGxzIFdlYlZpZXdJbXBsOjpzZXRQYWdlU2NhbGVGYWN0b3Igd2hpY2ggc2V0cyB0aGUg ZmxhZy4KKyAgICAgICAgCisgICAgICAgIFRoZSBzaW1wbGVzdCBzb2x1dGlvbiBpcyB0byBzaW1w bHkgZ2V0IHJpZCBvZiB0aGUgZWFybHkgcmV0dXJuIGluIAorICAgICAgICBXZWJWaWV3SW1wbDo6 c2V0UGFnZVNjYWxlRmFjdG9yUHJlc2VydmluZ1Njcm9sbE9mZnNldC4KKworICAgICAgICAqIHNy Yy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpzZXRQYWdl U2NhbGVGYWN0b3JQcmVzZXJ2aW5nU2Nyb2xsT2Zmc2V0KToKKwogMjAxMi0wMS0yNiAgS2VudCBU YW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBDbGVhbnVw IG9mIFdlYlBvcHVwTWVudUltcGwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJ bXBsLmNwcAppbmRleCA5NGNkNDVlYjUyNDhlOWNhMzU5NzAxZGMyMWY3MDY4MmY3ODcwODMyLi40 ZjIxMGNiZTE2OTVhMzJlMzg0YTVlZDczMjFhNTViYjJkY2E1NmVlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCkBAIC0yMDE5LDggKzIwMTksNiBAQCB2b2lk IFdlYlZpZXdJbXBsOjpzZXRQYWdlU2NhbGVGYWN0b3JQcmVzZXJ2aW5nU2Nyb2xsT2Zmc2V0KGZs b2F0IHNjYWxlRmFjdG9yKQogewogICAgIC8vIFBpY2sgYSBzY2FsZSBmYWN0b3IgdGhhdCBpcyB3 aXRoaW4gdGhlIGV4cGVjdGVkIGxpbWl0cwogICAgIHNjYWxlRmFjdG9yID0gY2xhbXBQYWdlU2Nh bGVGYWN0b3JUb0xpbWl0cyhzY2FsZUZhY3Rvcik7Ci0gICAgaWYgKHNjYWxlRmFjdG9yID09IHBh Z2VTY2FsZUZhY3RvcigpKQotICAgICAgICByZXR1cm47CiAKICAgICBJbnRQb2ludCBzY3JvbGxP ZmZzZXRBdE5ld1NjYWxlKG1haW5GcmFtZSgpLT5zY3JvbGxPZmZzZXQoKS53aWR0aCwgbWFpbkZy YW1lKCktPnNjcm9sbE9mZnNldCgpLmhlaWdodCk7CiAgICAgZmxvYXQgZGVsdGFTY2FsZSA9IHNj YWxlRmFjdG9yIC8gcGFnZVNjYWxlRmFjdG9yKCk7Cg==