<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>77391</bug_id>
          
          <creation_ts>2012-01-30 17:52:18 -0800</creation_ts>
          <short_desc>Hidden form elements do not save their state prior to form submission</short_desc>
          <delta_ts>2012-06-19 09:32:43 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Forms</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#hidden-state-(type=hidden)</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jon Lee">jonlee</reporter>
          <assigned_to name="Jon Lee">jonlee</assigned_to>
          <cc>beidson</cc>
    
    <cc>isherman</cc>
    
    <cc>priyajeet.hora</cc>
    
    <cc>tkent</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>545661</commentid>
    <comment_count>0</comment_count>
    <who name="Jon Lee">jonlee</who>
    <bug_when>2012-01-30 17:52:18 -0800</bug_when>
    <thetext>Hidden form elements has a value attribute in mode default, in contrast to most other form elements that work in value mode. Default mode clobbers the strings returned by value() and defaultValue(), which means that the input&apos;s state is not saved. When you go back to the page that had the hidden form element, its value is not restored to what it was immediately prior to submission.

&lt;rdar://problem/10563108&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>546346</commentid>
    <comment_count>1</comment_count>
      <attachid>124793</attachid>
    <who name="Jon Lee">jonlee</who>
    <bug_when>2012-01-31 12:09:19 -0800</bug_when>
    <thetext>Created attachment 124793
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>546347</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-01-31 12:12:19 -0800</bug_when>
    <thetext>Attachment 124793 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/update-webkit&apos;]&quot; exit_code: 9

Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: Fix compilation errors on build-webkit --debug --no-workers on mac.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging LayoutTests/platform/qt/Skipped
CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Auto-merging Source/WebCore/WebCore.exp.in
Auto-merging Source/WebKit/mac/ChangeLog
CONFLICT (content): Merge conflict in Source/WebKit/mac/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac.

When you have resolved this problem run &quot;git rebase --continue&quot;.
If you would prefer to skip this patch, instead run &quot;git rebase --skip&quot;.
To restore the original branch and stop rebasing run &quot;git rebase --abort&quot;.

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>546371</commentid>
    <comment_count>3</comment_count>
      <attachid>124793</attachid>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2012-01-31 12:35:25 -0800</bug_when>
    <thetext>Comment on attachment 124793
Patch

lol, really that easy huh?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>546454</commentid>
    <comment_count>4</comment_count>
    <who name="Jon Lee">jonlee</who>
    <bug_when>2012-01-31 13:44:13 -0800</bug_when>
    <thetext>Committed r106388: &lt;http://trac.webkit.org/changeset/106388&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>546463</commentid>
    <comment_count>5</comment_count>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2012-01-31 13:53:02 -0800</bug_when>
    <thetext>We stopped saving the value of the hidden type intentionally.  See Bug 23346.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>546470</commentid>
    <comment_count>6</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2012-01-31 14:01:22 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; We stopped saving the value of the hidden type intentionally.  See Bug 23346.

In what bug and/or revision did we actually *stop* saving/restoring form values for hidden elements on back navigation?  I don&apos;t remember being part of the conscious decision to do so and probably would&apos;ve objected.

Bug 23346 has a single r-&apos;ed patch in it.  It&apos;s been so long since activity there I don&apos;t remember details about the hubbub.  But on the surface it seems to be about fixing the incorrect restoration, and not disabling restoration.

Regardless, this bug was generated by a few very real world sites that are broken since we don&apos;t do this for hidden elements, so the fix needs to stand...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>546487</commentid>
    <comment_count>7</comment_count>
    <who name="Jon Lee">jonlee</who>
    <bug_when>2012-01-31 14:17:53 -0800</bug_when>
    <thetext>(In reply to comment #6)
&gt; Regardless, this bug was generated by a few very real world sites that are broken since we don&apos;t do this for hidden elements, so the fix needs to stand...

To that point, with this fix we will be matching Firefox&apos;s behavior.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>547595</commentid>
    <comment_count>8</comment_count>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2012-02-01 20:09:21 -0800</bug_when>
    <thetext>Please look at Bug 26241 http://trac.webkit.org/changeset/57013 .
Bug 23346 also have some discussion about it.

Type=hidden is often used for session keys, which can be refreshed by page reload, and the current implementation of WebCore often restores form control values to incorrect form controls.  Updating non user-editable controls like type=hidden is dangerous.

I think we should save/restore type=hidden values if
 - The value was updated during user gesture events
 - WebCore restores values to the correct controls.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>547615</commentid>
    <comment_count>9</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2012-02-01 21:04:46 -0800</bug_when>
    <thetext>(In reply to comment #8)
&gt; Please look at Bug 26241 http://trac.webkit.org/changeset/57013 .
&gt; Bug 23346 also have some discussion about it.
&gt; 
&gt; Type=hidden is often used for session keys, which can be refreshed by page reload, and the current implementation of WebCore often restores form control values to incorrect form controls.  Updating non user-editable controls like type=hidden is dangerous.
&gt; 
&gt; I think we should save/restore type=hidden values if
&gt;  - The value was updated during user gesture events
&gt;  - WebCore restores values to the correct controls.

I think we should save/restore type=hidden values if it is important to big websites, or important types of websites.  And it is:  More than one large bank has been requesting this.

So combining my &quot;should do this&quot; with your &quot;should do this&quot;, I think we simply need to fix the bug where we might restore values to the wrong form control.

I&apos;m not nearly as concern that auto generated session keys in hidden form controls are of concern.  Do you know of a real website that would break if we didn&apos;t also do the user gesture check?

Jon Lee might know more about the specific cases we&apos;ve been looking at and can comment on this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>649883</commentid>
    <comment_count>10</comment_count>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2012-06-14 22:28:10 -0700</bug_when>
    <thetext>Jon, what&apos;s the requirement for the bank site?
Does saving hidden values updated during UserGestureIndicator::processingUserGesture() solve the bank issue?
Does saving hidden values updated after HTMLInputElement::finishParsingChildren() solve the bank issue?
Does dispatching &apos;change&apos; events on restoring other field values solve the bank issue?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>652219</commentid>
    <comment_count>11</comment_count>
    <who name="Jon Lee">jonlee</who>
    <bug_when>2012-06-19 01:42:14 -0700</bug_when>
    <thetext>(In reply to comment #10)
&gt; Jon, what&apos;s the requirement for the bank site?
&gt; Does saving hidden values updated during UserGestureIndicator::processingUserGesture() solve the bank issue?
&gt; Does saving hidden values updated after HTMLInputElement::finishParsingChildren() solve the bank issue?
&gt; Does dispatching &apos;change&apos; events on restoring other field values solve the bank issue?

Sorry for the delay in response.

I actually am not totally sure what the requirement is, because the code that I received exhibiting the bug was only a simplified example. It is also unclear if this is the only situation in which they need hidden form fields to be restored.

But in the provided example, there is a link in an iframe, and upon clicking, it calls a JS function that alters the hidden form field and submit that field&apos;s owning form. The expectation is that the field&apos;s value remains what it was immediately prior to the submit upon back navigation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>652238</commentid>
    <comment_count>12</comment_count>
    <who name="Darth">priyajeet.hora</who>
    <bug_when>2012-06-19 02:03:59 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; The expectation is that the field&apos;s value remains what it was immediately prior to the submit upon back navigation.

Dunno, but isn&apos;t that kinda risky? For example in our case (accounting, money related) it caused serious issues. Our form was dynamically generated, so when back was pressed, it re-generated that form with correct values from the back end, but then the browser over wrote those values with what was previously submitted - stale values.

Maybe when a network action happens based on a user gesture, like a form submit, the back and forth navigation should not auto-complete stuff that is not visible to the user? For stuff that is visible, there is at least the visual sanity check that a user can do prior to a re-submit.

Or perhaps one can check the page cache control directive, if its no-store / no-cache, then don&apos;t fill the prior values, at least for hidden fields?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>652293</commentid>
    <comment_count>13</comment_count>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2012-06-19 03:30:04 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; (In reply to comment #10)
&gt; &gt; Jon, what&apos;s the requirement for the bank site?
&gt; &gt; Does saving hidden values updated during UserGestureIndicator::processingUserGesture() solve the bank issue?
&gt; &gt; Does saving hidden values updated after HTMLInputElement::finishParsingChildren() solve the bank issue?
&gt; &gt; Does dispatching &apos;change&apos; events on restoring other field values solve the bank issue?
&gt; 
&gt; Sorry for the delay in response.
&gt; 
&gt; I actually am not totally sure what the requirement is, because the code that I received exhibiting the bug was only a simplified example. It is also unclear if this is the only situation in which they need hidden form fields to be restored.
&gt; 
&gt; But in the provided example, there is a link in an iframe, and upon clicking, it calls a JS function that alters the hidden form field and submit that field&apos;s owning form. The expectation is that the field&apos;s value remains what it was immediately prior to the submit upon back navigation.

Thank you for the reply.
I think the second one (saving hidden values updated after HTMLInputElement::finishParsingChildren()) is the safest for Bug 88685.

Darth,
FYI. Adding autocomplete=off to a &lt;form&gt; prevents value restoring.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>652521</commentid>
    <comment_count>14</comment_count>
    <who name="Darth">priyajeet.hora</who>
    <bug_when>2012-06-19 09:28:06 -0700</bug_when>
    <thetext>(In reply to comment #13)
&gt; FYI. Adding autocomplete=off to a &lt;form&gt; prevents value restoring.

Yeah, thats what I ended up doing, just that some users liked some stuff getting auto filled.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>652524</commentid>
    <comment_count>15</comment_count>
    <who name="Jon Lee">jonlee</who>
    <bug_when>2012-06-19 09:32:43 -0700</bug_when>
    <thetext>You should be able to attach autocomplete on the elements you wish to have autocomplete on to override the form&apos;s autocomplete bit.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>124793</attachid>
            <date>2012-01-31 12:09:19 -0800</date>
            <delta_ts>2012-01-31 12:35:25 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-77391-20120131120935.patch</filename>
            <type>text/plain</type>
            <size>6092</size>
            <attacher name="Jon Lee">jonlee</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2Mjk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmE5NjczZGY4OTk3MDg1
NTdjYWJmMDA3MWVlMDYzNTA5M2M4ZTNjMy4uNjRhZDk3MDM3M2MxZDc5ODM0M2VjOWMyMzViYzc0
YTBiYWE1ODFjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAxLTMxICBKb24g
TGVlICA8am9ubGVlQGFwcGxlLmNvbT4KKworICAgICAgICBIaWRkZW4gZm9ybSBlbGVtZW50cyBk
byBub3Qgc2F2ZSB0aGVpciBzdGF0ZSBwcmlvciB0byBmb3JtIHN1Ym1pc3Npb24KKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3MzkxCisgICAgICAgIDxy
ZGFyOi8vcHJvYmxlbS8xMDU2MzEwOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0L2Zvcm1zL3N0YXRlLXJlc3RvcmUtaGlkZGVuLmh0
bWwKKworICAgICAgICAqIGh0bWwvSGlkZGVuSW5wdXRUeXBlLmNwcDogVGVhY2ggaGlkZGVuIGlu
cHV0cyB0byBzYXZlIGFuZCByZXN0b3JlIHRoZWlyIHN0YXRlLgorICAgICAgICAoV2ViQ29yZTo6
SGlkZGVuSW5wdXRUeXBlOjpzYXZlRm9ybUNvbnRyb2xTdGF0ZSk6CisgICAgICAgIChXZWJDb3Jl
OjpIaWRkZW5JbnB1dFR5cGU6OnJlc3RvcmVGb3JtQ29udHJvbFN0YXRlKToKKyAgICAgICAgKiBo
dG1sL0hpZGRlbklucHV0VHlwZS5oOgorICAgICAgICAoSGlkZGVuSW5wdXRUeXBlKToKKwogMjAx
Mi0wMS0zMCAgTGV2aSBXZWludHJhdWIgIDxsZXZpd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg
IW1faW5zaWRlUmVnaW9uUGFpbnQgYXNzZXJ0aW9uIGluIFJlbmRlclJlZ2lvbi5jcHAgaXMgaW52
YWxpZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IaWRkZW5JbnB1dFR5cGUuY3Bw
IGIvU291cmNlL1dlYkNvcmUvaHRtbC9IaWRkZW5JbnB1dFR5cGUuY3BwCmluZGV4IGNjM2FiNWEw
MjQ3YmIyNWVjN2Q1NzUyYzE1N2Q1M2RjMzc3ZWY3OWEuLmZjMTAzOTc1Yjc5ODllNTM2NDViZjg3
NzRmYzk5OGFiMTAyYTAxNjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSGlkZGVu
SW5wdXRUeXBlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hpZGRlbklucHV0VHlwZS5j
cHAKQEAgLTQ2LDEwICs0NiwyMiBAQCBQYXNzT3duUHRyPElucHV0VHlwZT4gSGlkZGVuSW5wdXRU
eXBlOjpjcmVhdGUoSFRNTElucHV0RWxlbWVudCogZWxlbWVudCkKICAgICByZXR1cm4gYWRvcHRQ
dHIobmV3IEhpZGRlbklucHV0VHlwZShlbGVtZW50KSk7CiB9CiAKLWNvbnN0IEF0b21pY1N0cmlu
ZyYgSGlkZGVuSW5wdXRUeXBlOjpmb3JtQ29udHJvbFR5cGUoKSBjb25zdCB7Citjb25zdCBBdG9t
aWNTdHJpbmcmIEhpZGRlbklucHV0VHlwZTo6Zm9ybUNvbnRyb2xUeXBlKCkgY29uc3QKK3sKICAg
ICByZXR1cm4gSW5wdXRUeXBlTmFtZXM6OmhpZGRlbigpOwogfQogCitib29sIEhpZGRlbklucHV0
VHlwZTo6c2F2ZUZvcm1Db250cm9sU3RhdGUoU3RyaW5nJiByZXN1bHQpIGNvbnN0Cit7CisgICAg
cmVzdWx0ID0gZWxlbWVudCgpLT52YWx1ZSgpOworICAgIHJldHVybiB0cnVlOworfQorCit2b2lk
IEhpZGRlbklucHV0VHlwZTo6cmVzdG9yZUZvcm1Db250cm9sU3RhdGUoY29uc3QgU3RyaW5nJiBz
dHJpbmcpIGNvbnN0Cit7CisgICAgZWxlbWVudCgpLT5zZXRBdHRyaWJ1dGUodmFsdWVBdHRyLCBz
dHJpbmcpOworfQorCiBib29sIEhpZGRlbklucHV0VHlwZTo6c3VwcG9ydHNWYWxpZGF0aW9uKCkg
Y29uc3QKIHsKICAgICByZXR1cm4gZmFsc2U7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o
dG1sL0hpZGRlbklucHV0VHlwZS5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IaWRkZW5JbnB1dFR5
cGUuaAppbmRleCAwN2EzZmVjZGY1ODAzNzI1OTI3ZjMzNDNjNDg3ZmRiY2M0M2YxMGQ5Li5mZDg2
ZmJjMWZkOWE5NTU2ODcyY2I3YjEwYzYyZjljOTAzN2QyMTgyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViQ29yZS9odG1sL0hpZGRlbklucHV0VHlwZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv
SGlkZGVuSW5wdXRUeXBlLmgKQEAgLTQyLDYgKzQyLDggQEAgcHVibGljOgogcHJpdmF0ZToKICAg
ICBIaWRkZW5JbnB1dFR5cGUoSFRNTElucHV0RWxlbWVudCogZWxlbWVudCkgOiBJbnB1dFR5cGUo
ZWxlbWVudCkgeyB9CiAgICAgdmlydHVhbCBjb25zdCBBdG9taWNTdHJpbmcmIGZvcm1Db250cm9s
VHlwZSgpIGNvbnN0IE9WRVJSSURFOworICAgIHZpcnR1YWwgYm9vbCBzYXZlRm9ybUNvbnRyb2xT
dGF0ZShTdHJpbmcmKSBjb25zdCBPVkVSUklERTsKKyAgICB2aXJ0dWFsIHZvaWQgcmVzdG9yZUZv
cm1Db250cm9sU3RhdGUoY29uc3QgU3RyaW5nJikgY29uc3QgT1ZFUlJJREU7CiAgICAgdmlydHVh
bCBib29sIHN1cHBvcnRzVmFsaWRhdGlvbigpIGNvbnN0IE9WRVJSSURFOwogICAgIHZpcnR1YWwg
UmVuZGVyT2JqZWN0KiBjcmVhdGVSZW5kZXJlcihSZW5kZXJBcmVuYSosIFJlbmRlclN0eWxlKikg
Y29uc3QgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIGFjY2Vzc0tleUFjdGlvbihib29sIHNl
bmRNb3VzZUV2ZW50cykgT1ZFUlJJREU7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWJiZWJiNjQ0NGMyYjBmNmExMThjYjJl
MTJiZjljOGE0NDJjYzE2ZC4uYjRhYTAzMjdmOWVhYTYwZDE5MTk2YjlkNzYzY2MzOTUyZGE0OTAw
ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0No
YW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAxLTMxICBKb24gTGVlICA8am9ubGVlQGFw
cGxlLmNvbT4KKworICAgICAgICBIaWRkZW4gZm9ybSBlbGVtZW50cyBkbyBub3Qgc2F2ZSB0aGVp
ciBzdGF0ZSBwcmlvciB0byBmb3JtIHN1Ym1pc3Npb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3MzkxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8x
MDU2MzEwOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICBUaGUgdGVzdCBjaGFuZ2VzIHRoZSB2YWx1ZSBvZiB0aGUgaGlkZGVuIGlucHV0IGVsZW1lbnQg
dmlhIEphdmFzY3JpcHQgcHJpb3IgdG8KKyAgICAgICAgc3VibWl0dGluZyB0aGUgZm9ybS4gVGhl
IGZvcm0gYWN0aW9uIGdvZXMgYmFjayBvbmUgcGFnZSwgYW5kIHdlIGNoZWNrIHRvIHNlZQorICAg
ICAgICB0aGF0IHRoZSBoaWRkZW4gaW5wdXQgdmFsdWUgaXMgd2hhdCBpdCB3YXMgc2V0IHRvIGJ5
IEphdmFzY3JpcHQsIHJhdGhlciB0aGFuIHdoYXQKKyAgICAgICAgaXQgd2FzIG9yaWdpbmFsbHkg
YXNzaWduZWQuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3N0YXRlLXJlc3RvcmUtaGlkZGVuLWV4
cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy9zdGF0ZS1yZXN0b3JlLWhp
ZGRlbi5odG1sOiBBZGRlZC4KKwogMjAxMi0wMS0zMCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21p
dW0ub3JnPgogCiAgICAgICAgIGNzczMvZmxleGJveC9jcm9zcy1heGlzLXNjcm9sbGJhci5odG1s
IHJlZiB0ZXN0IGZhaWxzIG9uIFdpbmRvd3MgQ2hyb21pdW0gYm90cwpkaWZmIC0tZ2l0IGEvTGF5
b3V0VGVzdHMvZmFzdC9mb3Jtcy9zdGF0ZS1yZXN0b3JlLWhpZGRlbi1leHBlY3RlZC50eHQgYi9M
YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3N0YXRlLXJlc3RvcmUtaGlkZGVuLWV4cGVjdGVkLnR4dApu
ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwLi41ZGUxYjI4Nzk3ZDQ1OGUzZThmZWUwODRiZGI5NGMwODk1NzE5YzE4Ci0tLSAv
ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zdGF0ZS1yZXN0b3JlLWhpZGRl
bi1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMSBAQAorQnVnIDc3MzkxIC0gSGlkZGVuIGZvcm0g
ZWxlbWVudHMgZG8gbm90IHNhdmUgdGhlaXIgc3RhdGUgcHJpb3IgdG8gZm9ybSBzdWJtaXNzaW9u
CisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMs
IGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGRvY3VtZW50LmYuaGlkZGVu
LnZhbHVlIGlzICJhZnRlciIKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVT
VCBDT01QTEVURQorCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc3RhdGUt
cmVzdG9yZS1oaWRkZW4uaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc3RhdGUtcmVzdG9y
ZS1oaWRkZW4uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45MGU0ZDRkYzcyMDlhZWJjNDk4YTVkNzhjYWZhOWMy
YTBlOWU2YzJhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zdGF0
ZS1yZXN0b3JlLWhpZGRlbi5odG1sCkBAIC0wLDAgKzEsNDUgQEAKKzwhRE9DVFlQRSBodG1sPgor
PGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUu
anMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorCis8ZGl2
IGlkPSJjb25zb2xlIj48L2Rpdj4KKworPGlucHV0IGlkPSJlbXB0eU9uRmlyc3RWaXNpdCIgLz4K
Kzxmb3JtIGFjdGlvbj0iZGF0YTp0ZXh0L2h0bWwsPHNjcmlwdD5oaXN0b3J5LmJhY2soKSZsdDsv
c2NyaXB0PiIgbmFtZT1mPgorICAgIDxpbnB1dCB0eXBlPSJoaWRkZW4iIG5hbWU9ImhpZGRlbiIg
dmFsdWU9ImJlZm9yZSIgLz4KKzwvZm9ybT4KKworPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCJCdWcg
NzczOTEgLSBIaWRkZW4gZm9ybSBlbGVtZW50cyBkbyBub3Qgc2F2ZSB0aGVpciBzdGF0ZSBwcmlv
ciB0byBmb3JtIHN1Ym1pc3Npb24iKTsKKworZnVuY3Rpb24gcnVuVGVzdCgpIHsKKyAgICB2YXIg
c3RhdGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZW1wdHlPbkZpcnN0VmlzaXQiKTsKKyAg
ICBpZiAoIXN0YXRlLnZhbHVlKSB7CisgICAgICAgIC8vIEZpcnN0IHZpc2l0LgorICAgICAgICBp
ZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENv
bnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworICAgICAgICBzdGF0ZS52YWx1ZSA9ICJ2aXNpdGVk
IjsKKworICAgICAgICBkb2N1bWVudC5mLmhpZGRlbi52YWx1ZSA9ICJhZnRlciI7CisgICAgICAg
IC8vIFN1Ym1pdCBmb3JtIGluIGEgdGltZW91dCB0byBtYWtlIHN1cmUgdGhhdCB3ZSBjcmVhdGUg
YSBuZXcgYmFjay9mb3J3YXJkIGxpc3QgaXRlbS4KKyAgICAgICAgc2V0VGltZW91dChmdW5jdGlv
bigpIHtkb2N1bWVudC5mLnN1Ym1pdCgpO30sIDApOworICAgIH0gZWxzZSB7CisgICAgICAgIC8v
IFNlY29uZCB2aXNpdC4KKyAgICAgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJkb2N1bWVudC5m
LmhpZGRlbi52YWx1ZSIsICJhZnRlciIpOworICAgICAgICBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0
cnVlOworICAgICAgICAKKyAgICAgICAgdmFyIHNjcmlwdCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1l
bnQoJ3NjcmlwdCcpOworICAgICAgICBzY3JpcHQuc3JjID0gIi4uL2pzL3Jlc291cmNlcy9qcy10
ZXN0LXBvc3QuanMiOworICAgICAgICBzY3JpcHQudHlwZSA9ICJ0ZXh0L2phdmFzY3JpcHQiOwor
ICAgICAgICBzY3JpcHQub25sb2FkID0gZnVuY3Rpb24oKSB7CisgICAgICAgICAgICBpZiAod2lu
ZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250
cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAgICAgICAgfTsKKyAgICAgICAgZG9jdW1lbnQuYm9keS5h
cHBlbmRDaGlsZChzY3JpcHQpOworICAgIH0KK30KKzwvc2NyaXB0PgorPC9ib2R5Pgo=
</data>
<flag name="review"
          id="126144"
          type_id="1"
          status="+"
          setter="beidson"
    />
          </attachment>
      

    </bug>

</bugzilla>