77350 2012-01-30 12:04:38 -0800 All mouse events after a right click are ignored when they came from WebkitTestRunner 2012-02-28 16:37:28 -0800 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 hugo.lima webkit-unassigned ap cshu hugo.lima mjs sam webkit.review.bot oldest_to_newest 545267 0 hugo.lima 2012-01-30 12:04:38 -0800 When a right click comes to WebCore and it realize that a context menu should pop up to the user it sends back a event telling the UI process to show the context menu, but as described in bug#58406, a mouse release event may already be in the CoreIPC pipeline because the UI sent it before receiving the "show context menu" event from WebProcess. To solve this issue the patch from bug#58406 added a flag to tell WebPage if it should ignore the mouse release event (or any other mouse events). WebKitTestRunner send events synchronized, so the issue reported on bug#58406 doesn't affect WebKitTestRunner, besides due to the sync nature of WebKitTestRunner it will only receive the showContextMenu (that was sent async) after it already sent all events, so all events sent after the right click event will be ignored by webcore. The proposed patch removes the check when using synchronized events making some tests that are Skipped on many webkit2 ports pass. Another possible approach would send the showContextMenu/contextMenuHidden events sync, but contextMenuHidden is only used to fix bug#58406. Please correct me if any assumptions I made are wrong. Test now passing: fast/events/mouse-click-events.html Found on following skip lists: qt-wk2/Skipped:57 efl/Skipped:1523 gtk/Skipped:839 mac-wk2/Skipped:146 win-wk2/Skipped:224 The patch only removes the test from qt-wk2 skip list, but it probably would make this test pass on other wk2 ports. 545294 1 124580 hugo.lima 2012-01-30 12:15:15 -0800 Created attachment 124580 Patch 555122 2 cshu 2012-02-13 02:00:42 -0800 Nice, have you tried to run all the tests to avoid regressions? 557301 3 hugo.lima 2012-02-15 08:35:54 -0800 I did it at the time I uploaded the patch, the results must be the same nowadays. 557409 4 124580 webkit.review.bot 2012-02-15 11:22:20 -0800 Comment on attachment 124580 Patch Rejecting attachment 124580 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ing file Source/WebKit2/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit2/WebProcess/WebPage/WebPage.cpp Hunk #1 succeeded at 1297 (offset 15 lines). patching file LayoutTests/platform/qt-wk2/Skipped Hunk #1 FAILED at 54. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt-wk2/Skipped.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Chang Shu']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11530252 558857 5 hugo.lima 2012-02-16 20:29:01 -0800 This reviewbot messge means I should rebase the patch myself and re-upload it? 559017 6 cshu 2012-02-17 00:55:41 -0800 yes,simply replace oops with reviewer's name and cq+ 564247 7 128720 hugo.lima 2012-02-24 05:43:50 -0800 Created attachment 128720 Patch 564248 8 hugo.lima 2012-02-24 05:46:03 -0800 Patch finally rebased. 567214 9 webkit.review.bot 2012-02-28 16:35:11 -0800 The commit-queue encountered the following flaky tests while processing attachment 128720: css3/filters/effect-hue-rotate-hw.html bug 79845 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch. 567219 10 128720 webkit.review.bot 2012-02-28 16:37:21 -0800 Comment on attachment 128720 Patch Clearing flags on attachment: 128720 Committed r109169: <http://trac.webkit.org/changeset/109169> 567220 11 webkit.review.bot 2012-02-28 16:37:28 -0800 All reviewed patches have been landed. Closing bug. 124580 2012-01-30 12:15:15 -0800 2012-02-24 05:43:40 -0800 Patch bug-77350-20120130171517.patch text/plain 2420 hugo.lima U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MjUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMmIzNzQzOTlkNWE0ZGZk N2EzMjg4MmFkNmJmYTBjMTdiMWRmYTdiMS4uYWM3YTUxMjUzNTAxNTIxOTBlNDQyNTAxMjFmOTdh MjYyMmVhNzUxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAxLTMwICBIdWdv IFBhcmVudGUgTGltYSAgPGh1Z28ubGltYUBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIEFsbCBt b3VzZSBldmVudHMgYWZ0ZXIgYSByaWdodCBjbGljayBhcmUgaWdub3JlZCB3aGVuIHRoZXkgY2Ft ZSBmcm9tIFdlYmtpdFRlc3RSdW5uZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTc3MzUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTmV2ZXIgaWdub3JlIG1vdXNlIGV2ZW50cyB3aGVuIHVzaW5nIHN5bmMg ZXZlbnRzLCBldmVuIGlmIHRoZSBjb250ZXh0IG1lbnUgaXMgYmVpbmcKKyAgICAgICAgc2hvdyBi dXQgdGhlIFVpIGRpZCByZXBsaWVkIHRoZSBTaG93Q29udGV4dE1lbnUgZXZlbnQgd2l0aCBhIENv bnRleHRNZW51SGlkZGVuLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2Uu Y3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjptb3VzZUV2ZW50U3luY0ZvclRlc3Rpbmcp OgorCiAyMDEyLTAxLTI2ICBObydhbSBSb3NlbnRoYWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5j b20+IGFuZCBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+CiAK ICAgICAgICAgW1F0XSBXS1RSOiBVc2UgYSBzb2Z0d2FyZSByZW5kZXJpbmcgcGlwaWxpbmUgd2hl biBydW5uaW5nIHRlc3RzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dl YlBhZ2UuY3BwCmluZGV4IDg1OWZmMzUyZmQ5ZGY2ZWRkOWI1ODNhOWYyNDczY2ViYTM3NzhiOGMu LjU2OTJmOTc1OWY5YWMxYjVmYWU2ZDBlZGUzNzJkNjg2YmJjOTg0ZGIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKQEAgLTEyODIsMTIgKzEyODIs NiBAQCB2b2lkIFdlYlBhZ2U6Om1vdXNlRXZlbnQoY29uc3QgV2ViTW91c2VFdmVudCYgbW91c2VF dmVudCkKIAogdm9pZCBXZWJQYWdlOjptb3VzZUV2ZW50U3luY0ZvclRlc3RpbmcoY29uc3QgV2Vi TW91c2VFdmVudCYgbW91c2VFdmVudCwgYm9vbCYgaGFuZGxlZCkKIHsKLSAgICAvLyBEb24ndCB0 cnkgdG8gaGFuZGxlIGFueSBwZW5kaW5nIG1vdXNlIGV2ZW50cyBpZiBhIGNvbnRleHQgbWVudSBp cyBzaG93aW5nLgotICAgIGlmIChtX2lzU2hvd2luZ0NvbnRleHRNZW51KSB7Ci0gICAgICAgIGhh bmRsZWQgPSB0cnVlOwotICAgICAgICByZXR1cm47Ci0gICAgfQotCiAgICAgaGFuZGxlZCA9IG1f cGFnZU92ZXJsYXkgJiYgbV9wYWdlT3ZlcmxheS0+bW91c2VFdmVudChtb3VzZUV2ZW50KTsKIAog ICAgIGlmICghaGFuZGxlZCkgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQt d2syL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC13azIvU2tpcHBlZAppbmRleCBl MmI1ZjdlZjc0OTMwMzE5NzliZTk0N2U1ZjMwMjRiMTA0ODIwZmM0Li4yNTY0Y2MzZmNkYjQ2YjFh N2Q0N2ZiODBhYjEyZDllY2VlZmI1OWRkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9xdC13azIvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC13azIvU2tpcHBl ZApAQCAtNTQsNyArNTQsNiBAQCBmYXN0L2V2ZW50cy9jb250ZXh0LW9ubW91c2Vkb3duLWV2ZW50 Lmh0bWwKIGZhc3QvZXZlbnRzL2NvbnRleHRtZW51LXNjcm9sbGVkLXBhZ2Utd2l0aC1mcmFtZS5o dG1sCiBmYXN0L2V2ZW50cy9jb250aW51b3VzLXBsYXRmb3JtLXdoZWVsZXZlbnQtaW4tc2Nyb2xs aW5nLWRpdi5odG1sCiBmYXN0L2V2ZW50cy9maXJlLW1vdXNlZG93bi13aGlsZS1wcmVzc2luZy1t b3VzZS1idXR0b24uaHRtbAotZmFzdC9ldmVudHMvbW91c2UtY2xpY2stZXZlbnRzLmh0bWwKIGZh c3QvZXZlbnRzL21vdXNldXAtZnJvbS1idXR0b24yLmh0bWwKIGZhc3QvZXZlbnRzL29wZW4td2lu ZG93LWZyb20tYW5vdGhlci1mcmFtZS5odG1sCiBmYXN0L2V2ZW50cy9wbGF0Zm9ybS13aGVlbGV2 ZW50LWluLXNjcm9sbGluZy1kaXYuaHRtbAo= 128720 2012-02-24 05:43:50 -0800 2012-02-28 16:37:21 -0800 Patch bug-77350-20120224104351.patch text/plain 3063 hugo.lima U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4Nzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2FiYzRhMmNiMTYxNGZl YmJjYjQ3YjYzNTgxYzNhMDQ0Y2VjZTY4Yi4uM2MzYTlhZWM5MWUzMmM1ODU3MzQ1YjNiMGVjNjdh MWQ2ZTJhOWVkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAyLTI0ICBIdWdv IFBhcmVudGUgTGltYSAgPGh1Z28ubGltYUBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIEFsbCBt b3VzZSBldmVudHMgYWZ0ZXIgYSByaWdodCBjbGljayBhcmUgaWdub3JlZCB3aGVuIHRoZXkgY2Ft ZSBmcm9tIFdlYmtpdFRlc3RSdW5uZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTc3MzUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ2hhbmcgU2h1Lgor CisgICAgICAgIE5ldmVyIGlnbm9yZSBtb3VzZSBldmVudHMgd2hlbiB1c2luZyBzeW5jIGV2ZW50 cywgZXZlbiBpZiB0aGUgY29udGV4dCBtZW51IGlzIGJlaW5nCisgICAgICAgIHNob3cgYnV0IHRo ZSBVaSBkaWQgcmVwbGllZCB0aGUgU2hvd0NvbnRleHRNZW51IGV2ZW50IHdpdGggYSBDb250ZXh0 TWVudUhpZGRlbi4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6bW91c2VFdmVudFN5bmNGb3JUZXN0aW5nKToKKwog MjAxMi0wMi0yNCAgU2hpbnlhIEthd2FuYWthICA8c2hpbnlha0BjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgU3BlbGxDaGVja1JlcXVlc3QgbmVlZHMgdG8ga25vdyB0aGUgY29udGV4dCB3aGVyZSB0 aGUgc3BlbGxjaGVjayBoYXBwZW5lZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlLmNwcAppbmRleCBkYWQ4MTA0OTFiNzI5M2I0NjNiZDdjMmFlMmI3NGZhN2Y0 MGE4MmI4Li4wNWY0M2E5MTgxMzc1NDRmZTRmNWRlN2M2ZTI2NTBjNTQ3NGM1NTAxIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC0xMjk5LDEy ICsxMjk5LDYgQEAgdm9pZCBXZWJQYWdlOjptb3VzZUV2ZW50KGNvbnN0IFdlYk1vdXNlRXZlbnQm IG1vdXNlRXZlbnQpCiAKIHZvaWQgV2ViUGFnZTo6bW91c2VFdmVudFN5bmNGb3JUZXN0aW5nKGNv bnN0IFdlYk1vdXNlRXZlbnQmIG1vdXNlRXZlbnQsIGJvb2wmIGhhbmRsZWQpCiB7Ci0gICAgLy8g RG9uJ3QgdHJ5IHRvIGhhbmRsZSBhbnkgcGVuZGluZyBtb3VzZSBldmVudHMgaWYgYSBjb250ZXh0 IG1lbnUgaXMgc2hvd2luZy4KLSAgICBpZiAobV9pc1Nob3dpbmdDb250ZXh0TWVudSkgewotICAg ICAgICBoYW5kbGVkID0gdHJ1ZTsKLSAgICAgICAgcmV0dXJuOwotICAgIH0KLQogICAgIGhhbmRs ZWQgPSBtX3BhZ2VPdmVybGF5ICYmIG1fcGFnZU92ZXJsYXktPm1vdXNlRXZlbnQobW91c2VFdmVu dCk7CiAKICAgICBpZiAoIWhhbmRsZWQpIHsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxNTkzNDJjYzg0ZTgxNjhlMThkNmIz N2VlZmEzZjA0ZTEzYjA2MDRhLi5kNzlmN2RiYWNkYTIzYTIwZGIzYzg4YzVmYzc4NmE1MDI2YmFi YTQzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDItMjQgIEh1Z28gUGFyZW50ZSBMaW1h ICA8aHVnby5saW1hQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgQWxsIG1vdXNlIGV2ZW50cyBh ZnRlciBhIHJpZ2h0IGNsaWNrIGFyZSBpZ25vcmVkIHdoZW4gdGhleSBjYW1lIGZyb20gV2Via2l0 VGVzdFJ1bm5lcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzczNTAKKworICAgICAgICBSZXZpZXdlZCBieSBDaGFuZyBTaHUuCisKKyAgICAgICAgVW5z a2lwIGZhc3QvZXZlbnRzL21vdXNlLWNsaWNrLWV2ZW50cy5odG1sLgorCisgICAgICAgICogcGxh dGZvcm0vcXQtNS4wLXdrMi9Ta2lwcGVkOgorCiAyMDEyLTAyLTI0ICBGbGV4IE1vYmlsZSAgPHJo YXVja0BhZG9iZS5jb20+CiAKICAgICAgICAgQ29udmVydCBzb21lIGZhc3QvcmVnaW9ucyBwaXhl bCB0ZXN0cyB0byByZWZ0ZXN0cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQt NS4wLXdrMi9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtNS4wLXdrMi9Ta2lwcGVk CmluZGV4IDkxZGEwN2NmZjdkNGIyOWM3ZDhjNzBkMzVjNDc0MjZiZGFkMDg3ZjIuLjhmOTE2MjZl ZjJkN2UwZjJjMzQyNWRhZjNlMzhiM2M3M2E4N2MxODQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL3F0LTUuMC13azIvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9x dC01LjAtd2syL1NraXBwZWQKQEAgLTU0LDcgKzU0LDYgQEAgZmFzdC9ldmVudHMvY29udGV4dC1v bm1vdXNlZG93bi1ldmVudC5odG1sCiBmYXN0L2V2ZW50cy9jb250ZXh0bWVudS1zY3JvbGxlZC1w YWdlLXdpdGgtZnJhbWUuaHRtbAogZmFzdC9ldmVudHMvY29udGludW91cy1wbGF0Zm9ybS13aGVl bGV2ZW50LWluLXNjcm9sbGluZy1kaXYuaHRtbAogZmFzdC9ldmVudHMvZmlyZS1tb3VzZWRvd24t d2hpbGUtcHJlc3NpbmctbW91c2UtYnV0dG9uLmh0bWwKLWZhc3QvZXZlbnRzL21vdXNlLWNsaWNr LWV2ZW50cy5odG1sCiBmYXN0L2V2ZW50cy9tb3VzZXVwLWZyb20tYnV0dG9uMi5odG1sCiBmYXN0 L2V2ZW50cy9vcGVuLXdpbmRvdy1mcm9tLWFub3RoZXItZnJhbWUuaHRtbAogZmFzdC9ldmVudHMv cGxhdGZvcm0td2hlZWxldmVudC1pbi1zY3JvbGxpbmctZGl2Lmh0bWwK