77328 2012-01-30 04:12:05 -0800 Import Dromaeo to WebKit repository 2012-01-31 20:02:57 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76156 1 morrita morrita abarth kling koivisto rniwa tony webkit.review.bot oldest_to_newest 545005 0 morrita 2012-01-30 04:12:05 -0800 I'm planning to pull the dromaeo repo somewhere before run. It might be better to have a fork in the repo though. I have no strong preference here. A modified version is here: https://github.com/omo/dromaeo I'm going to ask the upstream to pull this once it runs well. 545156 1 rniwa 2012-01-30 09:24:35 -0800 I think it's better to have a copy in the repository. I don't wanna see us re-creating the gclient nightmare. 545246 2 abarth 2012-01-30 11:46:24 -0800 How big is Dromaeo? 545255 3 rniwa 2012-01-30 11:56:36 -0800 About 10MB but test themselves are only 3.5MB: https://github.com/jeresig/dromaeo 545259 4 abarth 2012-01-30 12:00:28 -0800 3.5 MB sounds fine to import wholesale. 545585 5 morrita 2012-01-30 16:35:12 -0800 (In reply to comment #4) > 3.5 MB sounds fine to import wholesale. I thought we should pull it from the original source to make update easy. But maybe it's OK to have our own copy seeing Dromaeo doesn't have any big change these days. I'll take that way. 545590 6 rniwa 2012-01-30 16:37:33 -0800 (In reply to comment #5) > I thought we should pull it from the original source to make update easy. > But maybe it's OK to have our own copy seeing Dromaeo doesn't have any big change these days. > I'll take that way. I think importing will be better. For example, if we decide to import newer version of Dromaeo in the future, we can put in a separate directory in order to run both versions for a while. 545888 7 124693 morrita 2012-01-31 02:50:53 -0800 Created attachment 124693 Patch - Uploading manually because it's too big. 545891 8 webkit.review.bot 2012-01-31 02:56:10 -0800 Attachment 124693 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style. 546364 9 rniwa 2012-01-31 12:28:46 -0800 JSON.php is licensed under old BSD license, which is NOT compatible with GPL. So we can't land this as is. But given these aren't http tests, we don't need it, right? also, we probably don't need json.js since WebKit implements JSON. 546392 10 rniwa 2012-01-31 12:51:20 -0800 Alos, you may need to update some files after http://trac.webkit.org/changeset/106379. 546640 11 124849 morrita 2012-01-31 16:52:20 -0800 Created attachment 124849 Updated Patch 546644 12 morrita 2012-01-31 16:55:35 -0800 Oops the patch was wrong. But I cannot obsolete it because the page cannot finish loading. 546671 13 124857 morrita 2012-01-31 17:19:36 -0800 Created attachment 124857 Removed BSD-licensed files. 546674 14 morrita 2012-01-31 17:22:01 -0800 - The style errors are false positive. they came from third party libraries. - The bots failed to apply the patch because it was too big for them. 546696 15 rniwa 2012-01-31 17:52:17 -0800 r=me Unfortunately, the stupid iframe in Details page is preventing me from setting r+ so I can't set the flag on the actual patch. 546752 16 morrita 2012-01-31 19:52:02 -0800 Committed r106425: <http://trac.webkit.org/changeset/106425> 124693 2012-01-31 02:50:53 -0800 2012-01-31 16:52:20 -0800 Patch - Uploading manually because it's too big. wk77328.diff text/plain 0 morrita 124849 2012-01-31 16:52:20 -0800 2012-01-31 17:19:36 -0800 Updated Patch wk77328.diff text/plain 0 morrita 124857 2012-01-31 17:19:36 -0800 2012-01-31 20:02:57 -0800 Removed BSD-licensed files. wk77328.diff text/plain 0 morrita