77322 2012-01-30 01:25:05 -0800 No need to keep anonymous RenderBlock in DETAILS 2012-01-30 03:32:40 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76262 0 shinyak webkit-unassigned webkit.review.bot oldest_to_newest 544933 0 shinyak 2012-01-30 01:25:05 -0800 When detaching children of DETAILS element, anonymous RenderBlock may be left. It was introduced to prevent crash in r81812, but actually it is not necessary now. It often keeps unnecessary anonymous RenderObjects, and causes unexpected text diff mismatch when tweaking content element. 544941 1 124509 shinyak 2012-01-30 01:42:35 -0800 Created attachment 124509 Patch 544943 2 shinyak 2012-01-30 01:45:04 -0800 With this patch, Bug 76262's patch will not fail the following tests. fast/html/details-replace-text.html fast/html/details-remove-child-1.html And you can see that this test's expectation has unnecessary RenderBlock (so unexpected text mismatch will occur). fast/html/details-remove-child-2.html I will fix them in Bug 76262. 544953 3 124509 morrita 2012-01-30 02:08:58 -0800 Comment on attachment 124509 Patch Good catch! Evil is between the lines... 544983 4 124509 webkit.review.bot 2012-01-30 03:32:36 -0800 Comment on attachment 124509 Patch Clearing flags on attachment: 124509 Committed r106228: <http://trac.webkit.org/changeset/106228> 544984 5 webkit.review.bot 2012-01-30 03:32:40 -0800 All reviewed patches have been landed. Closing bug. 124509 2012-01-30 01:42:35 -0800 2012-01-30 03:32:36 -0800 Patch bug-77322-20120130184233.patch text/plain 1805 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWQ0MjYxN2UzZGNkYWJj YWRkNGUwM2NjZjI0ZDVmYTU2ZmNjYThjOS4uZWY2NDg5NTNlZTA2MWYyYjM3NDFiMzVmMWJiN2Ez NTJiN2M5Nzk3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAxLTMwICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGdvb2dsZS5jb20+CisKKyAgICAgICAgTm8gbmVlZCB0byBr ZWVwIGFub255bW91cyBSZW5kZXJCbG9jayBpbiBERVRBSUxTLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzczMjIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbm9ueW1vdXMgUmVuZGVyQmxvY2sgb2YgREVU QUlMUyBlbGVtZW50IHdhcyBub3Qgc3F1YXNoZWQgd2hlbiBkZXRhY2hpbmcgdGhlbS4KKyAgICAg ICAgSG93ZXZlciwgaXQgc2hvdWxkIGJlIHJlbW92ZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LiBTaG91bGQgYmUgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjYW5NZXJnZUNvbnRpZ3Vv dXNBbm9ueW1vdXNCbG9ja3MpOgorCiAyMDEyLTAxLTI5ICBOb2VsIEdvcmRvbiAgPG5vZWwuZ29y ZG9uQGdtYWlsLmNvbT4KIAogICAgICAgICBbY2hyb21pdW1dIFVzZSBkZWNvZGluZyBzd2l6emxl IG9ubHkgb24gbGlianBlZy10dXJibyAxLjEuOTArCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckJsb2NrLmNwcAppbmRleCA3MWM1ZDRiMWYyN2NjODQxYjJiZWJjOTVlZDQwMTkwZjE3ZTA4 ZGUxLi4yYmNlZDBmMTFlYjQ1MTY3YjEwMThiZWM2OTdhN2RiODdjNWI2MTA2IDEwMDc1NQotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKQEAgLTEwMDAsMTEgKzEwMDAsNiBAQCBz dGF0aWMgYm9vbCBjYW5NZXJnZUNvbnRpZ3VvdXNBbm9ueW1vdXNCbG9ja3MoUmVuZGVyT2JqZWN0 KiBvbGRDaGlsZCwgUmVuZGVyT2JqZQogICAgIGlmIChvbGRDaGlsZC0+ZG9jdW1lbnRCZWluZ0Rl c3Ryb3llZCgpIHx8IG9sZENoaWxkLT5pc0lubGluZSgpIHx8IG9sZENoaWxkLT52aXJ0dWFsQ29u dGludWF0aW9uKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotI2lmIEVOQUJMRShERVRBSUxT KQotICAgIGlmIChvbGRDaGlsZC0+cGFyZW50KCkgJiYgb2xkQ2hpbGQtPnBhcmVudCgpLT5pc0Rl dGFpbHMoKSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotI2VuZGlmCi0KICAgICBpZiAoKHByZXYg JiYgKCFwcmV2LT5pc0Fub255bW91c0Jsb2NrKCkgfHwgdG9SZW5kZXJCbG9jayhwcmV2KS0+Y29u dGludWF0aW9uKCkgfHwgdG9SZW5kZXJCbG9jayhwcmV2KS0+YmVpbmdEZXN0cm95ZWQoKSkpCiAg ICAgICAgIHx8IChuZXh0ICYmICghbmV4dC0+aXNBbm9ueW1vdXNCbG9jaygpIHx8IHRvUmVuZGVy QmxvY2sobmV4dCktPmNvbnRpbnVhdGlvbigpIHx8IHRvUmVuZGVyQmxvY2sobmV4dCktPmJlaW5n RGVzdHJveWVkKCkpKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwo=