77244 2012-01-27 14:15:14 -0800 [JSC] ThunkGenerators.cpp should hide its asm-defined symbols 2012-01-27 15:28:38 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72854 1 morrita morrita darin fpizlo kevino webkit.review.bot oldest_to_newest 544355 0 morrita 2012-01-27 14:15:14 -0800 This is a followup for Bug 77150. ThunkGenerators.cpp also defines some thunks that should be hidden. 544368 1 124369 morrita 2012-01-27 14:30:13 -0800 Created attachment 124369 Patch 544372 2 morrita 2012-01-27 14:33:21 -0800 Hi Filip, would you mind taking a look at this small imitation? This is a followup of Bug 77150 to hide some more asm-made symbols. 544373 3 124369 fpizlo 2012-01-27 14:36:15 -0800 Comment on attachment 124369 Patch I buy it. R=me. 544407 4 124369 morrita 2012-01-27 14:58:57 -0800 Comment on attachment 124369 Patch Thanks! 544437 5 124369 webkit.review.bot 2012-01-27 15:28:33 -0800 Comment on attachment 124369 Patch Clearing flags on attachment: 124369 Committed r106161: <http://trac.webkit.org/changeset/106161> 544438 6 webkit.review.bot 2012-01-27 15:28:38 -0800 All reviewed patches have been landed. Closing bug. 124369 2012-01-27 14:30:13 -0800 2012-01-27 15:28:33 -0800 Patch bug-77244-20120127143012.patch text/plain 3331 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 YmVkMzQzODAzMTZjMjFlOTc3ZjEzODhkMzQ4NDIzMTgyMTg3NWM0Li40MDYwMWViYmVkYzZhNzQx Y2RhYzhiNjBkZWI4NWE1ZmY3ZjU4Y2I3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMi0wMS0yNyAgSGFqaW1lIE1vcml0YSAgPG1vcnJpdGFAZ29vZ2xlLmNv bT4KKworICAgICAgICBbSlNDXSBUaHVua0dlbmVyYXRvcnMuY3BwIHNob3VsZCBoaWRlIGl0cyBh c20tZGVmaW5lZCBzeW1ib2xzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03NzI0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogaml0L1RodW5rR2VuZXJhdG9ycy5jcHA6IEFkZGVkIEhJREVfU1lNQk9MUygp CisgICAgICAgICogd3RmL0lubGluZUFTTS5oOiBNb3ZlZCBzb21lIGR1cGxpY2F0ZWQgbWFjcm9z IGZyb20gVGh1bmtHZW5lcmF0b3JzLmNwcAorCiAyMDEyLTAxLTI3ICBaZW5vIEFsYmlzc2VyICA8 emVub0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF1bTWFjXSBCdWlsZCBmYWlscyBhZnRlciBh ZGRpbmcgSUNVIHN1cHBvcnQgKHIxMDU5OTcpLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9UaHVua0dlbmVyYXRvcnMuY3BwCmluZGV4IDBlNTRjOGE4ZjkwNmFmMzRjMjc0ZDk5ZTI4MTQw ZWEyYTUyMTI1NDIuLjA5OTc5Njk4NjgxMzQ2NjAwMTUzNGNhMzFhZTM4NmJiM2I0YzdiODIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNwcAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2VuZXJhdG9ycy5jcHAKQEAgLTI3 LDggKzI3LDkgQEAKICNpbmNsdWRlICJUaHVua0dlbmVyYXRvcnMuaCIKIAogI2luY2x1ZGUgIkNv ZGVCbG9jay5oIgotI2luY2x1ZGUgPHd0Zi90ZXh0L1N0cmluZ0ltcGwuaD4KKyNpbmNsdWRlICJJ bmxpbmVBU00uaCIKICNpbmNsdWRlICJTcGVjaWFsaXplZFRodW5rSklULmgiCisjaW5jbHVkZSA8 d3RmL3RleHQvU3RyaW5nSW1wbC5oPgogCiAjaWYgRU5BQkxFKEpJVCkKIApAQCAtMTExLDIxICsx MTIsNiBAQCBNYWNyb0Fzc2VtYmxlckNvZGVSZWYgc3FydFRodW5rR2VuZXJhdG9yKEpTR2xvYmFs RGF0YSogZ2xvYmFsRGF0YSkKICAgICByZXR1cm4gaml0LmZpbmFsaXplKCpnbG9iYWxEYXRhLCBn bG9iYWxEYXRhLT5qaXRTdHVicy0+Y3RpTmF0aXZlQ2FsbCgpKTsKIH0KIAotI2lmIE9TKERBUldJ TikgfHwgKE9TKFdJTkRPV1MpICYmIENQVShYODYpKQotI2RlZmluZSBTWU1CT0xfU1RSSU5HKG5h bWUpICJfIiAjbmFtZQotI2Vsc2UKLSNkZWZpbmUgU1lNQk9MX1NUUklORyhuYW1lKSAjbmFtZQot I2VuZGlmCi0gICAgCi0jaWYgKE9TKExJTlVYKSB8fCBPUyhGUkVFQlNEKSkgJiYgQ1BVKFg4Nl82 NCkKLSNkZWZpbmUgU1lNQk9MX1NUUklOR19SRUxPQ0FUSU9OKG5hbWUpICNuYW1lICJAcGx0Igot I2VsaWYgT1MoREFSV0lOKSB8fCAoQ1BVKFg4Nl82NCkgJiYgQ09NUElMRVIoTUlOR1cpICYmICFH Q0NfVkVSU0lPTl9BVF9MRUFTVCg0LCA1LCAwKSkKLSNkZWZpbmUgU1lNQk9MX1NUUklOR19SRUxP Q0FUSU9OKG5hbWUpICJfIiAjbmFtZQotI2VsaWYgQ1BVKFg4NikgJiYgQ09NUElMRVIoTUlOR1cp Ci0jZGVmaW5lIFNZTUJPTF9TVFJJTkdfUkVMT0NBVElPTihuYW1lKSAiQCIgI25hbWUgIkA0Igot I2Vsc2UKLSNkZWZpbmUgU1lNQk9MX1NUUklOR19SRUxPQ0FUSU9OKG5hbWUpICNuYW1lCi0jZW5k aWYKIAogI2RlZmluZSBVbmFyeURvdWJsZU9wV3JhcHBlcihmdW5jdGlvbikgZnVuY3Rpb24jI1dy YXBwZXIKIGVudW0gTWF0aFRodW5rQ2FsbGluZ0NvbnZlbnRpb24geyB9OwpAQCAtMTQ3LDYgKzEz Myw3IEBAIGRvdWJsZSBqc1JvdW5kKGRvdWJsZSBkKQogICAgIGFzbSggXAogICAgICAgICAiLnRl eHRcbiIgXAogICAgICAgICAiLmdsb2JsICIgU1lNQk9MX1NUUklORyhmdW5jdGlvbiMjVGh1bmsp ICJcbiIgXAorICAgICAgICBISURFX1NZTUJPTChmdW5jdGlvbiMjVGh1bmspICJcbiIgXAogICAg ICAgICBTWU1CT0xfU1RSSU5HKGZ1bmN0aW9uIyNUaHVuaykgIjoiICJcbiIgXAogICAgICAgICAi Y2FsbCAiIFNZTUJPTF9TVFJJTkdfUkVMT0NBVElPTihmdW5jdGlvbikgIlxuIiBcCiAgICAgICAg ICJyZXRcbiIgXApAQCAtMTYxLDYgKzE0OCw3IEBAIGRvdWJsZSBqc1JvdW5kKGRvdWJsZSBkKQog ICAgIGFzbSggXAogICAgICAgICAiLnRleHRcbiIgXAogICAgICAgICAiLmdsb2JsICIgU1lNQk9M X1NUUklORyhmdW5jdGlvbiMjVGh1bmspICJcbiIgXAorICAgICAgICBISURFX1NZTUJPTChmdW5j dGlvbiMjVGh1bmspICJcbiIgXAogICAgICAgICBTWU1CT0xfU1RSSU5HKGZ1bmN0aW9uIyNUaHVu aykgIjoiICJcbiIgXAogICAgICAgICAic3VibCAkOCwgJWVzcFxuIiBcCiAgICAgICAgICJtb3Zz ZCAleG1tMCwgKCVlc3ApIFxuIiBcCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL0lubGluZUFTTS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9JbmxpbmVBU00uaApp bmRleCBjOGE5M2Y5OWNmNzAyMDEyNDdiYjgwMGVmZTQ1NTRmZTlkYTUzZmFmLi4zNzllYmQzNjRi OWZjMjNjZTI3NDYzZWRjZDQ2OGY1ZGJhNTk1MzdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvd3RmL0lubGluZUFTTS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYv SW5saW5lQVNNLmgKQEAgLTQ0LDYgKzQ0LDggQEAKIAogI2lmIChPUyhMSU5VWCkgfHwgT1MoRlJF RUJTRCkpICYmIENQVShYODZfNjQpCiAjZGVmaW5lIFNZTUJPTF9TVFJJTkdfUkVMT0NBVElPTihu YW1lKSAjbmFtZSAiQHBsdCIKKyNlbGlmIE9TKERBUldJTikgfHwgKENQVShYODZfNjQpICYmIENP TVBJTEVSKE1JTkdXKSAmJiAhR0NDX1ZFUlNJT05fQVRfTEVBU1QoNCwgNSwgMCkpCisjZGVmaW5l IFNZTUJPTF9TVFJJTkdfUkVMT0NBVElPTihuYW1lKSAiXyIgI25hbWUKICNlbGlmIENQVShYODYp ICYmIENPTVBJTEVSKE1JTkdXKQogI2RlZmluZSBTWU1CT0xfU1RSSU5HX1JFTE9DQVRJT04obmFt ZSkgIkAiICNuYW1lICJANCIKICNlbHNlCg==