77165 2012-01-26 17:22:51 -0800 JSC idl code generator generates bad code for [CachedAttribute] attributes 2012-01-26 18:25:19 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76035 0 pf webkit-unassigned abarth haraken japhet oliver webkit.review.bot oldest_to_newest 543680 0 pf 2012-01-26 17:22:51 -0800 JSC idl code generator generates bad code for [CachedAttribute] attributes 543684 1 124223 pf 2012-01-26 17:29:03 -0800 Created attachment 124223 Patch 543695 2 124223 oliver 2012-01-26 17:44:50 -0800 Comment on attachment 124223 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124223&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3000 > + return "$value ? $value->deserialize(exec, castedThis->globalObject(), 0) : jsNull()"; what is the additional argument here for? 543697 3 pf 2012-01-26 17:47:33 -0800 (In reply to comment #2) > (From update of attachment 124223 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=124223&action=review > > > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3000 > > + return "$value ? $value->deserialize(exec, castedThis->globalObject(), 0) : jsNull()"; > > what is the additional argument here for? MessagePortArray* MessageEvent (the only one declaring CachedAttributes so far) uses a custom getter, so i imagine that's why this has gone unnoticed. 543715 4 124223 webkit.review.bot 2012-01-26 18:25:15 -0800 Comment on attachment 124223 Patch Clearing flags on attachment: 124223 Committed r106077: <http://trac.webkit.org/changeset/106077> 543716 5 webkit.review.bot 2012-01-26 18:25:19 -0800 All reviewed patches have been landed. Closing bug. 124223 2012-01-26 17:29:03 -0800 2012-01-26 18:25:15 -0800 Patch bug-77165-20120126172901.patch text/plain 6422 pf U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1OTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI2NzY3MGZjMjU3YjEx ODczOTc1M2RlNDNhOTk3NDQ5MWMyMjRhMC4uZTRhZWViMjMzYmY0YTE0MjViN2FmNzZiZWJkZWVh MzRmZDVmMWNlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAxLTI2ICBQYWJs byBGbG91cmV0ICA8cGFibG9mQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBGaXggYmFkIGNvZGUg Z2VuZXJhdGVkIGJ5IHRoZSBKU0MgaWRsIGNvZGUgZ2VuZXJhdG9yIGZvciBbQ2FjaGVkQXR0cmli dXRlXSBhdHRyaWJ1dGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03NzE2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE1pc3NpbmcgcGFyYW1ldGVyIGluIGEgY2FsbCB0byBkZXNlcmlhbGl6ZSgpIGFuZCB1 c2luZyAndGhpcycgaW4gdGhlCisgICAgICAgIGF0dHJpYnV0ZSBhY2Nlc3NvciBmdW5jdGlvbnMg KHdoaWNoIGFyZSBzdGF0aWMpLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9ySlMucG06CisgICAgICAgIChHZW5lcmF0ZUltcGxlbWVudGF0aW9uKToKKyAgICAgICAg KE5hdGl2ZVRvSlNWYWx1ZSk6CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pT VGVzdE9iai5jcHA6CisgICAgICAgIChXZWJDb3JlOjpqc1Rlc3RPYmpDYWNoZWRBdHRyaWJ1dGUx KToKKyAgICAgICAgKFdlYkNvcmU6OmpzVGVzdE9iakNhY2hlZEF0dHJpYnV0ZTIpOgorICAgICAg ICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RTZXJpYWxpemVkU2NyaXB0VmFsdWVJ bnRlcmZhY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6anNUZXN0U2VyaWFsaXplZFNjcmlwdFZh bHVlSW50ZXJmYWNlVmFsdWUpOgorCiAyMDEyLTAxLTI1ICBEYW5pZWwgQ2hlbmcgIDxkY2hlbmdA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gRml4IENsaXBib2FyZENocm9taXVt Ojp2YWxpZGF0ZUZpbGVuYW1lIHRvIGFjdHVhbGx5IG9wZXJhdGUgb24gZXh0ZW5zaW9ucwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMu cG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQpp bmRleCA4MjNiNGY2Nzg3NzZiOTg3Njc5ZDU4OWM4MTRlODdjYTM2Nzk0NzdkLi4yMTM5YTkzZjEx MTgyMzVjMDhkNzhmMGFhOTg1ZTQ3YzMyMmM0NmJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQpAQCAtMTc1MSw3ICsxNzUxLDcg QEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50YXRpb24KICAgICAgICAgICAgICAgICAgICAgaWYgKCRh dHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkNhY2hlZEF0dHJpYnV0 ZSJ9KSB7CiAgICAgICAgICAgICAgICAgICAgICAgICAkY2FjaGVJbmRleCA9ICRjdXJyZW50Q2Fj aGVkQXR0cmlidXRlOwogICAgICAgICAgICAgICAgICAgICAgICAgJGN1cnJlbnRDYWNoZWRBdHRy aWJ1dGUrKzsKLSAgICAgICAgICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAg IGlmIChKU1ZhbHVlIGNhY2hlZFZhbHVlID0gbV8iIC4gJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5u YW1lIC4gIi5nZXQoKSlcbiIpOworICAgICAgICAgICAgICAgICAgICAgICAgcHVzaChAaW1wbENv bnRlbnQsICIgICAgaWYgKEpTVmFsdWUgY2FjaGVkVmFsdWUgPSBjYXN0ZWRUaGlzLT5tXyIgLiAk YXR0cmlidXRlLT5zaWduYXR1cmUtPm5hbWUgLiAiLmdldCgpKVxuIik7CiAgICAgICAgICAgICAg ICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICAgICAgcmV0dXJuIGNhY2hlZFZhbHVl O1xuIik7CiAgICAgICAgICAgICAgICAgICAgIH0KIApAQCAtMTc5NCw3ICsxNzk0LDcgQEAgc3Vi IEdlbmVyYXRlSW1wbGVtZW50YXRpb24KICAgICAgICAgICAgICAgICAgICAgICAgIH0KICAgICAg ICAgICAgICAgICAgICAgfQogCi0gICAgICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50 LCAiICAgIG1fIiAuICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+bmFtZSAuICIuc2V0KGV4ZWMtPmds b2JhbERhdGEoKSwgdGhpcywgcmVzdWx0KTtcbiIpIGlmICgkYXR0cmlidXRlLT5zaWduYXR1cmUt PmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDYWNoZWRBdHRyaWJ1dGUifSk7CisgICAgICAgICAgICAg ICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgIGNhc3RlZFRoaXMtPm1fIiAuICRhdHRyaWJ1 dGUtPnNpZ25hdHVyZS0+bmFtZSAuICIuc2V0KGV4ZWMtPmdsb2JhbERhdGEoKSwgY2FzdGVkVGhp cywgcmVzdWx0KTtcbiIpIGlmICgkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmli dXRlcy0+eyJDYWNoZWRBdHRyaWJ1dGUifSk7CiAgICAgICAgICAgICAgICAgICAgIHB1c2goQGlt cGxDb250ZW50LCAiICAgIHJldHVybiByZXN1bHQ7XG4iKTsKIAogICAgICAgICAgICAgICAgIH0g ZWxzZSB7CkBAIC0yOTk3LDcgKzI5OTcsNyBAQCBzdWIgTmF0aXZlVG9KU1ZhbHVlCiAgICAgICAg IEFkZFRvSW1wbEluY2x1ZGVzKCIkam9pbmVkTmFtZS5oIiwgJGNvbmRpdGlvbmFsKTsKICAgICB9 IGVsc2lmICgkdHlwZSBlcSAiU2VyaWFsaXplZFNjcmlwdFZhbHVlIiBvciAkdHlwZSBlcSAiYW55 IikgewogICAgICAgICBBZGRUb0ltcGxJbmNsdWRlcygiU2VyaWFsaXplZFNjcmlwdFZhbHVlLmgi LCAkY29uZGl0aW9uYWwpOwotICAgICAgICByZXR1cm4gIiR2YWx1ZSA/ICR2YWx1ZS0+ZGVzZXJp YWxpemUoZXhlYywgY2FzdGVkVGhpcy0+Z2xvYmFsT2JqZWN0KCkpIDoganNOdWxsKCkiOworICAg ICAgICByZXR1cm4gIiR2YWx1ZSA/ICR2YWx1ZS0+ZGVzZXJpYWxpemUoZXhlYywgY2FzdGVkVGhp cy0+Z2xvYmFsT2JqZWN0KCksIDApIDoganNOdWxsKCkiOwogICAgIH0gZWxzZSB7CiAgICAgICAg ICMgRGVmYXVsdCwgaW5jbHVkZSBoZWFkZXIgd2l0aCBzYW1lIG5hbWUuCiAgICAgICAgIEFkZFRv SW1wbEluY2x1ZGVzKCJKUyR0eXBlLmgiLCAkY29uZGl0aW9uYWwpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdE9iai5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmNwcAppbmRleCBi NjMzOGM3YzJmY2E2YjRiYWRmNzEzNzJhZjc5YTVkZTU2ODVjNTIzLi4wM2Y1NjI1MDMxYTNhY2Zi YzFmMzg5YmRkZTQxMTllMGE0OGM1MDVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmNwcApAQCAtNzU4LDExICs3NTgsMTEg QEAgSlNWYWx1ZSBqc1Rlc3RPYmpDYWNoZWRBdHRyaWJ1dGUxKEV4ZWNTdGF0ZSogZXhlYywgSlNW YWx1ZSBzbG90QmFzZSwgY29uc3QgSWRlbnQKIHsKICAgICBKU1Rlc3RPYmoqIGNhc3RlZFRoaXMg PSBzdGF0aWNfY2FzdDxKU1Rlc3RPYmoqPihhc09iamVjdChzbG90QmFzZSkpOwogICAgIFVOVVNF RF9QQVJBTShleGVjKTsKLSAgICBpZiAoSlNWYWx1ZSBjYWNoZWRWYWx1ZSA9IG1fY2FjaGVkQXR0 cmlidXRlMS5nZXQoKSkKKyAgICBpZiAoSlNWYWx1ZSBjYWNoZWRWYWx1ZSA9IGNhc3RlZFRoaXMt Pm1fY2FjaGVkQXR0cmlidXRlMS5nZXQoKSkKICAgICAgICAgcmV0dXJuIGNhY2hlZFZhbHVlOwog ICAgIFRlc3RPYmoqIGltcGwgPSBzdGF0aWNfY2FzdDxUZXN0T2JqKj4oY2FzdGVkVGhpcy0+aW1w bCgpKTsKLSAgICBKU1ZhbHVlIHJlc3VsdCA9IGltcGwtPmNhY2hlZEF0dHJpYnV0ZTEoKSA/IGlt cGwtPmNhY2hlZEF0dHJpYnV0ZTEoKS0+ZGVzZXJpYWxpemUoZXhlYywgY2FzdGVkVGhpcy0+Z2xv YmFsT2JqZWN0KCkpIDoganNOdWxsKCk7Ci0gICAgbV9jYWNoZWRBdHRyaWJ1dGUxLnNldChleGVj LT5nbG9iYWxEYXRhKCksIHRoaXMsIHJlc3VsdCk7CisgICAgSlNWYWx1ZSByZXN1bHQgPSBpbXBs LT5jYWNoZWRBdHRyaWJ1dGUxKCkgPyBpbXBsLT5jYWNoZWRBdHRyaWJ1dGUxKCktPmRlc2VyaWFs aXplKGV4ZWMsIGNhc3RlZFRoaXMtPmdsb2JhbE9iamVjdCgpLCAwKSA6IGpzTnVsbCgpOworICAg IGNhc3RlZFRoaXMtPm1fY2FjaGVkQXR0cmlidXRlMS5zZXQoZXhlYy0+Z2xvYmFsRGF0YSgpLCBj YXN0ZWRUaGlzLCByZXN1bHQpOwogICAgIHJldHVybiByZXN1bHQ7CiB9CiAKQEAgLTc3MSwxMSAr NzcxLDExIEBAIEpTVmFsdWUganNUZXN0T2JqQ2FjaGVkQXR0cmlidXRlMihFeGVjU3RhdGUqIGV4 ZWMsIEpTVmFsdWUgc2xvdEJhc2UsIGNvbnN0IElkZW50CiB7CiAgICAgSlNUZXN0T2JqKiBjYXN0 ZWRUaGlzID0gc3RhdGljX2Nhc3Q8SlNUZXN0T2JqKj4oYXNPYmplY3Qoc2xvdEJhc2UpKTsKICAg ICBVTlVTRURfUEFSQU0oZXhlYyk7Ci0gICAgaWYgKEpTVmFsdWUgY2FjaGVkVmFsdWUgPSBtX2Nh Y2hlZEF0dHJpYnV0ZTIuZ2V0KCkpCisgICAgaWYgKEpTVmFsdWUgY2FjaGVkVmFsdWUgPSBjYXN0 ZWRUaGlzLT5tX2NhY2hlZEF0dHJpYnV0ZTIuZ2V0KCkpCiAgICAgICAgIHJldHVybiBjYWNoZWRW YWx1ZTsKICAgICBUZXN0T2JqKiBpbXBsID0gc3RhdGljX2Nhc3Q8VGVzdE9iaio+KGNhc3RlZFRo aXMtPmltcGwoKSk7Ci0gICAgSlNWYWx1ZSByZXN1bHQgPSBpbXBsLT5jYWNoZWRBdHRyaWJ1dGUy KCkgPyBpbXBsLT5jYWNoZWRBdHRyaWJ1dGUyKCktPmRlc2VyaWFsaXplKGV4ZWMsIGNhc3RlZFRo aXMtPmdsb2JhbE9iamVjdCgpKSA6IGpzTnVsbCgpOwotICAgIG1fY2FjaGVkQXR0cmlidXRlMi5z ZXQoZXhlYy0+Z2xvYmFsRGF0YSgpLCB0aGlzLCByZXN1bHQpOworICAgIEpTVmFsdWUgcmVzdWx0 ID0gaW1wbC0+Y2FjaGVkQXR0cmlidXRlMigpID8gaW1wbC0+Y2FjaGVkQXR0cmlidXRlMigpLT5k ZXNlcmlhbGl6ZShleGVjLCBjYXN0ZWRUaGlzLT5nbG9iYWxPYmplY3QoKSwgMCkgOiBqc051bGwo KTsKKyAgICBjYXN0ZWRUaGlzLT5tX2NhY2hlZEF0dHJpYnV0ZTIuc2V0KGV4ZWMtPmdsb2JhbERh dGEoKSwgY2FzdGVkVGhpcywgcmVzdWx0KTsKICAgICByZXR1cm4gcmVzdWx0OwogfQogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0U2Vy aWFsaXplZFNjcmlwdFZhbHVlSW50ZXJmYWNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RTZXJpYWxpemVkU2NyaXB0VmFsdWVJbnRlcmZhY2UuY3Bw CmluZGV4IDc1NTRiZDBhZDk0Y2Y3MTA2OTFkMWZjN2JmMDQxNTYwYjliMzg3OGEuLmZiMmYyMWQ3 MWJhYjM0YmExMWZhMWNiZDY0YzI2YTU2NTcyNDFlNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RTZXJpYWxpemVkU2NyaXB0VmFsdWVJ bnRlcmZhY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9K Uy9KU1Rlc3RTZXJpYWxpemVkU2NyaXB0VmFsdWVJbnRlcmZhY2UuY3BwCkBAIC0xNjIsNyArMTYy LDcgQEAgSlNWYWx1ZSBqc1Rlc3RTZXJpYWxpemVkU2NyaXB0VmFsdWVJbnRlcmZhY2VWYWx1ZShF eGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgc2xvdEIKICAgICBKU1Rlc3RTZXJpYWxpemVkU2NyaXB0 VmFsdWVJbnRlcmZhY2UqIGNhc3RlZFRoaXMgPSBzdGF0aWNfY2FzdDxKU1Rlc3RTZXJpYWxpemVk U2NyaXB0VmFsdWVJbnRlcmZhY2UqPihhc09iamVjdChzbG90QmFzZSkpOwogICAgIFVOVVNFRF9Q QVJBTShleGVjKTsKICAgICBUZXN0U2VyaWFsaXplZFNjcmlwdFZhbHVlSW50ZXJmYWNlKiBpbXBs ID0gc3RhdGljX2Nhc3Q8VGVzdFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZUludGVyZmFjZSo+KGNhc3Rl ZFRoaXMtPmltcGwoKSk7Ci0gICAgSlNWYWx1ZSByZXN1bHQgPSBpbXBsLT52YWx1ZSgpID8gaW1w bC0+dmFsdWUoKS0+ZGVzZXJpYWxpemUoZXhlYywgY2FzdGVkVGhpcy0+Z2xvYmFsT2JqZWN0KCkp IDoganNOdWxsKCk7CisgICAgSlNWYWx1ZSByZXN1bHQgPSBpbXBsLT52YWx1ZSgpID8gaW1wbC0+ dmFsdWUoKS0+ZGVzZXJpYWxpemUoZXhlYywgY2FzdGVkVGhpcy0+Z2xvYmFsT2JqZWN0KCksIDAp IDoganNOdWxsKCk7CiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAo=