77150 2012-01-26 15:06:50 -0800 [JSC] Asm-originated symbols should be marked as hidden 2012-01-27 14:43:54 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72854 1 morrita hausmann fpizlo hausmann webkit.review.bot oldest_to_newest 543532 0 morrita 2012-01-26 15:06:50 -0800 This is from Bug 72854. Following symbols are currently not marked as hidden, that means these will be visible if we switched off the exp list based symbol management. We need to mark them hidden. ---- __ZThn16_N3JSC9CodeBlockD0Ev __ZThn16_N3JSC9CodeBlockD1Ev _ceilThunk _expThunk _floorThunk _jsRoundThunk _logThunk _getHostCallReturnValue _operationGetByIdBuildList _operationGetByIdOptimize _operationGetByIdProtoBuildList _operationLinkCall _operationLinkConstruct _operationPutByIdDirectNonStrictOptimize _operationPutByIdDirectStrictOptimize _operationPutByIdNonStrictOptimize _operationPutByIdStrictOptimize ---- 543946 1 124285 hausmann 2012-01-27 03:51:36 -0800 Created attachment 124285 Patch 544115 2 morrita 2012-01-27 09:01:29 -0800 CC-ing Filip, an expert in this area. 544318 3 124285 fpizlo 2012-01-27 13:30:47 -0800 Comment on attachment 124285 Patch I take it there will be additional packages to hide the various other symbols? R=me. 544325 4 morrita 2012-01-27 13:48:05 -0800 (In reply to comment #3) > (From update of attachment 124285 [details]) > I take it there will be additional packages to hide the various other symbols? R=me. Yeah, this is a part of effort to kill JavaScriptCore.exp with function-based annotation JS_EXPORT_PRIVATE. Thanks for your quick take, Filip. 544326 5 fpizlo 2012-01-27 13:48:40 -0800 (In reply to comment #3) > (From update of attachment 124285 [details]) > I take it there will be additional packages to hide the various other symbols? R=me. Ooops, sorry I meant to say "patches" not "packages". 544387 6 124285 webkit.review.bot 2012-01-27 14:43:49 -0800 Comment on attachment 124285 Patch Clearing flags on attachment: 124285 Committed r106153: <http://trac.webkit.org/changeset/106153> 544388 7 webkit.review.bot 2012-01-27 14:43:54 -0800 All reviewed patches have been landed. Closing bug. 124285 2012-01-27 03:51:36 -0800 2012-01-27 14:43:49 -0800 Patch bug-77150-20120127125136.patch text/plain 2408 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1OTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm NGQ4YTBlNmY5YzJmYmI2N2VhYTVmNDc4ZjYwMGFmNGRjOTcxNDlhLi42ZDVkOGI1ZWYyZGE5OWZi YTI3OWU2NDNhYmVkNTQ1OWVjNWQwMDhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMi0wMS0yNyAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBu b2tpYS5jb20+CisKKyAgICAgICAgW0pTQ10gQXNtLW9yaWdpbmF0ZWQgc3ltYm9scyBzaG91bGQg YmUgbWFya2VkIGFzIGhpZGRlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzcxNTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGRmZy9ERkdPcGVyYXRpb25zLmNwcDogVGhlIEhJREVfU1lNQk9MUyBtYWNy b3Mgd2VyZSBwcmVzZW50IGluIHRoZSBDUFUoQVJNKSBwcmVwcm9jZXNzb3IgYnJhbmNoZXMsCisg ICAgICAgIGJ1dCB0aGV5IHdlcmUgbWlzc2luZyBpbiB0aGUgQ1BVKFg4NikgYW5kIHRoZSBDUFUo WDg2XzY0KSBjYXNlcy4KKwogMjAxMi0wMS0yNiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5j b20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjEwNTU1NSk6IEluY29ycmVjdCB1c2Ugb2YgT1Mo KSBtYWNybyBicmVha3MgT3duUHRyIHdoZW4gdXNlZCB3aXRoIFdpbjMyIGRhdGEgdHlwZXMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCmluZGV4IGEyZTAyY2Vl NmI3MDhiZGJjYzQ1NWFhM2ZmMDk0MzM1MDlkMDhiMDEuLjc0YjA0OWFkOTQzNjFlNTczYzg4ZjE1 YWQ3MjBiM2RkMjA2OGY5YTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHT3BlcmF0aW9ucy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVy YXRpb25zLmNwcApAQCAtNDMsNiArNDMsNyBAQAogI2RlZmluZSBGVU5DVElPTl9XUkFQUEVSX1dJ VEhfUkVUVVJOX0FERFJFU1MoZnVuY3Rpb24sIHJlZ2lzdGVyKSBcCiAgICAgYXNtKCBcCiAgICAg Ii5nbG9ibCAiIFNZTUJPTF9TVFJJTkcoZnVuY3Rpb24pICJcbiIgXAorICAgIEhJREVfU1lNQk9M KGZ1bmN0aW9uKSAiXG4iIFwKICAgICBTWU1CT0xfU1RSSU5HKGZ1bmN0aW9uKSAiOiIgIlxuIiBc CiAgICAgICAgICJtb3YgKCVyc3ApLCAlIiBTVFJJTkdJWkUocmVnaXN0ZXIpICJcbiIgXAogICAg ICAgICAiam1wICIgU1lNQk9MX1NUUklOR19SRUxPQ0FUSU9OKGZ1bmN0aW9uIyNXaXRoUmV0dXJu QWRkcmVzcykgIlxuIiBcCkBAIC01Nyw2ICs1OCw3IEBACiAjZGVmaW5lIEZVTkNUSU9OX1dSQVBQ RVJfV0lUSF9SRVRVUk5fQUREUkVTUyhmdW5jdGlvbiwgb2Zmc2V0KSBcCiAgICAgYXNtKCBcCiAg ICAgIi5nbG9ibCAiIFNZTUJPTF9TVFJJTkcoZnVuY3Rpb24pICJcbiIgXAorICAgIEhJREVfU1lN Qk9MKGZ1bmN0aW9uKSAiXG4iIFwKICAgICBTWU1CT0xfU1RSSU5HKGZ1bmN0aW9uKSAiOiIgIlxu IiBcCiAgICAgICAgICJtb3YgKCVlc3ApLCAlZWF4XG4iIFwKICAgICAgICAgIm1vdiAlZWF4LCAi IFNUUklOR0laRShvZmZzZXQpICIoJWVzcClcbiIgXApAQCAtNjc3LDYgKzY3OSw3IEBAIEVuY29k ZWRKU1ZhbHVlIERGR19PUEVSQVRJT04gZ2V0SG9zdENhbGxSZXR1cm5WYWx1ZVdpdGhFeGVjU3Rh dGUoRXhlY1N0YXRlKik7CiAjaWYgQ1BVKFg4Nl82NCkKIGFzbSAoCiAiLmdsb2JsICIgU1lNQk9M X1NUUklORyhnZXRIb3N0Q2FsbFJldHVyblZhbHVlKSAiXG4iCitISURFX1NZTUJPTChnZXRIb3N0 Q2FsbFJldHVyblZhbHVlKSAiXG4iCiBTWU1CT0xfU1RSSU5HKGdldEhvc3RDYWxsUmV0dXJuVmFs dWUpICI6IiAiXG4iCiAgICAgIm1vdiAtNDAoJXIxMyksICVyMTNcbiIKICAgICAibW92ICVyMTMs ICVyZGlcbiIKQEAgLTY4NSw2ICs2ODgsNyBAQCBTWU1CT0xfU1RSSU5HKGdldEhvc3RDYWxsUmV0 dXJuVmFsdWUpICI6IiAiXG4iCiAjZWxpZiBDUFUoWDg2KQogYXNtICgKICIuZ2xvYmwgIiBTWU1C T0xfU1RSSU5HKGdldEhvc3RDYWxsUmV0dXJuVmFsdWUpICJcbiIKK0hJREVfU1lNQk9MKGdldEhv c3RDYWxsUmV0dXJuVmFsdWUpICJcbiIKIFNZTUJPTF9TVFJJTkcoZ2V0SG9zdENhbGxSZXR1cm5W YWx1ZSkgIjoiICJcbiIKICAgICAibW92IC00MCglZWRpKSwgJWVkaVxuIgogICAgICJtb3YgJWVk aSwgNCglZXNwKVxuIgo=