77113 2012-01-26 10:15:24 -0800 [WTF] WTFString.h has some extra JS_EXPORT_PRIVATEs 2012-01-27 12:53:48 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72854 1 morrita morrita darin kevino webkit.review.bot oldest_to_newest 543232 0 morrita 2012-01-26 10:15:24 -0800 As being mentioned at Bug 72854, there are some extra export annotation in WTFSTring.h which we can remove. 544172 1 124334 morrita 2012-01-27 10:40:47 -0800 Created attachment 124334 Patch 544175 2 124334 darin 2012-01-27 10:43:51 -0800 Comment on attachment 124334 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124334&action=review > Source/JavaScriptCore/ChangeLog:8 > + * wtf/text/WTFString.h: Removed some redundant WTF_EXPORT_PRIVATE attributes. To be clear, we are not removing these because they are “redundant”. We are removing them because we do not need to export these functions at this time. 544198 3 morrita 2012-01-27 11:09:48 -0800 Hi Darin, Thanks for your immediate review! > > Source/JavaScriptCore/ChangeLog:8 > > + * wtf/text/WTFString.h: Removed some redundant WTF_EXPORT_PRIVATE attributes. > > To be clear, we are not removing these because they are “redundant”. We are removing them because we do not need to export these functions at this time. That's right. I'll correct the explanation before land. 544200 4 124338 morrita 2012-01-27 11:14:03 -0800 Created attachment 124338 Patch for landing 544281 5 124338 webkit.review.bot 2012-01-27 12:53:43 -0800 Comment on attachment 124338 Patch for landing Clearing flags on attachment: 124338 Committed r106143: <http://trac.webkit.org/changeset/106143> 544283 6 webkit.review.bot 2012-01-27 12:53:48 -0800 All reviewed patches have been landed. Closing bug. 124334 2012-01-27 10:40:47 -0800 2012-01-27 11:13:57 -0800 Patch bug-77113-20120128034045.patch text/plain 3629 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 YmVkMzQzODAzMTZjMjFlOTc3ZjEzODhkMzQ4NDIzMTgyMTg3NWM0Li43ZGFiMjg0ZDc2MTY0NDk1 Mzk5NWI3MTA5N2E1YWYwY2EyYThiNTlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxMi0wMS0yNyAgTU9SSVRBIEhhamltZSAgPG1vcnJpdGFAZ29vZ2xlLmNv bT4KKworICAgICAgICBbV1RGXSBXVEZTdHJpbmcuaCBoYXMgc29tZSBleHRyYSBKU19FWFBPUlRf UFJJVkFURXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc3MTEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiB3dGYvdGV4dC9XVEZTdHJpbmcuaDogUmVtb3ZlZCBzb21lIHJlZHVuZGFudCBXVEZfRVhQT1JU X1BSSVZBVEUgYXR0cmlidXRlcy4KKwogMjAxMi0wMS0yNyAgWmVubyBBbGJpc3NlciAgPHplbm9A d2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdW01hY10gQnVpbGQgZmFpbHMgYWZ0ZXIgYWRkaW5n IElDVSBzdXBwb3J0IChyMTA1OTk3KS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS93dGYvdGV4dC9XVEZTdHJpbmcuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9X VEZTdHJpbmcuaAppbmRleCBlYjQ1YzdmODJjNDM3OGZkNGRjZWFiNDU2MDcwZDg5ZDU2ZWQxODg1 Li40NjdkNGQ2ZTU2YjU5YWY4NTQ0YTY4YjNlY2ViYjY5ZGY5ZGQyMjI0IDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvV1RGU3RyaW5nLmgKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1dURlN0cmluZy5oCkBAIC02Miw5ICs2Miw5IEBAIHN0cnVj dCBTdHJpbmdIYXNoOwogCiAvLyBEZWNsYXJhdGlvbnMgb2Ygc3RyaW5nIG9wZXJhdGlvbnMKIAot V1RGX0VYUE9SVF9QUklWQVRFIGludCBjaGFyYWN0ZXJzVG9JbnRTdHJpY3QoY29uc3QgTENoYXIq LCBzaXplX3QsIGJvb2wqIG9rID0gMCwgaW50IGJhc2UgPSAxMCk7CitpbnQgY2hhcmFjdGVyc1Rv SW50U3RyaWN0KGNvbnN0IExDaGFyKiwgc2l6ZV90LCBib29sKiBvayA9IDAsIGludCBiYXNlID0g MTApOwogV1RGX0VYUE9SVF9QUklWQVRFIGludCBjaGFyYWN0ZXJzVG9JbnRTdHJpY3QoY29uc3Qg VUNoYXIqLCBzaXplX3QsIGJvb2wqIG9rID0gMCwgaW50IGJhc2UgPSAxMCk7Ci1XVEZfRVhQT1JU X1BSSVZBVEUgdW5zaWduZWQgY2hhcmFjdGVyc1RvVUludFN0cmljdChjb25zdCBMQ2hhciosIHNp emVfdCwgYm9vbCogb2sgPSAwLCBpbnQgYmFzZSA9IDEwKTsKK3Vuc2lnbmVkIGNoYXJhY3RlcnNU b1VJbnRTdHJpY3QoY29uc3QgTENoYXIqLCBzaXplX3QsIGJvb2wqIG9rID0gMCwgaW50IGJhc2Ug PSAxMCk7CiBXVEZfRVhQT1JUX1BSSVZBVEUgdW5zaWduZWQgY2hhcmFjdGVyc1RvVUludFN0cmlj dChjb25zdCBVQ2hhciosIHNpemVfdCwgYm9vbCogb2sgPSAwLCBpbnQgYmFzZSA9IDEwKTsKIGlu dDY0X3QgY2hhcmFjdGVyc1RvSW50NjRTdHJpY3QoY29uc3QgTENoYXIqLCBzaXplX3QsIGJvb2wq IG9rID0gMCwgaW50IGJhc2UgPSAxMCk7CiBpbnQ2NF90IGNoYXJhY3RlcnNUb0ludDY0U3RyaWN0 KGNvbnN0IFVDaGFyKiwgc2l6ZV90LCBib29sKiBvayA9IDAsIGludCBiYXNlID0gMTApOwpAQCAt ODQsNyArODQsNyBAQCB1aW50NjRfdCBjaGFyYWN0ZXJzVG9VSW50NjQoY29uc3QgVUNoYXIqLCBz aXplX3QsIGJvb2wqIG9rID0gMCk7IC8vIGlnbm9yZXMgdHJhaQogaW50cHRyX3QgY2hhcmFjdGVy c1RvSW50UHRyKGNvbnN0IExDaGFyKiwgc2l6ZV90LCBib29sKiBvayA9IDApOyAvLyBpZ25vcmVz IHRyYWlsaW5nIGdhcmJhZ2UKIGludHB0cl90IGNoYXJhY3RlcnNUb0ludFB0cihjb25zdCBVQ2hh ciosIHNpemVfdCwgYm9vbCogb2sgPSAwKTsgLy8gaWdub3JlcyB0cmFpbGluZyBnYXJiYWdlCiAK LVdURl9FWFBPUlRfUFJJVkFURSBkb3VibGUgY2hhcmFjdGVyc1RvRG91YmxlKGNvbnN0IExDaGFy Kiwgc2l6ZV90LCBib29sKiBvayA9IDAsIGJvb2wqIGRpZFJlYWROdW1iZXIgPSAwKTsKK2RvdWJs ZSBjaGFyYWN0ZXJzVG9Eb3VibGUoY29uc3QgTENoYXIqLCBzaXplX3QsIGJvb2wqIG9rID0gMCwg Ym9vbCogZGlkUmVhZE51bWJlciA9IDApOwogV1RGX0VYUE9SVF9QUklWQVRFIGRvdWJsZSBjaGFy YWN0ZXJzVG9Eb3VibGUoY29uc3QgVUNoYXIqLCBzaXplX3QsIGJvb2wqIG9rID0gMCwgYm9vbCog ZGlkUmVhZE51bWJlciA9IDApOwogZmxvYXQgY2hhcmFjdGVyc1RvRmxvYXQoY29uc3QgTENoYXIq LCBzaXplX3QsIGJvb2wqIG9rID0gMCwgYm9vbCogZGlkUmVhZE51bWJlciA9IDApOwogV1RGX0VY UE9SVF9QUklWQVRFIGZsb2F0IGNoYXJhY3RlcnNUb0Zsb2F0KGNvbnN0IFVDaGFyKiwgc2l6ZV90 LCBib29sKiBvayA9IDAsIGJvb2wqIGRpZFJlYWROdW1iZXIgPSAwKTsKQEAgLTE4Nyw3ICsxODcs NyBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBtX2ltcGwtPmNoYXJhY3RlcnMoKVtpbmRleF07 CiAgICAgfQogCi0gICAgV1RGX0VYUE9SVF9QUklWQVRFIHN0YXRpYyBTdHJpbmcgbnVtYmVyKHNo b3J0KTsKKyAgICBzdGF0aWMgU3RyaW5nIG51bWJlcihzaG9ydCk7CiAgICAgV1RGX0VYUE9SVF9Q UklWQVRFIHN0YXRpYyBTdHJpbmcgbnVtYmVyKHVuc2lnbmVkIHNob3J0KTsKICAgICBXVEZfRVhQ T1JUX1BSSVZBVEUgc3RhdGljIFN0cmluZyBudW1iZXIoaW50KTsKICAgICBXVEZfRVhQT1JUX1BS SVZBVEUgc3RhdGljIFN0cmluZyBudW1iZXIodW5zaWduZWQpOwpAQCAtMzAxLDggKzMwMSw4IEBA IHB1YmxpYzoKICAgICBXVEZfRVhQT1JUX1BSSVZBVEUgaW50IHRvSW50U3RyaWN0KGJvb2wqIG9r ID0gMCwgaW50IGJhc2UgPSAxMCkgY29uc3Q7CiAgICAgV1RGX0VYUE9SVF9QUklWQVRFIHVuc2ln bmVkIHRvVUludFN0cmljdChib29sKiBvayA9IDAsIGludCBiYXNlID0gMTApIGNvbnN0OwogICAg IFdURl9FWFBPUlRfUFJJVkFURSBpbnQ2NF90IHRvSW50NjRTdHJpY3QoYm9vbCogb2sgPSAwLCBp bnQgYmFzZSA9IDEwKSBjb25zdDsKLSAgICBXVEZfRVhQT1JUX1BSSVZBVEUgdWludDY0X3QgdG9V SW50NjRTdHJpY3QoYm9vbCogb2sgPSAwLCBpbnQgYmFzZSA9IDEwKSBjb25zdDsKLSAgICBXVEZf RVhQT1JUX1BSSVZBVEUgaW50cHRyX3QgdG9JbnRQdHJTdHJpY3QoYm9vbCogb2sgPSAwLCBpbnQg YmFzZSA9IDEwKSBjb25zdDsKKyAgICB1aW50NjRfdCB0b1VJbnQ2NFN0cmljdChib29sKiBvayA9 IDAsIGludCBiYXNlID0gMTApIGNvbnN0OworICAgIGludHB0cl90IHRvSW50UHRyU3RyaWN0KGJv b2wqIG9rID0gMCwgaW50IGJhc2UgPSAxMCkgY29uc3Q7CiAKICAgICBXVEZfRVhQT1JUX1BSSVZB VEUgaW50IHRvSW50KGJvb2wqIG9rID0gMCkgY29uc3Q7CiAgICAgV1RGX0VYUE9SVF9QUklWQVRF IHVuc2lnbmVkIHRvVUludChib29sKiBvayA9IDApIGNvbnN0Owo= 124338 2012-01-27 11:14:03 -0800 2012-01-27 12:53:43 -0800 Patch for landing bug-77113-20120128041401.patch text/plain 3646 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 YmVkMzQzODAzMTZjMjFlOTc3ZjEzODhkMzQ4NDIzMTgyMTg3NWM0Li4xM2YxYzQzM2ZjNzVkYTVi ODU1ZDBlNTRmNzc5MzkyMDBiZTNjYzg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxMi0wMS0yNyAgTU9SSVRBIEhhamltZSAgPG1vcnJpdGFAZ29vZ2xlLmNv bT4KKworICAgICAgICBbV1RGXSBXVEZTdHJpbmcuaCBoYXMgc29tZSBleHRyYSBKU19FWFBPUlRf UFJJVkFURXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc3MTEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgKiB3 dGYvdGV4dC9XVEZTdHJpbmcuaDogUmVtb3ZlZCBzb21lIFdURl9FWFBPUlRfUFJJVkFURSBhdHRy aWJ1dGVzIHdoaWNoIHdlIGRvbid0IG5lZWQgdG8gZXhwb3J0LgorCiAyMDEyLTAxLTI3ICBaZW5v IEFsYmlzc2VyICA8emVub0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF1bTWFjXSBCdWlsZCBm YWlscyBhZnRlciBhZGRpbmcgSUNVIHN1cHBvcnQgKHIxMDU5OTcpLgpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1dURlN0cmluZy5oIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3d0Zi90ZXh0L1dURlN0cmluZy5oCmluZGV4IGViNDVjN2Y4MmM0Mzc4ZmQ0ZGNlYWI0 NTYwNzBkODlkNTZlZDE4ODUuLjQ2N2Q0ZDZlNTZiNTlhZjg1NDRhNjhiM2VjZWJiNjlkZjlkZDIy MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9XVEZTdHJpbmcu aAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvV1RGU3RyaW5nLmgKQEAgLTYy LDkgKzYyLDkgQEAgc3RydWN0IFN0cmluZ0hhc2g7CiAKIC8vIERlY2xhcmF0aW9ucyBvZiBzdHJp bmcgb3BlcmF0aW9ucwogCi1XVEZfRVhQT1JUX1BSSVZBVEUgaW50IGNoYXJhY3RlcnNUb0ludFN0 cmljdChjb25zdCBMQ2hhciosIHNpemVfdCwgYm9vbCogb2sgPSAwLCBpbnQgYmFzZSA9IDEwKTsK K2ludCBjaGFyYWN0ZXJzVG9JbnRTdHJpY3QoY29uc3QgTENoYXIqLCBzaXplX3QsIGJvb2wqIG9r ID0gMCwgaW50IGJhc2UgPSAxMCk7CiBXVEZfRVhQT1JUX1BSSVZBVEUgaW50IGNoYXJhY3RlcnNU b0ludFN0cmljdChjb25zdCBVQ2hhciosIHNpemVfdCwgYm9vbCogb2sgPSAwLCBpbnQgYmFzZSA9 IDEwKTsKLVdURl9FWFBPUlRfUFJJVkFURSB1bnNpZ25lZCBjaGFyYWN0ZXJzVG9VSW50U3RyaWN0 KGNvbnN0IExDaGFyKiwgc2l6ZV90LCBib29sKiBvayA9IDAsIGludCBiYXNlID0gMTApOwordW5z aWduZWQgY2hhcmFjdGVyc1RvVUludFN0cmljdChjb25zdCBMQ2hhciosIHNpemVfdCwgYm9vbCog b2sgPSAwLCBpbnQgYmFzZSA9IDEwKTsKIFdURl9FWFBPUlRfUFJJVkFURSB1bnNpZ25lZCBjaGFy YWN0ZXJzVG9VSW50U3RyaWN0KGNvbnN0IFVDaGFyKiwgc2l6ZV90LCBib29sKiBvayA9IDAsIGlu dCBiYXNlID0gMTApOwogaW50NjRfdCBjaGFyYWN0ZXJzVG9JbnQ2NFN0cmljdChjb25zdCBMQ2hh ciosIHNpemVfdCwgYm9vbCogb2sgPSAwLCBpbnQgYmFzZSA9IDEwKTsKIGludDY0X3QgY2hhcmFj dGVyc1RvSW50NjRTdHJpY3QoY29uc3QgVUNoYXIqLCBzaXplX3QsIGJvb2wqIG9rID0gMCwgaW50 IGJhc2UgPSAxMCk7CkBAIC04NCw3ICs4NCw3IEBAIHVpbnQ2NF90IGNoYXJhY3RlcnNUb1VJbnQ2 NChjb25zdCBVQ2hhciosIHNpemVfdCwgYm9vbCogb2sgPSAwKTsgLy8gaWdub3JlcyB0cmFpCiBp bnRwdHJfdCBjaGFyYWN0ZXJzVG9JbnRQdHIoY29uc3QgTENoYXIqLCBzaXplX3QsIGJvb2wqIG9r ID0gMCk7IC8vIGlnbm9yZXMgdHJhaWxpbmcgZ2FyYmFnZQogaW50cHRyX3QgY2hhcmFjdGVyc1Rv SW50UHRyKGNvbnN0IFVDaGFyKiwgc2l6ZV90LCBib29sKiBvayA9IDApOyAvLyBpZ25vcmVzIHRy YWlsaW5nIGdhcmJhZ2UKIAotV1RGX0VYUE9SVF9QUklWQVRFIGRvdWJsZSBjaGFyYWN0ZXJzVG9E b3VibGUoY29uc3QgTENoYXIqLCBzaXplX3QsIGJvb2wqIG9rID0gMCwgYm9vbCogZGlkUmVhZE51 bWJlciA9IDApOworZG91YmxlIGNoYXJhY3RlcnNUb0RvdWJsZShjb25zdCBMQ2hhciosIHNpemVf dCwgYm9vbCogb2sgPSAwLCBib29sKiBkaWRSZWFkTnVtYmVyID0gMCk7CiBXVEZfRVhQT1JUX1BS SVZBVEUgZG91YmxlIGNoYXJhY3RlcnNUb0RvdWJsZShjb25zdCBVQ2hhciosIHNpemVfdCwgYm9v bCogb2sgPSAwLCBib29sKiBkaWRSZWFkTnVtYmVyID0gMCk7CiBmbG9hdCBjaGFyYWN0ZXJzVG9G bG9hdChjb25zdCBMQ2hhciosIHNpemVfdCwgYm9vbCogb2sgPSAwLCBib29sKiBkaWRSZWFkTnVt YmVyID0gMCk7CiBXVEZfRVhQT1JUX1BSSVZBVEUgZmxvYXQgY2hhcmFjdGVyc1RvRmxvYXQoY29u c3QgVUNoYXIqLCBzaXplX3QsIGJvb2wqIG9rID0gMCwgYm9vbCogZGlkUmVhZE51bWJlciA9IDAp OwpAQCAtMTg3LDcgKzE4Nyw3IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIG1faW1wbC0+Y2hh cmFjdGVycygpW2luZGV4XTsKICAgICB9CiAKLSAgICBXVEZfRVhQT1JUX1BSSVZBVEUgc3RhdGlj IFN0cmluZyBudW1iZXIoc2hvcnQpOworICAgIHN0YXRpYyBTdHJpbmcgbnVtYmVyKHNob3J0KTsK ICAgICBXVEZfRVhQT1JUX1BSSVZBVEUgc3RhdGljIFN0cmluZyBudW1iZXIodW5zaWduZWQgc2hv cnQpOwogICAgIFdURl9FWFBPUlRfUFJJVkFURSBzdGF0aWMgU3RyaW5nIG51bWJlcihpbnQpOwog ICAgIFdURl9FWFBPUlRfUFJJVkFURSBzdGF0aWMgU3RyaW5nIG51bWJlcih1bnNpZ25lZCk7CkBA IC0zMDEsOCArMzAxLDggQEAgcHVibGljOgogICAgIFdURl9FWFBPUlRfUFJJVkFURSBpbnQgdG9J bnRTdHJpY3QoYm9vbCogb2sgPSAwLCBpbnQgYmFzZSA9IDEwKSBjb25zdDsKICAgICBXVEZfRVhQ T1JUX1BSSVZBVEUgdW5zaWduZWQgdG9VSW50U3RyaWN0KGJvb2wqIG9rID0gMCwgaW50IGJhc2Ug PSAxMCkgY29uc3Q7CiAgICAgV1RGX0VYUE9SVF9QUklWQVRFIGludDY0X3QgdG9JbnQ2NFN0cmlj dChib29sKiBvayA9IDAsIGludCBiYXNlID0gMTApIGNvbnN0OwotICAgIFdURl9FWFBPUlRfUFJJ VkFURSB1aW50NjRfdCB0b1VJbnQ2NFN0cmljdChib29sKiBvayA9IDAsIGludCBiYXNlID0gMTAp IGNvbnN0OwotICAgIFdURl9FWFBPUlRfUFJJVkFURSBpbnRwdHJfdCB0b0ludFB0clN0cmljdChi b29sKiBvayA9IDAsIGludCBiYXNlID0gMTApIGNvbnN0OworICAgIHVpbnQ2NF90IHRvVUludDY0 U3RyaWN0KGJvb2wqIG9rID0gMCwgaW50IGJhc2UgPSAxMCkgY29uc3Q7CisgICAgaW50cHRyX3Qg dG9JbnRQdHJTdHJpY3QoYm9vbCogb2sgPSAwLCBpbnQgYmFzZSA9IDEwKSBjb25zdDsKIAogICAg IFdURl9FWFBPUlRfUFJJVkFURSBpbnQgdG9JbnQoYm9vbCogb2sgPSAwKSBjb25zdDsKICAgICBX VEZfRVhQT1JUX1BSSVZBVEUgdW5zaWduZWQgdG9VSW50KGJvb2wqIG9rID0gMCkgY29uc3Q7Cg==