77044 2012-01-25 13:22:55 -0800 [Mac] Assertion failure in collectComplexTextRunsForCharactersCoreText 2012-03-13 16:58:19 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 77025 1 rniwa mitz hyatt mitz thorton oldest_to_newest 542574 0 rniwa 2012-01-25 13:22:55 -0800 $ Tools/Scripts/run-perf-tests --debug Parser/html5-full-render.html Running Parser/html5-full-render.html (1 of 1) crash: PerformanceTests/Parser/html5-full-render.html error: ASSERTION FAILED: runFontData /Volumes/Data/webkit3/Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm(275) : void WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText(const UChar*, unsigned int, unsigned int, const WebCore::SimpleFontData*) 1 0x101513046 WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText(unsigned short const*, unsigned int, unsigned int, WebCore::SimpleFontData const*) 2 0x101508804 WebCore::ComplexTextController::collectComplexTextRunsForCharacters(unsigned short const*, unsigned int, unsigned int, WebCore::SimpleFontData const*) 3 0x101508cf2 WebCore::ComplexTextController::collectComplexTextRuns() 4 0x10150a5e0 WebCore::ComplexTextController::ComplexTextController(WebCore::Font const*, WebCore::TextRun const&, bool, WTF::HashSet<WebCore::SimpleFontData const*, WTF::PtrHash<WebCore::SimpleFontData const*>, WTF::HashTraits<WebCore::SimpleFontData const*> >*, bool) 5 0x101a576b5 WebCore::Font::floatWidthForComplexText(WebCore::TextRun const&, WTF::HashSet<WebCore::SimpleFontData const*, WTF::PtrHash<WebCore::SimpleFontData const*>, WTF::HashTraits<WebCore::SimpleFontData const*> >*, WebCore::GlyphOverflow*) const 6 0x101a498fb WebCore::Font::width(WebCore::TextRun const&, WTF::HashSet<WebCore::SimpleFontData const*, WTF::PtrHash<WebCore::SimpleFontData const*>, WTF::HashTraits<WebCore::SimpleFontData const*> >*, WebCore::GlyphOverflow*) const 7 0x1023d4fa8 WebCore::RenderText::widthFromCache(WebCore::Font const&, int, int, float, WTF::HashSet<WebCore::SimpleFontData const*, WTF::PtrHash<WebCore::SimpleFontData const*>, WTF::HashTraits<WebCore::SimpleFontData const*> >*, WebCore::GlyphOverflow*) const 8 0x1023ce75b WebCore::RenderText::computePreferredLogicalWidths(float, WTF::HashSet<WebCore::SimpleFontData const*, WTF::PtrHash<WebCore::SimpleFontData const*>, WTF::HashTraits<WebCore::SimpleFontData const*> >&, WebCore::GlyphOverflow&) 9 0x1023cf136 WebCore::RenderText::computePreferredLogicalWidths(float) 10 0x1023cf26c WebCore::RenderText::trimmedPrefWidths(float, float&, bool&, float&, bool&, bool&, bool&, float&, float&, float&, float&, bool&) 11 0x1022311eb WebCore::RenderBlock::computeInlinePreferredLogicalWidths() 12 0x10223166a WebCore::RenderBlock::computePreferredLogicalWidths() 13 0x1023bafa1 WebCore::RenderTableCell::computePreferredLogicalWidths() 14 0x101443897 WebCore::AutoTableLayout::recalcColumn(unsigned int) 15 0x1014440bc WebCore::AutoTableLayout::fullRecalc() 16 0x10144537d WebCore::AutoTableLayout::computePreferredLogicalWidths(int&, int&) 17 0x1023b0593 WebCore::RenderTable::computePreferredLogicalWidths() 18 0x10227db0d WebCore::RenderBox::maxPreferredLogicalWidth() const 19 0x1023b26cf WebCore::RenderTable::computeLogicalWidth() 20 0x1023b16fd WebCore::RenderTable::layout() 21 0x10224269f WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, int&, int&) 22 0x1022440c8 WebCore::RenderBlock::layoutBlockChildren(bool, int&) 23 0x102244841 WebCore::RenderBlock::layoutBlock(bool, int, WebCore::RenderBlock::BlockLayoutPass) 24 0x10223ca95 WebCore::RenderBlock::layout() 25 0x10224269f WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, int&, int&) 26 0x1022440c8 WebCore::RenderBlock::layoutBlockChildren(bool, int&) 27 0x102244841 WebCore::RenderBlock::layoutBlock(bool, int, WebCore::RenderBlock::BlockLayoutPass) 28 0x10223ca95 WebCore::RenderBlock::layout() 29 0x10224269f WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, int&, int&) 30 0x1022440c8 WebCore::RenderBlock::layoutBlockChildren(bool, int&) 31 0x102244841 WebCore::RenderBlock::layoutBlock(bool, int, WebCore::RenderBlock::BlockLayoutPass) 542596 1 mitz 2012-01-25 13:54:41 -0800 Can you specify the platform and the OS version? 542602 2 rniwa 2012-01-25 13:58:41 -0800 (In reply to comment #1) > Can you specify the platform and the OS version? Snow Leopard. 576949 3 mitz 2012-03-12 20:01:22 -0700 <rdar://problem/11025217> 576963 4 mitz 2012-03-12 20:17:38 -0700 Looks like Core Text is acting up. We should not make this assertion, and if runFontData turns out to be 0, we should use the CTFont as returned (rather than doing the name lookup). 577025 5 131542 mitz 2012-03-12 21:56:43 -0700 Created attachment 131542 Handle the case of Core Text returning a fallback font that NSFontManager cannot find by name 577026 6 mitz 2012-03-12 21:57:37 -0700 Note that the test doesn’t trigger the assertion in all configurations, but that’s the closest I’ve been able to get. 577300 7 131542 eric.carlson 2012-03-13 07:48:53 -0700 Comment on attachment 131542 Handle the case of Core Text returning a fallback font that NSFontManager cannot find by name View in context: https://bugs.webkit.org/attachment.cgi?id=131542&action=review > Source/WebCore/ChangeLog:17 > + (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Removed the > + failing assertion, which was not true, and added code to handle the case where a font > + cannot be found by name by using the font as returned from Core Text. The assertion is still there, did you mean to remove it? 577327 8 mitz 2012-03-13 08:17:02 -0700 (In reply to comment #7) > (From update of attachment 131542 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=131542&action=review > > > Source/WebCore/ChangeLog:17 > > + (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Removed the > > + failing assertion, which was not true, and added code to handle the case where a font > > + cannot be found by name by using the font as returned from Core Text. > > The assertion is still there, did you mean to remove it? I did, thanks! I’m going to do it before committing. 578003 9 mitz 2012-03-13 16:58:19 -0700 Fixed in <http://trac.webkit.org/r110642>. 131542 2012-03-12 21:56:43 -0700 2012-03-13 11:40:18 -0700 Handle the case of Core Text returning a fallback font that NSFontManager cannot find by name bug-77044-20120312215645.patch text/plain 4814 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMDUzNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTEyICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzExMDI1 MjE3PiBbTWFjXSBBc3NlcnRpb24gZmFpbHVyZSBpbiBjb2xsZWN0Q29tcGxleFRleHRSdW5zRm9y Q2hhcmFjdGVyc0NvcmVUZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03NzA0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRlc3Q6IHBsYXRmb3JtL21hYy9mYXN0L3RleHQvY29yZS10ZXh0LWZhbGxiYWNr LXRvLXVua25vd24tZm9udC5odG1sCisKKyAgICAgICAgSGFuZGxlIHRoZSBjYXNlIG9mIENvcmUg VGV4dCBjaG9vc2luZyBhIGZhbGxiYWNrIGZvbnQgdGhhdCBOU0ZvbnRNYW5hZ2VyIGNhbm5vdCBm aW5kIGJ5IG5hbWUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FjaGUuaDoK KyAgICAgICAgKEZvbnRDYWNoZSk6IE1hZGUgQ29tcGxleFRleHRDb250cm9sbGVyIGEgZnJpZW5k IGNsYXNzLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL21hYy9Db21wbGV4VGV4dENvbnRy b2xsZXJDb3JlVGV4dC5tbToKKyAgICAgICAgKFdlYkNvcmU6OkNvbXBsZXhUZXh0Q29udHJvbGxl cjo6Y29sbGVjdENvbXBsZXhUZXh0UnVuc0ZvckNoYXJhY3RlcnNDb3JlVGV4dCk6IFJlbW92ZWQg dGhlCisgICAgICAgIGZhaWxpbmcgYXNzZXJ0aW9uLCB3aGljaCB3YXMgbm90IHRydWUsIGFuZCBh ZGRlZCBjb2RlIHRvIGhhbmRsZSB0aGUgY2FzZSB3aGVyZSBhIGZvbnQKKyAgICAgICAgY2Fubm90 IGJlIGZvdW5kIGJ5IG5hbWUgYnkgdXNpbmcgdGhlIGZvbnQgYXMgcmV0dXJuZWQgZnJvbSBDb3Jl IFRleHQuCisKIDIwMTItMDMtMTIgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFtWOF1bUmVmYWN0b3JpbmddIFJlbW92ZSBnZXRDYWNoZWRXcmFwcGVyU2xv dygpIGZyb20gVjhCaW5kaW5ncy5jcHAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0ZvbnRDYWNoZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0ZvbnRDYWNoZS5oCShyZXZpc2lvbiAxMTA1MzUpCisrKyBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FjaGUuaAkod29ya2luZyBjb3B5KQpAQCAtMTMwLDYg KzEzMCw5IEBAIHByaXZhdGU6CiAgICAgLy8gRG9uJ3QgcHVyZ2UgaWYgdGhpcyBjb3VudCBpcyA+ IDA7CiAgICAgaW50IG1fcHVyZ2VQcmV2ZW50Q291bnQ7CiAKKyNpZiBVU0UoQ09SRV9URVhUKQor ICAgIGZyaWVuZCBjbGFzcyBDb21wbGV4VGV4dENvbnRyb2xsZXI7CisjZW5kaWYKICAgICBmcmll bmQgY2xhc3MgU2ltcGxlRm9udERhdGE7IC8vIEZvciBnZXRDYWNoZWRGb250RGF0YShjb25zdCBG b250UGxhdGZvcm1EYXRhKikKICAgICBmcmllbmQgY2xhc3MgRm9udEZhbGxiYWNrTGlzdDsKIH07 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvQ29tcGxleFRleHRD b250cm9sbGVyQ29yZVRleHQubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvbWFjL0NvbXBsZXhUZXh0Q29udHJvbGxlckNvcmVUZXh0Lm1tCShyZXZpc2lv biAxMTA1MzUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvQ29tcGxl eFRleHRDb250cm9sbGVyQ29yZVRleHQubW0JKHdvcmtpbmcgY29weSkKQEAgLTI3MSw2ICsyNzEs MTIgQEAgdm9pZCBDb21wbGV4VGV4dENvbnRyb2xsZXI6OmNvbGxlY3RDb21wbAogICAgICAgICAg ICAgICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAg ICAgICAgICAgICAgcnVuRm9udERhdGEgPSBmb250Q2FjaGUoKS0+Z2V0Q2FjaGVkRm9udERhdGEo bV9mb250LmZvbnREZXNjcmlwdGlvbigpLCBmb250TmFtZS5nZXQoKSwgZmFsc2UsIEZvbnRDYWNo ZTo6RG9Ob3RSZXRhaW4pOworICAgICAgICAgICAgICAgICAgICAvLyBDb3JlIFRleHQgbWF5IGhh dmUgdXNlZCBhIGZvbnQgdGhhdCBpcyBub3Qga25vd24gdG8gTlNGb250TWFuYWdlci4gSW4gdGhh dCBjYXNlLCBmYWxsIGJhY2sgb24KKyAgICAgICAgICAgICAgICAgICAgLy8gdXNpbmcgdGhlIGZv bnQgYXMgcmV0dXJuZWQsIGV2ZW4gdGhvdWdoIGl0IG1heSBub3QgaGF2ZSB0aGUgYmVzdCBOU0Zv bnRSZW5kZXJpbmdNb2RlLgorICAgICAgICAgICAgICAgICAgICBpZiAoIXJ1bkZvbnREYXRhKSB7 CisgICAgICAgICAgICAgICAgICAgICAgICBGb250UGxhdGZvcm1EYXRhIHJ1bkZvbnRQbGF0Zm9y bURhdGEoKE5TRm9udCAqKXJ1bkZvbnQsIENURm9udEdldFNpemUocnVuRm9udCkpOworICAgICAg ICAgICAgICAgICAgICAgICAgcnVuRm9udERhdGEgPSBmb250Q2FjaGUoKS0+Z2V0Q2FjaGVkRm9u dERhdGEoJnJ1bkZvbnRQbGF0Zm9ybURhdGEsIEZvbnRDYWNoZTo6RG9Ob3RSZXRhaW4pOworICAg ICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIEFT U0VSVChydW5Gb250RGF0YSk7CiAgICAgICAgICAgICAgICAgaWYgKG1fZmFsbGJhY2tGb250cyAm JiBydW5Gb250RGF0YSAhPSBtX2ZvbnQucHJpbWFyeUZvbnQoKSkKSW5kZXg6IExheW91dFRlc3Rz L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9u IDExMDUzNikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEyLTAzLTEyICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzExMDI1MjE3PiBbTWFjXSBBc3NlcnRpb24gZmFpbHVy ZSBpbiBjb2xsZWN0Q29tcGxleFRleHRSdW5zRm9yQ2hhcmFjdGVyc0NvcmVUZXh0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzA0NAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL2Zh c3QvdGV4dC9jb3JlLXRleHQtZmFsbGJhY2stdG8tdW5rbm93bi1mb250LWV4cGVjdGVkLnR4dDog QWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2Zhc3QvdGV4dC9jb3JlLXRleHQtZmFsbGJh Y2stdG8tdW5rbm93bi1mb250Lmh0bWw6IEFkZGVkLgorCiAyMDEyLTAzLTEyICBIYW5zIE11bGxl ciAgPGhtdWxsZXJAYWRvYmUuY29tPgogCiAgICAgICAgIFNWRyBzaG91bGQgc3VwcG9ydCB0cmFu c2Zvcm0tb3JpZ2luIGFuZCByZWxhdGl2ZSB2YWx1ZXMKSW5kZXg6IExheW91dFRlc3RzL3BsYXRm b3JtL21hYy9mYXN0L3RleHQvY29yZS10ZXh0LWZhbGxiYWNrLXRvLXVua25vd24tZm9udC1leHBl Y3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvdGV4 dC9jb3JlLXRleHQtZmFsbGJhY2stdG8tdW5rbm93bi1mb250LWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3RleHQvY29yZS10ZXh0LWZh bGxiYWNrLXRvLXVua25vd24tZm9udC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMyBAQAorVGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2VzIG5vdCBjYXVzZSBhbiBhc3NlcnRp b24gZmFpbHVyZSBvciBhIGNyYXNoLgorCivil4zMowpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL2Zhc3QvdGV4dC9jb3JlLXRleHQtZmFsbGJhY2stdG8tdW5rbm93bi1mb250Lmh0bWwK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvdGV4dC9jb3JlLXRl eHQtZmFsbGJhY2stdG8tdW5rbm93bi1mb250Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC90ZXh0L2NvcmUtdGV4dC1mYWxsYmFjay10by11bmtub3du LWZvbnQuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw4IEBACis8c2NyaXB0PgorICAgIGlm ICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIGxheW91dFRlc3RDb250cm9s bGVyLmR1bXBBc1RleHQoKTsKKzwvc2NyaXB0PgorPHA+CisgICAgVGhpcyB0ZXN0IHBhc3NlcyBp ZiBpdCBkb2VzIG5vdCBjYXVzZSBhbiBhc3NlcnRpb24gZmFpbHVyZSBvciBhIGNyYXNoLgorPC9w PgorPHNwYW4gc3R5bGU9ImZvbnQtd2VpZ2h0OiBib2xkOyBmb250LWZhbWlseTogaGVsdmV0aWNh Ij4mI3gyNWNjOyYjeDAzMjM7PC9zcGFuPgo=