76926 2012-01-24 10:54:56 -0800 CodeGeneratorCPP.pm should overwrite the output .h/.cpp only if the bytes differ 2012-01-24 14:10:06 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76836 1 haraken haraken abarth darin dglazkov japhet webkit.review.bot oldest_to_newest 541477 0 haraken 2012-01-24 10:54:56 -0800 This is one of steps to stop rebuilding .h/.cpp files generated by unchanged IDLs (bug 76836). In this bug, we make a change on CodeGeneratorCPP.pm so that it overwrites the output .h/.cpp only if the bytes differ. 541484 1 123772 haraken 2012-01-24 11:00:27 -0800 Created attachment 123772 Patch 541560 2 123772 webkit.review.bot 2012-01-24 12:32:08 -0800 Comment on attachment 123772 Patch Attachment 123772 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11242291 New failing tests: media/audio-garbage-collect.html 541676 3 123772 webkit.review.bot 2012-01-24 14:10:01 -0800 Comment on attachment 123772 Patch Clearing flags on attachment: 123772 Committed r105805: <http://trac.webkit.org/changeset/105805> 541677 4 webkit.review.bot 2012-01-24 14:10:06 -0800 All reviewed patches have been landed. Closing bug. 123772 2012-01-24 11:00:27 -0800 2012-01-24 14:10:01 -0800 Patch bug-76926-20120124110026.patch text/plain 3816 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmI2OWIxZjc1YjYyNGVh ODMyNDNhYjNjNTAwNDJiYzFjYzdjZTA5ZC4uNDQzM2M4MDlhOGMyOTk0NDBhM2YyNzNlMGEwYzYz ZDcyMzc0MTczMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAxLTI0ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBDb2RlR2VuZXJhdG9y Q1BQLnBtIHNob3VsZCBvdmVyd3JpdGUgdGhlIG91dHB1dCAuaC8uY3BwCisgICAgICAgIG9ubHkg aWYgdGhlIGJ5dGVzIGRpZmZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzY5MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGlzIGlzIG9uZSBvZiBzdGVwcyB0byBzdG9wIHJlYnVpbGRpbmcgLmgvLmNw cCBmaWxlcworICAgICAgICBnZW5lcmF0ZWQgYnkgdW5jaGFuZ2VkIElETHMgKGJ1ZyA3NjgzNiku CisgICAgICAgIFRoaXMgcGF0Y2ggbWFrZXMgYSBjaGFuZ2Ugb24gQ29kZUdlbmVyYXRvckNQUC5w bSBzbyB0aGF0CisgICAgICAgIGl0IG92ZXJ3cml0ZXMgdGhlIG91dHB1dCAuaC8uY3BwIG9ubHkg aWYgdGhlIGJ5dGVzIGRpZmZlci4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJl aGF2aW9yLgorICAgICAgICBNYW51YWxseSBjb25maXJtIHRoYXQgd2hlbiB5b3UgYWRkIGEgbmV3 IGF0dHJpYnV0ZSB0byBFbGVtZW50LmlkbCwKKyAgICAgICAgdGhlIHRpbWUtc3RhbXBzIG9mIHVu cmVsYXRlZCBXZWJET00qLmggYW5kIFdlYkRPTSouY3BwIGRvIG5vdCBjaGFuZ2UuCisKKyAgICAg ICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JDUFAucG06CisgICAgICAgIChXcml0 ZURhdGEpOiBVc2VkIFVwZGF0ZUZpbGVJZkNoYW5nZWQoKS4KKwogMjAxMi0wMS0yNCAgTWFyaW8g U2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gUmVm YWN0b3IgR1RLJ3MgYWNjZXNzaWJpbGl0aXR5IGNvZGUgdG8gYmUgbW9yZSBtb2R1bGFyCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JDUFAu cG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JDUFAucG0K aW5kZXggNjk2NmQ5MGY5YzZhZDY0NzNiMmNmODY1YjhmYjk4MzAzY2MwZTc1ZC4uZDgxY2M2NGQx MGE4MmQwNmNlM2E4OWE1NjQwYjA1ZjgwNjc3NGU1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yQ1BQLnBtCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckNQUC5wbQpAQCAtOTM3LDE1ICs5Mzcs OSBAQCBzdWIgV3JpdGVEYXRhCiAgICAgbXkgJGhlYWRlckZpbGVOYW1lID0gIiRvdXRwdXREaXIv IiAuICRuYW1lIC4gIi5oIjsKICAgICBteSAkaW1wbEZpbGVOYW1lID0gIiRvdXRwdXREaXIvIiAu ICRuYW1lIC4gIi5jcHAiOwogCi0gICAgIyBSZW1vdmUgb2xkIGZpbGVzLgotICAgIHVubGluaygk aGVhZGVyRmlsZU5hbWUpOwotICAgIHVubGluaygkaW1wbEZpbGVOYW1lKTsKLQotICAgICMgV3Jp dGUgcHVibGljIGhlYWRlci4KLSAgICBvcGVuKEhFQURFUiwgIj4kaGVhZGVyRmlsZU5hbWUiKSBv ciBkaWUgIkNvdWxkbid0IG9wZW4gZmlsZSAkaGVhZGVyRmlsZU5hbWUiOwotICAgIAotICAgIHBy aW50IEhFQURFUiBAaGVhZGVyQ29udGVudEhlYWRlcjsKLSAgICBwcmludCBIRUFERVIgIlxuIjsK KyAgICAjIFVwZGF0ZSBhIC5oIGZpbGUgaWYgdGhlIGNvbnRlbnRzIGFyZSBjaGFuZ2VkLgorICAg IG15ICRjb250ZW50cyA9IGpvaW4gIiIsIEBoZWFkZXJDb250ZW50SGVhZGVyOworICAgICRjb250 ZW50cyAuPSAiXG4iOwogICAgIGZvcmVhY2ggbXkgJGNsYXNzIChzb3J0IGtleXMoJWhlYWRlckZv cndhcmREZWNsYXJhdGlvbnMpKSB7CiAgICAgICAgIGlmICgkY2xhc3MgPX4gLzo6LykgewogICAg ICAgICAgICAgbXkgJG5hbWVzcGFjZVBhcnQgPSAkY2xhc3M7CkBAIC05NTQsMzQgKzk0OCwzMiBA QCBzdWIgV3JpdGVEYXRhCiAgICAgICAgICAgICBteSAkY2xhc3NQYXJ0ID0gJGNsYXNzOwogICAg ICAgICAgICAgJGNsYXNzUGFydCA9fiBzLyR7bmFtZXNwYWNlUGFydH06Oi8vOwogCi0gICAgICAg ICAgICBwcmludCBIRUFERVIgIm5hbWVzcGFjZSAkbmFtZXNwYWNlUGFydCB7XG5jbGFzcyAkY2xh c3NQYXJ0O1xufTtcblxuIjsKKyAgICAgICAgICAgICRjb250ZW50cyAuPSAibmFtZXNwYWNlICRu YW1lc3BhY2VQYXJ0IHtcbmNsYXNzICRjbGFzc1BhcnQ7XG59O1xuXG4iOwogICAgICAgICB9IGVs c2UgewotICAgICAgICAgICAgcHJpbnQgSEVBREVSICJjbGFzcyAkY2xhc3M7XG4iCisgICAgICAg ICAgICAkY29udGVudHMgLj0gImNsYXNzICRjbGFzcztcbiIKICAgICAgICAgfQogICAgIH0KIAog ICAgIG15ICRoYXNGb3J3YXJkRGVjbGFyYXRpb25zID0ga2V5cyglaGVhZGVyRm9yd2FyZERlY2xh cmF0aW9ucyk7Ci0gICAgcHJpbnQgSEVBREVSICJcbiIgaWYgJGhhc0ZvcndhcmREZWNsYXJhdGlv bnM7Ci0gICAgcHJpbnQgSEVBREVSIEBoZWFkZXJDb250ZW50OwotICAgIGNsb3NlKEhFQURFUik7 CisgICAgJGNvbnRlbnRzIC49ICJcbiIgaWYgJGhhc0ZvcndhcmREZWNsYXJhdGlvbnM7CisgICAg JGNvbnRlbnRzIC49IGpvaW4gIiIsIEBoZWFkZXJDb250ZW50OworICAgICRjb2RlR2VuZXJhdG9y LT5VcGRhdGVGaWxlSWZDaGFuZ2VkKCRoZWFkZXJGaWxlTmFtZSwgJGNvbnRlbnRzKTsKIAogICAg IEBoZWFkZXJDb250ZW50SGVhZGVyID0gKCk7CiAgICAgQGhlYWRlckNvbnRlbnQgPSAoKTsKICAg ICAlaGVhZGVyRm9yd2FyZERlY2xhcmF0aW9ucyA9ICgpOwogCi0gICAgIyBXcml0ZSBpbXBsZW1l bnRhdGlvbiBmaWxlLgotICAgIG9wZW4oSU1QTCwgIj4kaW1wbEZpbGVOYW1lIikgb3IgZGllICJD b3VsZG4ndCBvcGVuIGZpbGUgJGltcGxGaWxlTmFtZSI7Ci0KLSAgICBwcmludCBJTVBMIEBpbXBs Q29udGVudEhlYWRlcjsKKyAgICAjIFVwZGF0ZSBhIC5jcHAgZmlsZSBpZiB0aGUgY29udGVudHMg YXJlIGNoYW5nZWQuCisgICAgJGNvbnRlbnRzID0gam9pbiAiIiwgQGltcGxDb250ZW50SGVhZGVy OwogCiAgICAgZm9yZWFjaCBteSAkaW5jbHVkZSAoc29ydCBrZXlzKCVpbXBsSW5jbHVkZXMpKSB7 CiAgICAgICAgICMgImNsYXNzTmFtZS5oIiBpcyBhbHJlYWR5IGluY2x1ZGVkIHJpZ2h0IGFmdGVy IGNvbmZpZy5oLCBzaWxlbmNlIGNoZWNrLXdlYmtpdC1zdHlsZQogICAgICAgICBuZXh0IGlmICRp bmNsdWRlIGVxICIkbmFtZS5oIjsKLSAgICAgICAgcHJpbnQgSU1QTCAiI2luY2x1ZGUgXCIkaW5j bHVkZVwiXG4iOworICAgICAgICAkY29udGVudHMgLj0gIiNpbmNsdWRlIFwiJGluY2x1ZGVcIlxu IjsKICAgICB9CiAKLSAgICBwcmludCBJTVBMIEBpbXBsQ29udGVudDsKLSAgICBjbG9zZShJTVBM KTsKKyAgICAkY29udGVudHMgLj0gam9pbiAiIiwgQGltcGxDb250ZW50OworICAgICRjb2RlR2Vu ZXJhdG9yLT5VcGRhdGVGaWxlSWZDaGFuZ2VkKCRpbXBsRmlsZU5hbWUsICRjb250ZW50cyk7CiAK ICAgICBAaW1wbENvbnRlbnRIZWFkZXIgPSAoKTsKICAgICBAaW1wbENvbnRlbnQgPSAoKTsK