76922 2012-01-24 09:51:38 -0800 CodeGeneratorJS.pm should overwrite the output .h/.cpp only if the bytes differ 2012-01-24 14:24:21 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76836 1 haraken haraken abarth darin japhet webkit.review.bot oldest_to_newest 541409 0 haraken 2012-01-24 09:51:38 -0800 This is one of steps to stop rebuilding .h/.cpp files generated by unchanged IDLs (bug 76836). In this bug, we make a change on CodeGeneratorJS.pm so that it overwrites the output .h/.cpp only if the bytes differ. 541416 1 123758 haraken 2012-01-24 10:01:35 -0800 Created attachment 123758 Patch 541662 2 123758 webkit.review.bot 2012-01-24 14:01:03 -0800 Comment on attachment 123758 Patch Rejecting attachment 123758 from commit-queue. New failing tests: media/audio-garbage-collect.html Full output: http://queues.webkit.org/results/11177053 541693 3 123758 webkit.review.bot 2012-01-24 14:24:17 -0800 Comment on attachment 123758 Patch Clearing flags on attachment: 123758 Committed r105809: <http://trac.webkit.org/changeset/105809> 541694 4 webkit.review.bot 2012-01-24 14:24:21 -0800 All reviewed patches have been landed. Closing bug. 123758 2012-01-24 10:01:35 -0800 2012-01-24 14:24:17 -0800 Patch bug-76922-20120124100134.patch text/plain 4581 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmI2OWIxZjc1YjYyNGVh ODMyNDNhYjNjNTAwNDJiYzFjYzdjZTA5ZC4uNjVlMmU5YzNmNWRjOTQ2NzMwYzI5OWRmZTc5MDI5 MDE2YjU4NGNmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAxLTI0ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBDb2RlR2VuZXJhdG9y SlMucG0gc2hvdWxkIG92ZXJ3cml0ZSB0aGUgb3V0cHV0IC5oLy5jcHAKKyAgICAgICAgb25seSBp ZiB0aGUgYnl0ZXMgZGlmZmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03NjkyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoaXMgaXMgb25lIG9mIHN0ZXBzIHRvIHN0b3AgcmVidWlsZGluZyAuaC8uY3Bw IGZpbGVzCisgICAgICAgIGdlbmVyYXRlZCBieSB1bmNoYW5nZWQgSURMcyAoYnVnIDc2ODM2KS4K KyAgICAgICAgVGhpcyBwYXRjaCBtYWtlcyBhIGNoYW5nZSBvbiBDb2RlR2VuZXJhdG9ySlMucG0g c28gdGhhdAorICAgICAgICBpdCBvdmVyd3JpdGVzIHRoZSBvdXRwdXQgLmgvLmNwcCBvbmx5IGlm IHRoZSBieXRlcyBkaWZmZXIuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhh dmlvci4KKyAgICAgICAgSSBtYW51YWxseSBjb25maXJtZWQgdGhhdCB3aGVuIEkgYWRkIGEgbmV3 IGF0dHJpYnV0ZSB0byBFbGVtZW50LmlkbCwKKyAgICAgICAgdGhlIHRpbWUtc3RhbXBzIG9mIHVu cmVsYXRlZCBKUyouaCBhbmQgSlMqLmNwcCBkbyBub3QgY2hhbmdlLgorCisgICAgICAgICogYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG06CisgICAgICAgIChXcml0ZURhdGEpOiBV c2VkIFVwZGF0ZUZpbGVJZkNoYW5nZWQoKS4KKwogMjAxMi0wMS0yNCAgTWFyaW8gU2FuY2hleiBQ cmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gUmVmYWN0b3IgR1RL J3MgYWNjZXNzaWJpbGl0aXR5IGNvZGUgdG8gYmUgbW9yZSBtb2R1bGFyCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbSBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCmluZGV4IDQyNjI3 N2VhYzMzNThjMmE0OTU1MzI2ODM4YjNmMmQyMzc1MzgzZjYuLjNhNTA3ZjI5YjU2NTI1ZjIzZjY0 ZWE3YjI0ZGMzNDRiMGZlZTBkMGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCkBAIC0zMjQwLDEzICszMjQwLDggQEAgc3ViIFdy aXRlRGF0YQogICAgIG15ICRpbXBsRmlsZU5hbWUgPSAiJG91dHB1dERpci8kcHJlZml4JG5hbWUu Y3BwIjsKICAgICBteSAkZGVwc0ZpbGVOYW1lID0gIiRvdXRwdXREaXIvJHByZWZpeCRuYW1lLmRl cCI7CiAKLSAgICAjIFJlbW92ZSBvbGQgZGVwZW5kZW5jeSBmaWxlLgotICAgIHVubGluaygkZGVw c0ZpbGVOYW1lKTsKLQotICAgIG9wZW4oSU1QTCwgIj4kaW1wbEZpbGVOYW1lIikgfHwgZGllICJD b3VsZG4ndCBvcGVuIGZpbGUgJGltcGxGaWxlTmFtZSI7Ci0KLSAgICAjIFdyaXRlIGNvbnRlbnQg dG8gZmlsZS4KLSAgICBwcmludCBJTVBMIEBpbXBsQ29udGVudEhlYWRlcjsKKyAgICAjIFVwZGF0 ZSBhIC5jcHAgZmlsZSBpZiB0aGUgY29udGVudHMgYXJlIGNoYW5nZWQuCisgICAgbXkgJGNvbnRl bnRzID0gam9pbiAiIiwgQGltcGxDb250ZW50SGVhZGVyOwogCiAgICAgbXkgQGluY2x1ZGVzID0g KCk7CiAgICAgbXkgJWltcGxJbmNsdWRlQ29uZGl0aW9ucyA9ICgpOwpAQCAtMzI2NSwyNyArMzI2 MCwyNSBAQCBzdWIgV3JpdGVEYXRhCiAgICAgICAgIH0KICAgICB9CiAgICAgZm9yZWFjaCBteSAk aW5jbHVkZSAoc29ydCBAaW5jbHVkZXMpIHsKLSAgICAgICAgcHJpbnQgSU1QTCAiI2luY2x1ZGUg JGluY2x1ZGVcbiI7CisgICAgICAgICRjb250ZW50cyAuPSAiI2luY2x1ZGUgJGluY2x1ZGVcbiI7 CiAgICAgfQogICAgIGZvcmVhY2ggbXkgJGNvbmRpdGlvbiAoc29ydCBrZXlzICVpbXBsSW5jbHVk ZUNvbmRpdGlvbnMpIHsKLSAgICAgICAgcHJpbnQgSU1QTCAiXG4jaWYgIiAuICRjb2RlR2VuZXJh dG9yLT5HZW5lcmF0ZUNvbmRpdGlvbmFsU3RyaW5nRnJvbUF0dHJpYnV0ZVZhbHVlKCRjb25kaXRp b24pIC4gIlxuIjsKKyAgICAgICAgJGNvbnRlbnRzIC49ICJcbiNpZiAiIC4gJGNvZGVHZW5lcmF0 b3ItPkdlbmVyYXRlQ29uZGl0aW9uYWxTdHJpbmdGcm9tQXR0cmlidXRlVmFsdWUoJGNvbmRpdGlv bikgLiAiXG4iOwogICAgICAgICBmb3JlYWNoIG15ICRpbmNsdWRlIChzb3J0IEB7JGltcGxJbmNs dWRlQ29uZGl0aW9uc3skY29uZGl0aW9ufX0pIHsKLSAgICAgICAgICAgIHByaW50IElNUEwgIiNp bmNsdWRlICRpbmNsdWRlXG4iOworICAgICAgICAgICAgJGNvbnRlbnRzIC49ICIjaW5jbHVkZSAk aW5jbHVkZVxuIjsKICAgICAgICAgfQotICAgICAgICBwcmludCBJTVBMICIjZW5kaWZcbiI7Cisg ICAgICAgICRjb250ZW50cyAuPSAiI2VuZGlmXG4iOwogICAgIH0KIAotICAgIHByaW50IElNUEwg QGltcGxDb250ZW50OwotICAgIGNsb3NlKElNUEwpOworICAgICRjb250ZW50cyAuPSBqb2luICIi LCBAaW1wbENvbnRlbnQ7CisgICAgJGNvZGVHZW5lcmF0b3ItPlVwZGF0ZUZpbGVJZkNoYW5nZWQo JGltcGxGaWxlTmFtZSwgJGNvbnRlbnRzKTsKIAogICAgIEBpbXBsQ29udGVudEhlYWRlciA9ICgp OwogICAgIEBpbXBsQ29udGVudCA9ICgpOwogICAgICVpbXBsSW5jbHVkZXMgPSAoKTsKIAotICAg IG9wZW4oSEVBREVSLCAiPiRoZWFkZXJGaWxlTmFtZSIpIHx8IGRpZSAiQ291bGRuJ3Qgb3BlbiBm aWxlICRoZWFkZXJGaWxlTmFtZSI7Ci0KLSAgICAjIFdyaXRlIGNvbnRlbnQgdG8gZmlsZS4KLSAg ICBwcmludCBIRUFERVIgQGhlYWRlckNvbnRlbnRIZWFkZXI7CisgICAgIyBVcGRhdGUgYSAuaCBm aWxlIGlmIHRoZSBjb250ZW50cyBhcmUgY2hhbmdlZC4KKyAgICAkY29udGVudHMgPSBqb2luICIi LCBAaGVhZGVyQ29udGVudEhlYWRlcjsKIAogICAgIEBpbmNsdWRlcyA9ICgpOwogICAgIGZvcmVh Y2ggbXkgJGluY2x1ZGUgKGtleXMgJWhlYWRlckluY2x1ZGVzKSB7CkBAIC0zMjkzLDEwICszMjg2 LDEwIEBAIHN1YiBXcml0ZURhdGEKICAgICAgICAgcHVzaCBAaW5jbHVkZXMsICRpbmNsdWRlOwog ICAgIH0KICAgICBmb3JlYWNoIG15ICRpbmNsdWRlIChzb3J0IEBpbmNsdWRlcykgewotICAgICAg ICBwcmludCBIRUFERVIgIiNpbmNsdWRlICRpbmNsdWRlXG4iOworICAgICAgICAkY29udGVudHMg Lj0gIiNpbmNsdWRlICRpbmNsdWRlXG4iOwogICAgIH0KIAotICAgIHByaW50IEhFQURFUiBAaGVh ZGVyQ29udGVudDsKKyAgICAkY29udGVudHMgLj0gam9pbiAiIiwgQGhlYWRlckNvbnRlbnQ7CiAK ICAgICBAaW5jbHVkZXMgPSAoKTsKICAgICBmb3JlYWNoIG15ICRpbmNsdWRlIChrZXlzICVoZWFk ZXJUcmFpbGluZ0luY2x1ZGVzKSB7CkBAIC0zMzA0LDEwICszMjk3LDkgQEAgc3ViIFdyaXRlRGF0 YQogICAgICAgICBwdXNoIEBpbmNsdWRlcywgJGluY2x1ZGU7CiAgICAgfQogICAgIGZvcmVhY2gg bXkgJGluY2x1ZGUgKHNvcnQgQGluY2x1ZGVzKSB7Ci0gICAgICAgIHByaW50IEhFQURFUiAiI2lu Y2x1ZGUgJGluY2x1ZGVcbiI7CisgICAgICAgICRjb250ZW50cyAuPSAiI2luY2x1ZGUgJGluY2x1 ZGVcbiI7CiAgICAgfQotCi0gICAgY2xvc2UoSEVBREVSKTsKKyAgICAkY29kZUdlbmVyYXRvci0+ VXBkYXRlRmlsZUlmQ2hhbmdlZCgkaGVhZGVyRmlsZU5hbWUsICRjb250ZW50cyk7CiAKICAgICBA aGVhZGVyQ29udGVudEhlYWRlciA9ICgpOwogICAgIEBoZWFkZXJDb250ZW50ID0gKCk7CkBAIC0z MzE1LDEwICszMzA3LDkgQEAgc3ViIFdyaXRlRGF0YQogICAgICVoZWFkZXJUcmFpbGluZ0luY2x1 ZGVzID0gKCk7CiAKICAgICBpZiAoQGRlcHNDb250ZW50KSB7Ci0gICAgICAgIG9wZW4oREVQUywg Ij4kZGVwc0ZpbGVOYW1lIikgfHwgZGllICJDb3VsZG4ndCBvcGVuIGZpbGUgJGRlcHNGaWxlTmFt ZSI7Ci0gICAgICAgICMgV3JpdGUgZGVwZW5kZW5jeSBmaWxlLgotICAgICAgICBwcmludCBERVBT IEBkZXBzQ29udGVudDsKLSAgICAgICAgY2xvc2UoREVQUyk7CisgICAgICAgICMgVXBkYXRlIGEg LmRlcCBmaWxlIGlmIHRoZSBjb250ZW50cyBhcmUgY2hhbmdlZC4KKyAgICAgICAgJGNvbnRlbnRz ID0gam9pbiAiIiwgQGRlcHNDb250ZW50OworICAgICAgICAkY29kZUdlbmVyYXRvci0+VXBkYXRl RmlsZUlmQ2hhbmdlZCgkZGVwc0ZpbGVOYW1lLCAkY29udGVudHMpOwogCiAgICAgICAgIEBkZXBz Q29udGVudCA9ICgpOwogICAgIH0K