76920 2012-01-24 09:34:33 -0800 CodeGeneratorV8.pm should overwrite the output .h/.cpp only if the bytes differ 2012-01-24 11:40:52 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76836 1 haraken haraken abarth darin japhet webkit.review.bot oldest_to_newest 541392 0 haraken 2012-01-24 09:34:33 -0800 This is one of steps to stop rebuilding .h/.cpp files generated by unchanged IDLs (bug 76836). In this bug, we make a change on CodeGeneratorV8.pm so that it overwrites the output .h/.cpp only if the bytes differ. 541401 1 123754 haraken 2012-01-24 09:42:42 -0800 Created attachment 123754 Patch 541521 2 123754 webkit.review.bot 2012-01-24 11:40:48 -0800 Comment on attachment 123754 Patch Clearing flags on attachment: 123754 Committed r105766: <http://trac.webkit.org/changeset/105766> 541522 3 webkit.review.bot 2012-01-24 11:40:52 -0800 All reviewed patches have been landed. Closing bug. 123754 2012-01-24 09:42:42 -0800 2012-01-24 11:40:48 -0800 Patch bug-76920-20120124094241.patch text/plain 3498 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmI2OWIxZjc1YjYyNGVh ODMyNDNhYjNjNTAwNDJiYzFjYzdjZTA5ZC4uMGY2OTU4ZjMyOGVmYTBmZWYxNTVhMjNlYTBjOTBl NDQzMmI4NmUxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAxLTI0ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbiBDb2RlR2VuZXJh dG9yVjgucG0sIG92ZXJ3cml0ZSB0aGUgb3V0cHV0IC5oLy5jcHAKKyAgICAgICAgb25seSBpZiB0 aGUgYnl0ZXMgZGlmZmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03NjkyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoaXMgaXMgb25lIG9mIHN0ZXBzIHRvIHN0b3AgcmVidWlsZGluZyAuaC8uY3BwIGZp bGVzCisgICAgICAgIGdlbmVyYXRlZCBieSB1bmNoYW5nZWQgSURMcyAoYnVnIDc2ODM2KS4KKyAg ICAgICAgVGhpcyBwYXRjaCBtYWtlcyBhIGNoYW5nZSBvbiBDb2RlR2VuZXJhdG9yVjgucG0gc28g dGhhdAorICAgICAgICBpdCBvdmVyd3JpdGVzIHRoZSBvdXRwdXQgLmgvLmNwcCBvbmx5IGlmIHRo ZSBieXRlcyBkaWZmZXIuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlv ci4KKyAgICAgICAgSSBtYW51YWxseSBjb25maXJtZWQgdGhhdCB3aGVuIEkgYWRkIGEgbmV3IGF0 dHJpYnV0ZSB0byBFbGVtZW50LmlkbCwKKyAgICAgICAgdGhlIHRpbWUtc3RhbXBzIG9mIHVucmVs YXRlZCBWOCouaCBhbmQgVjgqLmNwcCBkbyBub3QgY2hhbmdlLgorCisgICAgICAgICogYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06CisgICAgICAgIChXcml0ZURhdGEpOiBVc2Vk IFVwZGF0ZUZpbGVJZkNoYW5nZWQoKS4KKwogMjAxMi0wMS0yNCAgTWFyaW8gU2FuY2hleiBQcmFk YSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gUmVmYWN0b3IgR1RLJ3Mg YWNjZXNzaWJpbGl0aXR5IGNvZGUgdG8gYmUgbW9yZSBtb2R1bGFyCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCmluZGV4IDRkMzRkMmFk Mjg4ZTBiNjAyNzAzYWU1ODllN2EzYzVlZTNiMjBjNDkuLjY1NDA2MmIxZWVjYWZjMzhhNjM1YTRi NDhmMzFjMDI5NmRiY2QxYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0zODA1LDExICszODA1LDggQEAgc3ViIFdyaXRl RGF0YQogICAgIG15ICRoZWFkZXJGaWxlTmFtZSA9ICIkb3V0cHV0SGVhZGVyc0Rpci8kcHJlZml4 JG5hbWUuaCI7CiAgICAgbXkgJGltcGxGaWxlTmFtZSA9ICIkb3V0cHV0RGlyLyRwcmVmaXgkbmFt ZS5jcHAiOwogCi0gICAgb3BlbihJTVBMLCAiPiRpbXBsRmlsZU5hbWUiKSB8fCBkaWUgIkNvdWxk bid0IG9wZW4gZmlsZSAkaW1wbEZpbGVOYW1lIjsKLQotICAgICMgV3JpdGUgY29udGVudCB0byBm aWxlLgotICAgIHByaW50IElNUEwgQGltcGxDb250ZW50SGVhZGVyOwotICAgIHByaW50IElNUEwg QGltcGxGaXhlZEhlYWRlcjsKKyAgICAjIFVwZGF0ZSBhIC5jcHAgZmlsZSBpZiB0aGUgY29udGVu dHMgYXJlIGNoYW5nZWQuCisgICAgbXkgJGNvbnRlbnRzID0gam9pbiAiIiwgQGltcGxDb250ZW50 SGVhZGVyLCBAaW1wbEZpeGVkSGVhZGVyOwogCiAgICAgbXkgQGluY2x1ZGVzID0gKCk7CiAgICAg bXkgJWltcGxJbmNsdWRlQ29uZGl0aW9ucyA9ICgpOwpAQCAtMzgzMiwzMCArMzgyOSwyOCBAQCBz dWIgV3JpdGVEYXRhCiAgICAgICAgIH0KICAgICB9CiAgICAgZm9yZWFjaCBteSAkaW5jbHVkZSAo c29ydCBAaW5jbHVkZXMpIHsKLSAgICAgICAgcHJpbnQgSU1QTCAiI2luY2x1ZGUgJGluY2x1ZGVc biI7CisgICAgICAgICRjb250ZW50cyAuPSAiI2luY2x1ZGUgJGluY2x1ZGVcbiI7CiAgICAgfQog ICAgIGZvcmVhY2ggbXkgJGNvbmRpdGlvbiAoc29ydCBrZXlzICVpbXBsSW5jbHVkZUNvbmRpdGlv bnMpIHsKLSAgICAgICAgcHJpbnQgSU1QTCAiXG4jaWYgIiAuICRjb2RlR2VuZXJhdG9yLT5HZW5l cmF0ZUNvbmRpdGlvbmFsU3RyaW5nRnJvbUF0dHJpYnV0ZVZhbHVlKCRjb25kaXRpb24pIC4gIlxu IjsKKyAgICAgICAgJGNvbnRlbnRzIC49ICJcbiNpZiAiIC4gJGNvZGVHZW5lcmF0b3ItPkdlbmVy YXRlQ29uZGl0aW9uYWxTdHJpbmdGcm9tQXR0cmlidXRlVmFsdWUoJGNvbmRpdGlvbikgLiAiXG4i OwogICAgICAgICBmb3JlYWNoIG15ICRpbmNsdWRlIChzb3J0IEB7JGltcGxJbmNsdWRlQ29uZGl0 aW9uc3skY29uZGl0aW9ufX0pIHsKLSAgICAgICAgICAgIHByaW50IElNUEwgIiNpbmNsdWRlICRp bmNsdWRlXG4iOworICAgICAgICAgICAgJGNvbnRlbnRzIC49ICIjaW5jbHVkZSAkaW5jbHVkZVxu IjsKICAgICAgICAgfQotICAgICAgICBwcmludCBJTVBMICIjZW5kaWZcbiI7CisgICAgICAgICRj b250ZW50cyAuPSAiI2VuZGlmXG4iOwogICAgIH0KIAotICAgIHByaW50IElNUEwgIlxuIjsKLSAg ICBwcmludCBJTVBMIEBpbXBsQ29udGVudERlY2xzOwotICAgIHByaW50IElNUEwgQGltcGxDb250 ZW50OwotICAgIGNsb3NlKElNUEwpOworICAgICRjb250ZW50cyAuPSAiXG4iOworICAgICRjb250 ZW50cyAuPSBqb2luICIiLCBAaW1wbENvbnRlbnREZWNscywgQGltcGxDb250ZW50OworICAgICRj b2RlR2VuZXJhdG9yLT5VcGRhdGVGaWxlSWZDaGFuZ2VkKCRpbXBsRmlsZU5hbWUsICRjb250ZW50 cyk7CiAKICAgICAlaW1wbEluY2x1ZGVzID0gKCk7CiAgICAgQGltcGxGaXhlZEhlYWRlciA9ICgp OwogICAgIEBpbXBsQ29udGVudERlY2xzID0gKCk7CiAgICAgQGltcGxDb250ZW50ID0gKCk7CiAK LSAgICAjIFdyaXRlIGNvbnRlbnQgdG8gZmlsZS4KLSAgICBvcGVuKEhFQURFUiwgIj4kaGVhZGVy RmlsZU5hbWUiKSB8fCBkaWUgIkNvdWxkbid0IG9wZW4gZmlsZSAkaGVhZGVyRmlsZU5hbWUiOwot ICAgIHByaW50IEhFQURFUiBAaGVhZGVyQ29udGVudDsKLSAgICBjbG9zZShIRUFERVIpOworICAg ICMgVXBkYXRlIGEgLmggZmlsZSBpZiB0aGUgY29udGVudHMgYXJlIGNoYW5nZWQuCisgICAgJGNv bnRlbnRzID0gam9pbiAiIiwgQGhlYWRlckNvbnRlbnQ7CisgICAgJGNvZGVHZW5lcmF0b3ItPlVw ZGF0ZUZpbGVJZkNoYW5nZWQoJGhlYWRlckZpbGVOYW1lLCAkY29udGVudHMpOwogCiAgICAgQGhl YWRlckNvbnRlbnQgPSAoKTsKIH0K