76874 2012-01-23 16:07:04 -0800 In CodeGeneratorObjC.pm, overwrite the output .h/.cpp only if the bytes differ 2012-01-23 23:10:08 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76836 1 haraken haraken abarth darin japhet webkit.review.bot oldest_to_newest 540930 0 haraken 2012-01-23 16:07:04 -0800 This is one of steps to stop rebuilding .h/.cpp files generated by unchanged IDLs (bug 76836). In this bug, we make a change on CodeGeneratorObjC.pm so that it overwrites the output .h/.cpp only if the bytes differ. 540939 1 123648 haraken 2012-01-23 16:18:38 -0800 Created attachment 123648 Patch 541065 2 123648 abarth 2012-01-23 18:29:17 -0800 Comment on attachment 123648 Patch Ok 541143 3 123648 webkit.review.bot 2012-01-23 23:10:04 -0800 Comment on attachment 123648 Patch Clearing flags on attachment: 123648 Committed r105697: <http://trac.webkit.org/changeset/105697> 541144 4 webkit.review.bot 2012-01-23 23:10:08 -0800 All reviewed patches have been landed. Closing bug. 123648 2012-01-23 16:18:38 -0800 2012-01-23 23:10:03 -0800 Patch bug-76874-20120123161837.patch text/plain 6940 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWY0YWQ3NWVkZGIyY2Mz NGFmZDYxZDIxM2UxNjc5ODcwOTFiOWU4Yy4uM2M1MDI1YmEwZmFlYmYwNGEwYWZlYTIxZDUyZGY0 ZWY0NTUzMDg3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTAxLTIzICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbiBDb2RlR2VuZXJh dG9yT2JqQy5wbSwgb3ZlcndyaXRlIHRoZSBvdXRwdXQgLmgvLm1tCisgICAgICAgIG9ubHkgaWYg dGhlIGJ5dGVzIGRpZmZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzY4NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIGlzIG9uZSBvZiBzdGVwcyB0byBzdG9wIHJlYnVpbGRpbmcgLmgvLmNwcC8u bW0gZmlsZXMKKyAgICAgICAgZ2VuZXJhdGVkIGJ5IHVuY2hhbmdlZCBJRExzIChidWcgNzY4MzYp LgorICAgICAgICBUaGlzIHBhdGNoIG1ha2VzIGEgY2hhbmdlIG9uIENvZGVHZW5lcmF0b3JPYmpD LnBtIHNvIHRoYXQKKyAgICAgICAgaXQgb3ZlcndyaXRlcyB0aGUgb3V0cHV0IC5oLy5tbSBvbmx5 IGlmIHRoZSBieXRlcyBkaWZmZXIuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBi ZWhhdmlvci4KKyAgICAgICAgSSBtYW51YWxseSBjb25maXJtZWQgdGhhdCB3aGVuIEkgYWRkIGEg bmV3IGF0dHJpYnV0ZSB0byBFbGVtZW50LmlkbCwKKyAgICAgICAgdGhlIHRpbWUtc3RhbXBzIG9m IHVucmVsYXRlZCBET00qLmggYW5kIERPTSoubW0gZG8gbm90IGNoYW5nZS4KKworICAgICAgICAq IGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvci5wbToKKyAgICAgICAgKFVwZGF0ZUZpbGVJ ZkNoYW5nZWQpOiBBZGRlZC4gVGhpcyBtZXRob2Qgd3JpdGVzIGRhdGEgdG8gYSBmaWxlCisgICAg ICAgIG9ubHkgaWYgdGhlIGRhdGEgaXMgZGlmZmVyZW50IGZyb20gdGhlIGRhdGEgaW4gdGhlIGN1 cnJlbnQgZmlsZS4KKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JPYmpD LnBtOgorICAgICAgICAoV3JpdGVEYXRhKTogVXNlZCBVcGRhdGVGaWxlSWZDaGFuZ2VkKCkuCisK IDIwMTItMDEtMjMgIEFuZHJlYXMgS2xpbmcgIDxhd2Vzb21la2xpbmdAYXBwbGUuY29tPgogCiAg ICAgICAgIE1vdmUgbV9yb290RWRpdGFibGVFbGVtZW50Rm9yU2VsZWN0aW9uT25Nb3VzZURvd24g b2ZmIG9mIEhUTUxBbmNob3JFbGVtZW50LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9yLnBtCmluZGV4IGY5NGMwYjI5MzY4NGZiYzFmYTg3NDU0ZmU3 OWY2YTNhMGRjZTJiZDMuLjQ0ZmVmZGU2YjZhNmVhYjQ1ZjcxYTBiMzJhMTExNGM1Njk4OTg0YWUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv ci5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3Iu cG0KQEAgLTE2Myw2ICsxNjMsMzAgQEAgc3ViIEZpbGVOYW1lUHJlZml4CiAgICAgcmV0dXJuICRj b2RlR2VuZXJhdG9yLT5GaWxlTmFtZVByZWZpeCgpOwogfQogCitzdWIgVXBkYXRlRmlsZUlmQ2hh bmdlZAoreworICAgIG15ICRvYmplY3QgPSBzaGlmdDsKKyAgICBteSAkZmlsZU5hbWUgPSBzaGlm dDsKKyAgICBteSAkY29udGVudHMgPSBzaGlmdDsKKworICAgIG15ICRzaG91bGRVcGRhdGUgPSAw OworCisgICAgaWYgKG9wZW4gRkgsICRmaWxlTmFtZSkgeworICAgICAgICBsb2NhbCAkLyA9IHVu ZGVmOworICAgICAgICBteSAkb2xkQ29udGVudHMgPSA8Rkg+OworICAgICAgICAkc2hvdWxkVXBk YXRlID0gMSBpZiAkb2xkQ29udGVudHMgbmUgJGNvbnRlbnRzOworICAgICAgICBjbG9zZSBGSDsK KyAgICB9IGVsc2UgeworICAgICAgICAkc2hvdWxkVXBkYXRlID0gMTsKKyAgICB9CisKKyAgICBp ZiAoJHNob3VsZFVwZGF0ZSkgeworICAgICAgICBvcGVuIEZILCAiPiAkZmlsZU5hbWUiIG9yIGRp ZSAiQ291bGRuJ3Qgb3BlbiAkZmlsZU5hbWU6ICQhXG4iOworICAgICAgICBwcmludCBGSCAkY29u dGVudHM7CisgICAgICAgIGNsb3NlIEZIOworICAgIH0KK30KKwogc3ViIEZvckFsbFBhcmVudHMK IHsKICAgICBteSAkb2JqZWN0ID0gc2hpZnQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JPYmpDLnBtIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yT2JqQy5wbQppbmRleCA5MzczOWRhYTkwMWRmODA1 NzUxNDdlZmNiOGZkNmQ5ZjdiMjgzZmU4Li42Y2IxZmNiMTYwMjBkNjIwOTU0ZTJlMzdhMmMxYzQ5 NWMzNmFkNzYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3JPYmpDLnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvck9iakMucG0KQEAgLTE3NzYsMjUgKzE3NzYsMTUgQEAgc3ViIFdyaXRlRGF0 YQogICAgIG15ICRpbnRlcm5hbEhlYWRlckZpbGVOYW1lID0gIiRvdXRwdXREaXIvIiAuICRuYW1l IC4gIkludGVybmFsLmgiOwogICAgIG15ICRkZXBzRmlsZU5hbWUgPSAiJG91dHB1dERpci8iIC4g JG5hbWUgLiAiLmRlcCI7CiAKLSAgICAjIFJlbW92ZSBvbGQgZmlsZXMuCi0gICAgdW5saW5rKCRo ZWFkZXJGaWxlTmFtZSk7Ci0gICAgdW5saW5rKCRwcml2YXRlSGVhZGVyRmlsZU5hbWUpOwotICAg IHVubGluaygkaW1wbEZpbGVOYW1lKTsKLSAgICB1bmxpbmsoJGludGVybmFsSGVhZGVyRmlsZU5h bWUpOwotICAgIHVubGluaygkZGVwc0ZpbGVOYW1lKTsKLQogICAgICMgV3JpdGUgcHVibGljIGhl YWRlci4KLSAgICBvcGVuKEhFQURFUiwgIj4kaGVhZGVyRmlsZU5hbWUiKSBvciBkaWUgIkNvdWxk bid0IG9wZW4gZmlsZSAkaGVhZGVyRmlsZU5hbWUiOwotICAgIAotICAgIHByaW50IEhFQURFUiBA aGVhZGVyQ29udGVudEhlYWRlcjsKLSAgICBwcmludCBIRUFERVIgbWFwIHsgIlxAY2xhc3MgJF87 XG4iIH0gc29ydCBrZXlzKCVoZWFkZXJGb3J3YXJkRGVjbGFyYXRpb25zKTsKLSAgICBwcmludCBI RUFERVIgbWFwIHsgIlxAcHJvdG9jb2wgJF87XG4iIH0gc29ydCBrZXlzKCVoZWFkZXJGb3J3YXJk RGVjbGFyYXRpb25zRm9yUHJvdG9jb2xzKTsKKyAgICBteSAkY29udGVudHMgPSBqb2luICIiLCBA aGVhZGVyQ29udGVudEhlYWRlcjsKKyAgICBtYXAgeyAkY29udGVudHMgLj0gIlxAY2xhc3MgJF87 XG4iIH0gc29ydCBrZXlzKCVoZWFkZXJGb3J3YXJkRGVjbGFyYXRpb25zKTsKKyAgICBtYXAgeyAk Y29udGVudHMgLj0gIlxAcHJvdG9jb2wgJF87XG4iIH0gc29ydCBrZXlzKCVoZWFkZXJGb3J3YXJk RGVjbGFyYXRpb25zRm9yUHJvdG9jb2xzKTsKIAogICAgIG15ICRoYXNGb3J3YXJkRGVjbGFyYXRp b25zID0ga2V5cyglaGVhZGVyRm9yd2FyZERlY2xhcmF0aW9ucykgKyBrZXlzKCVoZWFkZXJGb3J3 YXJkRGVjbGFyYXRpb25zRm9yUHJvdG9jb2xzKTsKLSAgICBwcmludCBIRUFERVIgIlxuIiBpZiAk aGFzRm9yd2FyZERlY2xhcmF0aW9uczsKLSAgICBwcmludCBIRUFERVIgQGhlYWRlckNvbnRlbnQ7 Ci0KLSAgICBjbG9zZShIRUFERVIpOworICAgICRjb250ZW50cyAuPSAiXG4iIGlmICRoYXNGb3J3 YXJkRGVjbGFyYXRpb25zOworICAgICRjb250ZW50cyAuPSBqb2luICIiLCBAaGVhZGVyQ29udGVu dDsKKyAgICAkY29kZUdlbmVyYXRvci0+VXBkYXRlRmlsZUlmQ2hhbmdlZCgkaGVhZGVyRmlsZU5h bWUsICRjb250ZW50cyk7CiAKICAgICBAaGVhZGVyQ29udGVudEhlYWRlciA9ICgpOwogICAgIEBo ZWFkZXJDb250ZW50ID0gKCk7CkBAIC0xODAyLDE3ICsxNzkyLDE0IEBAIHN1YiBXcml0ZURhdGEK ICAgICAlaGVhZGVyRm9yd2FyZERlY2xhcmF0aW9uc0ZvclByb3RvY29scyA9ICgpOwogCiAgICAg aWYgKEBwcml2YXRlSGVhZGVyQ29udGVudCA+IDApIHsKLSAgICAgICAgb3BlbihQUklWQVRFX0hF QURFUiwgIj4kcHJpdmF0ZUhlYWRlckZpbGVOYW1lIikgb3IgZGllICJDb3VsZG4ndCBvcGVuIGZp bGUgJHByaXZhdGVIZWFkZXJGaWxlTmFtZSI7Ci0KLSAgICAgICAgcHJpbnQgUFJJVkFURV9IRUFE RVIgQHByaXZhdGVIZWFkZXJDb250ZW50SGVhZGVyOwotICAgICAgICBwcmludCBQUklWQVRFX0hF QURFUiBtYXAgeyAiXEBjbGFzcyAkXztcbiIgfSBzb3J0IGtleXMoJXByaXZhdGVIZWFkZXJGb3J3 YXJkRGVjbGFyYXRpb25zKTsKLSAgICAgICAgcHJpbnQgUFJJVkFURV9IRUFERVIgbWFwIHsgIlxA cHJvdG9jb2wgJF87XG4iIH0gc29ydCBrZXlzKCVwcml2YXRlSGVhZGVyRm9yd2FyZERlY2xhcmF0 aW9uc0ZvclByb3RvY29scyk7CisgICAgICAgICRjb250ZW50cyA9IGpvaW4gIiIsIEBwcml2YXRl SGVhZGVyQ29udGVudEhlYWRlcjsKKyAgICAgICAgbWFwIHsgJGNvbnRlbnRzIC49ICJcQGNsYXNz ICRfO1xuIiB9IHNvcnQga2V5cyglcHJpdmF0ZUhlYWRlckZvcndhcmREZWNsYXJhdGlvbnMpOwor ICAgICAgICBtYXAgeyAkY29udGVudHMgLj0gIlxAcHJvdG9jb2wgJF87XG4iIH0gc29ydCBrZXlz KCVwcml2YXRlSGVhZGVyRm9yd2FyZERlY2xhcmF0aW9uc0ZvclByb3RvY29scyk7CiAKICAgICAg ICAgJGhhc0ZvcndhcmREZWNsYXJhdGlvbnMgPSBrZXlzKCVwcml2YXRlSGVhZGVyRm9yd2FyZERl Y2xhcmF0aW9ucykgKyBrZXlzKCVwcml2YXRlSGVhZGVyRm9yd2FyZERlY2xhcmF0aW9uc0ZvclBy b3RvY29scyk7Ci0gICAgICAgIHByaW50IFBSSVZBVEVfSEVBREVSICJcbiIgaWYgJGhhc0Zvcndh cmREZWNsYXJhdGlvbnM7Ci0gICAgICAgIHByaW50IFBSSVZBVEVfSEVBREVSIEBwcml2YXRlSGVh ZGVyQ29udGVudDsKLQotICAgICAgICBjbG9zZShQUklWQVRFX0hFQURFUik7CisgICAgICAgICRj b250ZW50cyAuPSAiXG4iIGlmICRoYXNGb3J3YXJkRGVjbGFyYXRpb25zOworICAgICAgICAkY29u dGVudHMgLj0gam9pbiAiIiwgQHByaXZhdGVIZWFkZXJDb250ZW50OworICAgICAgICAkY29kZUdl bmVyYXRvci0+VXBkYXRlRmlsZUlmQ2hhbmdlZCgkcHJpdmF0ZUhlYWRlckZpbGVOYW1lLCAkY29u dGVudHMpOwogCiAgICAgICAgIEBwcml2YXRlSGVhZGVyQ29udGVudEhlYWRlciA9ICgpOwogICAg ICAgICBAcHJpdmF0ZUhlYWRlckNvbnRlbnQgPSAoKTsKQEAgLTE4MjIsMzQgKzE4MDksMjggQEAg c3ViIFdyaXRlRGF0YQogCiAgICAgIyBXcml0ZSBpbXBsZW1lbnRhdGlvbiBmaWxlLgogICAgIHVu bGVzcyAoJG5vSW1wbCkgewotICAgICAgICBvcGVuKElNUEwsICI+JGltcGxGaWxlTmFtZSIpIG9y IGRpZSAiQ291bGRuJ3Qgb3BlbiBmaWxlICRpbXBsRmlsZU5hbWUiOwotCi0gICAgICAgIHByaW50 IElNUEwgQGltcGxDb250ZW50SGVhZGVyOwotICAgICAgICBwcmludCBJTVBMIG1hcCB7ICIjaW1w b3J0IFwiJF9cIlxuIiB9IHNvcnQga2V5cyglaW1wbEluY2x1ZGVzKTsKLSAgICAgICAgcHJpbnQg SU1QTCBAaW1wbENvbnRlbnQ7Ci0KLSAgICAgICAgY2xvc2UoSU1QTCk7CisgICAgICAgICRjb250 ZW50cyA9IGpvaW4gIiIsIEBpbXBsQ29udGVudEhlYWRlcjsKKyAgICAgICAgbWFwIHsgJGNvbnRl bnRzIC49ICIjaW1wb3J0IFwiJF9cIlxuIiB9IHNvcnQga2V5cyglaW1wbEluY2x1ZGVzKTsKKyAg ICAgICAgJGNvbnRlbnRzIC49IGpvaW4gIiIsIEBpbXBsQ29udGVudDsKKyAgICAgICAgJGNvZGVH ZW5lcmF0b3ItPlVwZGF0ZUZpbGVJZkNoYW5nZWQoJGltcGxGaWxlTmFtZSwgJGNvbnRlbnRzKTsK IAogICAgICAgICBAaW1wbENvbnRlbnRIZWFkZXIgPSAoKTsKICAgICAgICAgQGltcGxDb250ZW50 ID0gKCk7CiAgICAgICAgICVpbXBsSW5jbHVkZXMgPSAoKTsKICAgICB9Ci0gICAgCi0gICAgaWYg KEBpbnRlcm5hbEhlYWRlckNvbnRlbnQgPiAwKSB7Ci0gICAgICAgb3BlbihJTlRFUk5BTF9IRUFE RVIsICI+JGludGVybmFsSGVhZGVyRmlsZU5hbWUiKSBvciBkaWUgIkNvdWxkbid0IG9wZW4gZmls ZSAkaW50ZXJuYWxIZWFkZXJGaWxlTmFtZSI7CiAKLSAgICAgICBwcmludCBJTlRFUk5BTF9IRUFE RVIgQGludGVybmFsSGVhZGVyQ29udGVudDsKLQotICAgICAgIGNsb3NlKElOVEVSTkFMX0hFQURF Uik7CisgICAgaWYgKEBpbnRlcm5hbEhlYWRlckNvbnRlbnQgPiAwKSB7CisgICAgICAgICRjb250 ZW50cyA9IGpvaW4gIiIsIEBpbnRlcm5hbEhlYWRlckNvbnRlbnQ7CisgICAgICAgICRjb2RlR2Vu ZXJhdG9yLT5VcGRhdGVGaWxlSWZDaGFuZ2VkKCRpbnRlcm5hbEhlYWRlckZpbGVOYW1lLCAkY29u dGVudHMpOwogCi0gICAgICAgQGludGVybmFsSGVhZGVyQ29udGVudCA9ICgpOworICAgICAgICBA aW50ZXJuYWxIZWFkZXJDb250ZW50ID0gKCk7CiAgICAgfQogCiAgICAgIyBXcml0ZSBkZXBlbmRl bmN5IGZpbGUuCiAgICAgaWYgKEBkZXBzQ29udGVudCkgewotICAgICAgICBvcGVuKERFUFMsICI+ JGRlcHNGaWxlTmFtZSIpIG9yIGRpZSAiQ291bGRuJ3Qgb3BlbiBmaWxlICRkZXBzRmlsZU5hbWUi OwotICAgICAgICBwcmludCBERVBTIEBkZXBzQ29udGVudDsKLSAgICAgICAgY2xvc2UoREVQUyk7 CisgICAgICAgICRjb250ZW50cyA9IGpvaW4gIiIsIEBkZXBzQ29udGVudDsKKyAgICAgICAgJGNv ZGVHZW5lcmF0b3ItPlVwZGF0ZUZpbGVJZkNoYW5nZWQoJGRlcHNGaWxlTmFtZSwgJGNvbnRlbnRz KTsKKwogICAgICAgICBAZGVwc0NvbnRlbnQgPSAoKTsKICAgICB9CiB9Cg==