76846 2012-01-23 11:21:34 -0800 [Refactoring] Make finish() of CodeGeneratorJS.pm empty 2012-01-24 18:16:41 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76836 1 haraken haraken abarth darin japhet ossy simon.fraser webkit.review.bot oldest_to_newest 540685 0 haraken 2012-01-23 11:21:34 -0800 This is one of steps to stop rebuilding .h/.cpp files generated by unchanged IDLs (bug 76836). As a refactoring, we are planning to remove finish() from all CodeGenerators. In this bug, we make finish() of CodeGeneratorJS.pm empty. 540694 1 123585 haraken 2012-01-23 11:36:03 -0800 Created attachment 123585 Patch 541085 2 123585 webkit.review.bot 2012-01-23 20:00:15 -0800 Comment on attachment 123585 Patch Clearing flags on attachment: 123585 Committed r105683: <http://trac.webkit.org/changeset/105683> 541086 3 webkit.review.bot 2012-01-23 20:00:20 -0800 All reviewed patches have been landed. Closing bug. 541152 4 123585 ossy 2012-01-23 23:55:57 -0800 Comment on attachment 123585 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123585&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3251 > + my @includes = (); Here is the first declaration. > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3290 > + my @includes = (); This change caused the following warning: "my" variable @includes masks earlier declaration in same scope at /home/oszi/WebKit/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm line 3290. 541154 5 ossy 2012-01-24 00:04:18 -0800 Reopening to attach new patch. 541155 6 123703 ossy 2012-01-24 00:04:23 -0800 Created attachment 123703 proposed warning fix 541276 7 123703 ossy 2012-01-24 05:58:39 -0800 Comment on attachment 123703 proposed warning fix Landed in http://trac.webkit.org/changeset/105734 541756 8 simon.fraser 2012-01-24 15:14:26 -0800 When I do incremental builds today, I see all IDL files being processed every time. This didn't used to happen. 541856 9 haraken 2012-01-24 16:59:23 -0800 (In reply to comment #8) > When I do incremental builds today, I see all IDL files being processed every time. This didn't used to happen. smfr: I was able to reproduce it. I'll fix it. 541939 10 haraken 2012-01-24 18:16:41 -0800 (In reply to comment #8) > When I do incremental builds today, I see all IDL files being processed every time. This didn't used to happen. smfr: Fixed it in bug 76970. 123585 2012-01-23 11:36:03 -0800 2012-01-24 00:04:10 -0800 Patch bug-76846-20120123113601.patch text/plain 8159 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWY0YWQ3NWVkZGIyY2Mz NGFmZDYxZDIxM2UxNjc5ODcwOTFiOWU4Yy4uNjAzMWE2OTVjMDg2ODhiMWU1MjJlNGExYTI5OTZi NzE1ZGFkMTA2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDEyLTAxLTIzICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbUmVmYWN0b3Jpbmdd IE1ha2UgZmluaXNoKCkgb2YgQ29kZUdlbmVyYXRvckpTLnBtIGVtcHR5CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Njg0NgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgb25lIG9mIHN0ZXBzIHRv IHN0b3AgcmVidWlsZGluZyAuaC8uY3BwIGZpbGVzIGdlbmVyYXRlZAorICAgICAgICBieSB1bmNo YW5nZWQgSURMcyAoYnVnIDc2ODM2KS4KKworICAgICAgICBBcyBhIHJlZmFjdG9yaW5nLCB3ZSBh cmUgcGxhbm5pbmcgdG8gcmVtb3ZlIGZpbmlzaCgpIGZyb20gYWxsCisgICAgICAgIENvZGVHZW5l cmF0b3JzLiBJbiB0aGlzIGJ1Zywgd2UgbWFrZSBmaW5pc2goKSBvZiBDb2RlR2VuZXJhdG9ySlMu cG0KKyAgICAgICAgZW1wdHkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4g YmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5w bToKKyAgICAgICAgKGZpbmlzaCk6IE1hZGUgaXQgZW1wdHkuIFdlIHdpbGwgcmVtb3ZlIGZpbmlz aCgpIGFmdGVyCisgICAgICAgIG1ha2luZyBmaW5pc2goKSBvZiBhbGwgQ29kZUdlbmVyYXRvcnMg ZW1wdHkuCisgICAgICAgIChHZW5lcmF0ZUludGVyZmFjZSk6IE1vZGlmaWVkIHRvIGNhbGwgV3Jp dGVEYXRhKCkuCisgICAgICAgIChXcml0ZURhdGEpOiBTaW1wbGUgY29kZSByZWZhY3RvcmluZy4K KyAgICAgICAgUmVtb3ZlZCBpZihkZWZpbmVkICRJTVBMKS4KKyAgICAgICAgUmVtb3ZlZCBpZihk ZWZpbmVkICRIRUFERVIpLgorICAgICAgICBSZW1vdmVkIGlmKGRlZmluZWQgJERFUFMpLgorICAg ICAgICAkSU1QTCAtPiBJTVBMLgorICAgICAgICAkSEVBREVSIC0+IEhFQURFUi4KKyAgICAgICAg JERFUFMgLT4gREVQUy4KKwogMjAxMi0wMS0yMyAgQW5kcmVhcyBLbGluZyAgPGF3ZXNvbWVrbGlu Z0BhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBtX3Jvb3RFZGl0YWJsZUVsZW1lbnRGb3JTZWxl Y3Rpb25Pbk1vdXNlRG93biBvZmYgb2YgSFRNTEFuY2hvckVsZW1lbnQuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbSBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCmluZGV4IGYxMTgx ZGY4MDdmZGE5NTZhNjNhOWU5YzkyYTg4YjM2YzRiMDQ2ODMuLjM4MTRiZjI3YjBkODY0YWQ5ZTE5 NTJlZGJjOTFiYmUxNjFhNDc3NDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCkBAIC0zMCw3ICszMCw3IEBAIHVzZSBzdHJpY3Q7 CiAKIHVzZSBjb25zdGFudCBGaWxlTmFtZVByZWZpeCA9PiAiSlMiOwogCi1teSAoJGNvZGVHZW5l cmF0b3IsICRJTVBMLCAkSEVBREVSLCAkREVQUyk7CitteSAoJGNvZGVHZW5lcmF0b3IpOwogCiBt eSAkbW9kdWxlID0gIiI7CiBteSAkb3V0cHV0RGlyID0gIiI7CkBAIC04OCwxMiArODgsMTAgQEAg c3ViIG5ldwogICAgIHJldHVybiAkcmVmZXJlbmNlOwogfQogCisjIEZJWE1FKGhhcmFrZW4pOiBm aW5pc2goKSB3aWxsIGJlIHNvb24gcmVtb3ZlZCBmcm9tIGFsbCBDb2RlR2VuZXJhdG9ycy4KIHN1 YiBmaW5pc2gKIHsKICAgICBteSAkb2JqZWN0ID0gc2hpZnQ7Ci0KLSAgICAjIENvbW1pdCBjaGFu Z2VzIQotICAgICRvYmplY3QtPldyaXRlRGF0YSgpOwogfQogCiBzdWIgbGVmdFNoaWZ0KCQkKSB7 CkBAIC0xMTksMjIgKzExNyw3IEBAIHN1YiBHZW5lcmF0ZUludGVyZmFjZQogICAgICAgICAkb2Jq ZWN0LT5HZW5lcmF0ZUltcGxlbWVudGF0aW9uKCRkYXRhTm9kZSk7CiAgICAgfQogCi0gICAgbXkg JG5hbWUgPSAkZGF0YU5vZGUtPm5hbWU7Ci0KLSAgICAjIE9wZW4gZmlsZXMgZm9yIHdyaXRpbmcK LSAgICBteSAkcHJlZml4ID0gRmlsZU5hbWVQcmVmaXg7Ci0gICAgbXkgJGhlYWRlckZpbGVOYW1l ID0gIiRvdXRwdXREaXIvJHByZWZpeCRuYW1lLmgiOwotICAgIG15ICRpbXBsRmlsZU5hbWUgPSAi JG91dHB1dERpci8kcHJlZml4JG5hbWUuY3BwIjsKLSAgICBteSAkZGVwc0ZpbGVOYW1lID0gIiRv dXRwdXREaXIvJHByZWZpeCRuYW1lLmRlcCI7Ci0KLSAgICAjIFJlbW92ZSBvbGQgZGVwZW5kZW5j eSBmaWxlLgotICAgIHVubGluaygkZGVwc0ZpbGVOYW1lKTsKLQotICAgIG9wZW4oJElNUEwsICI+ JGltcGxGaWxlTmFtZSIpIHx8IGRpZSAiQ291bGRuJ3Qgb3BlbiBmaWxlICRpbXBsRmlsZU5hbWUi OwotICAgIG9wZW4oJEhFQURFUiwgIj4kaGVhZGVyRmlsZU5hbWUiKSB8fCBkaWUgIkNvdWxkbid0 IG9wZW4gZmlsZSAkaGVhZGVyRmlsZU5hbWUiOwotICAgIGlmIChAZGVwc0NvbnRlbnQpIHsKLSAg ICAgICAgb3BlbigkREVQUywgIj4kZGVwc0ZpbGVOYW1lIikgfHwgZGllICJDb3VsZG4ndCBvcGVu IGZpbGUgJGRlcHNGaWxlTmFtZSI7Ci0gICAgfQorICAgICRvYmplY3QtPldyaXRlRGF0YSgkZGF0 YU5vZGUpOwogfQogCiBzdWIgR2VuZXJhdGVBdHRyaWJ1dGVFdmVudExpc3RlbmVyQ2FsbApAQCAt MzI0OCw4NCArMzIzMSw5NCBAQCBzdWIgR2VuZXJhdGVIYXNoVmFsdWUKICMgSW50ZXJuYWwgaGVs cGVyCiBzdWIgV3JpdGVEYXRhCiB7Ci0gICAgaWYgKGRlZmluZWQoJElNUEwpKSB7Ci0gICAgICAg ICMgV3JpdGUgY29udGVudCB0byBmaWxlLgotICAgICAgICBwcmludCAkSU1QTCBAaW1wbENvbnRl bnRIZWFkZXI7Ci0KLSAgICAgICAgbXkgQGluY2x1ZGVzID0gKCk7Ci0gICAgICAgIG15ICVpbXBs SW5jbHVkZUNvbmRpdGlvbnMgPSAoKTsKLSAgICAgICAgZm9yZWFjaCBteSAkaW5jbHVkZSAoa2V5 cyAlaW1wbEluY2x1ZGVzKSB7Ci0gICAgICAgICAgICBteSAkY29uZGl0aW9uID0gJGltcGxJbmNs dWRlc3skaW5jbHVkZX07Ci0gICAgICAgICAgICBteSAkY2hlY2tUeXBlID0gJGluY2x1ZGU7Ci0g ICAgICAgICAgICAkY2hlY2tUeXBlID1+IHMvXC5oLy87Ci0gICAgICAgICAgICBuZXh0IGlmICRj b2RlR2VuZXJhdG9yLT5Jc1NWR0FuaW1hdGVkVHlwZSgkY2hlY2tUeXBlKTsKLQotICAgICAgICAg ICAgJGluY2x1ZGUgPSAiXCIkaW5jbHVkZVwiIiB1bmxlc3MgJGluY2x1ZGUgPX4gL15bIjxdLzsg IyAiCi0KLSAgICAgICAgICAgIGlmICgkY29uZGl0aW9uIGVxIDEpIHsKLSAgICAgICAgICAgICAg ICBwdXNoIEBpbmNsdWRlcywgJGluY2x1ZGU7Ci0gICAgICAgICAgICB9IGVsc2UgewotICAgICAg ICAgICAgICAgIHB1c2ggQHskaW1wbEluY2x1ZGVDb25kaXRpb25zeyRjb25kaXRpb259fSwgJGlu Y2x1ZGU7Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KLSAgICAgICAgZm9yZWFjaCBteSAkaW5j bHVkZSAoc29ydCBAaW5jbHVkZXMpIHsKLSAgICAgICAgICAgIHByaW50ICRJTVBMICIjaW5jbHVk ZSAkaW5jbHVkZVxuIjsKLSAgICAgICAgfQotICAgICAgICBmb3JlYWNoIG15ICRjb25kaXRpb24g KHNvcnQga2V5cyAlaW1wbEluY2x1ZGVDb25kaXRpb25zKSB7Ci0gICAgICAgICAgICBwcmludCAk SU1QTCAiXG4jaWYgIiAuICRjb2RlR2VuZXJhdG9yLT5HZW5lcmF0ZUNvbmRpdGlvbmFsU3RyaW5n RnJvbUF0dHJpYnV0ZVZhbHVlKCRjb25kaXRpb24pIC4gIlxuIjsKLSAgICAgICAgICAgIGZvcmVh Y2ggbXkgJGluY2x1ZGUgKHNvcnQgQHskaW1wbEluY2x1ZGVDb25kaXRpb25zeyRjb25kaXRpb259 fSkgewotICAgICAgICAgICAgICAgIHByaW50ICRJTVBMICIjaW5jbHVkZSAkaW5jbHVkZVxuIjsK LSAgICAgICAgICAgIH0KLSAgICAgICAgICAgIHByaW50ICRJTVBMICIjZW5kaWZcbiI7Ci0gICAg ICAgIH0KKyAgICBteSAkb2JqZWN0ID0gc2hpZnQ7CisgICAgbXkgJGRhdGFOb2RlID0gc2hpZnQ7 CiAKLSAgICAgICAgcHJpbnQgJElNUEwgQGltcGxDb250ZW50OwotICAgICAgICBjbG9zZSgkSU1Q TCk7Ci0gICAgICAgIHVuZGVmKCRJTVBMKTsKKyAgICBteSAkbmFtZSA9ICRkYXRhTm9kZS0+bmFt ZTsKKyAgICBteSAkcHJlZml4ID0gRmlsZU5hbWVQcmVmaXg7CisgICAgbXkgJGhlYWRlckZpbGVO YW1lID0gIiRvdXRwdXREaXIvJHByZWZpeCRuYW1lLmgiOworICAgIG15ICRpbXBsRmlsZU5hbWUg PSAiJG91dHB1dERpci8kcHJlZml4JG5hbWUuY3BwIjsKKyAgICBteSAkZGVwc0ZpbGVOYW1lID0g IiRvdXRwdXREaXIvJHByZWZpeCRuYW1lLmRlcCI7CiAKLSAgICAgICAgQGltcGxDb250ZW50SGVh ZGVyID0gKCk7Ci0gICAgICAgIEBpbXBsQ29udGVudCA9ICgpOwotICAgICAgICAlaW1wbEluY2x1 ZGVzID0gKCk7Ci0gICAgfQorICAgICMgUmVtb3ZlIG9sZCBkZXBlbmRlbmN5IGZpbGUuCisgICAg dW5saW5rKCRkZXBzRmlsZU5hbWUpOwogCi0gICAgaWYgKGRlZmluZWQoJEhFQURFUikpIHsKLSAg ICAgICAgIyBXcml0ZSBjb250ZW50IHRvIGZpbGUuCi0gICAgICAgIHByaW50ICRIRUFERVIgQGhl YWRlckNvbnRlbnRIZWFkZXI7CisgICAgb3BlbihJTVBMLCAiPiRpbXBsRmlsZU5hbWUiKSB8fCBk aWUgIkNvdWxkbid0IG9wZW4gZmlsZSAkaW1wbEZpbGVOYW1lIjsKIAotICAgICAgICBteSBAaW5j bHVkZXMgPSAoKTsKLSAgICAgICAgZm9yZWFjaCBteSAkaW5jbHVkZSAoa2V5cyAlaGVhZGVySW5j bHVkZXMpIHsKLSAgICAgICAgICAgICRpbmNsdWRlID0gIlwiJGluY2x1ZGVcIiIgdW5sZXNzICRp bmNsdWRlID1+IC9eWyI8XS87ICMgIgotICAgICAgICAgICAgcHVzaCBAaW5jbHVkZXMsICRpbmNs dWRlOwotICAgICAgICB9Ci0gICAgICAgIGZvcmVhY2ggbXkgJGluY2x1ZGUgKHNvcnQgQGluY2x1 ZGVzKSB7Ci0gICAgICAgICAgICBwcmludCAkSEVBREVSICIjaW5jbHVkZSAkaW5jbHVkZVxuIjsK LSAgICAgICAgfQorICAgICMgV3JpdGUgY29udGVudCB0byBmaWxlLgorICAgIHByaW50IElNUEwg QGltcGxDb250ZW50SGVhZGVyOworCisgICAgbXkgQGluY2x1ZGVzID0gKCk7CisgICAgbXkgJWlt cGxJbmNsdWRlQ29uZGl0aW9ucyA9ICgpOworICAgIGZvcmVhY2ggbXkgJGluY2x1ZGUgKGtleXMg JWltcGxJbmNsdWRlcykgeworICAgICAgICBteSAkY29uZGl0aW9uID0gJGltcGxJbmNsdWRlc3sk aW5jbHVkZX07CisgICAgICAgIG15ICRjaGVja1R5cGUgPSAkaW5jbHVkZTsKKyAgICAgICAgJGNo ZWNrVHlwZSA9fiBzL1wuaC8vOworICAgICAgICBuZXh0IGlmICRjb2RlR2VuZXJhdG9yLT5Jc1NW R0FuaW1hdGVkVHlwZSgkY2hlY2tUeXBlKTsKIAotICAgICAgICBwcmludCAkSEVBREVSIEBoZWFk ZXJDb250ZW50OworICAgICAgICAkaW5jbHVkZSA9ICJcIiRpbmNsdWRlXCIiIHVubGVzcyAkaW5j bHVkZSA9fiAvXlsiPF0vOyAjICIKIAotICAgICAgICBAaW5jbHVkZXMgPSAoKTsKLSAgICAgICAg Zm9yZWFjaCBteSAkaW5jbHVkZSAoa2V5cyAlaGVhZGVyVHJhaWxpbmdJbmNsdWRlcykgewotICAg ICAgICAgICAgJGluY2x1ZGUgPSAiXCIkaW5jbHVkZVwiIiB1bmxlc3MgJGluY2x1ZGUgPX4gL15b IjxdLzsgIyAiCisgICAgICAgIGlmICgkY29uZGl0aW9uIGVxIDEpIHsKICAgICAgICAgICAgIHB1 c2ggQGluY2x1ZGVzLCAkaW5jbHVkZTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIHB1 c2ggQHskaW1wbEluY2x1ZGVDb25kaXRpb25zeyRjb25kaXRpb259fSwgJGluY2x1ZGU7CiAgICAg ICAgIH0KLSAgICAgICAgZm9yZWFjaCBteSAkaW5jbHVkZSAoc29ydCBAaW5jbHVkZXMpIHsKLSAg ICAgICAgICAgIHByaW50ICRIRUFERVIgIiNpbmNsdWRlICRpbmNsdWRlXG4iOworICAgIH0KKyAg ICBmb3JlYWNoIG15ICRpbmNsdWRlIChzb3J0IEBpbmNsdWRlcykgeworICAgICAgICBwcmludCBJ TVBMICIjaW5jbHVkZSAkaW5jbHVkZVxuIjsKKyAgICB9CisgICAgZm9yZWFjaCBteSAkY29uZGl0 aW9uIChzb3J0IGtleXMgJWltcGxJbmNsdWRlQ29uZGl0aW9ucykgeworICAgICAgICBwcmludCBJ TVBMICJcbiNpZiAiIC4gJGNvZGVHZW5lcmF0b3ItPkdlbmVyYXRlQ29uZGl0aW9uYWxTdHJpbmdG cm9tQXR0cmlidXRlVmFsdWUoJGNvbmRpdGlvbikgLiAiXG4iOworICAgICAgICBmb3JlYWNoIG15 ICRpbmNsdWRlIChzb3J0IEB7JGltcGxJbmNsdWRlQ29uZGl0aW9uc3skY29uZGl0aW9ufX0pIHsK KyAgICAgICAgICAgIHByaW50IElNUEwgIiNpbmNsdWRlICRpbmNsdWRlXG4iOwogICAgICAgICB9 CisgICAgICAgIHByaW50IElNUEwgIiNlbmRpZlxuIjsKKyAgICB9CiAKLSAgICAgICAgY2xvc2Uo JEhFQURFUik7Ci0gICAgICAgIHVuZGVmKCRIRUFERVIpOworICAgIHByaW50IElNUEwgQGltcGxD b250ZW50OworICAgIGNsb3NlKElNUEwpOwogCi0gICAgICAgIEBoZWFkZXJDb250ZW50SGVhZGVy ID0gKCk7Ci0gICAgICAgIEBoZWFkZXJDb250ZW50ID0gKCk7Ci0gICAgICAgICVoZWFkZXJJbmNs dWRlcyA9ICgpOwotICAgICAgICAlaGVhZGVyVHJhaWxpbmdJbmNsdWRlcyA9ICgpOworICAgIEBp bXBsQ29udGVudEhlYWRlciA9ICgpOworICAgIEBpbXBsQ29udGVudCA9ICgpOworICAgICVpbXBs SW5jbHVkZXMgPSAoKTsKKworICAgIG9wZW4oSEVBREVSLCAiPiRoZWFkZXJGaWxlTmFtZSIpIHx8 IGRpZSAiQ291bGRuJ3Qgb3BlbiBmaWxlICRoZWFkZXJGaWxlTmFtZSI7CisKKyAgICAjIFdyaXRl IGNvbnRlbnQgdG8gZmlsZS4KKyAgICBwcmludCBIRUFERVIgQGhlYWRlckNvbnRlbnRIZWFkZXI7 CisKKyAgICBteSBAaW5jbHVkZXMgPSAoKTsKKyAgICBmb3JlYWNoIG15ICRpbmNsdWRlIChrZXlz ICVoZWFkZXJJbmNsdWRlcykgeworICAgICAgICAkaW5jbHVkZSA9ICJcIiRpbmNsdWRlXCIiIHVu bGVzcyAkaW5jbHVkZSA9fiAvXlsiPF0vOyAjICIKKyAgICAgICAgcHVzaCBAaW5jbHVkZXMsICRp bmNsdWRlOworICAgIH0KKyAgICBmb3JlYWNoIG15ICRpbmNsdWRlIChzb3J0IEBpbmNsdWRlcykg eworICAgICAgICBwcmludCBIRUFERVIgIiNpbmNsdWRlICRpbmNsdWRlXG4iOworICAgIH0KKwor ICAgIHByaW50IEhFQURFUiBAaGVhZGVyQ29udGVudDsKKworICAgIEBpbmNsdWRlcyA9ICgpOwor ICAgIGZvcmVhY2ggbXkgJGluY2x1ZGUgKGtleXMgJWhlYWRlclRyYWlsaW5nSW5jbHVkZXMpIHsK KyAgICAgICAgJGluY2x1ZGUgPSAiXCIkaW5jbHVkZVwiIiB1bmxlc3MgJGluY2x1ZGUgPX4gL15b IjxdLzsgIyAiCisgICAgICAgIHB1c2ggQGluY2x1ZGVzLCAkaW5jbHVkZTsKKyAgICB9CisgICAg Zm9yZWFjaCBteSAkaW5jbHVkZSAoc29ydCBAaW5jbHVkZXMpIHsKKyAgICAgICAgcHJpbnQgSEVB REVSICIjaW5jbHVkZSAkaW5jbHVkZVxuIjsKICAgICB9CiAKLSAgICBpZiAoZGVmaW5lZCgkREVQ UykpIHsKKyAgICBjbG9zZShIRUFERVIpOworCisgICAgQGhlYWRlckNvbnRlbnRIZWFkZXIgPSAo KTsKKyAgICBAaGVhZGVyQ29udGVudCA9ICgpOworICAgICVoZWFkZXJJbmNsdWRlcyA9ICgpOwor ICAgICVoZWFkZXJUcmFpbGluZ0luY2x1ZGVzID0gKCk7CisKKyAgICBpZiAoQGRlcHNDb250ZW50 KSB7CisgICAgICAgIG9wZW4oREVQUywgIj4kZGVwc0ZpbGVOYW1lIikgfHwgZGllICJDb3VsZG4n dCBvcGVuIGZpbGUgJGRlcHNGaWxlTmFtZSI7CiAgICAgICAgICMgV3JpdGUgZGVwZW5kZW5jeSBm aWxlLgotICAgICAgICBwcmludCAkREVQUyBAZGVwc0NvbnRlbnQ7Ci0gICAgICAgIGNsb3NlKCRE RVBTKTsKLSAgICAgICAgdW5kZWYoJERFUFMpOworICAgICAgICBwcmludCBERVBTIEBkZXBzQ29u dGVudDsKKyAgICAgICAgY2xvc2UoREVQUyk7CiAKICAgICAgICAgQGRlcHNDb250ZW50ID0gKCk7 CiAgICAgfQo= 123703 2012-01-24 00:04:23 -0800 2012-01-24 05:58:39 -0800 proposed warning fix bug-76846-20120124000421.patch text/plain 1343 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDFjYTEwNzUyODkyM2Jk YTZiZmVkYTk1YjYxOGZhNzlhNTQwOTA2ZS4uNzVlNWNiMDExZmUwMDk1ODllZjQ4OTQwYTVlNDQw NjA1MDFiNDMyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAxLTI0ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1JlZmFjdG9yaW5n XSBNYWtlIGZpbmlzaCgpIG9mIENvZGVHZW5lcmF0b3JKUy5wbSBlbXB0eQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY4NDYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtOiBXYXJuaW5nIGZpeCBhZnRlciByMTA1NjgzLgorICAgICAgICAoV3Jp dGVEYXRhKToKKwogMjAxMi0wMS0yMyAgU2NvdHQgR3JhaGFtICA8c2NvdHRtZ0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgQXZvaWQgc3B1cmlvdXMgcmVidWlsZHMgb24gdnMyMDEwIGR1ZSB0byBE ZXJpdmVkU291cmNlcyBub3QgZXhpc3RpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KaW5kZXggNWYwZjNiOGM5YjU4NTQ2ZTI3NjJj OTU0NDliZmU0MTEzYzg5ZDA1MS4uNDI2Mjc3ZWFjMzM1OGMyYTQ5NTUzMjY4MzhiM2YyZDIzNzUz ODNmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9ySlMucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9ySlMucG0KQEAgLTMyODcsNyArMzI4Nyw3IEBAIHN1YiBXcml0ZURhdGEKICAgICAjIFdy aXRlIGNvbnRlbnQgdG8gZmlsZS4KICAgICBwcmludCBIRUFERVIgQGhlYWRlckNvbnRlbnRIZWFk ZXI7CiAKLSAgICBteSBAaW5jbHVkZXMgPSAoKTsKKyAgICBAaW5jbHVkZXMgPSAoKTsKICAgICBm b3JlYWNoIG15ICRpbmNsdWRlIChrZXlzICVoZWFkZXJJbmNsdWRlcykgewogICAgICAgICAkaW5j bHVkZSA9ICJcIiRpbmNsdWRlXCIiIHVubGVzcyAkaW5jbHVkZSA9fiAvXlsiPF0vOyAjICIKICAg ICAgICAgcHVzaCBAaW5jbHVkZXMsICRpbmNsdWRlOwo=