<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>76841</bug_id>
          
          <creation_ts>2012-01-23 10:52:10 -0800</creation_ts>
          <short_desc>[Refactoring] Remove finish() from CodeGeneratorV8.pm</short_desc>
          <delta_ts>2012-01-24 02:33:08 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore JavaScript</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>76836</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Kentaro Hara">haraken</reporter>
          <assigned_to name="Kentaro Hara">haraken</assigned_to>
          <cc>abarth</cc>
    
    <cc>darin</cc>
    
    <cc>japhet</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>540658</commentid>
    <comment_count>0</comment_count>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-01-23 10:52:10 -0800</bug_when>
    <thetext>This is one of steps to stop rebuilding .h/.cpp files generated by unchanged IDLs (bug 76836).

As refactoring, we are planning to remove finish() from all CodeGenerators. In this bug, we remove finish() from CodeGeneratorV8.pm.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>540662</commentid>
    <comment_count>1</comment_count>
      <attachid>123576</attachid>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-01-23 11:01:55 -0800</bug_when>
    <thetext>Created attachment 123576
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>541125</commentid>
    <comment_count>2</comment_count>
      <attachid>123576</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-01-23 22:00:42 -0800</bug_when>
    <thetext>Comment on attachment 123576
Patch

Rejecting attachment 123576 from commit-queue.

Failed to run &quot;[&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;-...&quot; exit_code: 2

Last 500 characters of output:
ion 55 --non-interactive --force --accept theirs-conflict --ignore-externals returned non-zero exit status 1 in /mnt/git/webkit-commit-queue/Source/WebKit/chromium
Error: &apos;depot_tools/gclient sync --force --reset --delete_unversioned_trees&apos; failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 106.
Re-trying &apos;depot_tools/gclient sync --force --reset --delete_unversioned_trees&apos;
No such file or directory at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2302.

Full output: http://queues.webkit.org/results/11333241</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>541126</commentid>
    <comment_count>3</comment_count>
      <attachid>123697</attachid>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-01-23 22:06:02 -0800</bug_when>
    <thetext>Created attachment 123697
rebased patch for review</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>541128</commentid>
    <comment_count>4</comment_count>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-01-23 22:07:20 -0800</bug_when>
    <thetext>adam: Sorry, would you please r+ again? I forgot to add --no-review option.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>541194</commentid>
    <comment_count>5</comment_count>
      <attachid>123697</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-01-24 02:33:03 -0800</bug_when>
    <thetext>Comment on attachment 123697
rebased patch for review

Clearing flags on attachment: 123697

Committed r105714: &lt;http://trac.webkit.org/changeset/105714&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>541195</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-01-24 02:33:08 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>123576</attachid>
            <date>2012-01-23 11:01:55 -0800</date>
            <delta_ts>2012-01-23 22:05:59 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-76841-20120123110154.patch</filename>
            <type>text/plain</type>
            <size>6412</size>
            <attacher name="Kentaro Hara">haraken</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWY0YWQ3NWVkZGIyY2Mz
NGFmZDYxZDIxM2UxNjc5ODcwOTFiOWU4Yy4uMTNkNzljNDNkN2M3YWM0ZTVmODBjNjUyODNlNzc2
ZmJkOTkxZGE5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTAxLTIzICBLZW50
YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbUmVmYWN0b3Jpbmdd
IE1ha2VzIGZpbmlzaCgpIG9mIENvZGVHZW5lcmF0b3JWOC5wbSBlbXB0eQorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY4NDEKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIG9uZSBvZiBzdGVwcyB0
byBzdG9wIHJlYnVpbGRpbmcgLmgvLmNwcCBmaWxlcworICAgICAgICBnZW5lcmF0ZWQgYnkgdW5j
aGFuZ2VkIElETHMgKGJ1ZyA3NjgzNikuCisKKyAgICAgICAgQXMgcmVmYWN0b3JpbmcsIHdlIGFy
ZSBwbGFubmluZyB0byByZW1vdmUgZmluaXNoKCkgZnJvbQorICAgICAgICBhbGwgQ29kZUdlbmVy
YXRvcnMuIFRoaXMgcGF0Y2ggbWFrZXMgZmluaXNoKCkgb2YKKyAgICAgICAgQ29kZUdlbmVyYXRv
clY4LnBtIGVtcHR5LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2
aW9yLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06Cisg
ICAgICAgIChmaW5pc2gpOiBNYWRlIGl0IGVtcHR5LiBXZSB3aWxsIHJlbW92ZSBmaW5pc2goKSBh
ZnRlcgorICAgICAgICBtYWtpbmcgZmluaXNoKCkgb2YgYWxsIENvZGVHZW5lcmF0b3JzIGVtcHR5
LgorICAgICAgICAoR2VuZXJhdGVJbnRlcmZhY2UpOiBNb2RpZmllZCB0byBjYWxsIFdyaXRlRGF0
YSgpLgorICAgICAgICAoV3JpdGVEYXRhKTogU2ltcGxlIGNvZGUgcmVmYWN0b3JpbmcuCisgICAg
ICAgIFJlbW92ZWQgaWYoZGVmaW5lZCAkSU1QTCkuCisgICAgICAgIFJlbW92ZWQgaWYoZGVmaW5l
ZCAkSEVBREVSKS4KKyAgICAgICAgJElNUEwgLT4gSU1QTC4KKyAgICAgICAgJEhFQURFUiAtPiBI
RUFERVIuCisKIDIwMTItMDEtMjMgIEFuZHJlYXMgS2xpbmcgIDxhd2Vzb21la2xpbmdAYXBwbGUu
Y29tPgogCiAgICAgICAgIE1vdmUgbV9yb290RWRpdGFibGVFbGVtZW50Rm9yU2VsZWN0aW9uT25N
b3VzZURvd24gb2ZmIG9mIEhUTUxBbmNob3JFbGVtZW50LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0gYi9Tb3VyY2UvV2ViQ29y
ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQppbmRleCBmZDFlZjJhNjQ0ODMx
NGEwMzRlYmM4YTY0Y2YxNjg2MTk1NjA3YTcwLi4yYTcxNTFjNTEyNTE0Nzc4MTFmYzU3YjZjNWE0
MjBlMjFlNzFjMDY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz
L0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz
L0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAtMzIsNyArMzIsNyBAQCB1c2UgRGlnZXN0OjpNRDU7CiAK
IHVzZSBjb25zdGFudCBGaWxlTmFtZVByZWZpeCA9PiAiVjgiOwogCi1teSAoJGNvZGVHZW5lcmF0
b3IsICRJTVBMLCAkSEVBREVSKTsKK215ICgkY29kZUdlbmVyYXRvcik7CiAKIG15ICRtb2R1bGUg
PSAiIjsKIG15ICRvdXRwdXREaXIgPSAiIjsKQEAgLTg1LDEyICs4NSwxMCBAQCBzdWIgbmV3CiAg
ICAgcmV0dXJuICRyZWZlcmVuY2U7CiB9CiAKKyMgRklYTUUoaGFyYWtlbik6IGZpbmlzaCgpIHdp
bGwgYmUgc29vbiByZW1vdmVkIGZyb20gYWxsIENvZGVHZW5lcmF0b3JzLgogc3ViIGZpbmlzaAog
ewogICAgIG15ICRvYmplY3QgPSBzaGlmdDsKLQotICAgICMgQ29tbWl0IGNoYW5nZXMhCi0gICAg
JG9iamVjdC0+V3JpdGVEYXRhKCk7CiB9CiAKICMgUGFyYW1zOiAnZG9tQ2xhc3MnIHN0cnVjdApA
QCAtMTA5LDE1ICsxMDcsNyBAQCBzdWIgR2VuZXJhdGVJbnRlcmZhY2UKICAgICAgICAgJG9iamVj
dC0+R2VuZXJhdGVJbXBsZW1lbnRhdGlvbigkZGF0YU5vZGUpOwogICAgIH0KIAotICAgIG15ICRu
YW1lID0gJGRhdGFOb2RlLT5uYW1lOwotCi0gICAgIyBPcGVuIGZpbGVzIGZvciB3cml0aW5nCi0g
ICAgbXkgJHByZWZpeCA9IEZpbGVOYW1lUHJlZml4OwotICAgIG15ICRoZWFkZXJGaWxlTmFtZSA9
ICIkb3V0cHV0SGVhZGVyc0Rpci8kcHJlZml4JG5hbWUuaCI7Ci0gICAgbXkgJGltcGxGaWxlTmFt
ZSA9ICIkb3V0cHV0RGlyLyRwcmVmaXgkbmFtZS5jcHAiOwotCi0gICAgb3BlbigkSU1QTCwgIj4k
aW1wbEZpbGVOYW1lIikgfHwgZGllICJDb3VsZG4ndCBvcGVuIGZpbGUgJGltcGxGaWxlTmFtZSI7
Ci0gICAgb3BlbigkSEVBREVSLCAiPiRoZWFkZXJGaWxlTmFtZSIpIHx8IGRpZSAiQ291bGRuJ3Qg
b3BlbiBmaWxlICRoZWFkZXJGaWxlTmFtZSI7CisgICAgJG9iamVjdC0+V3JpdGVEYXRhKCRkYXRh
Tm9kZSk7CiB9CiAKICMgUGFyYW1zOiAnaWRsRG9jdW1lbnQnIHN0cnVjdApAQCAtMzgwNyw2MyAr
Mzc5Nyw2NyBAQCBzdWIgUmV0dXJuTmF0aXZlVG9KU1ZhbHVlCiAjIEludGVybmFsIGhlbHBlcgog
c3ViIFdyaXRlRGF0YQogewotICAgIGlmIChkZWZpbmVkKCRJTVBMKSkgewotICAgICAgICAjIFdy
aXRlIGNvbnRlbnQgdG8gZmlsZS4KLSAgICAgICAgcHJpbnQgJElNUEwgQGltcGxDb250ZW50SGVh
ZGVyOworICAgIG15ICRvYmplY3QgPSBzaGlmdDsKKyAgICBteSAkZGF0YU5vZGUgPSBzaGlmdDsK
IAotICAgICAgICBwcmludCAkSU1QTCBAaW1wbEZpeGVkSGVhZGVyOworICAgIG15ICRuYW1lID0g
JGRhdGFOb2RlLT5uYW1lOworICAgIG15ICRwcmVmaXggPSBGaWxlTmFtZVByZWZpeDsKKyAgICBt
eSAkaGVhZGVyRmlsZU5hbWUgPSAiJG91dHB1dEhlYWRlcnNEaXIvJHByZWZpeCRuYW1lLmgiOwor
ICAgIG15ICRpbXBsRmlsZU5hbWUgPSAiJG91dHB1dERpci8kcHJlZml4JG5hbWUuY3BwIjsKIAot
ICAgICAgICBteSBAaW5jbHVkZXMgPSAoKTsKLSAgICAgICAgbXkgJWltcGxJbmNsdWRlQ29uZGl0
aW9ucyA9ICgpOwotICAgICAgICBmb3JlYWNoIG15ICRpbmNsdWRlIChrZXlzICVpbXBsSW5jbHVk
ZXMpIHsKLSAgICAgICAgICAgIG15ICRjb25kaXRpb24gPSAkaW1wbEluY2x1ZGVzeyRpbmNsdWRl
fTsKLSAgICAgICAgICAgIG15ICRjaGVja1R5cGUgPSAkaW5jbHVkZTsKLSAgICAgICAgICAgICRj
aGVja1R5cGUgPX4gcy9cLmgvLzsKLSAgICAgICAgICAgIG5leHQgaWYgJGNvZGVHZW5lcmF0b3It
PklzU1ZHQW5pbWF0ZWRUeXBlKCRjaGVja1R5cGUpOworICAgIG9wZW4oSU1QTCwgIj4kaW1wbEZp
bGVOYW1lIikgfHwgZGllICJDb3VsZG4ndCBvcGVuIGZpbGUgJGltcGxGaWxlTmFtZSI7CiAKLSAg
ICAgICAgICAgIGlmICgkaW5jbHVkZSA9fiAvd3RmLykgewotICAgICAgICAgICAgICAgICRpbmNs
dWRlID0gIlw8JGluY2x1ZGVcPiI7Ci0gICAgICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAg
ICAgICRpbmNsdWRlID0gIlwiJGluY2x1ZGVcIiI7Ci0gICAgICAgICAgICB9CisgICAgIyBXcml0
ZSBjb250ZW50IHRvIGZpbGUuCisgICAgcHJpbnQgSU1QTCBAaW1wbENvbnRlbnRIZWFkZXI7Cisg
ICAgcHJpbnQgSU1QTCBAaW1wbEZpeGVkSGVhZGVyOwogCi0gICAgICAgICAgICBpZiAoJGNvbmRp
dGlvbiBlcSAxKSB7Ci0gICAgICAgICAgICAgICAgcHVzaCBAaW5jbHVkZXMsICRpbmNsdWRlOwot
ICAgICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICBwdXNoIEB7JGltcGxJbmNsdWRl
Q29uZGl0aW9uc3skY29uZGl0aW9ufX0sICRpbmNsdWRlOwotICAgICAgICAgICAgfQorICAgIG15
IEBpbmNsdWRlcyA9ICgpOworICAgIG15ICVpbXBsSW5jbHVkZUNvbmRpdGlvbnMgPSAoKTsKKyAg
ICBmb3JlYWNoIG15ICRpbmNsdWRlIChrZXlzICVpbXBsSW5jbHVkZXMpIHsKKyAgICAgICAgbXkg
JGNvbmRpdGlvbiA9ICRpbXBsSW5jbHVkZXN7JGluY2x1ZGV9OworICAgICAgICBteSAkY2hlY2tU
eXBlID0gJGluY2x1ZGU7CisgICAgICAgICRjaGVja1R5cGUgPX4gcy9cLmgvLzsKKyAgICAgICAg
bmV4dCBpZiAkY29kZUdlbmVyYXRvci0+SXNTVkdBbmltYXRlZFR5cGUoJGNoZWNrVHlwZSk7CisK
KyAgICAgICAgaWYgKCRpbmNsdWRlID1+IC93dGYvKSB7CisgICAgICAgICAgICAkaW5jbHVkZSA9
ICJcPCRpbmNsdWRlXD4iOworICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgJGluY2x1ZGUg
PSAiXCIkaW5jbHVkZVwiIjsKICAgICAgICAgfQotICAgICAgICBmb3JlYWNoIG15ICRpbmNsdWRl
IChzb3J0IEBpbmNsdWRlcykgewotICAgICAgICAgICAgcHJpbnQgJElNUEwgIiNpbmNsdWRlICRp
bmNsdWRlXG4iOworCisgICAgICAgIGlmICgkY29uZGl0aW9uIGVxIDEpIHsKKyAgICAgICAgICAg
IHB1c2ggQGluY2x1ZGVzLCAkaW5jbHVkZTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAg
IHB1c2ggQHskaW1wbEluY2x1ZGVDb25kaXRpb25zeyRjb25kaXRpb259fSwgJGluY2x1ZGU7CiAg
ICAgICAgIH0KLSAgICAgICAgZm9yZWFjaCBteSAkY29uZGl0aW9uIChzb3J0IGtleXMgJWltcGxJ
bmNsdWRlQ29uZGl0aW9ucykgewotICAgICAgICAgICAgcHJpbnQgJElNUEwgIlxuI2lmICIgLiAk
Y29kZUdlbmVyYXRvci0+R2VuZXJhdGVDb25kaXRpb25hbFN0cmluZ0Zyb21BdHRyaWJ1dGVWYWx1
ZSgkY29uZGl0aW9uKSAuICJcbiI7Ci0gICAgICAgICAgICBmb3JlYWNoIG15ICRpbmNsdWRlIChz
b3J0IEB7JGltcGxJbmNsdWRlQ29uZGl0aW9uc3skY29uZGl0aW9ufX0pIHsKLSAgICAgICAgICAg
ICAgICBwcmludCAkSU1QTCAiI2luY2x1ZGUgJGluY2x1ZGVcbiI7Ci0gICAgICAgICAgICB9Ci0g
ICAgICAgICAgICBwcmludCAkSU1QTCAiI2VuZGlmXG4iOworICAgIH0KKyAgICBmb3JlYWNoIG15
ICRpbmNsdWRlIChzb3J0IEBpbmNsdWRlcykgeworICAgICAgICBwcmludCBJTVBMICIjaW5jbHVk
ZSAkaW5jbHVkZVxuIjsKKyAgICB9CisgICAgZm9yZWFjaCBteSAkY29uZGl0aW9uIChzb3J0IGtl
eXMgJWltcGxJbmNsdWRlQ29uZGl0aW9ucykgeworICAgICAgICBwcmludCBJTVBMICJcbiNpZiAi
IC4gJGNvZGVHZW5lcmF0b3ItPkdlbmVyYXRlQ29uZGl0aW9uYWxTdHJpbmdGcm9tQXR0cmlidXRl
VmFsdWUoJGNvbmRpdGlvbikgLiAiXG4iOworICAgICAgICBmb3JlYWNoIG15ICRpbmNsdWRlIChz
b3J0IEB7JGltcGxJbmNsdWRlQ29uZGl0aW9uc3skY29uZGl0aW9ufX0pIHsKKyAgICAgICAgICAg
IHByaW50IElNUEwgIiNpbmNsdWRlICRpbmNsdWRlXG4iOwogICAgICAgICB9CisgICAgICAgIHBy
aW50IElNUEwgIiNlbmRpZlxuIjsKKyAgICB9CiAKLSAgICAgICAgcHJpbnQgJElNUEwgIlxuIjsK
LSAgICAgICAgcHJpbnQgJElNUEwgQGltcGxDb250ZW50RGVjbHM7Ci0gICAgICAgIHByaW50ICRJ
TVBMIEBpbXBsQ29udGVudDsKLSAgICAgICAgY2xvc2UoJElNUEwpOwotICAgICAgICB1bmRlZigk
SU1QTCk7CisgICAgcHJpbnQgSU1QTCAiXG4iOworICAgIHByaW50IElNUEwgQGltcGxDb250ZW50
RGVjbHM7CisgICAgcHJpbnQgSU1QTCBAaW1wbENvbnRlbnQ7CisgICAgY2xvc2UoSU1QTCk7CiAK
LSAgICAgICAgJWltcGxJbmNsdWRlcyA9ICgpOwotICAgICAgICBAaW1wbEZpeGVkSGVhZGVyID0g
KCk7Ci0gICAgICAgIEBpbXBsQ29udGVudERlY2xzID0gKCk7Ci0gICAgICAgIEBpbXBsQ29udGVu
dCA9ICgpOwotICAgIH0KKyAgICAlaW1wbEluY2x1ZGVzID0gKCk7CisgICAgQGltcGxGaXhlZEhl
YWRlciA9ICgpOworICAgIEBpbXBsQ29udGVudERlY2xzID0gKCk7CisgICAgQGltcGxDb250ZW50
ID0gKCk7CiAKLSAgICBpZiAoZGVmaW5lZCgkSEVBREVSKSkgewotICAgICAgICAjIFdyaXRlIGNv
bnRlbnQgdG8gZmlsZS4KLSAgICAgICAgcHJpbnQgJEhFQURFUiBAaGVhZGVyQ29udGVudDsKLSAg
ICAgICAgY2xvc2UoJEhFQURFUik7Ci0gICAgICAgIHVuZGVmKCRIRUFERVIpOworICAgICMgV3Jp
dGUgY29udGVudCB0byBmaWxlLgorICAgIG9wZW4oSEVBREVSLCAiPiRoZWFkZXJGaWxlTmFtZSIp
IHx8IGRpZSAiQ291bGRuJ3Qgb3BlbiBmaWxlICRoZWFkZXJGaWxlTmFtZSI7CisgICAgcHJpbnQg
SEVBREVSIEBoZWFkZXJDb250ZW50OworICAgIGNsb3NlKEhFQURFUik7CiAKLSAgICAgICAgQGhl
YWRlckNvbnRlbnQgPSAoKTsKLSAgICB9CisgICAgQGhlYWRlckNvbnRlbnQgPSAoKTsKIH0KIAog
c3ViIEdldFZpc2libGVJbnRlcmZhY2VOYW1lCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>123697</attachid>
            <date>2012-01-23 22:06:02 -0800</date>
            <delta_ts>2012-01-24 02:33:03 -0800</delta_ts>
            <desc>rebased patch for review</desc>
            <filename>bug-76841-20120123220601.patch</filename>
            <type>text/plain</type>
            <size>6390</size>
            <attacher name="Kentaro Hara">haraken</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2IzMzg1N2MyZjI1NGEy
NDBhZWNhYmI5NTZmMDFjNTUzNDMzMWIxNy4uZWM4YWZhZjRiZWFiYmM1OTJlMzhjNDk3MWIxMjhk
NmZlNzA1MjEyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTAxLTIzICBLZW50
YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbUmVmYWN0b3Jpbmdd
IE1ha2VzIGZpbmlzaCgpIG9mIENvZGVHZW5lcmF0b3JWOC5wbSBlbXB0eQorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY4NDEKKworICAgICAgICBSZXZp
ZXdlZCBieSBBZGFtIEJhcnRoLgorCisgICAgICAgIFRoaXMgaXMgb25lIG9mIHN0ZXBzIHRvIHN0
b3AgcmVidWlsZGluZyAuaC8uY3BwIGZpbGVzCisgICAgICAgIGdlbmVyYXRlZCBieSB1bmNoYW5n
ZWQgSURMcyAoYnVnIDc2ODM2KS4KKworICAgICAgICBBcyByZWZhY3RvcmluZywgd2UgYXJlIHBs
YW5uaW5nIHRvIHJlbW92ZSBmaW5pc2goKSBmcm9tCisgICAgICAgIGFsbCBDb2RlR2VuZXJhdG9y
cy4gVGhpcyBwYXRjaCBtYWtlcyBmaW5pc2goKSBvZgorICAgICAgICBDb2RlR2VuZXJhdG9yVjgu
cG0gZW1wdHkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3Iu
CisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbToKKyAgICAg
ICAgKGZpbmlzaCk6IE1hZGUgaXQgZW1wdHkuIFdlIHdpbGwgcmVtb3ZlIGZpbmlzaCgpIGFmdGVy
CisgICAgICAgIG1ha2luZyBmaW5pc2goKSBvZiBhbGwgQ29kZUdlbmVyYXRvcnMgZW1wdHkuCisg
ICAgICAgIChHZW5lcmF0ZUludGVyZmFjZSk6IE1vZGlmaWVkIHRvIGNhbGwgV3JpdGVEYXRhKCku
CisgICAgICAgIChXcml0ZURhdGEpOiBTaW1wbGUgY29kZSByZWZhY3RvcmluZy4KKyAgICAgICAg
UmVtb3ZlZCBpZihkZWZpbmVkICRJTVBMKS4KKyAgICAgICAgUmVtb3ZlZCBpZihkZWZpbmVkICRI
RUFERVIpLgorICAgICAgICAkSU1QTCAtPiBJTVBMLgorICAgICAgICAkSEVBREVSIC0+IEhFQURF
Ui4KKwogMjAxMi0wMS0yMyAgTHVrZSBNYWNwaGVyc29uICAgPG1hY3BoZXJzb25AY2hyb21pdW0u
b3JnPgogCiAgICAgICAgIEltcGxlbWVudCBDU1MgY2xpcCBwcm9wZXJ0eSBpbiBDU1NTdHlsZUFw
cGx5UHJvcGVydHkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz
L0NvZGVHZW5lcmF0b3JWOC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k
ZUdlbmVyYXRvclY4LnBtCmluZGV4IGZkMWVmMmE2NDQ4MzE0YTAzNGViYzhhNjRjZjE2ODYxOTU2
MDdhNzAuLjJhNzE1MWM1MTI1MTQ3NzgxMWZjNTdiNmM1YTQyMGUyMWU3MWMwNjYgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisr
KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBA
IC0zMiw3ICszMiw3IEBAIHVzZSBEaWdlc3Q6Ok1ENTsKIAogdXNlIGNvbnN0YW50IEZpbGVOYW1l
UHJlZml4ID0+ICJWOCI7CiAKLW15ICgkY29kZUdlbmVyYXRvciwgJElNUEwsICRIRUFERVIpOwor
bXkgKCRjb2RlR2VuZXJhdG9yKTsKIAogbXkgJG1vZHVsZSA9ICIiOwogbXkgJG91dHB1dERpciA9
ICIiOwpAQCAtODUsMTIgKzg1LDEwIEBAIHN1YiBuZXcKICAgICByZXR1cm4gJHJlZmVyZW5jZTsK
IH0KIAorIyBGSVhNRShoYXJha2VuKTogZmluaXNoKCkgd2lsbCBiZSBzb29uIHJlbW92ZWQgZnJv
bSBhbGwgQ29kZUdlbmVyYXRvcnMuCiBzdWIgZmluaXNoCiB7CiAgICAgbXkgJG9iamVjdCA9IHNo
aWZ0OwotCi0gICAgIyBDb21taXQgY2hhbmdlcyEKLSAgICAkb2JqZWN0LT5Xcml0ZURhdGEoKTsK
IH0KIAogIyBQYXJhbXM6ICdkb21DbGFzcycgc3RydWN0CkBAIC0xMDksMTUgKzEwNyw3IEBAIHN1
YiBHZW5lcmF0ZUludGVyZmFjZQogICAgICAgICAkb2JqZWN0LT5HZW5lcmF0ZUltcGxlbWVudGF0
aW9uKCRkYXRhTm9kZSk7CiAgICAgfQogCi0gICAgbXkgJG5hbWUgPSAkZGF0YU5vZGUtPm5hbWU7
Ci0KLSAgICAjIE9wZW4gZmlsZXMgZm9yIHdyaXRpbmcKLSAgICBteSAkcHJlZml4ID0gRmlsZU5h
bWVQcmVmaXg7Ci0gICAgbXkgJGhlYWRlckZpbGVOYW1lID0gIiRvdXRwdXRIZWFkZXJzRGlyLyRw
cmVmaXgkbmFtZS5oIjsKLSAgICBteSAkaW1wbEZpbGVOYW1lID0gIiRvdXRwdXREaXIvJHByZWZp
eCRuYW1lLmNwcCI7Ci0KLSAgICBvcGVuKCRJTVBMLCAiPiRpbXBsRmlsZU5hbWUiKSB8fCBkaWUg
IkNvdWxkbid0IG9wZW4gZmlsZSAkaW1wbEZpbGVOYW1lIjsKLSAgICBvcGVuKCRIRUFERVIsICI+
JGhlYWRlckZpbGVOYW1lIikgfHwgZGllICJDb3VsZG4ndCBvcGVuIGZpbGUgJGhlYWRlckZpbGVO
YW1lIjsKKyAgICAkb2JqZWN0LT5Xcml0ZURhdGEoJGRhdGFOb2RlKTsKIH0KIAogIyBQYXJhbXM6
ICdpZGxEb2N1bWVudCcgc3RydWN0CkBAIC0zODA3LDYzICszNzk3LDY3IEBAIHN1YiBSZXR1cm5O
YXRpdmVUb0pTVmFsdWUKICMgSW50ZXJuYWwgaGVscGVyCiBzdWIgV3JpdGVEYXRhCiB7Ci0gICAg
aWYgKGRlZmluZWQoJElNUEwpKSB7Ci0gICAgICAgICMgV3JpdGUgY29udGVudCB0byBmaWxlLgot
ICAgICAgICBwcmludCAkSU1QTCBAaW1wbENvbnRlbnRIZWFkZXI7CisgICAgbXkgJG9iamVjdCA9
IHNoaWZ0OworICAgIG15ICRkYXRhTm9kZSA9IHNoaWZ0OwogCi0gICAgICAgIHByaW50ICRJTVBM
IEBpbXBsRml4ZWRIZWFkZXI7CisgICAgbXkgJG5hbWUgPSAkZGF0YU5vZGUtPm5hbWU7CisgICAg
bXkgJHByZWZpeCA9IEZpbGVOYW1lUHJlZml4OworICAgIG15ICRoZWFkZXJGaWxlTmFtZSA9ICIk
b3V0cHV0SGVhZGVyc0Rpci8kcHJlZml4JG5hbWUuaCI7CisgICAgbXkgJGltcGxGaWxlTmFtZSA9
ICIkb3V0cHV0RGlyLyRwcmVmaXgkbmFtZS5jcHAiOwogCi0gICAgICAgIG15IEBpbmNsdWRlcyA9
ICgpOwotICAgICAgICBteSAlaW1wbEluY2x1ZGVDb25kaXRpb25zID0gKCk7Ci0gICAgICAgIGZv
cmVhY2ggbXkgJGluY2x1ZGUgKGtleXMgJWltcGxJbmNsdWRlcykgewotICAgICAgICAgICAgbXkg
JGNvbmRpdGlvbiA9ICRpbXBsSW5jbHVkZXN7JGluY2x1ZGV9OwotICAgICAgICAgICAgbXkgJGNo
ZWNrVHlwZSA9ICRpbmNsdWRlOwotICAgICAgICAgICAgJGNoZWNrVHlwZSA9fiBzL1wuaC8vOwot
ICAgICAgICAgICAgbmV4dCBpZiAkY29kZUdlbmVyYXRvci0+SXNTVkdBbmltYXRlZFR5cGUoJGNo
ZWNrVHlwZSk7CisgICAgb3BlbihJTVBMLCAiPiRpbXBsRmlsZU5hbWUiKSB8fCBkaWUgIkNvdWxk
bid0IG9wZW4gZmlsZSAkaW1wbEZpbGVOYW1lIjsKIAotICAgICAgICAgICAgaWYgKCRpbmNsdWRl
ID1+IC93dGYvKSB7Ci0gICAgICAgICAgICAgICAgJGluY2x1ZGUgPSAiXDwkaW5jbHVkZVw+IjsK
LSAgICAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAgICAgJGluY2x1ZGUgPSAiXCIkaW5j
bHVkZVwiIjsKLSAgICAgICAgICAgIH0KKyAgICAjIFdyaXRlIGNvbnRlbnQgdG8gZmlsZS4KKyAg
ICBwcmludCBJTVBMIEBpbXBsQ29udGVudEhlYWRlcjsKKyAgICBwcmludCBJTVBMIEBpbXBsRml4
ZWRIZWFkZXI7CiAKLSAgICAgICAgICAgIGlmICgkY29uZGl0aW9uIGVxIDEpIHsKLSAgICAgICAg
ICAgICAgICBwdXNoIEBpbmNsdWRlcywgJGluY2x1ZGU7Ci0gICAgICAgICAgICB9IGVsc2Ugewot
ICAgICAgICAgICAgICAgIHB1c2ggQHskaW1wbEluY2x1ZGVDb25kaXRpb25zeyRjb25kaXRpb259
fSwgJGluY2x1ZGU7Ci0gICAgICAgICAgICB9CisgICAgbXkgQGluY2x1ZGVzID0gKCk7CisgICAg
bXkgJWltcGxJbmNsdWRlQ29uZGl0aW9ucyA9ICgpOworICAgIGZvcmVhY2ggbXkgJGluY2x1ZGUg
KGtleXMgJWltcGxJbmNsdWRlcykgeworICAgICAgICBteSAkY29uZGl0aW9uID0gJGltcGxJbmNs
dWRlc3skaW5jbHVkZX07CisgICAgICAgIG15ICRjaGVja1R5cGUgPSAkaW5jbHVkZTsKKyAgICAg
ICAgJGNoZWNrVHlwZSA9fiBzL1wuaC8vOworICAgICAgICBuZXh0IGlmICRjb2RlR2VuZXJhdG9y
LT5Jc1NWR0FuaW1hdGVkVHlwZSgkY2hlY2tUeXBlKTsKKworICAgICAgICBpZiAoJGluY2x1ZGUg
PX4gL3d0Zi8pIHsKKyAgICAgICAgICAgICRpbmNsdWRlID0gIlw8JGluY2x1ZGVcPiI7CisgICAg
ICAgIH0gZWxzZSB7CisgICAgICAgICAgICAkaW5jbHVkZSA9ICJcIiRpbmNsdWRlXCIiOwogICAg
ICAgICB9Ci0gICAgICAgIGZvcmVhY2ggbXkgJGluY2x1ZGUgKHNvcnQgQGluY2x1ZGVzKSB7Ci0g
ICAgICAgICAgICBwcmludCAkSU1QTCAiI2luY2x1ZGUgJGluY2x1ZGVcbiI7CisKKyAgICAgICAg
aWYgKCRjb25kaXRpb24gZXEgMSkgeworICAgICAgICAgICAgcHVzaCBAaW5jbHVkZXMsICRpbmNs
dWRlOworICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgcHVzaCBAeyRpbXBsSW5jbHVkZUNv
bmRpdGlvbnN7JGNvbmRpdGlvbn19LCAkaW5jbHVkZTsKICAgICAgICAgfQotICAgICAgICBmb3Jl
YWNoIG15ICRjb25kaXRpb24gKHNvcnQga2V5cyAlaW1wbEluY2x1ZGVDb25kaXRpb25zKSB7Ci0g
ICAgICAgICAgICBwcmludCAkSU1QTCAiXG4jaWYgIiAuICRjb2RlR2VuZXJhdG9yLT5HZW5lcmF0
ZUNvbmRpdGlvbmFsU3RyaW5nRnJvbUF0dHJpYnV0ZVZhbHVlKCRjb25kaXRpb24pIC4gIlxuIjsK
LSAgICAgICAgICAgIGZvcmVhY2ggbXkgJGluY2x1ZGUgKHNvcnQgQHskaW1wbEluY2x1ZGVDb25k
aXRpb25zeyRjb25kaXRpb259fSkgewotICAgICAgICAgICAgICAgIHByaW50ICRJTVBMICIjaW5j
bHVkZSAkaW5jbHVkZVxuIjsKLSAgICAgICAgICAgIH0KLSAgICAgICAgICAgIHByaW50ICRJTVBM
ICIjZW5kaWZcbiI7CisgICAgfQorICAgIGZvcmVhY2ggbXkgJGluY2x1ZGUgKHNvcnQgQGluY2x1
ZGVzKSB7CisgICAgICAgIHByaW50IElNUEwgIiNpbmNsdWRlICRpbmNsdWRlXG4iOworICAgIH0K
KyAgICBmb3JlYWNoIG15ICRjb25kaXRpb24gKHNvcnQga2V5cyAlaW1wbEluY2x1ZGVDb25kaXRp
b25zKSB7CisgICAgICAgIHByaW50IElNUEwgIlxuI2lmICIgLiAkY29kZUdlbmVyYXRvci0+R2Vu
ZXJhdGVDb25kaXRpb25hbFN0cmluZ0Zyb21BdHRyaWJ1dGVWYWx1ZSgkY29uZGl0aW9uKSAuICJc
biI7CisgICAgICAgIGZvcmVhY2ggbXkgJGluY2x1ZGUgKHNvcnQgQHskaW1wbEluY2x1ZGVDb25k
aXRpb25zeyRjb25kaXRpb259fSkgeworICAgICAgICAgICAgcHJpbnQgSU1QTCAiI2luY2x1ZGUg
JGluY2x1ZGVcbiI7CiAgICAgICAgIH0KKyAgICAgICAgcHJpbnQgSU1QTCAiI2VuZGlmXG4iOwor
ICAgIH0KIAotICAgICAgICBwcmludCAkSU1QTCAiXG4iOwotICAgICAgICBwcmludCAkSU1QTCBA
aW1wbENvbnRlbnREZWNsczsKLSAgICAgICAgcHJpbnQgJElNUEwgQGltcGxDb250ZW50OwotICAg
ICAgICBjbG9zZSgkSU1QTCk7Ci0gICAgICAgIHVuZGVmKCRJTVBMKTsKKyAgICBwcmludCBJTVBM
ICJcbiI7CisgICAgcHJpbnQgSU1QTCBAaW1wbENvbnRlbnREZWNsczsKKyAgICBwcmludCBJTVBM
IEBpbXBsQ29udGVudDsKKyAgICBjbG9zZShJTVBMKTsKIAotICAgICAgICAlaW1wbEluY2x1ZGVz
ID0gKCk7Ci0gICAgICAgIEBpbXBsRml4ZWRIZWFkZXIgPSAoKTsKLSAgICAgICAgQGltcGxDb250
ZW50RGVjbHMgPSAoKTsKLSAgICAgICAgQGltcGxDb250ZW50ID0gKCk7Ci0gICAgfQorICAgICVp
bXBsSW5jbHVkZXMgPSAoKTsKKyAgICBAaW1wbEZpeGVkSGVhZGVyID0gKCk7CisgICAgQGltcGxD
b250ZW50RGVjbHMgPSAoKTsKKyAgICBAaW1wbENvbnRlbnQgPSAoKTsKIAotICAgIGlmIChkZWZp
bmVkKCRIRUFERVIpKSB7Ci0gICAgICAgICMgV3JpdGUgY29udGVudCB0byBmaWxlLgotICAgICAg
ICBwcmludCAkSEVBREVSIEBoZWFkZXJDb250ZW50OwotICAgICAgICBjbG9zZSgkSEVBREVSKTsK
LSAgICAgICAgdW5kZWYoJEhFQURFUik7CisgICAgIyBXcml0ZSBjb250ZW50IHRvIGZpbGUuCisg
ICAgb3BlbihIRUFERVIsICI+JGhlYWRlckZpbGVOYW1lIikgfHwgZGllICJDb3VsZG4ndCBvcGVu
IGZpbGUgJGhlYWRlckZpbGVOYW1lIjsKKyAgICBwcmludCBIRUFERVIgQGhlYWRlckNvbnRlbnQ7
CisgICAgY2xvc2UoSEVBREVSKTsKIAotICAgICAgICBAaGVhZGVyQ29udGVudCA9ICgpOwotICAg
IH0KKyAgICBAaGVhZGVyQ29udGVudCA9ICgpOwogfQogCiBzdWIgR2V0VmlzaWJsZUludGVyZmFj
ZU5hbWUK
</data>

          </attachment>
      

    </bug>

</bugzilla>