76535 2012-01-18 05:48:13 -0800 CSS Shaders: Remove the setTimeout from the layout tests 2012-01-19 15:21:13 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achicu achicu japhet webkit.review.bot oldest_to_newest 537798 0 achicu 2012-01-18 05:48:13 -0800 In the CSS Shaders tests we've used setTimeout to make sure the resources are loaded and the painting is ready. Remove the setTimeout. 538598 1 achicu 2012-01-19 03:49:48 -0800 We cannot remove the setTimeout, but we can make the setTimeout use a 0 delay. The problem is that the onload event is triggered before the last resource notifies its clients that it finished. The code is in SubresourceLoader::releaseResources() which calls "m_document->cachedResourceLoader()->loadDone();" before "m_resource->stopLoading();" . "loadDone()" triggers the onload JS event. Even if we do a layout in this event the RenderLayer is not notified yet that the resources are now loaded and ready for paint. The notification will come only after the onload event is triggered, meaning that a simple setTimeout("", 0) will do the trick. 538669 2 123120 achicu 2012-01-19 06:37:46 -0800 Created attachment 123120 Patch V1 It was much simpler than I expected. It just needed to call the CachedResource::data in CachedShader::data when the resource was finished. Otherwise the notification was postponed only after the onload event. 539070 3 123120 webkit.review.bot 2012-01-19 15:21:09 -0800 Comment on attachment 123120 Patch V1 Clearing flags on attachment: 123120 Committed r105454: <http://trac.webkit.org/changeset/105454> 539071 4 webkit.review.bot 2012-01-19 15:21:13 -0800 All reviewed patches have been landed. Closing bug. 123120 2012-01-19 06:37:46 -0800 2012-01-19 15:21:09 -0800 Patch V1 bug76535.patch text/plain 6918 achicu ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2ZWRhZWY5Li41ZjI5MDk4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDEt MTkgIEFsZXhhbmRydSBDaGljdWxpdGEgIDxhY2hpY3VAYWRvYmUuY29tPgorCisgICAgICAgIENT UyBTaGFkZXJzOiBSZW1vdmUgdGhlIHNldFRpbWVvdXQgZnJvbSB0aGUgbGF5b3V0IHRlc3RzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjUzNQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5lZWQgZm9y IHNldFRpbWVvdXQgYW55bW9yZSwgc28gSSd2ZSByZW1vdmVkIHRoZW0gZnJvbSB0aGUgY3VzdG9t IGZpbHRlciB0ZXN0cy4KKworICAgICAgICAqIGNzczMvZmlsdGVycy9jdXN0b20tZmlsdGVyLXNo YWRlci1jYWNoZS5odG1sOgorICAgICAgICAqIGNzczMvZmlsdGVycy9lZmZlY3QtY3VzdG9tLWNv bWJpbmVkLW1pc3NpbmcuaHRtbDoKKyAgICAgICAgKiBjc3MzL2ZpbHRlcnMvZWZmZWN0LWN1c3Rv bS1wYXJhbWV0ZXJzLmh0bWw6CisgICAgICAgICogY3NzMy9maWx0ZXJzL2VmZmVjdC1jdXN0b20u aHRtbDoKKyAgICAgICAgKiBjc3MzL2ZpbHRlcnMvbWlzc2luZy1jdXN0b20tZmlsdGVyLXNoYWRl ci5odG1sOgorCiAyMDEyLTAxLTE5ICBEb21pbmljIE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgLSByZS1lbmFibGVzIHRlc3RzIG9uIGNocm9taXVt LW1hYyBieSBtYWtpbmcgbWlub3IKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczMvZmlsdGVy cy9jdXN0b20tZmlsdGVyLXNoYWRlci1jYWNoZS5odG1sIGIvTGF5b3V0VGVzdHMvY3NzMy9maWx0 ZXJzL2N1c3RvbS1maWx0ZXItc2hhZGVyLWNhY2hlLmh0bWwKaW5kZXggODEyNmUwNy4uMDFhMTM4 NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvY3NzMy9maWx0ZXJzL2N1c3RvbS1maWx0ZXItc2hh ZGVyLWNhY2hlLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvY3NzMy9maWx0ZXJzL2N1c3RvbS1maWx0 ZXItc2hhZGVyLWNhY2hlLmh0bWwKQEAgLTEzLDExICsxMyw4IEBACiAgICAgICAgICAgICBmdW5j dGlvbiBydW5UZXN0KCkKICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICAvLyBXZSBuZWVk IHRvIHJ1biB0aGUgdGVzdHMgYWZ0ZXIgdGhlIGRvd25sb2FkaW5nIHN1Y2NlZWRlZC4KLSAgICAg ICAgICAgICAgICAvLyBVc2luZyBhIHRpbWVyIGlzIG5vdCBpZGVhbCwgYnV0IHRoZXJlIHNlZW1z IHRvIGJlIG5vIGJldHRlciBvcHRpb25zLgotICAgICAgICAgICAgICAgIHNldFRpbWVvdXQoZnVu Y3Rpb24oKSB7Ci0gICAgICAgICAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRy b2xsZXIpCi0gICAgICAgICAgICAgICAgICAgICAgICB3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xs ZXIubm90aWZ5RG9uZSgpOwotICAgICAgICAgICAgICAgIH0sIDIwMCk7CisgICAgICAgICAgICAg ICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgICAgICAgICAg d2luZG93LmxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKICAgICAgICAgICAgIH0K ICAgICAgICAgPC9zY3JpcHQ+CiAgICAgICAgIDxzdHlsZT4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2NzczMvZmlsdGVycy9lZmZlY3QtY3VzdG9tLWNvbWJpbmVkLW1pc3NpbmcuaHRtbCBiL0xh eW91dFRlc3RzL2NzczMvZmlsdGVycy9lZmZlY3QtY3VzdG9tLWNvbWJpbmVkLW1pc3NpbmcuaHRt bAppbmRleCA4NmRlNjhkLi42NzQ3ZDU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9jc3MzL2Zp bHRlcnMvZWZmZWN0LWN1c3RvbS1jb21iaW5lZC1taXNzaW5nLmh0bWwKKysrIGIvTGF5b3V0VGVz dHMvY3NzMy9maWx0ZXJzL2VmZmVjdC1jdXN0b20tY29tYmluZWQtbWlzc2luZy5odG1sCkBAIC0x NCwxMSArMTQsOCBAQAogICAgICAgICAgICAgZnVuY3Rpb24gcnVuVGVzdCgpCiAgICAgICAgICAg ICB7CiAgICAgICAgICAgICAgICAgLy8gV2UgbmVlZCB0byBydW4gdGhlIHRlc3RzIGFmdGVyIHRo ZSBkb3dubG9hZGluZyBzdWNjZWVkZWQuCi0gICAgICAgICAgICAgICAgLy8gVXNpbmcgYSB0aW1l ciBpcyBub3QgaWRlYWwsIGJ1dCB0aGVyZSBzZWVtcyB0byBiZSBubyBiZXR0ZXIgb3B0aW9ucy4K LSAgICAgICAgICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgewotICAgICAgICAgICAgICAg ICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQotICAgICAgICAgICAgICAgICAg ICAgICAgd2luZG93LmxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKLSAgICAgICAg ICAgICAgICB9LCAyMDApOworICAgICAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENv bnRyb2xsZXIpCisgICAgICAgICAgICAgICAgICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl ci5ub3RpZnlEb25lKCk7CiAgICAgICAgICAgICB9CiAgICAgICAgIDwvc2NyaXB0PgogICAgICAg ICA8c3R5bGU+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MzL2ZpbHRlcnMvZWZmZWN0LWN1 c3RvbS1wYXJhbWV0ZXJzLmh0bWwgYi9MYXlvdXRUZXN0cy9jc3MzL2ZpbHRlcnMvZWZmZWN0LWN1 c3RvbS1wYXJhbWV0ZXJzLmh0bWwKaW5kZXggNDc4MzdjNS4uMTIwY2UwYiAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvY3NzMy9maWx0ZXJzL2VmZmVjdC1jdXN0b20tcGFyYW1ldGVycy5odG1sCisr KyBiL0xheW91dFRlc3RzL2NzczMvZmlsdGVycy9lZmZlY3QtY3VzdG9tLXBhcmFtZXRlcnMuaHRt bApAQCAtMTQsMTEgKzE0LDggQEAKICAgICAgICAgICAgIGZ1bmN0aW9uIHJ1blRlc3QoKQogICAg ICAgICAgICAgewogICAgICAgICAgICAgICAgIC8vIFdlIG5lZWQgdG8gcnVuIHRoZSB0ZXN0cyBh ZnRlciB0aGUgZG93bmxvYWRpbmcgc3VjY2VlZGVkLgotICAgICAgICAgICAgICAgIC8vIFVzaW5n IGEgdGltZXIgaXMgbm90IGlkZWFsLCBidXQgdGhlcmUgc2VlbXMgdG8gYmUgbm8gYmV0dGVyIG9w dGlvbnMuCi0gICAgICAgICAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKLSAgICAgICAg ICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKLSAgICAgICAgICAg ICAgICAgICAgICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7Ci0g ICAgICAgICAgICAgICAgfSwgMjAwKTsKKyAgICAgICAgICAgICAgICBpZiAod2luZG93LmxheW91 dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgICAgICAgICB3aW5kb3cubGF5b3V0VGVzdENv bnRyb2xsZXIubm90aWZ5RG9uZSgpOwogICAgICAgICAgICAgfQogICAgICAgICA8L3NjcmlwdD4K ICAgICAgICAgPHN0eWxlPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY3NzMy9maWx0ZXJzL2Vm ZmVjdC1jdXN0b20uaHRtbCBiL0xheW91dFRlc3RzL2NzczMvZmlsdGVycy9lZmZlY3QtY3VzdG9t Lmh0bWwKaW5kZXggZjhmMzdjYi4uNDI3YmZkZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvY3Nz My9maWx0ZXJzL2VmZmVjdC1jdXN0b20uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9jc3MzL2ZpbHRl cnMvZWZmZWN0LWN1c3RvbS5odG1sCkBAIC0xNCwxMSArMTQsOCBAQAogICAgICAgICAgICAgZnVu Y3Rpb24gcnVuVGVzdCgpCiAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgLy8gV2UgbmVl ZCB0byBydW4gdGhlIHRlc3RzIGFmdGVyIHRoZSBkb3dubG9hZGluZyBzdWNjZWVkZWQuCi0gICAg ICAgICAgICAgICAgLy8gVXNpbmcgYSB0aW1lciBpcyBub3QgaWRlYWwsIGJ1dCB0aGVyZSBzZWVt cyB0byBiZSBubyBiZXR0ZXIgb3B0aW9ucy4KLSAgICAgICAgICAgICAgICBzZXRUaW1lb3V0KGZ1 bmN0aW9uKCkgewotICAgICAgICAgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250 cm9sbGVyKQotICAgICAgICAgICAgICAgICAgICAgICAgd2luZG93LmxheW91dFRlc3RDb250cm9s bGVyLm5vdGlmeURvbmUoKTsKLSAgICAgICAgICAgICAgICB9LCAyMDApOworICAgICAgICAgICAg ICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICAgICAgICAg IHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CiAgICAgICAgICAgICB9 CiAgICAgICAgIDwvc2NyaXB0PgogICAgIDwvaGVhZD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2NzczMvZmlsdGVycy9taXNzaW5nLWN1c3RvbS1maWx0ZXItc2hhZGVyLmh0bWwgYi9MYXlvdXRU ZXN0cy9jc3MzL2ZpbHRlcnMvbWlzc2luZy1jdXN0b20tZmlsdGVyLXNoYWRlci5odG1sCmluZGV4 IDZmNThlNjguLjgzMGY2YTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2NzczMvZmlsdGVycy9t aXNzaW5nLWN1c3RvbS1maWx0ZXItc2hhZGVyLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvY3NzMy9m aWx0ZXJzL21pc3NpbmctY3VzdG9tLWZpbHRlci1zaGFkZXIuaHRtbApAQCAtMTMsMTEgKzEzLDgg QEAKICAgICAgICAgICAgIGZ1bmN0aW9uIHJ1blRlc3QoKQogICAgICAgICAgICAgewogICAgICAg ICAgICAgICAgIC8vIFdlIG5lZWQgdG8gcnVuIHRoZSB0ZXN0cyBhZnRlciB0aGUgZG93bmxvYWRp bmcgc3VjY2VlZGVkIG9yIGZhaWxzLgotICAgICAgICAgICAgICAgIC8vIFVzaW5nIGEgdGltZXIg aXMgbm90IGlkZWFsLCBidXQgdGhlcmUgc2VlbXMgdG8gYmUgbm8gYmV0dGVyIG9wdGlvbnMuCi0g ICAgICAgICAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKLSAgICAgICAgICAgICAgICAg ICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKLSAgICAgICAgICAgICAgICAgICAg ICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7Ci0gICAgICAgICAg ICAgICAgfSwgMjAwKTsKKyAgICAgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250 cm9sbGVyKQorICAgICAgICAgICAgICAgICAgICB3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIu bm90aWZ5RG9uZSgpOwogICAgICAgICAgICAgfQogICAgICAgICA8L3NjcmlwdD4KICAgICAgICAg PHN0eWxlPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCmluZGV4IDg0ZWU1OTQuLjI4MDBhNTAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxMi0wMS0xOSAgQWxleGFuZHJ1IENoaWN1bGl0YSAgPGFjaGljdUBhZG9i ZS5jb20+CisKKyAgICAgICAgQ1NTIFNoYWRlcnM6IFJlbW92ZSB0aGUgc2V0VGltZW91dCBmcm9t IHRoZSBsYXlvdXQgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc2NTM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2UgaGFkIHNldFRpbWVvdXQgb24gb2xkIHRlc3RzIGJlY2F1c2UgdGhlIHNuYXBz aG90IHBpY3R1cmUgd2FzIHRha2VuIHRvbyBlYXJseSwgYmVmb3JlIHRoZSBzaGFkZXJzIHdlcmUg bG9hZGVkLgorICAgICAgICBUaGUgcHJvYmxlbSB3YXMgdGhhdCB0aGUgUmVuZGVyTGF5ZXIgd2Fz IG5vdGlmaWVkIHRoYXQgdGhlIHNoYWRlciB3YXMgbG9hZGVkIG9ubHkgYWZ0ZXIgdGhlIG9ubG9h ZCBldmVudCB3YXMgdHJpZ2dlcmVkLAorICAgICAgICBzbyBhIHNpbXBsZSBzZXRUaW1lb3V0KDAp IHdvdWxkIGhhdmUgZml4ZWQgdGhlIGlzc3VlLCBidXQgYmV0dGVyIHRoYW4gdGhhdCB3b3VsZCBi ZSB0byB0byBhbHdheXMgY2FsbCBDYWNoZWRSZXNvdXJjZTo6ZGF0YSAKKyAgICAgICAgaW4gQ2Fj aGVkU2hhZGVyOjpkYXRhLCB3aGljaCBub3RpZmllcyB0aGUgbG9hZCBlYXJsaWVyIChiZWZvcmUg b25sb2FkKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGp1c3QgcmVtb3ZlZCB0aGUgc2V0VGlt ZW91dCBmcm9tIG9sZCBvbmVzLgorCisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFNoYWRl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDYWNoZWRTaGFkZXI6OmRhdGEpOgorCiAyMDEyLTAx LTE5ICBLYXp1aGlybyBJbmFiYSAgPGtpbmFiYUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0No cm9taXVtXSBSYW5kb20gY2hhcmFjdGVycyBnb3QgcmVuZGVyZWQgYXMgZW1wdHkgYm94ZXMgb3Ig d2l0aCBpbmNvcnJlY3QgZ2x5cGhzIGV2ZW4gd2hlbiBhIGZvbnQgaXMgcHJlc2VudApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFNoYWRlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkU2hhZGVyLmNwcAppbmRleCA4ZDdmMDZiLi4x NmQ3ODBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkU2hh ZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkU2hhZGVyLmNw cApAQCAtNjIsMTEgKzYyLDggQEAgY29uc3QgU3RyaW5nJiBDYWNoZWRTaGFkZXI6OnNoYWRlclN0 cmluZygpCiAKIHZvaWQgQ2FjaGVkU2hhZGVyOjpkYXRhKFBhc3NSZWZQdHI8U2hhcmVkQnVmZmVy PiBkYXRhLCBib29sIGFsbERhdGFSZWNlaXZlZCkKIHsKLSAgICBpZiAoYWxsRGF0YVJlY2VpdmVk KSB7CisgICAgaWYgKGFsbERhdGFSZWNlaXZlZCkKICAgICAgICAgbV9kYXRhID0gZGF0YTsKLSAg ICAgICAgcmV0dXJuOwotICAgIH0KLQogICAgIENhY2hlZFJlc291cmNlOjpkYXRhKGRhdGEsIGFs bERhdGFSZWNlaXZlZCk7CiB9CiAK