76426 2012-01-16 21:13:27 -0800 [Internals] member varaibles should follow naming convention. 2012-01-16 22:45:10 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76423 1 morrita morrita webkit.review.bot oldest_to_newest 536873 0 morrita 2012-01-16 21:13:27 -0800 There are some apparent and easy to fix violations. 536876 1 122710 morrita 2012-01-16 21:36:17 -0800 Created attachment 122710 Patch 536877 2 122710 tkent 2012-01-16 21:38:59 -0800 Comment on attachment 122710 Patch Looks ok 536896 3 122710 webkit.review.bot 2012-01-16 22:45:06 -0800 Comment on attachment 122710 Patch Clearing flags on attachment: 122710 Committed r105126: <http://trac.webkit.org/changeset/105126> 536897 4 webkit.review.bot 2012-01-16 22:45:10 -0800 All reviewed patches have been landed. Closing bug. 122710 2012-01-16 21:36:17 -0800 2012-01-16 22:45:06 -0800 Patch bug-76426-20120117143615.patch text/plain 4367 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1MTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjU1MmYzYzQ5YzE1MWI5 M2Q3ODRiNzgwNGVhZTJiMjg5ZDgwZmRiZS4uNzA5ODI5M2M5NzJiYTM5MDdjZjYzYWRlYzgyYzk3 MTYzNDVhZTg1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAxLTE2ICBIYWpp bWUgTW9ycml0YSAgPG1vcnJpdGFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtJbnRlcm5hbHNd IG1lbWJlciB2YXJhaWJsZXMgc2hvdWxkIGZvbGxvdyBuYW1pbmcgY29udmVudGlvbi4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NDI2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBK dXN0IGEgcmVuYW1lLgorCisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbHMuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6SW50ZXJuYWxzOjpJbnRlcm5hbHMpOgorICAgICAgICAoV2ViQ29yZTo6SW50 ZXJuYWxzOjpzZXRQYXNzd29yZEVjaG9FbmFibGVkKToKKyAgICAgICAgKFdlYkNvcmU6OkludGVy bmFsczo6c2V0UGFzc3dvcmRFY2hvRHVyYXRpb25JblNlY29uZHMpOgorICAgICAgICAoV2ViQ29y ZTo6SW50ZXJuYWxzOjpyZXNldCk6CisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbHMuaDoKKwog MjAxMi0wMS0xNiAgRW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAg IFJFR1JFU1NJT046IHIxMDI1NTMgQXV0b2NvcnJlY3Rpb24gYnViYmxlIGRvZXNuJ3Qgc2hvdyB1 cApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwIGIvU291 cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCmluZGV4IDc4M2MzODA1NjkzYWVjNjNk NGQ5ODViZDc4YzM4NGZkNDQ4NGM0ZWMuLjBjNWFkNDE1MjYzOWU4M2QwYmNhNmY1ZTI1Zjk5NjQ4 NTEwODM0ZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKQEAgLTExMyw4ICsx MTMsOSBAQCBJbnRlcm5hbHM6On5JbnRlcm5hbHMoKQogfQogCiBJbnRlcm5hbHM6OkludGVybmFs cygpCi0gICAgOiBwYXNzd29yZEVjaG9EdXJhdGlvbkluU2Vjb25kc0JhY2tlZFVwKGZhbHNlKQot ICAgICwgcGFzc3dvcmRFY2hvRW5hYmxlZEJhY2tlZFVwKGZhbHNlKQorICAgIDogbV9wYXNzd29y ZEVjaG9EdXJhdGlvbkluU2Vjb25kc0JhY2t1cCgwKQorICAgICwgbV9wYXNzd29yZEVjaG9EdXJh dGlvbkluU2Vjb25kc0JhY2tlZFVwKGZhbHNlKQorICAgICwgbV9wYXNzd29yZEVjaG9FbmFibGVk QmFja2VkVXAoZmFsc2UpCiB7CiB9CiAKQEAgLTM5Nyw5ICszOTgsOSBAQCB2b2lkIEludGVybmFs czo6c2V0UGFzc3dvcmRFY2hvRW5hYmxlZChEb2N1bWVudCogZG9jdW1lbnQsIGJvb2wgZW5hYmxl ZCwgRXhjZXB0aQogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgaWYgKCFwYXNzd29yZEVj aG9FbmFibGVkQmFja2VkVXApIHsKLSAgICAgICAgcGFzc3dvcmRFY2hvRW5hYmxlZEJhY2t1cCA9 IGRvY3VtZW50LT5zZXR0aW5ncygpLT5wYXNzd29yZEVjaG9FbmFibGVkKCk7Ci0gICAgICAgIHBh c3N3b3JkRWNob0VuYWJsZWRCYWNrZWRVcCA9IHRydWU7CisgICAgaWYgKCFtX3Bhc3N3b3JkRWNo b0VuYWJsZWRCYWNrZWRVcCkgeworICAgICAgICBtX3Bhc3N3b3JkRWNob0VuYWJsZWRCYWNrdXAg PSBkb2N1bWVudC0+c2V0dGluZ3MoKS0+cGFzc3dvcmRFY2hvRW5hYmxlZCgpOworICAgICAgICBt X3Bhc3N3b3JkRWNob0VuYWJsZWRCYWNrZWRVcCA9IHRydWU7CiAgICAgfQogICAgIGRvY3VtZW50 LT5zZXR0aW5ncygpLT5zZXRQYXNzd29yZEVjaG9FbmFibGVkKGVuYWJsZWQpOwogfQpAQCAtNDEx LDkgKzQxMiw5IEBAIHZvaWQgSW50ZXJuYWxzOjpzZXRQYXNzd29yZEVjaG9EdXJhdGlvbkluU2Vj b25kcyhEb2N1bWVudCogZG9jdW1lbnQsIGRvdWJsZSBkdXJhCiAgICAgICAgIHJldHVybjsKICAg ICB9CiAKLSAgICBpZiAoIXBhc3N3b3JkRWNob0R1cmF0aW9uSW5TZWNvbmRzQmFja2VkVXApIHsK LSAgICAgICAgcGFzc3dvcmRFY2hvRHVyYXRpb25JblNlY29uZHNCYWNrdXAgPSBkb2N1bWVudC0+ c2V0dGluZ3MoKS0+cGFzc3dvcmRFY2hvRHVyYXRpb25JblNlY29uZHMoKTsKLSAgICAgICAgcGFz c3dvcmRFY2hvRHVyYXRpb25JblNlY29uZHNCYWNrZWRVcCA9IHRydWU7CisgICAgaWYgKCFtX3Bh c3N3b3JkRWNob0R1cmF0aW9uSW5TZWNvbmRzQmFja2VkVXApIHsKKyAgICAgICAgbV9wYXNzd29y ZEVjaG9EdXJhdGlvbkluU2Vjb25kc0JhY2t1cCA9IGRvY3VtZW50LT5zZXR0aW5ncygpLT5wYXNz d29yZEVjaG9EdXJhdGlvbkluU2Vjb25kcygpOworICAgICAgICBtX3Bhc3N3b3JkRWNob0R1cmF0 aW9uSW5TZWNvbmRzQmFja2VkVXAgPSB0cnVlOwogICAgIH0KICAgICBkb2N1bWVudC0+c2V0dGlu Z3MoKS0+c2V0UGFzc3dvcmRFY2hvRHVyYXRpb25JblNlY29uZHMoZHVyYXRpb25JblNlY29uZHMp OwogfQpAQCAtNDY1LDE0ICs0NjYsMTQgQEAgdm9pZCBJbnRlcm5hbHM6OnJlc2V0KERvY3VtZW50 KiBkb2N1bWVudCkKICAgICBpZiAoIWRvY3VtZW50IHx8ICFkb2N1bWVudC0+c2V0dGluZ3MoKSkK ICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKHBhc3N3b3JkRWNob0R1cmF0aW9uSW5TZWNvbmRz QmFja2VkVXApIHsKLSAgICAgICAgZG9jdW1lbnQtPnNldHRpbmdzKCktPnNldFBhc3N3b3JkRWNo b0R1cmF0aW9uSW5TZWNvbmRzKHBhc3N3b3JkRWNob0R1cmF0aW9uSW5TZWNvbmRzQmFja3VwKTsK LSAgICAgICAgcGFzc3dvcmRFY2hvRHVyYXRpb25JblNlY29uZHNCYWNrZWRVcCA9IGZhbHNlOwor ICAgIGlmIChtX3Bhc3N3b3JkRWNob0R1cmF0aW9uSW5TZWNvbmRzQmFja2VkVXApIHsKKyAgICAg ICAgZG9jdW1lbnQtPnNldHRpbmdzKCktPnNldFBhc3N3b3JkRWNob0R1cmF0aW9uSW5TZWNvbmRz KG1fcGFzc3dvcmRFY2hvRHVyYXRpb25JblNlY29uZHNCYWNrdXApOworICAgICAgICBtX3Bhc3N3 b3JkRWNob0R1cmF0aW9uSW5TZWNvbmRzQmFja2VkVXAgPSBmYWxzZTsKICAgICB9CiAKLSAgICBp ZiAocGFzc3dvcmRFY2hvRW5hYmxlZEJhY2tlZFVwKSB7Ci0gICAgICAgIGRvY3VtZW50LT5zZXR0 aW5ncygpLT5zZXRQYXNzd29yZEVjaG9FbmFibGVkKHBhc3N3b3JkRWNob0VuYWJsZWRCYWNrdXAp OwotICAgICAgICBwYXNzd29yZEVjaG9FbmFibGVkQmFja2VkVXAgPSBmYWxzZTsKKyAgICBpZiAo bV9wYXNzd29yZEVjaG9FbmFibGVkQmFja2VkVXApIHsKKyAgICAgICAgZG9jdW1lbnQtPnNldHRp bmdzKCktPnNldFBhc3N3b3JkRWNob0VuYWJsZWQobV9wYXNzd29yZEVjaG9FbmFibGVkQmFja3Vw KTsKKyAgICAgICAgbV9wYXNzd29yZEVjaG9FbmFibGVkQmFja2VkVXAgPSBmYWxzZTsKICAgICB9 CiAKICAgICBpZiAoUGFnZSogcGFnZSA9IGRvY3VtZW50LT5wYWdlKCkpCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5oIGIvU291cmNlL1dlYkNvcmUvdGVzdGlu Zy9JbnRlcm5hbHMuaAppbmRleCBlZDQ3MzcwNTViOTkzODNkYTliMjgwMjFhZjNmNjk1OWM2MWQz NWY3Li5jZjk3YTE0MGI0OTYwOWMwNDE1NmRkOGU4YmExYzAyM2FkZGJkYTMyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3Rlc3RpbmcvSW50ZXJuYWxzLmgKQEAgLTEyMiwxMCArMTIyLDEwIEBAIHB1YmxpYzoKIHByaXZh dGU6CiAgICAgSW50ZXJuYWxzKCk7CiAKLSAgICBkb3VibGUgcGFzc3dvcmRFY2hvRHVyYXRpb25J blNlY29uZHNCYWNrdXA7Ci0gICAgYm9vbCBwYXNzd29yZEVjaG9FbmFibGVkQmFja3VwIDogMTsK LSAgICBib29sIHBhc3N3b3JkRWNob0R1cmF0aW9uSW5TZWNvbmRzQmFja2VkVXAgOiAxOwotICAg IGJvb2wgcGFzc3dvcmRFY2hvRW5hYmxlZEJhY2tlZFVwIDogMTsKKyAgICBkb3VibGUgbV9wYXNz d29yZEVjaG9EdXJhdGlvbkluU2Vjb25kc0JhY2t1cDsKKyAgICBib29sIG1fcGFzc3dvcmRFY2hv RW5hYmxlZEJhY2t1cCA6IDE7CisgICAgYm9vbCBtX3Bhc3N3b3JkRWNob0R1cmF0aW9uSW5TZWNv bmRzQmFja2VkVXAgOiAxOworICAgIGJvb2wgbV9wYXNzd29yZEVjaG9FbmFibGVkQmFja2VkVXAg OiAxOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=