76266 2012-01-13 04:36:45 -0800 Cache RenderStyle pointer in updateBoxModelInfoFromStyle methods 2012-01-13 05:34:49 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 76265 1 mihnea webkit-unassigned oldest_to_newest 535586 0 mihnea 2012-01-13 04:36:45 -0800 Modify RenderBoxModelObject/RenderBox::updateBoxModelInfoFromStyle to cache the result of RenderObject::style() and use that result instead of repeatedly calling the style() method. 535589 1 122410 mihnea 2012-01-13 04:42:50 -0800 Created attachment 122410 Patch 535605 2 122410 kling 2012-01-13 05:34:49 -0800 Comment on attachment 122410 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122410&action=review > Source/WebCore/ChangeLog:8 > + Refactoring code therefore no new tests. (OOPS!) CQ can't land this automatically with the OOPS intact, you need to remove it. Also, you should mention why we are doing this, as it's not obvious since RenderObject::style() is just a trivial inline getter right now. 122410 2012-01-13 04:42:50 -0800 2012-01-13 05:34:49 -0800 Patch 76266.patch text/plain 3787 mihnea ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmM2M1MThlLi40NWJlOGU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDEtMTMgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAg ICAgICAgQ2FjaGUgUmVuZGVyU3R5bGUgcG9pbnRlciBpbiB1cGRhdGVCb3hNb2RlbEluZm9Gcm9t U3R5bGUgbWV0aG9kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzYyNjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBSZWZhY3RvcmluZyBjb2RlIHRoZXJlZm9yZSBubyBuZXcgdGVzdHMuIChPT1BTISkKKwor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyQm94Ojp1cGRhdGVCb3hNb2RlbEluZm9Gcm9tU3R5bGUpOgorICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3hN b2RlbE9iamVjdDo6dXBkYXRlQm94TW9kZWxJbmZvRnJvbVN0eWxlKToKKwogMjAxMi0wMS0xMyAg S2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgdGV4dC1kZWNv cmF0aW9ucyBzaG91bGQgbm90IGJlIHByb3BhZ2F0ZWQgdG8gZmxvYXRpbmcsIGFic29sdXRlbHkg b3IgZml4ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3gu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKaW5kZXggYmVmZDVh Mi4uZjk0MzJlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJv eC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKQEAgLTQw Miw2ICs0MDIsNyBAQCB2b2lkIFJlbmRlckJveDo6dXBkYXRlQm94TW9kZWxJbmZvRnJvbVN0eWxl KCkKIHsKICAgICBSZW5kZXJCb3hNb2RlbE9iamVjdDo6dXBkYXRlQm94TW9kZWxJbmZvRnJvbVN0 eWxlKCk7CiAKKyAgICBSZW5kZXJTdHlsZSogc3R5bGVUb1VzZSA9IHN0eWxlKCk7CiAgICAgYm9v bCBpc1Jvb3RPYmplY3QgPSBpc1Jvb3QoKTsKICAgICBib29sIGlzVmlld09iamVjdCA9IGlzUmVu ZGVyVmlldygpOwogCkBAIC00MDksMTEgKzQxMCwxMSBAQCB2b2lkIFJlbmRlckJveDo6dXBkYXRl Qm94TW9kZWxJbmZvRnJvbVN0eWxlKCkKICAgICBpZiAoaXNSb290T2JqZWN0IHx8IGlzVmlld09i amVjdCkKICAgICAgICAgc2V0SGFzQm94RGVjb3JhdGlvbnModHJ1ZSk7CiAKLSAgICBzZXRQb3Np dGlvbmVkKHN0eWxlKCktPmlzUG9zaXRpb25lZCgpKTsKLSAgICBzZXRGbG9hdGluZyhzdHlsZSgp LT5pc0Zsb2F0aW5nKCkgJiYgKCFpc1Bvc2l0aW9uZWQoKSB8fCBzdHlsZSgpLT5mbG9hdGluZygp ID09IFBvc2l0aW9uZWRGbG9hdCkpOworICAgIHNldFBvc2l0aW9uZWQoc3R5bGVUb1VzZS0+aXNQ b3NpdGlvbmVkKCkpOworICAgIHNldEZsb2F0aW5nKHN0eWxlVG9Vc2UtPmlzRmxvYXRpbmcoKSAm JiAoIWlzUG9zaXRpb25lZCgpIHx8IHN0eWxlVG9Vc2UtPmZsb2F0aW5nKCkgPT0gUG9zaXRpb25l ZEZsb2F0KSk7CiAKICAgICAvLyBXZSBhbHNvIGhhbmRsZSA8Ym9keT4gYW5kIDxodG1sPiwgd2hv c2Ugb3ZlcmZsb3cgYXBwbGllcyB0byB0aGUgdmlld3BvcnQuCi0gICAgaWYgKHN0eWxlKCktPm92 ZXJmbG93WCgpICE9IE9WSVNJQkxFICYmICFpc1Jvb3RPYmplY3QgJiYgKGlzUmVuZGVyQmxvY2so KSB8fCBpc1RhYmxlUm93KCkgfHwgaXNUYWJsZVNlY3Rpb24oKSkpIHsKKyAgICBpZiAoc3R5bGVU b1VzZS0+b3ZlcmZsb3dYKCkgIT0gT1ZJU0lCTEUgJiYgIWlzUm9vdE9iamVjdCAmJiAoaXNSZW5k ZXJCbG9jaygpIHx8IGlzVGFibGVSb3coKSB8fCBpc1RhYmxlU2VjdGlvbigpKSkgewogICAgICAg ICBib29sIGJveEhhc092ZXJmbG93Q2xpcCA9IHRydWU7CiAgICAgICAgIGlmIChpc0JvZHkoKSkg ewogICAgICAgICAgICAgLy8gT3ZlcmZsb3cgb24gdGhlIGJvZHkgY2FuIHByb3BhZ2F0ZSB0byB0 aGUgdmlld3BvcnQgdW5kZXIgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zLgpAQCAtNDM2LDggKzQz Nyw4IEBAIHZvaWQgUmVuZGVyQm94Ojp1cGRhdGVCb3hNb2RlbEluZm9Gcm9tU3R5bGUoKQogICAg ICAgICB9CiAgICAgfQogCi0gICAgc2V0SGFzVHJhbnNmb3JtKHN0eWxlKCktPmhhc1RyYW5zZm9y bVJlbGF0ZWRQcm9wZXJ0eSgpKTsKLSAgICBzZXRIYXNSZWZsZWN0aW9uKHN0eWxlKCktPmJveFJl ZmxlY3QoKSk7CisgICAgc2V0SGFzVHJhbnNmb3JtKHN0eWxlVG9Vc2UtPmhhc1RyYW5zZm9ybVJl bGF0ZWRQcm9wZXJ0eSgpKTsKKyAgICBzZXRIYXNSZWZsZWN0aW9uKHN0eWxlVG9Vc2UtPmJveFJl ZmxlY3QoKSk7CiB9CiAKIHZvaWQgUmVuZGVyQm94OjpsYXlvdXQoKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAKaW5kZXggZDhiYzdiMS4u YjdhODhiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1v ZGVsT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9k ZWxPYmplY3QuY3BwCkBAIC0zOTIsMTAgKzM5MiwxMSBAQCB2b2lkIFJlbmRlckJveE1vZGVsT2Jq ZWN0Ojp1cGRhdGVCb3hNb2RlbEluZm9Gcm9tU3R5bGUoKQogewogICAgIC8vIFNldCB0aGUgYXBw cm9wcmlhdGUgYml0cyBmb3IgYSBib3ggbW9kZWwgb2JqZWN0LiAgU2luY2UgYWxsIGJpdHMgYXJl IGNsZWFyZWQgaW4gc3R5bGVXaWxsQ2hhbmdlLAogICAgIC8vIHdlIG9ubHkgY2hlY2sgZm9yIGJp dHMgdGhhdCBjb3VsZCBwb3NzaWJseSBiZSBzZXQgdG8gdHJ1ZS4KLSAgICBzZXRIYXNCb3hEZWNv cmF0aW9ucyhoYXNCYWNrZ3JvdW5kKCkgfHwgc3R5bGUoKS0+aGFzQm9yZGVyKCkgfHwgc3R5bGUo KS0+aGFzQXBwZWFyYW5jZSgpIHx8IHN0eWxlKCktPmJveFNoYWRvdygpKTsKLSAgICBzZXRJbmxp bmUoc3R5bGUoKS0+aXNEaXNwbGF5SW5saW5lVHlwZSgpKTsKLSAgICBzZXRSZWxQb3NpdGlvbmVk KHN0eWxlKCktPnBvc2l0aW9uKCkgPT0gUmVsYXRpdmVQb3NpdGlvbik7Ci0gICAgc2V0SG9yaXpv bnRhbFdyaXRpbmdNb2RlKHN0eWxlKCktPmlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkpOworICAg IFJlbmRlclN0eWxlKiBzdHlsZVRvVXNlID0gc3R5bGUoKTsKKyAgICBzZXRIYXNCb3hEZWNvcmF0 aW9ucyhoYXNCYWNrZ3JvdW5kKCkgfHwgc3R5bGVUb1VzZS0+aGFzQm9yZGVyKCkgfHwgc3R5bGVU b1VzZS0+aGFzQXBwZWFyYW5jZSgpIHx8IHN0eWxlVG9Vc2UtPmJveFNoYWRvdygpKTsKKyAgICBz ZXRJbmxpbmUoc3R5bGVUb1VzZS0+aXNEaXNwbGF5SW5saW5lVHlwZSgpKTsKKyAgICBzZXRSZWxQ b3NpdGlvbmVkKHN0eWxlVG9Vc2UtPnBvc2l0aW9uKCkgPT0gUmVsYXRpdmVQb3NpdGlvbik7Cisg ICAgc2V0SG9yaXpvbnRhbFdyaXRpbmdNb2RlKHN0eWxlVG9Vc2UtPmlzSG9yaXpvbnRhbFdyaXRp bmdNb2RlKCkpOwogfQogCiBMYXlvdXRVbml0IFJlbmRlckJveE1vZGVsT2JqZWN0OjpyZWxhdGl2 ZVBvc2l0aW9uT2Zmc2V0WCgpIGNvbnN0Cg==