76147 2012-01-11 21:47:28 -0800 [Chromium] JSExportMacros.h should be visible. 2012-01-12 21:13:54 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72855 1 morrita morrita abarth tony webkit.review.bot oldest_to_newest 534564 0 morrita 2012-01-11 21:47:28 -0800 JSExportMacros.h is hidden from Chromium port by the USE(JSC) gaurd. But WebCore uses Yarr which is a part of JSC and it includes JSExportMacros.h indirectly. So Chromium should be able to see it. 534570 1 122171 morrita 2012-01-11 22:18:59 -0800 Created attachment 122171 Patch 534577 2 abarth 2012-01-11 22:47:01 -0800 Ah, Yarr. /me hopes Tony will review this patch. 534609 3 morrita 2012-01-12 00:08:14 -0800 (In reply to comment #2) > Ah, Yarr. /me hopes Tony will review this patch. OK, thanks for taking a look! 534930 4 122171 tony 2012-01-12 10:03:57 -0800 Comment on attachment 122171 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122171&action=review > Source/JavaScriptCore/config.h:37 > +// Chromium doesn't have runtime/ in its include paths. > +#include "runtime/JSExportMacros.h" Should we add runtime/ to the include path for yarr? Actually, it looks like it's already there for the yarr target. Should we add it to direct_dependent_settings? 535391 5 morrita 2012-01-12 19:35:06 -0800 (In reply to comment #4) > (From update of attachment 122171 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=122171&action=review > > > Source/JavaScriptCore/config.h:37 > > +// Chromium doesn't have runtime/ in its include paths. > > +#include "runtime/JSExportMacros.h" > > Should we add runtime/ to the include path for yarr? Actually, it looks like it's already there for the yarr Whoa, I didn't know about direct_dependent_settings. I'll try it. 535400 6 morrita 2012-01-12 20:01:31 -0800 > > Should we add runtime/ to the include path for yarr? Actually, it looks like it's already there for the yarr Whoa, I didn't know about direct_dependent_settings. I'll try it. I just tried direct_dependent_settings but noticed that JavaScriptCore/config.h is included from not only direct_dependent but also some more (like Webkit APi layer). Including runtime/ everywhere looks a bit too much polluting for me so I'll land this as is. Anyway, thanks for pointing it out. I hope I could find some cleaner way for this. 535425 7 122171 webkit.review.bot 2012-01-12 21:13:49 -0800 Comment on attachment 122171 Patch Clearing flags on attachment: 122171 Committed r104897: <http://trac.webkit.org/changeset/104897> 535426 8 webkit.review.bot 2012-01-12 21:13:54 -0800 All reviewed patches have been landed. Closing bug. 122171 2012-01-11 22:18:59 -0800 2012-01-12 21:13:49 -0800 Patch bug-76147-20120112151857.patch text/plain 2242 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0Nzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw OWMzYzljNDVhNmViMzQ3YjY1Yzc2NTg2YjBkNjE4MmVhZGZmMGNmLi40ODYwNDY1YjA2MGFmZTY2 NDdkMDUxMDMyYjMyODE4N2YwNGNmZDFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxMi0wMS0xMSAgTU9SSVRBIEhhamltZSAgPG1vcnJpdGFAZ29vZ2xlLmNv bT4KKworICAgICAgICBbQ2hyb21pdW1dIEpTRXhwb3J0TWFjcm9zLmggc2hvdWxkIGJlIHZpc2li bGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjE0 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogY29u ZmlnLmg6CisKIDIwMTItMDEtMTEgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBw bGUuY29tPgogCiAgICAgICAgIE9iamVjdC5kZWZpbmVQcm9wZXJ0eShbXSwgJ2xlbmd0aCcsIHt9 KSBzaG91bGQgbm90IG1ha2UgbGVuZ3RoIHJlYWQtb25seQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGIxZmJmYjlh NjJiMzFhMDRjNWQ1YTczMGZiMWJkYmVlYWU3YTY1ZDUuLmI2Y2U3YzFmZjgwZGQ4ZmI5ODE5ZmE0 NzEzOTYzYjE0YmM0N2ZiMjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wMS0x MSAgTU9SSVRBIEhhamltZSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KKworICAgICAgICBbQ2hyb21p dW1dIEpTRXhwb3J0TWFjcm9zLmggc2hvdWxkIGJlIHZpc2libGUuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjE0NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8gYmVoYXZpb3Ig Y2hhbmdlLgorCisgICAgICAgICogY29uZmlnLmg6CisKIDIwMTItMDEtMTEgIEFkYW0gQmFydGgg IDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBpZnJhbWUgc2FuZGJveCBkb2Vzbid0IGJs b2NrIGF1dG9mb2N1cyAoSUVUQyBhdXRvbWF0aWMtZmVhdHVyZS1ibG9jay1hdXRvZm9jdXMtZm9y bS1jb250cm9sKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2NvbmZpZy5oIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2NvbmZpZy5oCmluZGV4IGQ3NzhmNjNhOGZiZGJlZTk1ZmEz NGM1ZDFlOGY4MmQ1YzQzNmZmMWIuLmJhNjU0NzZhNTU5NGY0NTc4ZTMzOGQwZDdiNzMwODU5NDk0 OTc1N2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9jb25maWcuaAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvY29uZmlnLmgKQEAgLTMyLDYgKzMyLDkgQEAKIC8vIFdURiBj YW5ub3QgZGVwZW5kIG9uIEpTQyBldmVuIGlmIFVTRShKU0MpLgogI2lmIFVTRShKU0MpICYmICFk ZWZpbmVkKEJVSUxESU5HX1dURikKICNpbmNsdWRlICJKU0V4cG9ydE1hY3Jvcy5oIgorI2VsaWYg UExBVEZPUk0oQ0hST01JVU0pCisvLyBDaHJvbWl1bSBkb2Vzbid0IGhhdmUgcnVudGltZS8gaW4g aXRzIGluY2x1ZGUgcGF0aHMuCisjaW5jbHVkZSAicnVudGltZS9KU0V4cG9ydE1hY3Jvcy5oIgog I2VuZGlmCiAKICNpZiBPUyhXSU5ET1dTKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY29u ZmlnLmggYi9Tb3VyY2UvV2ViQ29yZS9jb25maWcuaAppbmRleCAzODhkYjc2ZWE2MDg1MDg4YWI5 YTM4ZDg2NmE1OWRiNTU1Nzc2NzQyLi4yZTBmZWVjOGQ2OWIxM2ZkYTA0NDFkMzExYTBkZWJlNDRm MTFkMTY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jb25maWcuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9jb25maWcuaApAQCAtMzQsOSArMzQsNyBAQAogI2VuZGlmCiAKICNpbmNsdWRlIDx3 dGYvRXhwb3J0TWFjcm9zLmg+Ci0jaWYgVVNFKEpTQykKICNpbmNsdWRlIDxydW50aW1lL0pTRXhw b3J0TWFjcm9zLmg+Ci0jZW5kaWYKICNpbmNsdWRlICJQbGF0Zm9ybUV4cG9ydE1hY3Jvcy5oIgog CiAjaWZkZWYgX19BUFBMRV9fCg==