76034 2012-01-10 23:41:15 -0800 REGRESSION(r101445): [V8] Generated code for custom getters and setters with the [Supplemental] IDL is wrong 2012-01-11 01:25:17 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72138 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 533680 0 haraken 2012-01-10 23:41:15 -0800 The class name of the implementation of custom getters and setters is wrong. Current V8TestInterface.cpp: // Attribute 'supplementalStr3' (Type: 'attribute' ExtAttr: 'CustomSetter CustomGetter Conditional ImplementedBy') {"supplementalStr3", V8TestSupplemental::supplementalStr3AccessorGetter, V8TestSupplemental::supplementalStr3AccessorSetter, 0 /* no data */, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */}, Expected V8TestInterface.cpp: // Attribute 'supplementalStr3' (Type: 'attribute' ExtAttr: 'CustomSetter CustomGetter Conditional ImplementedBy') {"supplementalStr3", V8TestInterface::supplementalStr3AccessorGetter, V8TestInterface::supplementalStr3AccessorSetter, 0 /* no data */, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */}, 533681 1 121984 haraken 2012-01-10 23:45:24 -0800 Created attachment 121984 Patch 533686 2 121984 abarth 2012-01-10 23:55:34 -0800 Comment on attachment 121984 Patch Ah, good point. 533687 3 abarth 2012-01-10 23:55:45 -0800 Sorry I missed that earlier. 533741 4 121984 webkit.review.bot 2012-01-11 01:25:13 -0800 Comment on attachment 121984 Patch Clearing flags on attachment: 121984 Committed r104684: <http://trac.webkit.org/changeset/104684> 533742 5 webkit.review.bot 2012-01-11 01:25:17 -0800 All reviewed patches have been landed. Closing bug. 121984 2012-01-10 23:45:24 -0800 2012-01-11 01:25:13 -0800 Patch bug-76034-20120111164523.patch text/plain 3960 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTdiZjU2ODU0YjM1NzZl OTM4Yjg5OTYxOTNjOTgzNmZhOWNlNjU0MC4uZmNlOTg0MzhkNzk2YTZiZmRjZTcwYjI1OTI5ODky NzgzZDJiMjAzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMxIEBACiAyMDEyLTAxLTEwICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSRUdSRVNTSU9OKHIx MDE0NDUpOiBbVjhdIEdlbmVyYXRlZCBjb2RlIGZvciBjdXN0b20gZ2V0dGVycyBhbmQgc2V0dGVy cworICAgICAgICB3aXRoIHRoZSBbU3VwcGxlbWVudGFsXSBJREwgaXMgd3JvbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2MDM0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBmaXhlcyB0 aGUgY2xhc3MgbmFtZSBvZiB0aGUgaW1wbGVtZW50YXRpb24gb2YgY3VzdG9tIGdldHRlcnMKKyAg ICAgICAgYW5kIHNldHRlcnMsIGFzIGZvbGxvd3MuCisKKyAgICAgICAgUHJldmlvdXMgVjhUZXN0 SW50ZXJmYWNlLmNwcDoKKyAgICAgICAgICAgIC8vIEF0dHJpYnV0ZSAnc3VwcGxlbWVudGFsU3Ry MycKKyAgICAgICAgICAgIHsic3VwcGxlbWVudGFsU3RyMyIsIFY4VGVzdFN1cHBsZW1lbnRhbDo6 c3VwcGxlbWVudGFsU3RyM0FjY2Vzc29yR2V0dGVyLCBWOFRlc3RTdXBwbGVtZW50YWw6OnN1cHBs ZW1lbnRhbFN0cjNBY2Nlc3NvclNldHRlciwgLi4ufSwKKworICAgICAgICBOZXcgVjhUZXN0SW50 ZXJmYWNlLmNwcDoKKyAgICAgICAgICAgIC8vIEF0dHJpYnV0ZSAnc3VwcGxlbWVudGFsU3RyMycK KyAgICAgICAgICAgIHsic3VwcGxlbWVudGFsU3RyMyIsIFY4VGVzdEludGVyZmFjZTo6c3VwcGxl bWVudGFsU3RyM0FjY2Vzc29yR2V0dGVyLCBWOFRlc3RJbnRlcmZhY2U6OnN1cHBsZW1lbnRhbFN0 cjNBY2Nlc3NvclNldHRlciwgLi4ufSwKKworICAgICAgICBUZXN0OiBiaW5kaW5ncy9zY3JpcHRz L3Rlc3QvVGVzdEludGVyZmFjZS5pZGwKKyAgICAgICAgICAgICAgYmluZGluZ3Mvc2NyaXB0cy90 ZXN0L1Rlc3RTdXBwbGVtZW50YWwuaWRsCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3JWOC5wbToKKyAgICAgICAgKEdlbmVyYXRlU2luZ2xlQmF0Y2hlZEF0dHJpYnV0 ZSk6CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdEludGVyZmFjZS5j cHA6CisKKzIwMTItMDEtMTAgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgor CiAgICAgICAgIFVzZSB0aGUgW1N1cHBsZW1lbnRhbF0gSURMIGluIFNRTERhdGFiYXNlCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjAwNAogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5w bSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCmlu ZGV4IGMwMTZjZjlhMGRhYWM5YTBjMmEwZjYwNGRiZWQ5NjY4OTcwYWQzMWIuLmIyYTUzMTRhNjdh ZjAyMGVkNWMzZjBlNmI2OWU0N2MyZDY4NGEwY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0xOTMxLDEyICsxOTMxLDcg QEAgc3ViIEdlbmVyYXRlU2luZ2xlQmF0Y2hlZEF0dHJpYnV0ZQogICAgICAgICAiIjsKICAgICBp ZiAoJGN1c3RvbUFjY2Vzc29yIGVxIDEpIHsKICAgICAgICAgIyB1c2UgdGhlIG5hbWluZyBjb252 ZW5zaW9uLCBpbnRlcmZhY2UgKyAoY2FwaXRhbGl6ZSkgYXR0ciBuYW1lCi0gICAgICAgIGlmICgk YXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJJbXBsZW1lbnRlZEJ5 In0pIHsKLSAgICAgICAgICAgICRjdXN0b21BY2Nlc3NvciA9ICRhdHRyaWJ1dGUtPnNpZ25hdHVy ZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkltcGxlbWVudGVkQnkifSAuICI6OiIgLiAkYXR0ck5h bWU7Ci0gICAgICAgICAgICBBZGRUb0ltcGxJbmNsdWRlcygiVjgiIC4gJGF0dHJpYnV0ZS0+c2ln bmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiSW1wbGVtZW50ZWRCeSJ9IC4gIi5oIik7Ci0g ICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAkY3VzdG9tQWNjZXNzb3IgPSAkaW50ZXJmYWNl TmFtZSAuICI6OiIgLiAkYXR0ck5hbWU7Ci0gICAgICAgIH0KKyAgICAgICAgJGN1c3RvbUFjY2Vz c29yID0gJGludGVyZmFjZU5hbWUgLiAiOjoiIC4gJGF0dHJOYW1lOwogICAgIH0KIAogICAgIG15 ICRnZXR0ZXI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rl c3QvVjgvVjhUZXN0SW50ZXJmYWNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvdGVzdC9WOC9WOFRlc3RJbnRlcmZhY2UuY3BwCmluZGV4IGVjMWY0ZTA0NjRjNTI1ODIzNjU4 NTkwYmU5NmEwNjU5OWZlMTE5ZmYuLjRiM2Y2YWU2YWQwNzliM2U3Y2Y0YTFjYWU2ZDBjZWU5NjBk ZTc5ZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9W OC9WOFRlc3RJbnRlcmZhY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvdGVzdC9WOC9WOFRlc3RJbnRlcmZhY2UuY3BwCkBAIC0zMyw3ICszMyw2IEBACiAjaW5jbHVk ZSAiVjhJc29sYXRlZENvbnRleHQuaCIKICNpbmNsdWRlICJWOFByb3h5LmgiCiAjaW5jbHVkZSAi VjhUZXN0T2JqLmgiCi0jaW5jbHVkZSAiVjhUZXN0U3VwcGxlbWVudGFsLmgiCiAjaW5jbHVkZSA8 d3RmL0dldFB0ci5oPgogI2luY2x1ZGUgPHd0Zi9SZWZDb3VudGVkLmg+CiAjaW5jbHVkZSA8d3Rm L1JlZlB0ci5oPgpAQCAtMTM0LDcgKzEzMyw3IEBAIHN0YXRpYyBjb25zdCBCYXRjaGVkQXR0cmli dXRlIFRlc3RJbnRlcmZhY2VBdHRyc1tdID0gewogI2VuZGlmIC8vIEVOQUJMRShDb25kaXRpb24x MSkgfHwgRU5BQkxFKENvbmRpdGlvbjEyKQogI2lmIEVOQUJMRShDb25kaXRpb24xMSkgfHwgRU5B QkxFKENvbmRpdGlvbjEyKQogICAgIC8vIEF0dHJpYnV0ZSAnc3VwcGxlbWVudGFsU3RyMycgKFR5 cGU6ICdhdHRyaWJ1dGUnIEV4dEF0dHI6ICdDdXN0b21TZXR0ZXIgQ3VzdG9tR2V0dGVyIENvbmRp dGlvbmFsIEltcGxlbWVudGVkQnknKQotICAgIHsic3VwcGxlbWVudGFsU3RyMyIsIFY4VGVzdFN1 cHBsZW1lbnRhbDo6c3VwcGxlbWVudGFsU3RyM0FjY2Vzc29yR2V0dGVyLCBWOFRlc3RTdXBwbGVt ZW50YWw6OnN1cHBsZW1lbnRhbFN0cjNBY2Nlc3NvclNldHRlciwgMCAvKiBubyBkYXRhICovLCBz dGF0aWNfY2FzdDx2ODo6QWNjZXNzQ29udHJvbD4odjg6OkRFRkFVTFQpLCBzdGF0aWNfY2FzdDx2 ODo6UHJvcGVydHlBdHRyaWJ1dGU+KHY4OjpOb25lKSwgMCAvKiBvbiBpbnN0YW5jZSAqL30sCisg ICAgeyJzdXBwbGVtZW50YWxTdHIzIiwgVjhUZXN0SW50ZXJmYWNlOjpzdXBwbGVtZW50YWxTdHIz QWNjZXNzb3JHZXR0ZXIsIFY4VGVzdEludGVyZmFjZTo6c3VwcGxlbWVudGFsU3RyM0FjY2Vzc29y U2V0dGVyLCAwIC8qIG5vIGRhdGEgKi8sIHN0YXRpY19jYXN0PHY4OjpBY2Nlc3NDb250cm9sPih2 ODo6REVGQVVMVCksIHN0YXRpY19jYXN0PHY4OjpQcm9wZXJ0eUF0dHJpYnV0ZT4odjg6Ok5vbmUp LCAwIC8qIG9uIGluc3RhbmNlICovfSwKICNlbmRpZiAvLyBFTkFCTEUoQ29uZGl0aW9uMTEpIHx8 IEVOQUJMRShDb25kaXRpb24xMikKIH07CiAK