76030 2012-01-10 22:53:22 -0800 ShouldSkipTypeHeader() and ShouldSkipTypeInImplementation() in CodeGeneratorCPP.pm should be the same 2012-01-11 02:25:19 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72138 1 haraken haraken abarth darin japhet webkit.review.bot oldest_to_newest 533657 0 haraken 2012-01-10 22:53:22 -0800 The conditions under which 1 is returned by ShouldSkipTypeHeader() and ShouldSkipTypeInImplementation() are messy. We should clean up the conditions. This is a refactoring for implementing the [Supplemental] IDL for custom methods. 533675 1 121982 haraken 2012-01-10 23:25:58 -0800 Created attachment 121982 Patch 533758 2 121982 webkit.review.bot 2012-01-11 02:25:09 -0800 Comment on attachment 121982 Patch Clearing flags on attachment: 121982 Committed r104690: <http://trac.webkit.org/changeset/104690> 533759 3 webkit.review.bot 2012-01-11 02:25:19 -0800 All reviewed patches have been landed. Closing bug. 121982 2012-01-10 23:25:58 -0800 2012-01-11 02:25:09 -0800 Patch bug-76030-20120111162557.patch text/plain 6696 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTdiZjU2ODU0YjM1NzZl OTM4Yjg5OTYxOTNjOTgzNmZhOWNlNjU0MC4uZjhkZmVlYmE2ZTBhNDNlMjNlZTdlY2FkYTlkYTY3 ZWJhMzE0ZmE1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEyLTAxLTEwICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBTaG91bGRTa2lwVHlw ZUluSGVhZGVyKCkgYW5kIFNob3VsZFNraXBUeXBlSW5JbXBsZW1lbnRhdGlvbigpIHNob3VsZCBi ZSB0aGUgc2FtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzYwMzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCZWNhdXNlIHRoZSBhdHRyaWJ1dGVzL21ldGhvZHMgdGhhdCBkbyBub3QgYXBwZWFyIGluIHRo ZSBpbXBsZW1lbnRhdGlvbgorICAgICAgICBkbyBub3QgbmVlZCB0byBhcHBlYXIgaW4gdGhlIGhl YWRlci4KKworICAgICAgICBUZXN0czogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RDYWxsYmFj ay5pZGwKKyAgICAgICAgICAgICAgIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9UZXN0T2JqLmlkbAor CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yQ1BQLnBtOgorICAgICAg ICAoU2hvdWxkU2tpcFR5cGUpOiBSZW5hbWVkIGZyb20gU2hvdWxkU2tpcFR5cGVJbkltcGxlbWVu dGF0aW9uKCkuCisgICAgICAgIChHZW5lcmF0ZUhlYWRlcik6IFJlcGxhY2VkIFNob3VsZFNraXBU eXBlSW5JbXBsZW1lbnRhdGlvbigpIHdpdGggU2hvdWxkU2tpcFR5cGUoKSwKKyAgICAgICAgYW5k IHJlcGxhY2VkIFNob3VsZFNraXBUeXBlSW5IZWFkZXIoKSB3aXRoIFNob3VsZFNraXBUeXBlKCku CisgICAgICAgIChHZW5lcmF0ZUltcGxlbWVudGF0aW9uKTogRGl0dG8uCisgICAgICAgICogYmlu ZGluZ3Mvc2NyaXB0cy90ZXN0L0NQUC9XZWJET01UZXN0Q2FsbGJhY2suaDogVXBkYXRlZCB0aGUg dGVzdCByZXN1bHQuCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0NQUC9XZWJET01U ZXN0T2JqLmg6IERpdHRvLgorCisyMDEyLTAxLTEwICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNo cm9taXVtLm9yZz4KKwogICAgICAgICBVc2UgdGhlIFtTdXBwbGVtZW50YWxdIElETCBpbiBTUUxE YXRhYmFzZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzYwMDQKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2Rl R2VuZXJhdG9yQ1BQLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9yQ1BQLnBtCmluZGV4IGQzMTQ1OTI5ZjA3MGIyZDI3MWE2OTE0NGRlYjYxZDgwZmYxMzhj ZDQuLjY5NjZkOTBmOWM2YWQ2NDczYjJjZjg2NWI4ZmI5ODMwM2NjMGU3NWQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckNQUC5wbQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JDUFAucG0KQEAg LTE5Miw3ICsxOTIsNyBAQCBzdWIgR2V0UGFyZW50CiAgICAgcmV0dXJuICRwYXJlbnQ7CiB9CiAK LXN1YiBTaG91bGRTa2lwVHlwZUluSW1wbGVtZW50YXRpb24KK3N1YiBTaG91bGRTa2lwVHlwZQog ewogICAgIG15ICR0eXBlSW5mbyA9IHNoaWZ0OwogCkBAIC0yMTAsMjEgKzIxMCw2IEBAIHN1YiBT aG91bGRTa2lwVHlwZUluSW1wbGVtZW50YXRpb24KICAgICByZXR1cm4gMDsKIH0KIAotc3ViIFNo b3VsZFNraXBUeXBlSW5IZWFkZXIKLXsKLSAgICBteSAkdHlwZUluZm8gPSBzaGlmdDsKLQotICAg ICMgRklYTUU6IFdlIGN1cnJlbnRseSBpZ25vcmUgYW55IGF0dHJpYnV0ZS9mdW5jdGlvbiBuZWVk aW5nIGN1c3RvbSBjb2RlCi0gICAgcmV0dXJuIDEgaWYgJHR5cGVJbmZvLT5zaWduYXR1cmUtPmV4 dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21Bcmd1bWVudEhhbmRsaW5nIn0KLSAgICAgICAgICAg ICBvciAkdHlwZUluZm8tPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkN1c3RvbUdl dHRlciJ9OwotCi0gICAgIyBGSVhNRTogV2UgZG9uJ3QgZ2VuZXJhdGUgYmluZGluZ3MgZm9yIFNW RyByZWxhdGVkIGludGVyZmFjZXMgeWV0Ci0gICAgcmV0dXJuIDEgaWYgJHR5cGVJbmZvLT5zaWdu YXR1cmUtPm5hbWUgPX4gL2dldFNWR0RvY3VtZW50LzsKLQotICAgIHJldHVybiAxIGlmICR0eXBl SW5mby0+c2lnbmF0dXJlLT5uYW1lID1+IC9Db25zdHJ1Y3Rvci87Ci0gICAgcmV0dXJuIDA7Ci19 Ci0KIHN1YiBHZXRDUFBUeXBlCiB7CiAgICAgbXkgJHR5cGUgPSBzaGlmdDsKQEAgLTQ0Myw3ICs0 MjgsNyBAQCBzdWIgR2VuZXJhdGVIZWFkZXIKICAgICAjIC0gQWRkIGF0dHJpYnV0ZSBnZXR0ZXJz L3NldHRlcnMuCiAgICAgaWYgKCRudW1BdHRyaWJ1dGVzID4gMCkgewogICAgICAgICBmb3JlYWNo IG15ICRhdHRyaWJ1dGUgKEB7JGRhdGFOb2RlLT5hdHRyaWJ1dGVzfSkgewotICAgICAgICAgICAg bmV4dCBpZiBTaG91bGRTa2lwVHlwZUluSGVhZGVyKCRhdHRyaWJ1dGUpOworICAgICAgICAgICAg bmV4dCBpZiBTaG91bGRTa2lwVHlwZSgkYXR0cmlidXRlKTsKIAogICAgICAgICAgICAgbXkgJGF0 dHJpYnV0ZUNvbmRpdGlvbmFsU3RyaW5nID0gR2VuZXJhdGVDb25kaXRpb25hbFN0cmluZygkYXR0 cmlidXRlLT5zaWduYXR1cmUpOwogICAgICAgICAgICAgbXkgJGF0dHJpYnV0ZU5hbWUgPSAkYXR0 cmlidXRlLT5zaWduYXR1cmUtPm5hbWU7CkBAIC00ODIsNyArNDY3LDcgQEAgc3ViIEdlbmVyYXRl SGVhZGVyCiAgICAgIyAtIEFkZCBmdW5jdGlvbnMuCiAgICAgaWYgKCRudW1GdW5jdGlvbnMgPiAw KSB7CiAgICAgICAgIGZvcmVhY2ggbXkgJGZ1bmN0aW9uIChAeyRkYXRhTm9kZS0+ZnVuY3Rpb25z fSkgewotICAgICAgICAgICAgbmV4dCBpZiBTaG91bGRTa2lwVHlwZUluSGVhZGVyKCRmdW5jdGlv bik7CisgICAgICAgICAgICBuZXh0IGlmIFNob3VsZFNraXBUeXBlKCRmdW5jdGlvbik7CiAgICAg ICAgICAgICBteSAkZnVuY3Rpb25OYW1lID0gJGZ1bmN0aW9uLT5zaWduYXR1cmUtPm5hbWU7CiAK ICAgICAgICAgICAgIG15ICRyZXR1cm5UeXBlID0gR2V0Q1BQVHlwZSgkZnVuY3Rpb24tPnNpZ25h dHVyZS0+dHlwZSwgMCk7CkBAIC02OTQsNyArNjc5LDcgQEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50 YXRpb24KICAgICAjIC0gQXR0cmlidXRlcwogICAgIGlmICgkbnVtQXR0cmlidXRlcyA+IDApIHsK ICAgICAgICAgZm9yZWFjaCBteSAkYXR0cmlidXRlIChAeyRkYXRhTm9kZS0+YXR0cmlidXRlc30p IHsKLSAgICAgICAgICAgIG5leHQgaWYgU2hvdWxkU2tpcFR5cGVJbkltcGxlbWVudGF0aW9uKCRh dHRyaWJ1dGUpOworICAgICAgICAgICAgbmV4dCBpZiBTaG91bGRTa2lwVHlwZSgkYXR0cmlidXRl KTsKICAgICAgICAgICAgIEFkZEluY2x1ZGVzRm9yVHlwZSgkYXR0cmlidXRlLT5zaWduYXR1cmUt PnR5cGUpOwogCiAgICAgICAgICAgICBteSAkaWRsVHlwZSA9ICRjb2RlR2VuZXJhdG9yLT5TdHJp cE1vZHVsZSgkYXR0cmlidXRlLT5zaWduYXR1cmUtPnR5cGUpOwpAQCAtODA1LDcgKzc5MCw3IEBA IHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9uCiAgICAgaWYgKCRudW1GdW5jdGlvbnMgPiAwKSB7 CiAgICAgICAgIGZvcmVhY2ggbXkgJGZ1bmN0aW9uIChAeyRkYXRhTm9kZS0+ZnVuY3Rpb25zfSkg ewogICAgICAgICAgICAgIyBUcmVhdCBQdXJlSW50ZXJmYWNlIGFzIEN1c3RvbSBhcyB3ZWxsLCBz aW5jZSB0aGUgV2ViQ29yZSB2ZXJzaW9ucyB3aWxsIHRha2UgYSBzY3JpcHQgY29udGV4dCBhcyB3 ZWxsCi0gICAgICAgICAgICBuZXh0IGlmIFNob3VsZFNraXBUeXBlSW5JbXBsZW1lbnRhdGlvbigk ZnVuY3Rpb24pIHx8ICRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlB1cmVJbnRlcmZh Y2UifTsKKyAgICAgICAgICAgIG5leHQgaWYgU2hvdWxkU2tpcFR5cGUoJGZ1bmN0aW9uKSB8fCAk ZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJQdXJlSW50ZXJmYWNlIn07CiAgICAgICAg ICAgICBBZGRJbmNsdWRlc0ZvclR5cGUoJGZ1bmN0aW9uLT5zaWduYXR1cmUtPnR5cGUpOwogCiAg ICAgICAgICAgICBteSAkZnVuY3Rpb25OYW1lID0gJGZ1bmN0aW9uLT5zaWduYXR1cmUtPm5hbWU7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvQ1BQL1dl YkRPTVRlc3RDYWxsYmFjay5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0 L0NQUC9XZWJET01UZXN0Q2FsbGJhY2suaAppbmRleCAxYTU1YTM1NTA4ZjUzMjZiZjM5MWZmMzYz Y2Q2YWYxNDZiYTgzYTg1Li5jZWM4YjZjM2M4MjFmN2IyMjU0YmE5NTQyNzZjNmI0MDVlMTE3ZDU4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvQ1BQL1dl YkRPTVRlc3RDYWxsYmFjay5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv dGVzdC9DUFAvV2ViRE9NVGVzdENhbGxiYWNrLmgKQEAgLTM1LDggKzM1LDYgQEAgY2xhc3MgVGVz dENhbGxiYWNrOwogY2xhc3MgV2ViRE9NQ2xhc3MxOwogY2xhc3MgV2ViRE9NQ2xhc3MyOwogY2xh c3MgV2ViRE9NQ2xhc3MzOwotY2xhc3MgV2ViRE9NQ2xhc3M1OwotY2xhc3MgV2ViRE9NQ2xhc3M2 OwogY2xhc3MgV2ViRE9NRE9NU3RyaW5nTGlzdDsKIAogY2xhc3MgV2ViRE9NVGVzdENhbGxiYWNr IDogcHVibGljIFdlYkRPTU9iamVjdCB7CkBAIC01MSw3ICs0OSw2IEBAIHB1YmxpYzoKICAgICBi b29sIGNhbGxiYWNrV2l0aENsYXNzMVBhcmFtKGNvbnN0IFdlYkRPTUNsYXNzMSYgY2xhc3MxUGFy YW0pOwogICAgIGJvb2wgY2FsbGJhY2tXaXRoQ2xhc3MyUGFyYW0oY29uc3QgV2ViRE9NQ2xhc3My JiBjbGFzczJQYXJhbSwgY29uc3QgV2ViRE9NU3RyaW5nJiBzdHJBcmcpOwogICAgIGludCBjYWxs YmFja1dpdGhOb25Cb29sUmV0dXJuVHlwZShjb25zdCBXZWJET01DbGFzczMmIGNsYXNzM1BhcmFt KTsKLSAgICBpbnQgY3VzdG9tQ2FsbGJhY2soY29uc3QgV2ViRE9NQ2xhc3M1JiBjbGFzczVQYXJh bSwgY29uc3QgV2ViRE9NQ2xhc3M2JiBjbGFzczZQYXJhbSk7CiAgICAgYm9vbCBjYWxsYmFja1dp dGhTdHJpbmdMaXN0KGNvbnN0IFdlYkRPTURPTVN0cmluZ0xpc3QmIGxpc3RQYXJhbSk7CiAKICAg ICBXZWJDb3JlOjpUZXN0Q2FsbGJhY2sqIGltcGwoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9DUFAvV2ViRE9NVGVzdE9iai5oIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0NQUC9XZWJET01UZXN0T2JqLmgKaW5k ZXggZTliMDNiYzNhNDNjNmRhOTI3YWNkZmU3OTQxNDM2ZjdiYTE3YzdlYy4uNDNmZDk4YzAyOWE2 NGQ0ZmRlM2Y3ZjcyMGFhYTM5NTVjN2I0ZmMwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L0NQUC9XZWJET01UZXN0T2JqLmgKKysrIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0NQUC9XZWJET01UZXN0T2JqLmgKQEAgLTEyNCw4 ICsxMjQsNiBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRTdHJpbmdBdHRyV2l0aEdldHRlckV4Y2Vw dGlvbihjb25zdCBXZWJET01TdHJpbmcmKTsKICAgICBXZWJET01TdHJpbmcgc3RyaW5nQXR0cldp dGhTZXR0ZXJFeGNlcHRpb24oKSBjb25zdDsKICAgICB2b2lkIHNldFN0cmluZ0F0dHJXaXRoU2V0 dGVyRXhjZXB0aW9uKGNvbnN0IFdlYkRPTVN0cmluZyYpOwotICAgIGludCBjdXN0b21BdHRyKCkg Y29uc3Q7Ci0gICAgdm9pZCBzZXRDdXN0b21BdHRyKGludCk7CiAgICAgV2ViRE9NU3RyaW5nIHNj cmlwdFN0cmluZ0F0dHIoKSBjb25zdDsKICNpZiBFTkFCTEUoQ29uZGl0aW9uMSkKICAgICBpbnQg Y29uZGl0aW9uYWxBdHRyMSgpIGNvbnN0OwpAQCAtMTc0LDggKzE3Miw2IEBAIHB1YmxpYzoKICAg ICB2b2lkIGlkYktleShjb25zdCBXZWJET01JREJLZXkmIGtleSk7CiAgICAgdm9pZCBvcHRpb25z T2JqZWN0KGNvbnN0IFdlYkRPTU9wdGlvbnNPYmplY3QmIG9vLCBjb25zdCBXZWJET01PcHRpb25z T2JqZWN0JiBvb28pOwogICAgIHZvaWQgbWV0aG9kV2l0aEV4Y2VwdGlvbigpOwotICAgIHZvaWQg Y3VzdG9tTWV0aG9kKCk7Ci0gICAgdm9pZCBjdXN0b21NZXRob2RXaXRoQXJncyhpbnQgaW50QXJn LCBjb25zdCBXZWJET01TdHJpbmcmIHN0ckFyZywgY29uc3QgV2ViRE9NVGVzdE9iaiYgb2JqQXJn KTsKICAgICB2b2lkIGFkZEV2ZW50TGlzdGVuZXIoY29uc3QgV2ViRE9NU3RyaW5nJiB0eXBlLCBj b25zdCBXZWJET01FdmVudExpc3RlbmVyJiBsaXN0ZW5lciwgYm9vbCB1c2VDYXB0dXJlKTsKICAg ICB2b2lkIHJlbW92ZUV2ZW50TGlzdGVuZXIoY29uc3QgV2ViRE9NU3RyaW5nJiB0eXBlLCBjb25z dCBXZWJET01FdmVudExpc3RlbmVyJiBsaXN0ZW5lciwgYm9vbCB1c2VDYXB0dXJlKTsKICAgICB2 b2lkIHdpdGhTY3JpcHRTdGF0ZVZvaWQoKTsK