75828 2012-01-08 23:34:21 -0800 [Refactoring] Use join(", ", @arguments) to build a method argument string in CodeGeneratorV8.pm 2012-01-09 00:26:41 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72138 1 haraken haraken abarth darin japhet webkit.review.bot oldest_to_newest 532007 0 haraken 2012-01-08 23:34:21 -0800 This is a refactoring for implementing the [Supplemental] IDL for methods (bug 72138). The code in CodeGeneratorV8.pm to build a method argument string is dirty and error-prone. It is concatenating arguments one by one judging whether ", " is necessary or not. Instead, we should refactor the code so that it pushes all arguments into @arguments and then build a method string by join(", ", @arguments). 532009 1 121625 haraken 2012-01-08 23:39:41 -0800 Created attachment 121625 Patch 532019 2 121625 webkit.review.bot 2012-01-09 00:26:36 -0800 Comment on attachment 121625 Patch Clearing flags on attachment: 121625 Committed r104438: <http://trac.webkit.org/changeset/104438> 532020 3 webkit.review.bot 2012-01-09 00:26:41 -0800 All reviewed patches have been landed. Closing bug. 121625 2012-01-08 23:39:41 -0800 2012-01-09 00:26:36 -0800 Patch bug-75828-20120109163940.patch text/plain 4214 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NDMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTRhMjk1ZmJlY2VkYjZi NzlhODkyZDQwMDg1NGZmZDQyMTE2Mzk3Yi4uZjM1ZjNkYjNiOWRkODg4NDg3NWZmNDNmZWM2NDBi YzZmZTRiMTU2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAxLTA4ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbUmVmYWN0b3Jpbmdd IFVzZSBqb2luKCIsICIsIEBhcmd1bWVudHMpIHRvIGJ1aWxkIGEgbWV0aG9kIGFyZ3VtZW50Cisg ICAgICAgIHN0cmluZyBpbiBDb2RlR2VuZXJhdG9yVjgucG0KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1ODI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNvZGUgaW4gQ29kZUdlbmVyYXRvclY4LnBt IHRvIGJ1aWxkIGEgbWV0aG9kIGFyZ3VtZW50IHN0cmluZyBpcyBkaXJ0eQorICAgICAgICBhbmQg ZXJyb3ItcHJvbmUuIEl0IGlzIGNvbmNhdGVuYXRpbmcgYXJndW1lbnRzIG9uZSBieSBvbmUganVk Z2luZyB3aGV0aGVyCisgICAgICAgICIsICIgaXMgbmVjZXNzYXJ5IG9yIG5vdC4gVGhpcyBwYXRj aCByZWZhY3RvcnMgdGhlIGNvZGUgc28gdGhhdCBpdCBwdXNoZXMKKyAgICAgICAgYWxsIGFyZ3Vt ZW50cyBpbnRvIEBhcmd1bWVudHMgYW5kIHRoZW4gYnVpbGRzIGEgbWV0aG9kIHN0cmluZyBieQor ICAgICAgICBqb2luKCIsICIsIEBhcmd1bWVudHMpLgorCisgICAgICAgIFRlc3Q6IGJpbmRpbmdz L3NjcmlwdHMvdGVzdC8qCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0 b3JWOC5wbToKKyAgICAgICAgKEdlbmVyYXRlRnVuY3Rpb25DYWxsU3RyaW5nKToKKwogMjAxMi0w MS0wOCAgQ2hhbmdTZW9rIE9oICA8c2hpdmFtaWRvd0BnbWFpbC5jb20+CiAKICAgICAgICAgTWVt b3J5IGFsbG9jYXRpb24gbWlzbWF0Y2ggYnkgdXNpbmcgYWRvcHRBcnJheVB0ciBpbiBHcmFwaGlj c0NvbnRleHQzRE9wZW5HTC5jcHAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KaW5kZXggOWNkYTAwYTQ0ZDhjMjQ3NGU1ZGU4MjBkNGY1 MjQyMjE1YWZlMjEwMS4uMjVkNjk2MGMyZDkyYTUyNGVhYmM2ZWUwOGIxYTFlZTQ0NWE0MmYwYSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y VjgucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y VjgucG0KQEAgLTMxODUsMTEgKzMxODUsNyBAQCBzdWIgR2VuZXJhdGVGdW5jdGlvbkNhbGxTdHJp bmcoKQogICAgICAgICAkbmFtZSA9ICRmdW5jdGlvbi0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJp YnV0ZXMtPnsiSW1wbGVtZW50YXRpb25GdW5jdGlvbiJ9OwogICAgIH0KIAotICAgIG15ICRmdW5j dGlvblN0cmluZyA9ICJpbXAtPiR7bmFtZX0oIjsKLSAgICBpZiAoJGZ1bmN0aW9uLT5pc1N0YXRp YykgewotICAgICAgICAkZnVuY3Rpb25TdHJpbmcgPSAiJHtpbXBsQ2xhc3NOYW1lfTo6JHtuYW1l fSgiOwotICAgIH0KLQorICAgIG15IEBhcmd1bWVudHM7CiAgICAgbXkgJGluZGV4ID0gMDsKICAg ICBteSAkaGFzU2NyaXB0U3RhdGUgPSAwOwogCkBAIC0zMjA2LDggKzMyMDIsNyBAQCBzdWIgR2Vu ZXJhdGVGdW5jdGlvbkNhbGxTdHJpbmcoKQogICAgICAgICAgICAgJHJlc3VsdCAuPSAkaW5kZW50 IC4gIiAgICByZXR1cm4gdjg6OlVuZGVmaW5lZCgpO1xuIjsKICAgICAgICAgICAgICRjYWxsV2l0 aEFyZyA9ICJzY3JpcHRDb250ZXh0IjsKICAgICAgICAgfQotICAgICAgICAkZnVuY3Rpb25TdHJp bmcgLj0gIiwgIiBpZiAkaW5kZXg7Ci0gICAgICAgICRmdW5jdGlvblN0cmluZyAuPSAkY2FsbFdp dGhBcmc7CisgICAgICAgIHB1c2ggQGFyZ3VtZW50cywgJGNhbGxXaXRoQXJnOwogICAgICAgICAk aW5kZXgrKzsKICAgICAgICAgJG51bWJlck9mUGFyYW1ldGVycysrCiAgICAgfQpAQCAtMzIxNiwz OCArMzIxMSwzNCBAQCBzdWIgR2VuZXJhdGVGdW5jdGlvbkNhbGxTdHJpbmcoKQogICAgICAgICBp ZiAoJGluZGV4IGVxICRudW1iZXJPZlBhcmFtZXRlcnMpIHsKICAgICAgICAgICAgIGxhc3Q7CiAg ICAgICAgIH0KLSAgICAgICAgJGZ1bmN0aW9uU3RyaW5nIC49ICIsICIgaWYgJGluZGV4OwogICAg ICAgICBteSAkcGFyYW1OYW1lID0gJHBhcmFtZXRlci0+bmFtZTsKICAgICAgICAgbXkgJHBhcmFt VHlwZSA9ICRwYXJhbWV0ZXItPnR5cGU7CiAKICAgICAgICAgaWYgKCRwYXJhbWV0ZXItPnR5cGUg ZXEgIk5vZGVGaWx0ZXIiIHx8ICRwYXJhbWV0ZXItPnR5cGUgZXEgIlhQYXRoTlNSZXNvbHZlciIp IHsKLSAgICAgICAgICAgICRmdW5jdGlvblN0cmluZyAuPSAiJHBhcmFtTmFtZS5nZXQoKSI7Cisg ICAgICAgICAgICBwdXNoIEBhcmd1bWVudHMsICIkcGFyYW1OYW1lLmdldCgpIjsKICAgICAgICAg fSBlbHNpZiAoJGNvZGVHZW5lcmF0b3ItPklzU1ZHVHlwZU5lZWRpbmdUZWFyT2ZmKCRwYXJhbWV0 ZXItPnR5cGUpIGFuZCBub3QgJGltcGxDbGFzc05hbWUgPX4gL0xpc3QkLykgewotICAgICAgICAg ICAgJGZ1bmN0aW9uU3RyaW5nIC49ICIkcGFyYW1OYW1lLT5wcm9wZXJ0eVJlZmVyZW5jZSgpIjsK KyAgICAgICAgICAgIHB1c2ggQGFyZ3VtZW50cywgIiRwYXJhbU5hbWUtPnByb3BlcnR5UmVmZXJl bmNlKCkiOwogICAgICAgICAgICAgJHJlc3VsdCAuPSAkaW5kZW50IC4gImlmICghJHBhcmFtTmFt ZSkge1xuIjsKICAgICAgICAgICAgICRyZXN1bHQgLj0gJGluZGVudCAuICIgICAgVjhQcm94eTo6 c2V0RE9NRXhjZXB0aW9uKFdlYkNvcmU6OlRZUEVfTUlTTUFUQ0hfRVJSKTtcbiI7CiAgICAgICAg ICAgICAkcmVzdWx0IC49ICRpbmRlbnQgLiAiICAgIHJldHVybiB2ODo6SGFuZGxlPHY4OjpWYWx1 ZT4oKTtcbiI7CiAgICAgICAgICAgICAkcmVzdWx0IC49ICRpbmRlbnQgLiAifVxuIjsKICAgICAg ICAgfSBlbHNpZiAoJHBhcmFtZXRlci0+dHlwZSBlcSAiU1ZHTWF0cml4IiBhbmQgJGltcGxDbGFz c05hbWUgZXEgIlNWR1RyYW5zZm9ybUxpc3QiKSB7Ci0gICAgICAgICAgICAkZnVuY3Rpb25TdHJp bmcgLj0gIiRwYXJhbU5hbWUuZ2V0KCkiOworICAgICAgICAgICAgcHVzaCBAYXJndW1lbnRzLCAi JHBhcmFtTmFtZS5nZXQoKSI7CiAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAkZnVuY3Rp b25TdHJpbmcgLj0gJHBhcmFtTmFtZTsKKyAgICAgICAgICAgIHB1c2ggQGFyZ3VtZW50cywgJHBh cmFtTmFtZTsKICAgICAgICAgfQogICAgICAgICAkaW5kZXgrKzsKICAgICB9CiAKICAgICBpZiAo JGZ1bmN0aW9uLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21Bcmd1bWVu dEhhbmRsaW5nIn0pIHsKLSAgICAgICAgJGZ1bmN0aW9uU3RyaW5nIC49ICIsICIgaWYgJGluZGV4 OwotICAgICAgICAkZnVuY3Rpb25TdHJpbmcgLj0gInNjcmlwdEFyZ3VtZW50cywgY2FsbFN0YWNr IjsKLSAgICAgICAgJGluZGV4ICs9IDI7CisgICAgICAgIHB1c2ggQGFyZ3VtZW50cywgInNjcmlw dEFyZ3VtZW50cywgY2FsbFN0YWNrIjsKICAgICB9CiAKICAgICBpZiAoQHskZnVuY3Rpb24tPnJh aXNlc0V4Y2VwdGlvbnN9KSB7Ci0gICAgICAgICRmdW5jdGlvblN0cmluZyAuPSAiLCAiIGlmICRp bmRleDsKLSAgICAgICAgJGZ1bmN0aW9uU3RyaW5nIC49ICJlYyI7Ci0gICAgICAgICRpbmRleCsr OworICAgICAgICBwdXNoIEBhcmd1bWVudHMsICJlYyI7CiAgICAgfQotICAgICRmdW5jdGlvblN0 cmluZyAuPSAiKSI7CisKKyAgICBteSAkZnVuY3Rpb25TdHJpbmcgPSAoJGZ1bmN0aW9uLT5pc1N0 YXRpYyA/ICIke2ltcGxDbGFzc05hbWV9Ojoke25hbWV9KCIgOiAiaW1wLT4ke25hbWV9KCIpIC4g am9pbigiLCAiLCBAYXJndW1lbnRzKSAuICIpIjsKIAogICAgIG15ICRyZXR1cm4gPSAicmVzdWx0 IjsKICAgICBteSAkcmV0dXJuSXNSZWYgPSBJc1JlZlB0clR5cGUoJHJldHVyblR5cGUpOwo=