75658 2012-01-05 15:22:14 -0800 Enable a compositing trigger for filters 2012-01-09 04:23:54 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noam webkit-unassigned achicu cmarrin simon.fraser webkit.review.bot oldest_to_newest 530690 0 noam 2012-01-05 15:22:14 -0800 For Qt, we would like an option to force the compositing path for filters, and the right place to do so seems to be RenderLayerCompositor and the triggers in ChromeClient. 530701 1 121349 noam 2012-01-05 15:32:04 -0800 Created attachment 121349 Patch 531386 2 121492 noam 2012-01-06 14:07:54 -0800 Created attachment 121492 Patch 531437 3 121492 webkit.review.bot 2012-01-06 15:13:18 -0800 Comment on attachment 121492 Patch Clearing flags on attachment: 121492 Committed r104347: <http://trac.webkit.org/changeset/104347> 531438 4 webkit.review.bot 2012-01-06 15:13:22 -0800 All reviewed patches have been landed. Closing bug. 532088 5 achicu 2012-01-09 04:23:54 -0800 This patch broke the cases when some of the filters do not render in composited mode. That's because RenderLayerBacking::paintIntoLayer has no logic for applying filters yet. I've added https://bugs.webkit.org/show_bug.cgi?id=75842 to fix that. 121349 2012-01-05 15:32:04 -0800 2012-01-06 14:07:54 -0800 Patch patch.diff text/plain 3431 noam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyYzUyY2ExLi44ZWFiMDA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMg QEAKKyAgICAgICAgRW5hYmxlIGEgY29tcG9zaXRpbmcgdHJpZ2dlciBmb3IgZmlsdGVycworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU2NTgKKworICAg ICAgICBUaGlzIHdpbGwgZW5hYmxlIGZvcmNpbmcgdGhlIGNvbXBvc2l0aW5nIGNvZGUgcGF0aCB3 aGVuIGZpbHRlcnMKKyAgICAgICAgZXhpc3QgZm9yIGEgUmVuZGVyT2JqZWN0LgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyBmdW5jdGlvbmFs aXR5IHNvIG5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBhZ2UvQ2hyb21lQ2xpZW50Lmg6Cisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OnJlcXVpcmVzQ29tcG9zaXRpbmdMYXllcik6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OnJlcXVpcmVzQ29tcG9z aXRpbmdGb3JGaWx0ZXJzKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3Np dG9yLmg6CisKKzIwMTItMDEtMDUgIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5v a2lhLmNvbT4KKwogICAgICAgICBbUXRdW1RleG1hcF0gQ29udmVydCBzaGFkZXJzIGluIFRleHR1 cmVNYXBwZXJHTCB0byB1c2UgYSBtYWNybwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzU1OTgKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFn ZS9DaHJvbWVDbGllbnQuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21lQ2xpZW50LmgKaW5k ZXggMDQ4MTg3Ny4uOTgyYTdjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9DaHJv bWVDbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZUNsaWVudC5oCkBAIC0y NTgsNiArMjU4LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAgICAgUGx1Z2luVHJp Z2dlciA9IDEgPDwgMiwKICAgICAgICAgICAgIENhbnZhc1RyaWdnZXIgPSAxIDw8IDMsCiAgICAg ICAgICAgICBBbmltYXRpb25UcmlnZ2VyID0gMSA8PCA0LAorICAgICAgICAgICAgRmlsdGVyVHJp Z2dlciA9IDEgPDwgNSwKICAgICAgICAgICAgIEFsbFRyaWdnZXJzID0gMHhGRkZGRkZGRgogICAg ICAgICB9OwogICAgICAgICB0eXBlZGVmIHVuc2lnbmVkIENvbXBvc2l0aW5nVHJpZ2dlckZsYWdz OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9y LmNwcAppbmRleCBhYzQ0NjQxLi4yZjk4ZTE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcApAQCAtMTMzMSw2ICsxMzMxLDcgQEAg Ym9vbCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OnJlcXVpcmVzQ29tcG9zaXRpbmdMYXllcihjb25z dCBSZW5kZXJMYXllciogbGF5ZXIpIGMKICAgICAgICAgICAgICB8fCBjbGlwc0NvbXBvc2l0aW5n RGVzY2VuZGFudHMobGF5ZXIpCiAgICAgICAgICAgICAgfHwgcmVxdWlyZXNDb21wb3NpdGluZ0Zv ckFuaW1hdGlvbihyZW5kZXJlcikKICAgICAgICAgICAgICB8fCByZXF1aXJlc0NvbXBvc2l0aW5n Rm9yRnVsbFNjcmVlbihyZW5kZXJlcikKKyAgICAgICAgICAgICB8fCByZXF1aXJlc0NvbXBvc2l0 aW5nRm9yRmlsdGVycyhyZW5kZXJlcikKICAgICAgICAgICAgICB8fCByZXF1aXJlc0NvbXBvc2l0 aW5nRm9yUG9zaXRpb24ocmVuZGVyZXIsIGxheWVyKTsKIH0KIApAQCAtMTUxNiw2ICsxNTE3LDE5 IEBAIGJvb2wgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpyZXF1aXJlc0NvbXBvc2l0aW5nRm9yRnVs bFNjcmVlbihSZW5kZXJPYmplY3QqIHJlbmRlCiAjZW5kaWYKIH0KIAorYm9vbCBSZW5kZXJMYXll ckNvbXBvc2l0b3I6OnJlcXVpcmVzQ29tcG9zaXRpbmdGb3JGaWx0ZXJzKFJlbmRlck9iamVjdCog cmVuZGVyZXIpIGNvbnN0Cit7CisjaWYgRU5BQkxFKENTU19GSUxURVJTKQorICAgIGlmICghKG1f Y29tcG9zaXRpbmdUcmlnZ2VycyAmIENocm9tZUNsaWVudDo6RmlsdGVyVHJpZ2dlcikpCisgICAg ICAgIHJldHVybiBmYWxzZTsKKworICAgIHJldHVybiByZW5kZXJlci0+aGFzRmlsdGVyKCk7Cisj ZWxzZQorICAgIFVOVVNFRF9QQVJBTShyZW5kZXJlcik7CisgICAgcmV0dXJuIGZhbHNlOworI2Vu ZGlmCit9CisKIGJvb2wgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpyZXF1aXJlc0NvbXBvc2l0aW5n Rm9yUG9zaXRpb24oUmVuZGVyT2JqZWN0KiByZW5kZXJlciwgY29uc3QgUmVuZGVyTGF5ZXIqIGxh eWVyKSBjb25zdAogewogICAgIC8vIHBvc2l0aW9uOmZpeGVkIGVsZW1lbnRzIHRoYXQgY3JlYXRl IHRoZWlyIG93biBzdGFja2luZyBjb250ZXh0IChlLmcuIGhhdmUgYW4gZXhwbGljaXQgei1pbmRl eCwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBv c2l0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3Iu aAppbmRleCBkYzRiMjdkLi5hNTVjZTlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oCkBAIC0yODUsNiArMjg1LDcgQEAgcHJpdmF0ZToK ICAgICBib29sIHJlcXVpcmVzQ29tcG9zaXRpbmdGb3JGcmFtZShSZW5kZXJPYmplY3QqKSBjb25z dDsKICAgICBib29sIHJlcXVpcmVzQ29tcG9zaXRpbmdXaGVuRGVzY2VuZGFudHNBcmVDb21wb3Np dGluZyhSZW5kZXJPYmplY3QqKSBjb25zdDsKICAgICBib29sIHJlcXVpcmVzQ29tcG9zaXRpbmdG b3JGdWxsU2NyZWVuKFJlbmRlck9iamVjdCopIGNvbnN0OworICAgIGJvb2wgcmVxdWlyZXNDb21w b3NpdGluZ0ZvckZpbHRlcnMoUmVuZGVyT2JqZWN0KikgY29uc3Q7CiAgICAgYm9vbCByZXF1aXJl c0NvbXBvc2l0aW5nRm9yU2Nyb2xsYWJsZUZyYW1lKCkgY29uc3Q7CiAgICAgYm9vbCByZXF1aXJl c0NvbXBvc2l0aW5nRm9yUG9zaXRpb24oUmVuZGVyT2JqZWN0KiwgY29uc3QgUmVuZGVyTGF5ZXIq KSBjb25zdDsKIAo= 121492 2012-01-06 14:07:54 -0800 2012-01-06 15:13:18 -0800 Patch patch.diff text/plain 3381 noam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0OGJlNTJiLi4zYWY0MDQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMDEtMDYgIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNv bT4KKworICAgICAgICBFbmFibGUgYSBjb21wb3NpdGluZyB0cmlnZ2VyIGZvciBmaWx0ZXJzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTY1OAorCisg ICAgICAgIFRoaXMgd2lsbCBlbmFibGUgZm9yY2luZyB0aGUgY29tcG9zaXRpbmcgY29kZSBwYXRo IHdoZW4gZmlsdGVycyBleGlzdCBmb3IgYSBSZW5kZXJPYmplY3QuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAgICAgIE5vIG5ldyBmdW5jdGlvbmFsaXR5IHNvIG5v IG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBhZ2UvQ2hyb21lQ2xpZW50Lmg6CisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJMYXllckNvbXBvc2l0b3I6OnJlcXVpcmVzQ29tcG9zaXRpbmdMYXllcik6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OnJlcXVpcmVzQ29tcG9zaXRpbmdGb3JG aWx0ZXJzKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmg6CisK IDIwMTEtMTEtMDIgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCiAgICAgICAg IENTU1J1bGU6IERldmlydHVhbGl6ZSBjc3NUZXh0KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvQ2hyb21lQ2xpZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZUNsaWVu dC5oCmluZGV4IGNkZTdjNDIuLmM3ZTNmMDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvQ2hyb21lQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9DaHJvbWVDbGllbnQu aApAQCAtMjY3LDYgKzI2Nyw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgICAgIFBs dWdpblRyaWdnZXIgPSAxIDw8IDIsCiAgICAgICAgICAgICBDYW52YXNUcmlnZ2VyID0gMSA8PCAz LAogICAgICAgICAgICAgQW5pbWF0aW9uVHJpZ2dlciA9IDEgPDwgNCwKKyAgICAgICAgICAgIEZp bHRlclRyaWdnZXIgPSAxIDw8IDUsCiAgICAgICAgICAgICBBbGxUcmlnZ2VycyA9IDB4RkZGRkZG RkYKICAgICAgICAgfTsKICAgICAgICAgdHlwZWRlZiB1bnNpZ25lZCBDb21wb3NpdGluZ1RyaWdn ZXJGbGFnczsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ckNvbXBvc2l0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29t cG9zaXRvci5jcHAKaW5kZXggNmFiNTBjYi4uZmQzMjUwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKQEAgLTEzMjMsNiArMTMy Myw3IEBAIGJvb2wgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpyZXF1aXJlc0NvbXBvc2l0aW5nTGF5 ZXIoY29uc3QgUmVuZGVyTGF5ZXIqIGxheWVyKSBjCiAgICAgICAgICAgICAgfHwgY2xpcHNDb21w b3NpdGluZ0Rlc2NlbmRhbnRzKGxheWVyKQogICAgICAgICAgICAgIHx8IHJlcXVpcmVzQ29tcG9z aXRpbmdGb3JBbmltYXRpb24ocmVuZGVyZXIpCiAgICAgICAgICAgICAgfHwgcmVxdWlyZXNDb21w b3NpdGluZ0ZvckZ1bGxTY3JlZW4ocmVuZGVyZXIpCisgICAgICAgICAgICAgfHwgcmVxdWlyZXND b21wb3NpdGluZ0ZvckZpbHRlcnMocmVuZGVyZXIpCiAgICAgICAgICAgICAgfHwgcmVxdWlyZXND b21wb3NpdGluZ0ZvclBvc2l0aW9uKHJlbmRlcmVyLCBsYXllcik7CiB9CiAKQEAgLTE1MDgsNiAr MTUwOSwxOSBAQCBib29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6cmVxdWlyZXNDb21wb3NpdGlu Z0ZvckZ1bGxTY3JlZW4oUmVuZGVyT2JqZWN0KiByZW5kZQogI2VuZGlmCiB9CiAKK2Jvb2wgUmVu ZGVyTGF5ZXJDb21wb3NpdG9yOjpyZXF1aXJlc0NvbXBvc2l0aW5nRm9yRmlsdGVycyhSZW5kZXJP YmplY3QqIHJlbmRlcmVyKSBjb25zdAoreworI2lmIEVOQUJMRShDU1NfRklMVEVSUykKKyAgICBp ZiAoIShtX2NvbXBvc2l0aW5nVHJpZ2dlcnMgJiBDaHJvbWVDbGllbnQ6OkZpbHRlclRyaWdnZXIp KQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICByZXR1cm4gcmVuZGVyZXItPmhhc0ZpbHRl cigpOworI2Vsc2UKKyAgICBVTlVTRURfUEFSQU0ocmVuZGVyZXIpOworICAgIHJldHVybiBmYWxz ZTsKKyNlbmRpZgorfQorCiBib29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6cmVxdWlyZXNDb21w b3NpdGluZ0ZvclBvc2l0aW9uKFJlbmRlck9iamVjdCogcmVuZGVyZXIsIGNvbnN0IFJlbmRlckxh eWVyKiBsYXllcikgY29uc3QKIHsKICAgICAvLyBwb3NpdGlvbjpmaXhlZCBlbGVtZW50cyB0aGF0 IGNyZWF0ZSB0aGVpciBvd24gc3RhY2tpbmcgY29udGV4dCAoZS5nLiBoYXZlIGFuIGV4cGxpY2l0 IHotaW5kZXgsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJDb21wb3NpdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21w b3NpdG9yLmgKaW5kZXggYWNjNWMzOC4uMWMxOWQwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaApAQCAtMjgxLDYgKzI4MSw3IEBAIHBy aXZhdGU6CiAgICAgYm9vbCByZXF1aXJlc0NvbXBvc2l0aW5nRm9yRnJhbWUoUmVuZGVyT2JqZWN0 KikgY29uc3Q7CiAgICAgYm9vbCByZXF1aXJlc0NvbXBvc2l0aW5nV2hlbkRlc2NlbmRhbnRzQXJl Q29tcG9zaXRpbmcoUmVuZGVyT2JqZWN0KikgY29uc3Q7CiAgICAgYm9vbCByZXF1aXJlc0NvbXBv c2l0aW5nRm9yRnVsbFNjcmVlbihSZW5kZXJPYmplY3QqKSBjb25zdDsKKyAgICBib29sIHJlcXVp cmVzQ29tcG9zaXRpbmdGb3JGaWx0ZXJzKFJlbmRlck9iamVjdCopIGNvbnN0OwogICAgIGJvb2wg cmVxdWlyZXNDb21wb3NpdGluZ0ZvclNjcm9sbGFibGVGcmFtZSgpIGNvbnN0OwogICAgIGJvb2wg cmVxdWlyZXNDb21wb3NpdGluZ0ZvclBvc2l0aW9uKFJlbmRlck9iamVjdCosIGNvbnN0IFJlbmRl ckxheWVyKikgY29uc3Q7CiAK