75629 2012-01-05 09:15:00 -0800 NRWT fails to open results.html for Apple's Windows port 2012-01-05 11:56:16 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 38756 1 aroben webkit-unassigned abarth dpranke eric ojan webkit-bug-importer oldest_to_newest 530338 0 aroben 2012-01-05 09:15:00 -0800 When NRWT tries to open results.html on Apple's Windows port, all that happens is this error message gets printed: Failed to open file:///home/Adam%20Roben/dev/Build_WebKit/Debug/bin/layout-test-results/results.html 530339 1 aroben 2012-01-05 09:15:46 -0800 Looks like the default implementation: return self.host.user.open_url(self._filesystem.file_path_as_url(results_filename)) …doesn't work in Cygwin. 530340 2 webkit-bug-importer 2012-01-05 09:16:00 -0800 <rdar://problem/10648621> 530341 3 aroben 2012-01-05 09:16:24 -0800 Ah, that's because User.open_url uses the webbrowser module, which doesn't work in Cygwin. 530377 4 eric 2012-01-05 10:11:45 -0800 We'll probably have to make User smarter at some point. This is not the only trouble we've had with this. See bug 75438 for the most recent fix to this code. 530411 5 aroben 2012-01-05 10:38:20 -0800 (In reply to comment #4) > We'll probably have to make User smarter at some point. This is not the only trouble we've had with this. See bug 75438 for the most recent fix to this code. A simple fix for User on Cygwin would be to use something like executive.run_command(['cygstart', url]). But in this specific case we probably want to use run-safari instead. 530413 6 eric 2012-01-05 10:39:28 -0800 I thought the ApplePort already overrode this method to use run-safari? Maybe I'm remembering wrong. 530416 7 aroben 2012-01-05 10:40:44 -0800 (In reply to comment #6) > I thought the ApplePort already overrode this method to use run-safari? Maybe I'm remembering wrong. MacPort does that. We should move that logic up to ApplePort. We'll still need to override it on Windows so we can pass the path through cygpath first. 530417 8 eric 2012-01-05 10:41:10 -0800 I see. Looks like the mac port does: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py#L160 But the Apple base class does not: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/apple.py That's probably right, since we have to pass specific args to run-safari for Mac. Sounds like Win should just ovveride like Mac does. 530480 9 121305 aroben 2012-01-05 11:36:55 -0800 Created attachment 121305 Teach NRWT to use run-safari to open results.html on Apple's Windows port 530486 10 121305 eric 2012-01-05 11:39:40 -0800 Comment on attachment 121305 Teach NRWT to use run-safari to open results.html on Apple's Windows port LGTM. 530498 11 aroben 2012-01-05 11:56:16 -0800 Committed r104191: <http://trac.webkit.org/changeset/104191> 121305 2012-01-05 11:36:55 -0800 2012-01-05 11:39:39 -0800 Teach NRWT to use run-safari to open results.html on Apple's Windows port bug-75629-20120105113653.patch text/plain 3837 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0MTU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGMxMjNkMWIwNTNhNzgxZmZlZThkYzc5NmZiZDdhZTNj ZGQ3YjYzMS4uMmY1MjM1NjYwMTUzZWZlZWJlYjM4NzNkMDAwMDdlNzA0N2U4NTNkYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1 IEBACiAyMDEyLTAxLTA1ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAorICAgICAg ICBUZWFjaCBOUldUIHRvIHVzZSBydW4tc2FmYXJpIHRvIG9wZW4gcmVzdWx0cy5odG1sIG9uIEFw cGxlJ3MgV2luZG93cyBwb3J0CisKKyAgICAgICAgTlJXVCB3YXMgdHJ5aW5nIHRvIHVzZSBVc2Vy Lm9wZW5fdXJsLCB3aGljaCBkb2Vzbid0IHdvcmsgb24gQ3lnd2luLiBCdXQgcnVuLXNhZmFyaSBp cworICAgICAgICBiZXR0ZXIsIHNpbmNlIHdlIGFsd2F5cyB3YW50IHRvIG9wZW4gcmVzdWx0cy5o dG1sIHVzaW5nIHRoZSB1c2VyJ3MgYnVpbGQgb2YgV2ViS2l0LCBub3QKKyAgICAgICAgd2hhdGV2 ZXIgdGhlaXIgZGVmYXVsdCBicm93c2VyIGlzLgorCisgICAgICAgIEZpeGVzIDxodHRwOi8vd2Vi a2l0Lm9yZy9iLzc1NjI5PiA8cmRhcjovL3Byb2JsZW0vMTA2NDg2MjE+IE5SV1QgZmFpbHMgdG8g b3BlbiByZXN1bHRzLmh0bWwKKyAgICAgICAgZm9yIEFwcGxlJ3MgV2luZG93cyBwb3J0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dpbi5weToKKyAgICAgICAgKFdpblBvcnQuc2hvd19y ZXN1bHRzX2h0bWxfZmlsZSk6IENoYW5nZWQgdG8gdXNlIHJ1bl9zYWZhcmksIGxpa2UgTWFjUG9y dCBkb2VzLiBBbHNvIHJlbW92ZWQKKyAgICAgICAgYW4gb2Jzb2xldGUgY29tbWVudC4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2luX3VuaXR0ZXN0LnB5 OgorICAgICAgICAoV2luUG9ydFRlc3QudGVzdF9zaG93X3Jlc3VsdHNfaHRtbF9maWxlKTogVXBk YXRlZCBleHBlY3RlZCByZXN1bHRzLgorCisyMDEyLTAxLTA1ICBBZGFtIFJvYmVuICA8YXJvYmVu QGFwcGxlLmNvbT4KKwogICAgICAgICBQcmVwZW5kIFNhZmFyaS5leGUncyBwYXRoIHRvIHRoZSBj b21tYW5kLWxpbmUgcGFzc2VkIHRvIENyZWF0ZVByb2Nlc3MKIAogICAgICAgICBTYWZhcmkgZXhw ZWN0cyB0aGUgZmlyc3QgYXJndW1lbnQgaW4gdGhlIGNvbW1hbmQtbGluZSB0byBiZSB0aGUgcGF0 aCB0byBTYWZhcmkuZXhlIGl0c2VsZi4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2luLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC93aW4ucHkKaW5kZXggY2E2NGU5NjI1ODQ1NjViZjE5NmYxNWFlNTUyMDMx ZDdjZGRkMjVhZS4uNWQ4ZTQwYjE5ZWFlYmRmZjliYTQzZGI0YmQxOTI5MjE1YmM0YzdiYiAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93aW4ucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93aW4ucHkKQEAg LTMxLDYgKzMxLDcgQEAgaW1wb3J0IHJlCiBpbXBvcnQgc3lzCiAKIGZyb20gd2Via2l0cHkuY29t bW9uLnN5c3RlbS5leGVjdXRpdmUgaW1wb3J0IFNjcmlwdEVycm9yCitmcm9tIHdlYmtpdHB5LmNv bW1vbi5zeXN0ZW0ucGF0aCBpbXBvcnQgY3lncGF0aAogZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVz dHMucG9ydC5hcHBsZSBpbXBvcnQgQXBwbGVQb3J0CiAKIApAQCAtMTA3LDkgKzEwOCw4IEBAIGNs YXNzIFdpblBvcnQoQXBwbGVQb3J0KToKICAgICBkZWYgb3BlcmF0aW5nX3N5c3RlbShzZWxmKToK ICAgICAgICAgcmV0dXJuICd3aW4nCiAKLSAgICAjIFRoaXMgcG9ydCBtYXkgbmVlZCB0byBvdmVy cmlkZSBzZXR1cF9lbnZpcm9uX2Zvcl9zZXJ2ZXIKLSAgICAjIHRvIG1hdGNoIGJlaGF2aW9yIG9m IHNldFBhdGhGb3JSdW5uaW5nV2ViS2l0QXBwIGZyb20gT1JXVC4KLSAgICAjICRlbnYtPntQQVRI fSA9IGpvaW4oJzonLCBwcm9kdWN0RGlyKCksIGRpcm5hbWUoaW5zdGFsbGVkU2FmYXJpUGF0aCgp KSwgYXBwbGVBcHBsaWNhdGlvblN1cHBvcnRQYXRoKCksICRlbnYtPntQQVRIfSB8fCAiIik7Cisg ICAgZGVmIHNob3dfcmVzdWx0c19odG1sX2ZpbGUoc2VsZiwgcmVzdWx0c19maWxlbmFtZSk6Cisg ICAgICAgIHNlbGYuX3J1bl9zY3JpcHQoJ3J1bi1zYWZhcmknLCBbY3lncGF0aChyZXN1bHRzX2Zp bGVuYW1lKV0pCiAKICAgICAjIEZJWE1FOiB3ZWJraXRwZXJsL2h0dHBkLnBtIGluc3RhbGxzIC91 c3IvbGliL2FwYWNoZS9saWJwaHA0LmRsbCBvbiBjeWN3aW4gYXV0b21hdGljYWxseQogICAgICMg YXMgcGFydCBvZiBydW5uaW5nIG9sZC1ydW4td2Via2l0LXRlc3RzLiAgVGhhdCdzIGJhZCBkZXNp Z24sIGJ1dCB3ZSBtYXkgbmVlZCBzb21lIHNpbWlsYXIgaGFjay4KZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2luX3VuaXR0ZXN0LnB5IGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93aW5fdW5pdHRlc3QucHkKaW5k ZXggOGFjY2EzYmRmNGM1OTcxNmY5M2JmZDVmYjI4ODQ3OWZmYTZmZjhlYS4uOTcyNDE1OTk4ZjQ3 YjVlNjkzOWJjZGViYTZmMTRmYjg0NjdjNjlkMyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93aW5fdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93aW5fdW5pdHRlc3QucHkKQEAgLTQ2LDgg KzQ2LDE0IEBAIGNsYXNzIFdpblBvcnRUZXN0KHBvcnRfdGVzdGNhc2UuUG9ydFRlc3RDYXNlKToK ICAgICBkZWYgdGVzdF9zaG93X3Jlc3VsdHNfaHRtbF9maWxlKHNlbGYpOgogICAgICAgICBwb3J0 ID0gc2VsZi5tYWtlX3BvcnQoKQogICAgICAgICBwb3J0Ll9leGVjdXRpdmUgPSBNb2NrRXhlY3V0 aXZlKHNob3VsZF9sb2c9VHJ1ZSkKLSAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0gIk1PQ0s6IHVz ZXIub3Blbl91cmw6IGZpbGU6Ly8uLi5cbiIKLSAgICAgICAgT3V0cHV0Q2FwdHVyZSgpLmFzc2Vy dF9vdXRwdXRzKHNlbGYsIHBvcnQuc2hvd19yZXN1bHRzX2h0bWxfZmlsZSwgWyJ0ZXN0Lmh0bWwi XSwgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKKyAgICAgICAgY2FwdHVyZSA9IE91 dHB1dENhcHR1cmUoKQorICAgICAgICBjYXB0dXJlLmNhcHR1cmVfb3V0cHV0KCkKKyAgICAgICAg cG9ydC5zaG93X3Jlc3VsdHNfaHRtbF9maWxlKCd0ZXN0Lmh0bWwnKQorICAgICAgICBfLCBzdGRl cnIsIF8gPSBjYXB0dXJlLnJlc3RvcmVfb3V0cHV0KCkKKyAgICAgICAgIyBXZSBjYW4ndCBrbm93 IGZvciBzdXJlIHdoYXQgcGF0aCB3aWxsIGJlIHByb2R1Y2VkIGJ5IGN5Z3BhdGgsIGJ1dCB3ZSBj YW4gYXNzZXJ0IGFib3V0CisgICAgICAgICMgZXZlcnl0aGluZyBlbHNlLgorICAgICAgICBzZWxm LmFzc2VydFRydWUoc3RkZXJyLnN0YXJ0c3dpdGgoIk1PQ0sgcnVuX2NvbW1hbmQ6IFsnVG9vbHMv U2NyaXB0cy9ydW4tc2FmYXJpJywgJy0tcmVsZWFzZScsICciKSkKKyAgICAgICAgc2VsZi5hc3Nl cnRUcnVlKHN0ZGVyci5lbmRzd2l0aCgidGVzdC5odG1sJ10sIGN3ZD0vbW9jay1jaGVja291dFxu IikpCiAKICAgICBkZWYgdGVzdF9kZXRlY3RfdmVyc2lvbihzZWxmKToKICAgICAgICAgcG9ydCA9 IHNlbGYubWFrZV9wb3J0KCkK