75457 2012-01-02 18:48:38 -0800 [WK2] Share cairo specific codes with EFL port. 2012-01-11 17:29:48 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61838 1 ryuan.choi ryuan.choi bfulgham mrobinson webkit.review.bot oldest_to_newest 528629 0 ryuan.choi 2012-01-02 18:48:38 -0800 Change PLATFORM(GTK) to USE(CAIRO) in WebGraphicsContext{h,cpp} to share with EFL port. 528651 1 120908 ryuan.choi 2012-01-02 20:16:10 -0800 Created attachment 120908 Patch 534392 2 ryuan.choi 2012-01-11 16:32:41 -0800 Add bfulgham to CCs to know whether this patch is valid for the WinCairo port. Should I add `&& !PLATFORM(WIN_CAIRO)` ? 534406 3 120908 bfulgham 2012-01-11 16:42:21 -0800 Comment on attachment 120908 Patch These changes are all perfect for WinCairo. No need to add the PLATFORM(WIN_CAIRO) stuff here, as these are all applicable to the port. 534407 4 120908 bfulgham 2012-01-11 16:43:10 -0800 Comment on attachment 120908 Patch In fact, this change looks great as it is. Please apply it. 534410 5 120908 ryuan.choi 2012-01-11 16:48:49 -0800 Comment on attachment 120908 Patch Thank you for the review. 534445 6 120908 webkit.review.bot 2012-01-11 17:29:44 -0800 Comment on attachment 120908 Patch Clearing flags on attachment: 120908 Committed r104776: <http://trac.webkit.org/changeset/104776> 534446 7 webkit.review.bot 2012-01-11 17:29:48 -0800 All reviewed patches have been landed. Closing bug. 120908 2012-01-02 20:16:10 -0800 2012-01-11 17:29:43 -0800 Patch bug-75457-20120103131609.patch text/plain 2501 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzOTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2IxNzQzYWNhNjJhNWQ0 ZjI1MjI0ODFiYTdkZTY3NzUzOTZkODk1MS4uMmJjNzdkNTA2N2UxZjA4MTE3MmZkMTQ1MzYyMWUy MjkwNDUwMmQxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAxLTAyICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXSBTaGFyZSBj YWlybyBzcGVjaWZpYyBjb2RlcyB3aXRoIEVGTCBwb3J0LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU0NTcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2UgUExBVEZPUk0oR1RLKSB0byBVU0UoQ0FJ Uk8pIGluIFdlYkdyYXBoaWNzQ29udGV4dHtoLGNwcH0gdG8gc2hhcmUKKyAgICAgICAgd2l0aCBF RkwgcG9ydC4KKworICAgICAgICAqIFNoYXJlZC9XZWJHcmFwaGljc0NvbnRleHQuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJHcmFwaGljc0NvbnRleHQ6OldlYkdyYXBoaWNzQ29udGV4dCk6Cisg ICAgICAgICogU2hhcmVkL1dlYkdyYXBoaWNzQ29udGV4dC5oOgorCiAyMDEyLTAxLTAyICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggdGhlIFdpbmRvd3MgYnVp bGQgKGFnYWluKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJHcmFwaGlj c0NvbnRleHQuY3BwIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkdyYXBoaWNzQ29udGV4dC5j cHAKaW5kZXggNzIyMjBiMzE5MDQ1MTM3NzVhNmQyMjc0ZTcxNzBkYmI4OTIyMmRiZC4uMDFkZmNm ZGRmNDc3NzIxMGMwNWUzY2JkYjhlOGI5MzNjNmYwMDJiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvU2hhcmVkL1dlYkdyYXBoaWNzQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv U2hhcmVkL1dlYkdyYXBoaWNzQ29udGV4dC5jcHAKQEAgLTI2LDkgKzI2LDkgQEAKICNpbmNsdWRl ICJjb25maWcuaCIKICNpbmNsdWRlICJXZWJHcmFwaGljc0NvbnRleHQuaCIKIAotI2lmIFBMQVRG T1JNKEdUSykgCi0jaW5jbHVkZSA8V2ViQ29yZS9QbGF0Zm9ybUNvbnRleHRDYWlyby5oPiAKLSNl bmRpZiAKKyNpZiBVU0UoQ0FJUk8pCisjaW5jbHVkZSA8V2ViQ29yZS9QbGF0Zm9ybUNvbnRleHRD YWlyby5oPgorI2VuZGlmCiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCkBAIC0zNyw3ICsz Nyw3IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogV2ViR3JhcGhpY3NDb250ZXh0OjpXZWJHcmFwaGlj c0NvbnRleHQoR3JhcGhpY3NDb250ZXh0KiBncmFwaGljc0NvbnRleHQpCiAjaWYgVVNFKENHKQog ICAgIDogbV9wbGF0Zm9ybUNvbnRleHQoZ3JhcGhpY3NDb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQo KSkKLSNlbGlmIFBMQVRGT1JNKEdUSykKKyNlbGlmIFVTRShDQUlSTykKICAgICA6IG1fcGxhdGZv cm1Db250ZXh0KGdyYXBoaWNzQ29udGV4dC0+cGxhdGZvcm1Db250ZXh0KCktPmNyKCkpCiAjZW5k aWYKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJHcmFwaGljc0NvbnRl eHQuaCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJHcmFwaGljc0NvbnRleHQuaAppbmRleCA1 ZjcyYWFlMDNlZGJkMDFhNGY3MWYzOThjNDQ1YTJkYmEwZjhkYWExLi5lMDQ4YWI0MzY1NjMwNTg5 MWY4YzMxZWE5MGVhMzRjYWM5YTA2NjUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFy ZWQvV2ViR3JhcGhpY3NDb250ZXh0LmgKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkdy YXBoaWNzQ29udGV4dC5oCkBAIC0zMiw3ICszMiw3IEBACiAKICNpZiBVU0UoQ0cpCiAjaW5jbHVk ZSA8d3RmL1JldGFpblB0ci5oPgotI2VsaWYgUExBVEZPUk0oR1RLKQorI2VsaWYgVVNFKENBSVJP KQogI2luY2x1ZGUgIlJlZlB0ckNhaXJvLmgiCiAjZW5kaWYKIApAQCAtNDksNyArNDksNyBAQCBw dWJsaWM6CiAKICNpZiBVU0UoQ0cpCiAgICAgQ0dDb250ZXh0UmVmIHBsYXRmb3JtQ29udGV4dCgp IHsgcmV0dXJuIG1fcGxhdGZvcm1Db250ZXh0LmdldCgpOyB9Ci0jZWxpZiBQTEFURk9STShHVEsp CisjZWxpZiBVU0UoQ0FJUk8pCiAgICAgY2Fpcm9fdCogcGxhdGZvcm1Db250ZXh0KCkgeyByZXR1 cm4gbV9wbGF0Zm9ybUNvbnRleHQuZ2V0KCk7IH0KICNlbmRpZgogCkBAIC02MSw3ICs2MSw3IEBA IHByaXZhdGU6CiAKICNpZiBVU0UoQ0cpCiAgICAgUmV0YWluUHRyPENHQ29udGV4dFJlZj4gbV9w bGF0Zm9ybUNvbnRleHQ7Ci0jZWxpZiBQTEFURk9STShHVEspCisjZWxpZiBVU0UoQ0FJUk8pCiAg ICAgUmVmUHRyPGNhaXJvX3Q+IG1fcGxhdGZvcm1Db250ZXh0OwogI2VuZGlmCiB9Owo=