75438 2012-01-02 08:48:18 -0800 When showing results.html pass a correct URL to webbrowser.open 2012-01-04 13:10:47 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen abarth dpranke eric ojan webkit.review.bot oldest_to_newest 528531 0 jochen 2012-01-02 08:48:18 -0800 When showing results.html pass a correct URL to webbrowser.open 528532 1 120882 jochen 2012-01-02 08:48:57 -0800 Created attachment 120882 Patch 528533 2 jochen 2012-01-02 08:50:26 -0800 Eric, can you please review? Without this patch, I get the following error on my Lion box: 2012-01-02 17:08:14.094 osascript[95311:f07] CFURLCreateWithString was passed this invalid URL string: '/Volumes/Data/WebKit/Source/WebKit/chromium/webkit/Debug/layout-test-results/results.html' (a file system path instead of an URL string). The URL created will not work with most file URL functions. CFURLCreateWithFileSystemPath or CFURLCreateWithFileSystemPathRelativeToBase should be used instead. 528546 3 120882 eric 2012-01-02 09:53:29 -0800 Comment on attachment 120882 Patch It would be better to add this in a mockable fashion. like adding a file_url_for_path to FileSystem or just making open_url do this automatically? I'm surprised this only affects chromium? 528547 4 eric 2012-01-02 09:54:25 -0800 I believe I've run the tests on Lion before and had it open the results correctly. So I'm surprised that this is a new issue? 528554 5 abarth 2012-01-02 10:45:33 -0800 I've had the same problem. It seems to affect the Chromium port, not the Apple port. 528555 6 120882 abarth 2012-01-02 10:46:00 -0800 Comment on attachment 120882 Patch Test? 528556 7 jochen 2012-01-02 10:52:26 -0800 Some ports override the show_results_html method. I was a bit hesitant to add this to open_url, because there might be other call sites that pass in correct URLs. I'd then first have to try to guess whether it's a filesystem path or already a valid URL. Adding file_path_as_url to FileSystem sounds like a good idea. I'll do that and write a test for it. 528736 8 120936 jochen 2012-01-03 05:21:21 -0800 Created attachment 120936 Patch 528920 9 120936 abarth 2012-01-03 11:46:38 -0800 Comment on attachment 120936 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120936&action=review > Tools/Scripts/webkitpy/common/system/filesystem_unittest.py:66 > + self.assertEqual(fs.file_path_as_url('/foo'), > + 'file:///foo') Is this going to pass on Windows? 528933 10 jochen 2012-01-03 11:57:07 -0800 (In reply to comment #9) > (From update of attachment 120936 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120936&action=review > > > Tools/Scripts/webkitpy/common/system/filesystem_unittest.py:66 > > + self.assertEqual(fs.file_path_as_url('/foo'), > > + 'file:///foo') > > Is this going to pass on Windows? I don't know. I don't have a windows checkout of webkit handy to try and no bots execute those tests :-/ 528936 11 eric 2012-01-03 11:58:01 -0800 (In reply to comment #10) > (In reply to comment #9) > > (From update of attachment 120936 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=120936&action=review > > > > > Tools/Scripts/webkitpy/common/system/filesystem_unittest.py:66 > > > + self.assertEqual(fs.file_path_as_url('/foo'), > > > + 'file:///foo') > > > > Is this going to pass on Windows? > > I don't know. I don't have a windows checkout of webkit handy to try and no bots execute those tests :-/ All the bots execute tehse tests. :) I don't think the EWS bots do today... but they used to. 528951 12 jochen 2012-01-03 12:14:05 -0800 (In reply to comment #11) > (In reply to comment #10) > > (In reply to comment #9) > > > (From update of attachment 120936 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=120936&action=review > > > > > > > Tools/Scripts/webkitpy/common/system/filesystem_unittest.py:66 > > > > + self.assertEqual(fs.file_path_as_url('/foo'), > > > > + 'file:///foo') > > > > > > Is this going to pass on Windows? > > > > I don't know. I don't have a windows checkout of webkit handy to try and no bots execute those tests :-/ > > All the bots execute tehse tests. :) I don't think the EWS bots do today... but they used to. ah, ok, I was mistaken, just the slow scm tests aren't executed. I'll watch the buildbots for the result then 529133 13 120936 webkit.review.bot 2012-01-03 16:18:44 -0800 Comment on attachment 120936 Patch Clearing flags on attachment: 120936 Committed r103984: <http://trac.webkit.org/changeset/103984> 529134 14 webkit.review.bot 2012-01-03 16:18:49 -0800 All reviewed patches have been landed. Closing bug. 529689 15 dpranke 2012-01-04 13:08:31 -0800 Hm. We already had a path module in webkitpy.common.system that provided an abspath_to_uri() method that did the same thing. It's not clear to me that this should really live on filesystem instead (although at least that would give you predictable behavior using a mock filesystem on windows) but we probably shouldn't have both. 529691 16 jochen 2012-01-04 13:10:47 -0800 (In reply to comment #15) > Hm. We already had a path module in webkitpy.common.system that provided an abspath_to_uri() method that did the same thing. It's not clear to me that this should really live on filesystem instead (although at least that would give you predictable behavior using a mock filesystem on windows) but we probably shouldn't have both. Oh, I didn't see that I'll try to come up with a way to unify this 120882 2012-01-02 08:48:57 -0800 2012-01-03 05:21:13 -0800 Patch bug-75438-20120102174854.patch text/plain 1640 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzOTA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjRkYWMzNTM5YTM5YzQ2NGExOWQ1ZWEwYmE2NTlkZmZm OTI5N2U4YS4uZTJlZDRlZDkyZDY1Y2VkMTRhZTA2MjQwMzA4NWYyMWJkYWNhZTYwNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEyLTAxLTAyICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFdoZW4gc2hvd2luZyByZXN1bHRzLmh0bWwgcGFzcyBhIGNvcnJlY3QgVVJMIHRv IHdlYmJyb3dzZXIub3BlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzU0MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weToKKyAg ICAgICAgKHNob3dfcmVzdWx0c19odG1sX2ZpbGUpOgorCiAyMDEyLTAxLTAyICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGQgYSB3 YXkgdG8gY2hhbmdlIHdlYiB2aWV3IHNldHRpbmdzIGluIE1pbmlCcm93c2VyCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkKaW5kZXggMWVmMmMz MTAzZjAzY2ExN2RhYmRmZTgzOGVmOTM0ZTMzYjVhZjFkZi4uZjkwNWZjMTM1MjA4YmNiNGZhOGMz YzM0YmYyZDliNjQ0Y2ViM2Y4YSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvYmFzZS5weQpAQCAtMzcsNiArMzcsNyBAQCBpbXBvcnQgZGlmZmxpYgog aW1wb3J0IGVycm5vCiBpbXBvcnQgb3MKIGltcG9ydCByZQorZnJvbSB1cmxsaWIgaW1wb3J0IHBh dGhuYW1lMnVybAogCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5tZW1vaXplZCBpbXBvcnQgbWVtb2l6 ZWQKIApAQCAtNzUxLDcgKzc1Miw3IEBAIGNsYXNzIFBvcnQob2JqZWN0KToKICAgICBkZWYgc2hv d19yZXN1bHRzX2h0bWxfZmlsZShzZWxmLCByZXN1bHRzX2ZpbGVuYW1lKToKICAgICAgICAgIiIi VGhpcyByb3V0aW5lIHNob3VsZCBkaXNwbGF5IHRoZSBIVE1MIGZpbGUgcG9pbnRlZCBhdCBieQog ICAgICAgICByZXN1bHRzX2ZpbGVuYW1lIGluIGEgdXNlcnMnIGJyb3dzZXIuIiIiCi0gICAgICAg IHJldHVybiBzZWxmLmhvc3QudXNlci5vcGVuX3VybChyZXN1bHRzX2ZpbGVuYW1lKQorICAgICAg ICByZXR1cm4gc2VsZi5ob3N0LnVzZXIub3Blbl91cmwoJ2ZpbGU6JyArIHBhdGhuYW1lMnVybChy ZXN1bHRzX2ZpbGVuYW1lKSkKIAogICAgIGRlZiBjcmVhdGVfZHJpdmVyKHNlbGYsIHdvcmtlcl9u dW1iZXIpOgogICAgICAgICAiIiJSZXR1cm4gYSBuZXdseSBjcmVhdGVkIERyaXZlciBzdWJjbGFz cyBmb3Igc3RhcnRpbmcvc3RvcHBpbmcgdGhlIHRlc3QgZHJpdmVyLiIiIgo= 120936 2012-01-03 05:21:21 -0800 2012-01-03 16:18:44 -0800 Patch bug-75438-20120103142118.patch text/plain 7883 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzOTA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjRkYWMzNTM5YTM5YzQ2NGExOWQ1ZWEwYmE2NTlkZmZm OTI5N2U4YS4uY2ZhOGJjMmQzNTJhODVhMzljNTc4NTAxMWJjZWI4ZjJlNThhN2YyYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDEyLTAxLTAzICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFdoZW4gc2hvd2luZyByZXN1bHRzLmh0bWwgcGFzcyBhIGNvcnJlY3QgVVJMIHRv IHdlYmJyb3dzZXIub3BlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzU0MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9maWxlc3lzdGVtLnB5Ogor ICAgICAgICAoZmlsZV9wYXRoX2FzX3VybCk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9j b21tb24vc3lzdGVtL2ZpbGVzeXN0ZW1fbW9jay5weToKKyAgICAgICAgKGZpbGVfcGF0aF9hc191 cmwpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9maWxlc3lzdGVt X3VuaXR0ZXN0LnB5OgorICAgICAgICAodGVzdF9maWxlX3BhdGhfYXNfdXJsKToKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHk6CisgICAgICAgIChz aG93X3Jlc3VsdHNfaHRtbF9maWxlKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L3dpbl91bml0dGVzdC5weToKKyAgICAgICAgKHRlc3Rfc2hvd19yZXN1bHRz X2h0bWxfZmlsZSk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVu X3dlYmtpdF90ZXN0c19pbnRlZ3JhdGlvbnRlc3QucHk6CisgICAgICAgICh0ZXN0X3Jlc3VsdHNf ZGlyZWN0b3J5X3JlbGF0aXZlKToKKwogMjAxMi0wMS0wMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg IDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIGEgd2F5IHRvIGNoYW5n ZSB3ZWIgdmlldyBzZXR0aW5ncyBpbiBNaW5pQnJvd3NlcgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2ZpbGVzeXN0ZW0ucHkgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZmlsZXN5c3RlbS5weQppbmRleCA3ZGU0MWE0MjRkMWJi Y2Y5NTFiZWNhMmZlOGU0YTU0OTQyMWE2ZDgyLi43NzMyNGQ3ZGYwMmJmODgyNzkzMDMyZjQ5MWNm MzYwY2ViZTc0M2IwIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9z eXN0ZW0vZmlsZXN5c3RlbS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9z eXN0ZW0vZmlsZXN5c3RlbS5weQpAQCAtNDAsNiArNDAsNyBAQCBpbXBvcnQgc2h1dGlsCiBpbXBv cnQgc3lzCiBpbXBvcnQgdGVtcGZpbGUKIGltcG9ydCB0aW1lCitmcm9tIHVybGxpYiBpbXBvcnQg cGF0aG5hbWUydXJsCiAKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbSBpbXBvcnQgb3NwYXRo CiAKQEAgLTgyLDYgKzgzLDkgQEAgY2xhc3MgRmlsZVN5c3RlbShvYmplY3QpOgogICAgIGRlZiBl eGlzdHMoc2VsZiwgcGF0aCk6CiAgICAgICAgIHJldHVybiBvcy5wYXRoLmV4aXN0cyhwYXRoKQog CisgICAgZGVmIGZpbGVfcGF0aF9hc191cmwoc2VsZiwgcGF0aCk6CisgICAgICAgIHJldHVybiAn ZmlsZTovLycgKyBwYXRobmFtZTJ1cmwocGF0aCkKKwogICAgIGRlZiBmaWxlc191bmRlcihzZWxm LCBwYXRoLCBkaXJzX3RvX3NraXA9W10sIGZpbGVfZmlsdGVyPU5vbmUpOgogICAgICAgICAiIiJS ZXR1cm4gdGhlIGxpc3Qgb2YgYWxsIGZpbGVzIHVuZGVyIHRoZSBnaXZlbiBwYXRoIGluIHRvcGRv d24gb3JkZXIuCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5 c3RlbS9maWxlc3lzdGVtX21vY2sucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9z eXN0ZW0vZmlsZXN5c3RlbV9tb2NrLnB5CmluZGV4IDMyZmQxMDcxYTcwMGM2N2MyODYyNTYyMzYz YTRmMDU2MDUyNDhiMzMuLjgwYWVlMGIzZDdiMDdmNTEzMzNhMWZmMTA5YWVhZDc0YWUwNDczNGQg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9maWxlc3lz dGVtX21vY2sucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2Zp bGVzeXN0ZW1fbW9jay5weQpAQCAtMzEsNiArMzEsNyBAQCBpbXBvcnQgZXJybm8KIGltcG9ydCBo YXNobGliCiBpbXBvcnQgb3MKIGltcG9ydCByZQorZnJvbSB1cmxsaWIgaW1wb3J0IHBhdGhuYW1l MnVybAogCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0gaW1wb3J0IHBhdGgKIGZyb20gd2Vi a2l0cHkuY29tbW9uLnN5c3RlbSBpbXBvcnQgb3NwYXRoCkBAIC0xMTcsNiArMTE4LDkgQEAgY2xh c3MgTW9ja0ZpbGVTeXN0ZW0ob2JqZWN0KToKICAgICBkZWYgZXhpc3RzKHNlbGYsIHBhdGgpOgog ICAgICAgICByZXR1cm4gc2VsZi5pc2ZpbGUocGF0aCkgb3Igc2VsZi5pc2RpcihwYXRoKQogCisg ICAgZGVmIGZpbGVfcGF0aF9hc191cmwoc2VsZiwgcGF0aCk6CisgICAgICAgIHJldHVybiAnZmls ZTovLycgKyBwYXRobmFtZTJ1cmwocGF0aCkKKwogICAgIGRlZiBmaWxlc191bmRlcihzZWxmLCBw YXRoLCBkaXJzX3RvX3NraXA9W10sIGZpbGVfZmlsdGVyPU5vbmUpOgogICAgICAgICBkZWYgZmls dGVyX2FsbChmcywgZGlycGF0aCwgYmFzZW5hbWUpOgogICAgICAgICAgICAgcmV0dXJuIFRydWUK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9maWxlc3lz dGVtX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2Zp bGVzeXN0ZW1fdW5pdHRlc3QucHkKaW5kZXggYzI0MzQ0Yzc2OTZhNDM2YzU4M2MxODdkYjNmY2Iz YjY0OGQ5MDExMC4uMThhZTZiY2QxOTNmMTg5ZWU5YmM3NDUxZmU5YzE2MjE1MzM2NTQ0OCAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2ZpbGVzeXN0ZW1f dW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2Zp bGVzeXN0ZW1fdW5pdHRlc3QucHkKQEAgLTYwLDYgKzYwLDExIEBAIGNsYXNzIEdlbmVyaWNGaWxl U3lzdGVtVGVzdHMob2JqZWN0KToKICAgICAgICAgc2VsZi5mcy5jaGRpcihzZWxmLm9yaWdfY3dk KQogICAgICAgICBzZWxmLmdlbmVyaWNfdGVzdF9kaXIgPSBOb25lCiAKKyAgICBkZWYgdGVzdF9m aWxlX3BhdGhfYXNfdXJsKHNlbGYpOgorICAgICAgICBmcyA9IEZpbGVTeXN0ZW0oKQorICAgICAg ICBzZWxmLmFzc2VydEVxdWFsKGZzLmZpbGVfcGF0aF9hc191cmwoJy9mb28nKSwKKyAgICAgICAg ICAgICAgICAgICAgICAgICAnZmlsZTovLy9mb28nKQorCiAgICAgZGVmIHRlc3RfZ2xvYl9fdHJh aWxpbmdfYXN0ZXJpc2soc2VsZik6CiAgICAgICAgIHNlbGYuZnMuY2hkaXIoc2VsZi5nZW5lcmlj X3Rlc3RfZGlyKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhzZXQoc2VsZi5mcy5nbG9iKCdm byonKSksIHNldChbJ2Zvby50eHQnLCAnZm9vYmFyJywgJ2Zvb2RpciddKSkKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weQppbmRleCAxZWYyYzMx MDNmMDNjYTE3ZGFiZGZlODM4ZWY5MzRlMzNiNWFmMWRmLi40YjFlNWE5NjQyYjBlMTM4NjBiMTc0 YjYxODFiYzNhMDdkMjdiZDcyIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L2Jhc2UucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9iYXNlLnB5CkBAIC03NTEsNyArNzUxLDcgQEAgY2xhc3MgUG9ydChvYmpl Y3QpOgogICAgIGRlZiBzaG93X3Jlc3VsdHNfaHRtbF9maWxlKHNlbGYsIHJlc3VsdHNfZmlsZW5h bWUpOgogICAgICAgICAiIiJUaGlzIHJvdXRpbmUgc2hvdWxkIGRpc3BsYXkgdGhlIEhUTUwgZmls ZSBwb2ludGVkIGF0IGJ5CiAgICAgICAgIHJlc3VsdHNfZmlsZW5hbWUgaW4gYSB1c2VycycgYnJv d3Nlci4iIiIKLSAgICAgICAgcmV0dXJuIHNlbGYuaG9zdC51c2VyLm9wZW5fdXJsKHJlc3VsdHNf ZmlsZW5hbWUpCisgICAgICAgIHJldHVybiBzZWxmLmhvc3QudXNlci5vcGVuX3VybChzZWxmLl9m aWxlc3lzdGVtLmZpbGVfcGF0aF9hc191cmwocmVzdWx0c19maWxlbmFtZSkpCiAKICAgICBkZWYg Y3JlYXRlX2RyaXZlcihzZWxmLCB3b3JrZXJfbnVtYmVyKToKICAgICAgICAgIiIiUmV0dXJuIGEg bmV3bHkgY3JlYXRlZCBEcml2ZXIgc3ViY2xhc3MgZm9yIHN0YXJ0aW5nL3N0b3BwaW5nIHRoZSB0 ZXN0IGRyaXZlci4iIiIKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvd2luX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC93aW5fdW5pdHRlc3QucHkKaW5kZXggMmRiZmNmNDZjMGUyZmJiM2U5ZjQ2 OTU0NGNiOWViOTc2NzU0YmYwOC4uY2U5ODNiOWIzYTNkMzIxM2FiYjNjOTEzOGYyMjdkNTc0YzQx Mjc1ZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC93aW5fdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC93aW5fdW5pdHRlc3QucHkKQEAgLTQ2LDcgKzQ2LDcgQEAgY2xhc3MgV2luUG9ydFRl c3QocG9ydF90ZXN0Y2FzZS5Qb3J0VGVzdENhc2UpOgogICAgIGRlZiB0ZXN0X3Nob3dfcmVzdWx0 c19odG1sX2ZpbGUoc2VsZik6CiAgICAgICAgIHBvcnQgPSBzZWxmLm1ha2VfcG9ydCgpCiAgICAg ICAgIHBvcnQuX2V4ZWN1dGl2ZSA9IE1vY2tFeGVjdXRpdmUoc2hvdWxkX2xvZz1UcnVlKQotICAg ICAgICBleHBlY3RlZF9zdGRlcnIgPSAiTU9DSzogdXNlci5vcGVuX3VybDogdGVzdC5odG1sXG4i CisgICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9ICJNT0NLOiB1c2VyLm9wZW5fdXJsOiBmaWxlOi8v Li4uXG4iCiAgICAgICAgIE91dHB1dENhcHR1cmUoKS5hc3NlcnRfb3V0cHV0cyhzZWxmLCBwb3J0 LnNob3dfcmVzdWx0c19odG1sX2ZpbGUsIFsidGVzdC5odG1sIl0sIGV4cGVjdGVkX3N0ZGVycj1l eHBlY3RlZF9zdGRlcnIpCiAKICAgICBkZWYgdGVzdF9kZXRlY3RfdmVyc2lvbihzZWxmKToKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRf dGVzdHNfaW50ZWdyYXRpb250ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcnVuX3dlYmtpdF90ZXN0c19pbnRlZ3JhdGlvbnRlc3QucHkKaW5kZXggNmNjMzk5NDg0 ZmFkNTdmMTAzOWQ1MjJiMGYyYmYwNGRlNDNjM2Q4OS4uNTlmMjFhZDY0MzQ2OGNiYTY1ODFkYzZh NTAwMmU2N2M5ODUwNjQ4OSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c19pbnRlZ3JhdGlvbnRlc3QucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c19pbnRlZ3JhdGlv bnRlc3QucHkKQEAgLTQzMSw3ICs0MzEsNyBAQCBjbGFzcyBNYWluVGVzdCh1bml0dGVzdC5UZXN0 Q2FzZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocmVzLCB1bmV4cGVjdGVkX3Rlc3RzX2Nv dW50KQogICAgICAgICBzZWxmLmFzc2VydEZhbHNlKG91dC5lbXB0eSgpKQogICAgICAgICBzZWxm LmFzc2VydEZhbHNlKGVyci5lbXB0eSgpKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHVzZXIu b3BlbmVkX3VybHMsIFsnL3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzL3Jlc3VsdHMuaHRtbCddKQor ICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHVzZXIub3BlbmVkX3VybHMsIFsnZmlsZTovLy90bXAv bGF5b3V0LXRlc3QtcmVzdWx0cy9yZXN1bHRzLmh0bWwnXSkKIAogICAgIGRlZiB0ZXN0X21pc3Np bmdfYW5kX3VuZXhwZWN0ZWRfcmVzdWx0cyhzZWxmKToKICAgICAgICAgIyBUZXN0IHRoYXQgd2Ug dXBkYXRlIGV4cGVjdGF0aW9ucyBpbiBwbGFjZS4gSWYgdGhlIGV4cGVjdGF0aW9uCkBAIC02MDQs NyArNjA0LDcgQEAgY2xhc3MgTWFpblRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICB3 aXRoIGhvc3QuZmlsZXN5c3RlbS5ta2R0ZW1wKCkgYXMgdG1wZGlyOgogICAgICAgICAgICAgcmVz LCBvdXQsIGVyciwgdXNlciA9IGxvZ2dpbmdfcnVuKFsnLS1yZXN1bHRzLWRpcmVjdG9yeT0nICsg c3RyKHRtcGRpcildLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHRlc3RzX2luY2x1ZGVkPVRydWUsIGhvc3Q9aG9zdCkKLSAgICAgICAgICAgIHNlbGYuYXNz ZXJ0RXF1YWwodXNlci5vcGVuZWRfdXJscywgW2hvc3QuZmlsZXN5c3RlbS5qb2luKHRtcGRpciwg J3Jlc3VsdHMuaHRtbCcpXSkKKyAgICAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwodXNlci5vcGVu ZWRfdXJscywgW2hvc3QuZmlsZXN5c3RlbS5maWxlX3BhdGhfYXNfdXJsKGhvc3QuZmlsZXN5c3Rl bS5qb2luKHRtcGRpciwgJ3Jlc3VsdHMuaHRtbCcpKV0pCiAKICAgICBkZWYgdGVzdF9yZXN1bHRz X2RpcmVjdG9yeV9kZWZhdWx0KHNlbGYpOgogICAgICAgICAjIFdlIHJ1biBhIGNvbmZpZ3VyYXRp b24gdGhhdCBzaG91bGQgZmFpbCwgdG8gZ2VuZXJhdGUgb3V0cHV0LCB0aGVuCkBAIC02MTIsNyAr NjEyLDcgQEAgY2xhc3MgTWFpblRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogCiAgICAgICAgICMg VGhpcyBpcyB0aGUgZGVmYXVsdCBsb2NhdGlvbi4KICAgICAgICAgcmVzLCBvdXQsIGVyciwgdXNl ciA9IGxvZ2dpbmdfcnVuKHRlc3RzX2luY2x1ZGVkPVRydWUpCi0gICAgICAgIHNlbGYuYXNzZXJ0 RXF1YWwodXNlci5vcGVuZWRfdXJscywgWycvdG1wL2xheW91dC10ZXN0LXJlc3VsdHMvcmVzdWx0 cy5odG1sJ10pCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwodXNlci5vcGVuZWRfdXJscywgWydm aWxlOi8vL3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzL3Jlc3VsdHMuaHRtbCddKQogCiAgICAgZGVm IHRlc3RfcmVzdWx0c19kaXJlY3RvcnlfcmVsYXRpdmUoc2VsZik6CiAgICAgICAgICMgV2UgcnVu IGEgY29uZmlndXJhdGlvbiB0aGF0IHNob3VsZCBmYWlsLCB0byBnZW5lcmF0ZSBvdXRwdXQsIHRo ZW4KQEAgLTYyMiw3ICs2MjIsNyBAQCBjbGFzcyBNYWluVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6 CiAgICAgICAgIGhvc3QuZmlsZXN5c3RlbS5jaGRpcignL3RtcC9jd2QnKQogICAgICAgICByZXMs IG91dCwgZXJyLCB1c2VyID0gbG9nZ2luZ19ydW4oWyctLXJlc3VsdHMtZGlyZWN0b3J5PWZvbydd LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdGVzdHNfaW5jbHVk ZWQ9VHJ1ZSwgaG9zdD1ob3N0KQotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHVzZXIub3BlbmVk X3VybHMsIFsnL3RtcC9jd2QvZm9vL3Jlc3VsdHMuaHRtbCddKQorICAgICAgICBzZWxmLmFzc2Vy dEVxdWFsKHVzZXIub3BlbmVkX3VybHMsIFsnZmlsZTovLy90bXAvY3dkL2Zvby9yZXN1bHRzLmh0 bWwnXSkKIAogICAgIGRlZiB0ZXN0X3JldHJpZXNfZGlyZWN0b3J5KHNlbGYpOgogICAgICAgICBo b3N0ID0gTW9ja0hvc3QoKQo=