75411 2011-12-31 16:47:16 -0800 Enable the [Supplemental] IDL on GTK/GObject 2012-01-02 17:25:12 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72138 1 haraken haraken abarth mrobinson webkit.review.bot xan.lopez oldest_to_newest 528312 0 haraken 2011-12-31 16:47:16 -0800 We have enabled the [Supplemental] IDL on Chromium, AppleWebKit, GTK, Qt, Efl and WinCE, and are planning to enable it on all platforms (Meta bug 72138). In this bug, we enable it on GTK/GObject. 528343 1 120843 haraken 2012-01-01 01:38:23 -0800 Created attachment 120843 WIP patch to see if build passes 528552 2 120843 abarth 2012-01-02 10:42:15 -0800 Comment on attachment 120843 WIP patch to see if build passes View in context: https://bugs.webkit.org/attachment.cgi?id=120843&action=review > Source/WebCore/bindings/gobject/GNUmakefile.am:467 > + $(AM_V_GEN)$(PERL) -I$(WebCore)/bindings/scripts $(WebCore)/bindings/scripts/generate-bindings.pl --include $(WebCore)/dom --include $(WebCore)/html --include $(WebCore)/css --include $(WebCore)/page --include $(WebCore)/xml --include $(WebCore)/svg --outputDir "$(GENSOURCES_WEBKIT)" --defines "LANGUAGE_GOBJECT=1 $(gdom_feature_defines)" --generator GObject --supplementalDependencyFile $(SUPPLEMENTAL_DEPENDENCY_FILE) $< I'm surprised that these includes aren't broken out into a variable, but I see that's how this script worked before. 528612 3 120843 webkit.review.bot 2012-01-02 17:25:07 -0800 Comment on attachment 120843 WIP patch to see if build passes Clearing flags on attachment: 120843 Committed r103920: <http://trac.webkit.org/changeset/103920> 528613 4 webkit.review.bot 2012-01-02 17:25:12 -0800 All reviewed patches have been landed. Closing bug. 120843 2012-01-01 01:38:23 -0800 2012-01-02 17:25:07 -0800 WIP patch to see if build passes bug-75411-20120101183821.patch text/plain 5386 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzODczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQ1OTRhNjAxY2ViODJi NzdjNjc0OWMxODAwZWUwZjZmMTlmNGQ1ZC4uMTNkZjBiZGFiYWQwOTE5ODIwODQ2Y2ZjOTFiOGQ3 OWM4MDQxZTVmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM5IEBACisyMDEyLTAxLTAxICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBFbmFibGUgdGhlIFtT dXBwbGVtZW50YWxdIElETCBvbiBHVEsvR09iamVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU0MTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGVuYWJsZXMgdGhlIFtTdXBwbGVtZW50 YWxdIElETCBvbiBHT2JqZWN0IGJpbmRpbmdzIG9mIEdUSworICAgICAgICBieSBjaGFuZ2luZyB0 aGUgYnVpbGQgZmxvdyBvZiBiaW5kaW5ncy9nb2JqZWN0L0dOVW1ha2VmaWxlLmFtIGFzIGZvbGxv d3MuCisKKyAgICAgICAgLSBQcmV2aW91cyBidWlsZCBmbG93OgorICAgICAgICAgICAgZm9yZWFj aCAkaWRsIChhbGwgSURMIGZpbGVzKSB7CisgICAgICAgICAgICAgICAgZ2VuZXJhdGUtYmluZGlu Z3MucGwgZGVwZW5kcyBvbiAkaWRsOworICAgICAgICAgICAgICAgIGdlbmVyYXRlLWJpbmRpbmdz LnBsIHJlYWRzICRpZGw7CisgICAgICAgICAgICAgICAgZ2VuZXJhdGUtYmluZGluZ3MucGwgZ2Vu ZXJhdGVzIC5oIGFuZCAuY3BwIGZpbGVzIGZvciAkaWRsOworICAgICAgICAgICAgfQorCisgICAg ICAgIC0gTmV3IGJ1aWxkIGZsb3cgKFNlZSB0aGUgZGlzY3Vzc2lvbnMgaW4gYnVnIDcyMTM4IGZv ciBtb3JlIGRldGFpbHMpOgorICAgICAgICAgICAgcmVzb2x2ZS1zdXBwbGVtZW50YWwucGwgZGVw ZW5kcyBvbiBhbGwgSURMIGZpbGVzOworICAgICAgICAgICAgcmVzb2x2ZS1zdXBwbGVtZW50YWwu cGwgcmVhZHMgYWxsIElETCBmaWxlczsKKyAgICAgICAgICAgIHJlc29sdmUtc3VwcGxlbWVudGFs LnBsIHJlc29sdmVzIHRoZSBkZXBlbmRlbmN5IG9mIFtTdXBwbGVtZW50YWw9WFhYWF07CisgICAg ICAgICAgICByZXNvbHZlLXN1cHBsZW1lbnRhbC5wbCBvdXRwdXRzIHN1cHBsZW1lbnRhbF9kZXBl bmRlbmN5LnRtcDsKKyAgICAgICAgICAgIGZvcmVhY2ggJGlkbCAoYWxsIElETCBmaWxlcykgewor ICAgICAgICAgICAgICAgIGdlbmVyYXRlLWJpbmRpbmdzLnBsIGRlcGVuZHMgb24gJGlkbCBhbmQg c3VwcGxlbWVudGFsX2RlcGVuZGVuY3kudG1wOworICAgICAgICAgICAgICAgIGdlbmVyYXRlLWJp bmRpbmdzLnBsIHJlYWRzICRpZGw7CisgICAgICAgICAgICAgICAgZ2VuZXJhdGUtYmluZGluZ3Mu cGwgcmVhZHMgc3VwcGxlbWVudGFsX2RlcGVuZGVuY3kudG1wOworICAgICAgICAgICAgICAgIGdl bmVyYXRlLWJpbmRpbmdzLnBsIGdlbmVyYXRlcyAuaCBhbmQgLmNwcCBmaWxlcyBmb3IgJGlkbCwK KyAgICAgICAgICAgICAgICAgICAgaW5jbHVkaW5nIGFsbCBhdHRyaWJ1dGVzIGluIHRoZSBJREwg ZmlsZXMgdGhhdCBhcmUgaW1wbGVtZW50aW5nICRpZGw7CisgICAgICAgICAgICB9CisKKyAgICAg ICAgVGVzdHM6IENvbmZpcm0gdGhhdCBidWlsZCBzdWNjZWVkcy4KKyAgICAgICAgICAgICAgIGh0 dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzLyoKKworICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOgor ICAgICAgICAqIGJpbmRpbmdzL2dvYmplY3QvR05VbWFrZWZpbGUuYW06CisKIDIwMTItMDEtMDEg IEFuZHJlYXMgS2xpbmcgIDxhd2Vzb21la2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2Ug SFRNTENvbGxlY3Rpb25zIHBsYXkgbmljZSBhZnRlciB0aGVpciBiYXNlIG5vZGUgaXMgZ29uZS4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmFtIGIvU291cmNlL1dlYkNv cmUvR05VbWFrZWZpbGUuYW0KaW5kZXggZTY2YjgyNThhY2M2NDhkZGFjZWE4OGYzNzUxODZhYTRh YmIyNzdjNS4uODgyODc5MzVhM2QzMmFhNjQxMzc5MmRiZWNmNzE2ZGY4NjczODI0ZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0KKysrIGIvU291cmNlL1dlYkNvcmUv R05VbWFrZWZpbGUuYW0KQEAgLTY2NSw3ICs2NjUsNiBAQCBVU0VSX0FHRU5UX1NUWUxFX1NIRUVU UyA9IFwKICMgbmV3LXN0eWxlIEphdmFTY3JpcHQgYmluZGluZ3MKIFNDUklQVFNfRk9SX0dFTkVS QVRFX0JJTkRJTkdTID0gXAogCSQoV2ViQ29yZSkvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9yLnBtIFwKLQkkKFdlYkNvcmUpL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBt IFwKIAkkKFdlYkNvcmUpL2JpbmRpbmdzL3NjcmlwdHMvSURMUGFyc2VyLnBtIFwKIAkkKFdlYkNv cmUpL2JpbmRpbmdzL3NjcmlwdHMvSURMU3RydWN0dXJlLnBtIFwKIAkkKFdlYkNvcmUpL2JpbmRp bmdzL3NjcmlwdHMvSW5GaWxlc0NvbXBpbGVyLnBtIFwKQEAgLTc4MSw3ICs3ODAsNyBAQCAkKFNV UFBMRU1FTlRBTF9ERVBFTkRFTkNZX0ZJTEUpOiAkKFNDUklQVFNfRk9SX1JFU09MVkVfU1VQUExF TUVOVEFMKSAkKGRvbV9iaW5kaQogCSQoQU1fVl9HRU4pJChQRVJMKSAtSSQoV2ViQ29yZSkvYmlu ZGluZ3Mvc2NyaXB0cyAkKFdlYkNvcmUpL2JpbmRpbmdzL3NjcmlwdHMvcmVzb2x2ZS1zdXBwbGVt ZW50YWwucGwgLS1kZWZpbmVzICJMQU5HVUFHRV9KQVZBU0NSSVBUPTEgJChGRUFUVVJFX0RFRklO RVMpIiAtLWlkbEZpbGVzTGlzdCAkKElETF9GSUxFU19UTVApIC0tc3VwcGxlbWVudGFsRGVwZW5k ZW5jeUZpbGUgJEAKIAogLlNFQ09OREFSWToKLURlcml2ZWRTb3VyY2VzL1dlYkNvcmUvSlMlLmg6 ICUuaWRsICQoU0NSSVBUU19GT1JfR0VORVJBVEVfQklORElOR1MpICQoU1VQUExFTUVOVEFMX0RF UEVOREVOQ1lfRklMRSkKK0Rlcml2ZWRTb3VyY2VzL1dlYkNvcmUvSlMlLmg6ICUuaWRsICQoU0NS SVBUU19GT1JfR0VORVJBVEVfQklORElOR1MpICQoV2ViQ29yZSkvYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9ySlMucG0gJChTVVBQTEVNRU5UQUxfREVQRU5ERU5DWV9GSUxFKQogCSQoQU1f Vl9HRU4pJChQRVJMKSAtSSQoV2ViQ29yZSkvYmluZGluZ3Mvc2NyaXB0cyAkKFdlYkNvcmUpL2Jp bmRpbmdzL3NjcmlwdHMvZ2VuZXJhdGUtYmluZGluZ3MucGwgJChJRExfUEFUSDolPS0taW5jbHVk ZSAiJSIpIC0tb3V0cHV0RGlyICIkKEdFTlNPVVJDRVNfV0VCQ09SRSkiIC0tZGVmaW5lcyAiTEFO R1VBR0VfSkFWQVNDUklQVD0xICQoRkVBVFVSRV9ERUZJTkVTKSIgLS1nZW5lcmF0b3IgSlMgLS1z dXBwbGVtZW50YWxEZXBlbmRlbmN5RmlsZSAkKFNVUFBMRU1FTlRBTF9ERVBFTkRFTkNZX0ZJTEUp ICQ8CiAKIG5vaW5zdF9MVExJQlJBUklFUyArPSBcCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9nb2JqZWN0L0dOVW1ha2VmaWxlLmFtIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvZ29iamVjdC9HTlVtYWtlZmlsZS5hbQppbmRleCAwOGU3NzIxODJmMWUyODA5N2FkNDQ1MTEy MDg5MmEzYzUwYTVmZGU1Li44MGZmMTllMmJkNDIyODdlMjgwYzFiYTRkNDhiNTU3YTliMzZjMGIy IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L0dOVW1ha2VmaWxl LmFtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvR05VbWFrZWZpbGUuYW0K QEAgLTQ2Myw2ICs0NjMsNSBAQCAkKHRvcF9idWlsZGRpcikvRGVyaXZlZFNvdXJjZXMvd2Via2l0 L1dlYktpdERPTUN1c3RvbS5oOiAkKFdlYkNvcmUpL2JpbmRpbmdzL2dvYgogCiAjIEZpbHRlciBv dXQgU1ZHIGFuZCBJbmRleGVkREIgZm9yIG5vdwogZ2RvbV9mZWF0dXJlX2RlZmluZXMgOj0gJChm aWx0ZXItb3V0IEVOQUJMRV9JTkRFWEVEX0RBVEFCQVNFPTEsICQoZmlsdGVyLW91dCBFTkFCTEVf U1ZHJSwgJChGRUFUVVJFX0RFRklORVMpKSkKLURlcml2ZWRTb3VyY2VzL3dlYmtpdC9XZWJLaXRE T00lLmNwcCBEZXJpdmVkU291cmNlcy93ZWJraXQvV2ViS2l0RE9NJS5oIERlcml2ZWRTb3VyY2Vz L3dlYmtpdC9XZWJLaXRET00lUHJpdmF0ZS5oOiAlLmlkbCAkKFNDUklQVFNfQklORElOR1MpICQo V2ViQ29yZSkvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbSAkKFdlYkNv cmUpL2JpbmRpbmdzL2dvYmplY3QvR05VbWFrZWZpbGUuYW0KLQkkKEFNX1ZfR0VOKSQoUEVSTCkg LUkkKFdlYkNvcmUpL2JpbmRpbmdzL3NjcmlwdHMgJChXZWJDb3JlKS9iaW5kaW5ncy9zY3JpcHRz L2dlbmVyYXRlLWJpbmRpbmdzLnBsIC0taW5jbHVkZSAkKFdlYkNvcmUpL2RvbSAtLWluY2x1ZGUg JChXZWJDb3JlKS9odG1sIC0taW5jbHVkZSAkKFdlYkNvcmUpL2NzcyAtLWluY2x1ZGUgJChXZWJD b3JlKS9wYWdlIC0taW5jbHVkZSAkKFdlYkNvcmUpL3htbCAtLWluY2x1ZGUgJChXZWJDb3JlKS9z dmcgLS1vdXRwdXREaXIgIiQoR0VOU09VUkNFU19XRUJLSVQpIiAtLWRlZmluZXMgIkxBTkdVQUdF X0dPQkpFQ1Q9MSAkKGdkb21fZmVhdHVyZV9kZWZpbmVzKSIgLS1nZW5lcmF0b3IgR09iamVjdCAk PAotCitEZXJpdmVkU291cmNlcy93ZWJraXQvV2ViS2l0RE9NJS5jcHAgRGVyaXZlZFNvdXJjZXMv d2Via2l0L1dlYktpdERPTSUuaCBEZXJpdmVkU291cmNlcy93ZWJraXQvV2ViS2l0RE9NJVByaXZh dGUuaDogJS5pZGwgJChTQ1JJUFRTX0ZPUl9HRU5FUkFURV9CSU5ESU5HUykgJChXZWJDb3JlKS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtICQoV2ViQ29yZSkvYmluZGlu Z3MvZ29iamVjdC9HTlVtYWtlZmlsZS5hbSAkKFNVUFBMRU1FTlRBTF9ERVBFTkRFTkNZX0ZJTEUp CisJJChBTV9WX0dFTikkKFBFUkwpIC1JJChXZWJDb3JlKS9iaW5kaW5ncy9zY3JpcHRzICQoV2Vi Q29yZSkvYmluZGluZ3Mvc2NyaXB0cy9nZW5lcmF0ZS1iaW5kaW5ncy5wbCAtLWluY2x1ZGUgJChX ZWJDb3JlKS9kb20gLS1pbmNsdWRlICQoV2ViQ29yZSkvaHRtbCAtLWluY2x1ZGUgJChXZWJDb3Jl KS9jc3MgLS1pbmNsdWRlICQoV2ViQ29yZSkvcGFnZSAtLWluY2x1ZGUgJChXZWJDb3JlKS94bWwg LS1pbmNsdWRlICQoV2ViQ29yZSkvc3ZnIC0tb3V0cHV0RGlyICIkKEdFTlNPVVJDRVNfV0VCS0lU KSIgLS1kZWZpbmVzICJMQU5HVUFHRV9HT0JKRUNUPTEgJChnZG9tX2ZlYXR1cmVfZGVmaW5lcyki IC0tZ2VuZXJhdG9yIEdPYmplY3QgLS1zdXBwbGVtZW50YWxEZXBlbmRlbmN5RmlsZSAkKFNVUFBM RU1FTlRBTF9ERVBFTkRFTkNZX0ZJTEUpICQ8Cg==