<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>75001</bug_id>
          
          <creation_ts>2011-12-21 01:59:03 -0800</creation_ts>
          <short_desc>Painting on a table with overflow: hidden cells is very slow</short_desc>
          <delta_ts>2023-10-03 00:39:06 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=73715</see_also>
          <bug_file_loc>http://dglazkov.github.com/performance-tests/biggrid.html</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>88386</dependson>
    
    <dependson>89389</dependson>
    
    <dependson>89899</dependson>
    
    <dependson>85678</dependson>
    
    <dependson>88464</dependson>
    
    <dependson>88570</dependson>
    
    <dependson>88888</dependson>
          <blocked>73714</blocked>
    
    <blocked>92258</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Julien Chaffraix">jchaffraix</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>dglazkov</cc>
    
    <cc>eric</cc>
    
    <cc>jamesr</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>thorton</cc>
    
    <cc>tomhudson</cc>
    
    <cc>tonikitoo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>525196</commentid>
    <comment_count>0</comment_count>
    <who name="Julien Chaffraix">jchaffraix</who>
    <bug_when>2011-12-21 01:59:03 -0800</bug_when>
    <thetext>Seen on the benchmark: http://dglazkov.github.com/performance-tests/biggrid.html. If you toggle overflow: hidden and scroll on the table, you can see that painting takes several times more time that without overflow: hidden (for example by looking at the WebInspector timeline).

RenderTableSection implements an optimization during painting where it finds the dirtied cells to paint using a binary search on the rows and columns (see RenderTableSection::paintObject). When we toggle overflow: hidden, the painting goes through the RenderLayer path. However there is no such optimization and we spend a lot of time trying to repaint layers that are not dirty (or even worse off-screen). This bug may be related to bug 73715 but it looks like there is more to the other bug (composition is involved for example).

As a side note, hit testing has exactly the same issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>644011</commentid>
    <comment_count>1</comment_count>
    <who name="Julien Chaffraix">jchaffraix</who>
    <bug_when>2012-06-07 15:56:07 -0700</bug_when>
    <thetext>For the record, when scrolling on the page on a 10,000 * 100 table with overflow: hidden, the painting used to take ~255 ms (for 2048 x 256). We are now down to ~45 ms.

Painting has been sped up but the core issue still remains: we should have visit only the visible cells instead of all the cells in the table.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>651680</commentid>
    <comment_count>2</comment_count>
    <who name="Julien Chaffraix">jchaffraix</who>
    <bug_when>2012-06-18 13:42:15 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; For the record, when scrolling on the page on a 10,000 * 100 table with overflow: hidden, the painting used to take ~255 ms (for 2048 x 256). We are now down to ~45 ms.

Bug 88888 landed another performance optimization. It makes us not visit any of the cells in biggrid.html particular case. This brings the paint time to ~6ms in the same conditions.

&gt; Painting has been sped up but the core issue still remains: we should have visit only the visible cells instead of all the cells in the table.

The optimization is somewhat limited and could be improved upon. First hit-testing is still sluggish but also the optimization relies on having _no_ self-painting-descendants which means that if you have one, you don&apos;t reap any performance benefit.

I am keeping this bug open to track more of the fixes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>722957</commentid>
    <comment_count>3</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-09-18 11:58:49 -0700</bug_when>
    <thetext>bug 92258 is another bug on the topic of this benchmark.  Perhaps it should be duped against this one or both related to some more generic meta-bug.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>