74873 2011-12-19 11:00:14 -0800 WebVTT cues sometimes render when they should not 2011-12-20 18:38:39 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 43668 1 eric.carlson eric.carlson dglazkov webkit-bug-importer webkit.review.bot oldest_to_newest 524017 0 eric.carlson 2011-12-19 11:00:14 -0800 Captions continue to render after their end time if there are no cues at all for the current time. 524019 1 webkit-bug-importer 2011-12-19 11:01:10 -0800 <rdar://problem/10601950> 524050 2 119893 eric.carlson 2011-12-19 11:20:01 -0800 Created attachment 119893 Proposed patch 524099 3 119893 webkit.review.bot 2011-12-19 12:11:35 -0800 Comment on attachment 119893 Proposed patch Attachment 119893 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10915029 New failing tests: media/track/track-cue-nothing-to-render.html 524990 4 eric.carlson 2011-12-20 17:14:51 -0800 http://trac.webkit.org/changeset/103371 524993 5 eric.carlson 2011-12-20 17:16:52 -0800 I can't figure out why the new test failed on the Linux bot, will watch the builders and fix or skip it. 525039 6 eric.carlson 2011-12-20 18:38:39 -0800 Plus http://trac.webkit.org/changeset/103386 to fix the cr build. 119893 2011-12-19 11:20:01 -0800 2011-12-20 11:49:41 -0800 Proposed patch patch_remove_cues_1.txt text/plain 7667 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMzI0OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDExLTEyLTE5ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFdlYlZUVCBjdWVzIHNv bWV0aW1lcyByZW5kZXIgd2hlbiB0aGV5IHNob3VsZCBub3QKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0ODczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogbWVkaWEvdHJhY2svdHJhY2stY3VlLW5v dGhpbmctdG8tcmVuZGVyLmh0bWwKKworICAgICAgICAqIGh0bWwvc2hhZG93L01lZGlhQ29udHJv bFJvb3RFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhQ29udHJvbFJvb3RFbGVt ZW50Ojp1cGRhdGVUZXh0VHJhY2tEaXNwbGF5KTogRG9uJ3QgcmV0dXJuIGVhcmx5IGlmIHRoZSBj dXJyZW50CisgICAgICAgICAgICBjdWUgaXMgZW1wdHkgc28gdGhlIHByZXZpb3VzIGN1ZSBpcyBy ZW1vdmVkLgorCiAyMDExLTEyLTE5ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgV2UgZG9uJ3QgcGFzcyBhbGwgb2YgdGhlIGh0bWw1bGliIHVuc2FmZS10ZXh0LmRh dCB0ZXN0cwpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sUm9v dEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01l ZGlhQ29udHJvbFJvb3RFbGVtZW50LmNwcAkocmV2aXNpb24gMTAzMjQyKQorKysgU291cmNlL1dl YkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sUm9vdEVsZW1lbnQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC02MzQsOSArNjM0LDYgQEAgdm9pZCBNZWRpYUNvbnRyb2xSb290RWxlbWVudDo6dXBk YXRlVGV4dAogICAgICAgICBjcmVhdGVUZXh0VHJhY2tEaXNwbGF5KCk7CiAKICAgICBDdWVMaXN0 IGFjdGl2ZUN1ZXMgPSB0b1BhcmVudE1lZGlhRWxlbWVudChtX3RleHREaXNwbGF5Q29udGFpbmVy KS0+Y3VycmVudGx5QWN0aXZlQ3VlcygpOwotICAgIGlmIChhY3RpdmVDdWVzLmlzRW1wdHkoKSkK LSAgICAgICAgcmV0dXJuOwotCiAgICAgbV90ZXh0VHJhY2tEaXNwbGF5LT5yZW1vdmVDaGlsZHJl bigpOwogICAgIGJvb2wgbm90aGluZ1RvRGlzcGxheSA9IHRydWU7CiAgICAgZm9yIChzaXplX3Qg aSA9IDA7IGkgPCBhY3RpdmVDdWVzLnNpemUoKTsgKytpKSB7CkluZGV4OiBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAx MDMyNDgpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxNCBAQAorMjAxMS0xMi0xOSAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNv bT4KKworICAgICAgICBXZWJWVFQgY3VlcyBzb21ldGltZXMgcmVuZGVyIHdoZW4gdGhleSBzaG91 bGQgbm90CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 NDg3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog bWVkaWEvdHJhY2svY2FwdGlvbnMtd2VidnR0L2NhcHRpb25zLWdhcHMudnR0OiBBZGRlZC4KKyAg ICAgICAgKiBtZWRpYS90cmFjay90cmFjay1jdWUtbm90aGluZy10by1yZW5kZXItZXhwZWN0ZWQu dHh0OiBBZGRlZC4KKyAgICAgICAgKiBtZWRpYS90cmFjay90cmFjay1jdWUtbm90aGluZy10by1y ZW5kZXIuaHRtbDogQWRkZWQuCisKIDIwMTEtMTItMTkgIEFkcmllbm5lIFdhbGtlciAgPGVubmVA Z29vZ2xlLmNvbT4KIAogICAgICAgICBbY2hyb21pdW1dIE1hcmsgbW9yZSB3b3JrZXIgdGVzdHMg YXMgYmVpbmcgZmxha3kgY3Jhc2hlcnMKQEAgLTQzLDYgKzU0LDcgQEAKICAgICAgICAgKG1lZGlh Q29udHJvbHNCdXR0b25Db29yZGluYXRlcyk6CiAgICAgICAgICh0ZXh0VHJhY2tEaXNwbGF5RWxl bWVudCk6IEZpbmQgdGhlIGN1ZSBkaXNwbGF5IGVsZW1lbnQuCiAKKyAgICAgICAgKiBtZWRpYS90 cmFjay9jYXB0aW9ucy13ZWJ2dHQvY2FwdGlvbnMudnR0OiBBZGRlZC4KICAgICAgICAgKiBtZWRp YS90cmFjay90cmFjay1jdWUtcmVuZGVyaW5nLWV4cGVjdGVkLnR4dDogQWRkZWQuCiAgICAgICAg ICogbWVkaWEvdHJhY2svdHJhY2stY3VlLXJlbmRlcmluZy5odG1sOiBBZGRlZC4KIApJbmRleDog TGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stY3VlLW5vdGhpbmctdG8tcmVuZGVyLWV4cGVj dGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jdWUt bm90aGluZy10by1yZW5kZXItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvbWVkaWEvdHJhY2svdHJhY2stY3VlLW5vdGhpbmctdG8tcmVuZGVyLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKQEAgLTAsMCArMSw0OCBAQAorVGVzdCB0aGF0IGN1ZXMgYXJlIHJlbmRlcmVk IGFuZCByZW1vdmVkLgorCitFVkVOVChjYW5wbGF5dGhyb3VnaCkKK0VWRU5UKHNlZWtlZCkKK0VY UEVDVEVEICh2aWRlby5jdXJyZW50VGltZS50b0ZpeGVkKDEpID09ICcwLjUnKSBPSworRVhQRUNU RUQgKHRleHRUcmFja0Rpc3BsYXlFbGVtZW50KHZpZGVvKS5pbm5lclRleHQgPT0gJycpIE9LCisK K1JVTih2aWRlby5jdXJyZW50VGltZSA9IDEuNSkKK0VWRU5UKHNlZWtlZCkKK0VYUEVDVEVEICh2 aWRlby5jdXJyZW50VGltZS50b0ZpeGVkKDEpID09ICcxLjUnKSBPSworRVhQRUNURUQgKHRlc3RU cmFjay50cmFjay5hY3RpdmVDdWVzWzBdLmdldEN1ZUFzU291cmNlKCkgPT0gJ0xvcmVtIGlwc3Vt IGRvbG9yIHNpdCBhbWV0LCcpIE9LCitFWFBFQ1RFRCAodGV4dFRyYWNrRGlzcGxheUVsZW1lbnQo dmlkZW8pLmlubmVyVGV4dCA9PSAnTG9yZW0gaXBzdW0gZG9sb3Igc2l0IGFtZXQsJykgT0sKKwor UlVOKHZpZGVvLmN1cnJlbnRUaW1lID0gMi41KQorRVZFTlQoc2Vla2VkKQorRVhQRUNURUQgKHZp ZGVvLmN1cnJlbnRUaW1lLnRvRml4ZWQoMSkgPT0gJzIuNScpIE9LCitFWFBFQ1RFRCAodGV4dFRy YWNrRGlzcGxheUVsZW1lbnQodmlkZW8pLmlubmVyVGV4dCA9PSAnJykgT0sKKworUlVOKHZpZGVv LmN1cnJlbnRUaW1lID0gMy4zKQorRVZFTlQoc2Vla2VkKQorRVhQRUNURUQgKHZpZGVvLmN1cnJl bnRUaW1lLnRvRml4ZWQoMSkgPT0gJzMuMycpIE9LCitFWFBFQ1RFRCAodGVzdFRyYWNrLnRyYWNr LmFjdGl2ZUN1ZXNbMF0uZ2V0Q3VlQXNTb3VyY2UoKSA9PSAnY29uc2VjdGV0dWVyIGFkaXBpc2Np bmcgZWxpdCwnKSBPSworRVhQRUNURUQgKHRleHRUcmFja0Rpc3BsYXlFbGVtZW50KHZpZGVvKS5p bm5lclRleHQgPT0gJ2NvbnNlY3RldHVlciBhZGlwaXNjaW5nIGVsaXQsJykgT0sKKworUlVOKHZp ZGVvLmN1cnJlbnRUaW1lID0gMC42KQorRVZFTlQoc2Vla2VkKQorRVhQRUNURUQgKHZpZGVvLmN1 cnJlbnRUaW1lLnRvRml4ZWQoMSkgPT0gJzAuNicpIE9LCitFWFBFQ1RFRCAodGV4dFRyYWNrRGlz cGxheUVsZW1lbnQodmlkZW8pLmlubmVyVGV4dCA9PSAnJykgT0sKKworUlVOKHZpZGVvLmN1cnJl bnRUaW1lID0gNS45KQorRVZFTlQoc2Vla2VkKQorRVhQRUNURUQgKHZpZGVvLmN1cnJlbnRUaW1l LnRvRml4ZWQoMSkgPT0gJzUuOScpIE9LCitFWFBFQ1RFRCAodGVzdFRyYWNrLnRyYWNrLmFjdGl2 ZUN1ZXNbMF0uZ2V0Q3VlQXNTb3VyY2UoKSA9PSAnc2VkIGRpYW0gbm9udW1teSBuaWJoIGV1aXNt b2QgdGluY2lkdW50JykgT0sKK0VYUEVDVEVEICh0ZXh0VHJhY2tEaXNwbGF5RWxlbWVudCh2aWRl bykuaW5uZXJUZXh0ID09ICdzZWQgZGlhbSBub251bW15IG5pYmggZXVpc21vZCB0aW5jaWR1bnQn KSBPSworCitSVU4odmlkZW8uY3VycmVudFRpbWUgPSA0LjQpCitFVkVOVChzZWVrZWQpCitFWFBF Q1RFRCAodmlkZW8uY3VycmVudFRpbWUudG9GaXhlZCgxKSA9PSAnNC40JykgT0sKK0VYUEVDVEVE ICh0ZXh0VHJhY2tEaXNwbGF5RWxlbWVudCh2aWRlbykuaW5uZXJUZXh0ID09ICcnKSBPSworCitS VU4odmlkZW8uY3VycmVudFRpbWUgPSA3LjkpCitFVkVOVChzZWVrZWQpCitFWFBFQ1RFRCAodmlk ZW8uY3VycmVudFRpbWUudG9GaXhlZCgxKSA9PSAnNy45JykgT0sKK0VYUEVDVEVEICh0ZXN0VHJh Y2sudHJhY2suYWN0aXZlQ3Vlc1swXS5nZXRDdWVBc1NvdXJjZSgpID09ICd1dCBsYW9yZWV0IGRv bG9yZSBtYWduYSBhbGlxdWFtIGVyYXQgdm9sdXRwYXQuJykgT0sKK0VYUEVDVEVEICh0ZXh0VHJh Y2tEaXNwbGF5RWxlbWVudCh2aWRlbykuaW5uZXJUZXh0ID09ICd1dCBsYW9yZWV0IGRvbG9yZSBt YWduYSBhbGlxdWFtIGVyYXQgdm9sdXRwYXQuJykgT0sKKworRU5EIE9GIFRFU1QKKwpJbmRleDog TGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stY3VlLW5vdGhpbmctdG8tcmVuZGVyLmh0bWwK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stY3VlLW5vdGhpbmct dG8tcmVuZGVyLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90 cmFjay1jdWUtbm90aGluZy10by1yZW5kZXIuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw2 MyBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAgICAgPG1ldGEg aHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9dXRm LTgiIC8+CisKKyAgICAgICAgPHNjcmlwdCBzcmM9Li4vbWVkaWEtZmlsZS5qcz48L3NjcmlwdD4K KyAgICAgICAgPHNjcmlwdCBzcmM9Li4vdmlkZW8tdGVzdC5qcz48L3NjcmlwdD4KKyAgICAgICAg PHNjcmlwdCBzcmM9Li4vbWVkaWEtY29udHJvbHMuanM+PC9zY3JpcHQ+CisKKyAgICAgICAgPHNj cmlwdD4gICAgICAgICAgICAKKworICAgICAgICB2YXIgdGVzdFRyYWNrOworICAgICAgICB2YXIg c2Vla2VkQ291bnQgPSAwOworICAgICAgICB2YXIgaW5mbyA9IFsgCisgICAgICAgICAgICAwLjUs ICIiLCAKKyAgICAgICAgICAgIDEuNSwgIkxvcmVtIGlwc3VtIGRvbG9yIHNpdCBhbWV0LCIsIAor ICAgICAgICAgICAgMi41LCAiIiwgCisgICAgICAgICAgICAzLjMsICJjb25zZWN0ZXR1ZXIgYWRp cGlzY2luZyBlbGl0LCIsIAorICAgICAgICAgICAgMC42LCAiIiwKKyAgICAgICAgICAgIDUuOSwg InNlZCBkaWFtIG5vbnVtbXkgbmliaCBldWlzbW9kIHRpbmNpZHVudCIsCisgICAgICAgICAgICA0 LjQsICIiLAorICAgICAgICAgICAgNy45LCAidXQgbGFvcmVldCBkb2xvcmUgbWFnbmEgYWxpcXVh bSBlcmF0IHZvbHV0cGF0LiIgCisgICAgICAgIF07CisKKyAgICAgICAgZnVuY3Rpb24gc2Vla2Vk KCkKKyAgICAgICAgeworICAgICAgICAgICAgdmFyIHRpbWUgPSBpbmZvW3NlZWtlZENvdW50XTsK KyAgICAgICAgICAgIHZhciBjdWVUZXh0ID0gaW5mb1tzZWVrZWRDb3VudCArIDFdOworICAgICAg ICAgICAgc2Vla2VkQ291bnQgKz0gMjsKKworICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJ2aWRl by5jdXJyZW50VGltZS50b0ZpeGVkKDEpIiwgdGltZS50b0ZpeGVkKDEpKTsKKyAgICAgICAgICAg IGlmIChjdWVUZXh0Lmxlbmd0aCkKKyAgICAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoInRlc3RU cmFjay50cmFjay5hY3RpdmVDdWVzWzBdLmdldEN1ZUFzU291cmNlKCkiLCBjdWVUZXh0KTsKKyAg ICAgICAgICAgIHRlc3RFeHBlY3RlZCgidGV4dFRyYWNrRGlzcGxheUVsZW1lbnQodmlkZW8pLmlu bmVyVGV4dCIsIGN1ZVRleHQpOworCisgICAgICAgICAgICBpZiAoc2Vla2VkQ291bnQgPj0gaW5m by5sZW5ndGgpIHsKKyAgICAgICAgICAgICAgICBjb25zb2xlV3JpdGUoIiIpOworICAgICAgICAg ICAgICAgIGVuZFRlc3QoKTsKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB9 CisKKyAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiIik7CisgICAgICAgICAgICBydW4oInZpZGVv LmN1cnJlbnRUaW1lID0gIiArIChpbmZvW3NlZWtlZENvdW50XSkpOworICAgICAgICB9CisKKyAg ICAgICAgZnVuY3Rpb24gbG9hZGVkKCkKKyAgICAgICAgeworICAgICAgICAgICAgZmluZE1lZGlh RWxlbWVudCgpOworICAgICAgICAgICAgdGVzdFRyYWNrID0gZG9jdW1lbnQucXVlcnlTZWxlY3Rv cigndHJhY2snKTsKKyAgICAgICAgICAgIHZpZGVvLnNyYyA9IGZpbmRNZWRpYUZpbGUoJ3ZpZGVv JywgJy4uL2NvbnRlbnQvY291bnRpbmcnKTsKKyAgICAgICAgICAgIHdhaXRGb3JFdmVudCgnc2Vl a2VkJywgc2Vla2VkKTsKKyAgICAgICAgICAgIHdhaXRGb3JFdmVudCgnY2FucGxheXRocm91Z2gn LCBmdW5jdGlvbigpIHsgdmlkZW8uY3VycmVudFRpbWUgPSAuNTsgfSk7CisgICAgICAgIH0KKyAg ICAgICAgCisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvaGVhZD4KKyAgICA8Ym9keSBvbmxvYWQ9 ImxvYWRlZCgpIj4KKyAgICAgICAgPHZpZGVvIGNvbnRyb2xzID4KKyAgICAgICAgICAgIDx0cmFj ayBzcmM9ImNhcHRpb25zLXdlYnZ0dC9jYXB0aW9ucy1nYXBzLnZ0dCIga2luZD0iY2FwdGlvbnMi IGRlZmF1bHQ+CisgICAgICAgIDwvdmlkZW8+CisgICAgICAgIDxwPlRlc3QgdGhhdCBjdWVzIGFy ZSByZW5kZXJlZCBhbmQgcmVtb3ZlZC48L3A+CisgICAgPC9ib2R5PgorPC9odG1sPgpJbmRleDog TGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svY2FwdGlvbnMtd2VidnR0L2NhcHRpb25zLWdhcHMudnR0 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL21lZGlhL3RyYWNrL2NhcHRpb25zLXdlYnZ0dC9j YXB0aW9ucy1nYXBzLnZ0dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL21lZGlhL3RyYWNr L2NhcHRpb25zLXdlYnZ0dC9jYXB0aW9ucy1nYXBzLnZ0dAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSwxOCBAQAor77u/V0VCVlRUCisKKzEKKzAwOjAwOjAxLjAwMCAtLT4gMDA6MDA6MDIuMDAwCitM b3JlbSBpcHN1bSBkb2xvciBzaXQgYW1ldCwKKworMgorMDA6MDA6MDMuMDAwIC0tPiAwMDowMDow NC4wMDAKK2NvbnNlY3RldHVlciBhZGlwaXNjaW5nIGVsaXQsCisKKzMKKzAwOjAwOjA1LjAwMCAt LT4gMDA6MDA6MDYuMDAwCitzZWQgZGlhbSBub251bW15IG5pYmggZXVpc21vZCB0aW5jaWR1bnQK KworNAorMDA6MDA6MDcuMDAwIC0tPiAwMDowMDowOC4wMDAKK3V0IGxhb3JlZXQgZG9sb3JlIG1h Z25hIGFsaXF1YW0gZXJhdCB2b2x1dHBhdC4KKwo=