74526 2011-12-14 11:26:28 -0800 [Qt][WK2] Setting Download as action for navigation request crashes WebProcess 2011-12-15 05:19:05 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED Qt, QtTriaged P2 Normal --- 74541 1 rafael.lobo jesus rafael.lobo oldest_to_newest 521123 0 rafael.lobo 2011-12-14 11:26:28 -0800 An easy way to check this out is to handle onNavigationRequested on MiniBrowser for example. I`ve added a small diff that adds this feature on MiniBrowser. In order to crash it, just click with middle button on any link. You'll see the following output: We are supposed to start a download. WARNING: The web process experienced a crash on 'http://www.google.com.br/'. 521124 1 119262 rafael.lobo 2011-12-14 11:27:19 -0800 Created attachment 119262 This adds simple handler to navigation request on MiniBrowser, so you can see it crashing. 521262 2 jesus 2011-12-14 13:53:07 -0800 Backtrace shows that this is not related to the Download code path itself but to ResouceRequest and ThirdPartyCookies. IIRC, this has been recently refactored by Simon. I will talk to him. #0 0x00007f59a4c1bd1a in WebCore::thirdPartyCookiePolicyPermits Source/WebCore/platform/qt/ThirdPartyCookiesQt.cpp:65 #1 0x00007f59a4c0829d in WebCore::ResourceRequest::toNetworkRequest Source/WebCore/platform/network/qt/ResourceRequestQt.cpp:83 #2 0x00007f59a407ce55 in WebKit::Download::start Source/WebKit2/WebProcess/Downloads/qt/DownloadQt.cpp:48 521310 3 119301 jesus 2011-12-14 14:44:57 -0800 Created attachment 119301 Patch 521840 4 119301 jesus 2011-12-15 05:18:56 -0800 Comment on attachment 119301 Patch Clearing flags on attachment: 119301 Committed r102926: <http://trac.webkit.org/changeset/102926> 521841 5 jesus 2011-12-15 05:19:05 -0800 All reviewed patches have been landed. Closing bug. 119262 2011-12-14 11:27:19 -0800 2011-12-14 14:44:50 -0800 This adds simple handler to navigation request on MiniBrowser, so you can see it crashing. download-crash.diff text/plain 1218 rafael.lobo ZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL3F0L3FtbC9Ccm93c2VyV2luZG93LnFtbCBi L1Rvb2xzL01pbmlCcm93c2VyL3F0L3FtbC9Ccm93c2VyV2luZG93LnFtbAppbmRleCBhMjIxNTUz Li45OGIxZjRkIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9xdC9xbWwvQnJvd3Nlcldp bmRvdy5xbWwKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvcXQvcW1sL0Jyb3dzZXJXaW5kb3cucW1s CkBAIC0yMzIsNiArMjMyLDMwIEBAIFJlY3RhbmdsZSB7CiAgICAgICAgICAgICBmb3JjZUFjdGl2 ZUZvY3VzKCk7CiAgICAgICAgIH0KIAorICAgICAgICBvbk5hdmlnYXRpb25SZXF1ZXN0ZWQ6IHsK KyAgICAgICAgICAgIGlmIChyZXF1ZXN0LmJ1dHRvbiA9PSBRdC5NaWRkbGVCdXR0b24pIHsKKyAg ICAgICAgICAgICAgICBjb25zb2xlLmxvZygnV2UgYXJlIHN1cHBvc2VkIHRvIHN0YXJ0IGEgZG93 bmxvYWQuJykKKyAgICAgICAgICAgICAgICByZXF1ZXN0LmFjdGlvbiA9IFdlYlZpZXcuRG93bmxv YWRSZXF1ZXN0CisgICAgICAgICAgICB9CisgICAgICAgIH0KKworICAgICAgICBleHBlcmltZW50 YWwub25Eb3dubG9hZFJlcXVlc3RlZDogeworICAgICAgICAgICAgY29uc29sZS5sb2coJ0Rvd25s b2FkIGhhcyBiZWVuIHJlcXVlc3RlZC4gU3RhcnQgaXQuJyk7CisgICAgICAgICAgICBkb3dubG9h ZC50YXJnZXQgPSBkb3dubG9hZEl0ZW0KKyAgICAgICAgICAgIGV4cGVjdGVkTGVuZ3RoID0gZG93 bmxvYWRJdGVtLmV4cGVjdGVkQ29udGVudExlbmd0aAorICAgICAgICAgICAgZG93bmxvYWRJdGVt LmRlc3RpbmF0aW9uUGF0aCA9IGRvd25sb2FkSXRlbS5zdWdnZXN0ZWRGaWxlbmFtZQorICAgICAg ICAgICAgZG93bmxvYWRJdGVtLnN0YXJ0KCkKKyAgICAgICAgfQorCisgICAgICAgIENvbm5lY3Rp b25zIHsKKyAgICAgICAgICAgIGlkOiBkb3dubG9hZAorICAgICAgICAgICAgaWdub3JlVW5rbm93 blNpZ25hbHM6IHRydWUKKyAgICAgICAgICAgIG9uU3VjY2VlZGVkOiB7CisgICAgICAgICAgICAg ICAgY29uc29sZS5sb2coJ0Rvd25sb2FkIGZpbmlzaGVkIScpCisgICAgICAgICAgICAgICAgdG90 YWxCeXRlcyA9IGRvd25sb2FkLnRhcmdldC50b3RhbEJ5dGVzUmVjZWl2ZWQKKyAgICAgICAgICAg IH0KKyAgICAgICAgfQorCiAgICAgICAgIGV4cGVyaW1lbnRhbC5pdGVtU2VsZWN0b3I6IEl0ZW1T ZWxlY3RvciB7IH0KICAgICB9CiAK 119301 2011-12-14 14:44:57 -0800 2011-12-15 05:18:56 -0800 Patch bug-74526-20111214194443.patch text/plain 1708 jesus U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyODEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWQ3M2EyY2U1MDdmZTU5 NDYyMWZkOTI3Yzg3NzlkMjRlNzYzMDliZC4uZGY4ZjM5NGU3MDhhZDIyMDYwN2Y0MDdhMmI0ZTJh OGI5ZDBjMzM3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTEyLTE0ICBKZXN1 cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KKworICAg ICAgICBbUXRdW1dLMl0gU2V0dGluZyBEb3dubG9hZCBhcyBhY3Rpb24gZm9yIG5hdmlnYXRpb24g cmVxdWVzdCBjcmFzaGVzIFdlYlByb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc0NTI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkaW5nIGNoZWNrcyBmb3IgbmV0d29ya2NvbnRleHQgYW5kIG5l dHdvcmtBY2Nlc3NNYW5hZ2VyCisgICAgICAgIGFuZCByZXR1cm4gdHJ1ZSBpbiBjYXNlIHRoZXkg ZG9uJ3QgZXhpc3QsIGZvbGxvd2luZyB0aGUgc2FtZQorICAgICAgICBsb2dpYyBhcyBpZiB0aGUg Q29va2llSmFyIGRvZXNuJ3QgZXhpc3QuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9UaGlyZFBh cnR5Q29va2llc1F0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnRoaXJkUGFydHlDb29raWVQb2xp Y3lQZXJtaXRzKToKKwogMjAxMS0xMi0xNCAgUmF5bW9uZCBUb3kgIDxydG95QGdvb2dsZS5jb20+ CiAKICAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9EaXN0YW5jZS5oIChXZWJDb3JlKTogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9UaGlyZFBhcnR5Q29va2llc1F0LmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1RoaXJkUGFydHlDb29raWVzUXQuY3BwCmlu ZGV4IDIzZDcxZTlmZWRhYjk3MzFiNzM3ZGFkNmZiMDcxY2JjNWI4NGY0NzAuLjNkNDlhYmUxN2Yy MGVmZWFjNzQzNmM0NTViOWUzY2Y0ODFlZTQ4YTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3F0L1RoaXJkUGFydHlDb29raWVzUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3F0L1RoaXJkUGFydHlDb29raWVzUXQuY3BwCkBAIC02Miw2ICs2MiwxMiBAQCBz dGF0aWMgYm9vbCB1cmxzU2hhcmVTYW1lRG9tYWluKGNvbnN0IFFVcmwmIHVybCwgY29uc3QgUVVy bCYgZmlyc3RQYXJ0eVVybCkKIGJvb2wgdGhpcmRQYXJ0eUNvb2tpZVBvbGljeVBlcm1pdHMoTmV0 d29ya2luZ0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IFFVcmwmIHVybCwgY29uc3QgUVVybCYgZmly c3RQYXJ0eVVybCkKIHsKICNpZiBRVF9WRVJTSU9OID49IFFUX1ZFUlNJT05fQ0hFQ0soNCwgOCwg MCkKKyAgICBpZiAoIWNvbnRleHQpCisgICAgICAgIHJldHVybiB0cnVlOworCisgICAgaWYgKCFj b250ZXh0LT5uZXR3b3JrQWNjZXNzTWFuYWdlcigpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKwog ICAgIFFOZXR3b3JrQ29va2llSmFyKiBqYXIgPSBjb250ZXh0LT5uZXR3b3JrQWNjZXNzTWFuYWdl cigpLT5jb29raWVKYXIoKTsKICAgICBpZiAoIWphcikKICAgICAgICAgcmV0dXJuIHRydWU7Cg==