74180 2011-12-09 06:28:43 -0800 [Qt][WK2] Unskip API tests 2011-12-09 17:28:47 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 70236 1 jesus jesus menard webkit.review.bot zoltan oldest_to_newest 518235 0 jesus 2011-12-09 06:28:43 -0800 Now we can unskip the API tests for geolocation and the ones for javascript dialogs, since the experimental property is now available in JS contexts. 518236 1 118568 jesus 2011-12-09 06:30:28 -0800 Created attachment 118568 Patch 518422 2 menard 2011-12-09 12:52:10 -0800 Really Jesus you could land that rather polluting the cq :D. 518673 3 118568 webkit.review.bot 2011-12-09 17:28:43 -0800 Comment on attachment 118568 Patch Clearing flags on attachment: 118568 Committed r102499: <http://trac.webkit.org/changeset/102499> 518674 4 webkit.review.bot 2011-12-09 17:28:47 -0800 All reviewed patches have been landed. Closing bug. 118568 2011-12-09 06:30:28 -0800 2011-12-09 17:28:43 -0800 Patch bug-74180-20111209113012.patch text/plain 2939 jesus U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNDUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTcxNmI1ZWI5YmZjOGYx YThmNTQzYTM5YjAzMzU3OTlkZWEzNjg0NS4uNWE4MzhhMjlmMjhiNzc1NWY0Y2U3YWZiNzA5NmJk OTk4MjQzODgwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTEyLTA5ICBKZXN1 cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KKworICAg ICAgICBbUXRdW1dLMl0gVW5za2lwIEFQSSB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQxODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBVbnNraXAgQVBJIHRlc3RzIGZvciBnZW9sb2NhdGlvbiBh bmQgamF2YXNjcmlwdCBkaWFsb2dzLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC90ZXN0 cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9nZW9wZXJtaXNzaW9uLnFtbDoKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X2phdmFTY3JpcHREaWFsb2dz LnFtbDoKKwogMjAxMS0xMi0wOSAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tp YS5jb20+CiAKICAgICAgICAgW1F0XSBGaXggY29tcGlsYXRpb24gd2l0aCBuZXdseSBzZXBhcmF0 ZWQgUXQgNSBRdFF1aWNrIG1vZHVsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9nZW9wZXJtaXNzaW9uLnFtbCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvV2ViVmlldy90 c3RfZ2VvcGVybWlzc2lvbi5xbWwKaW5kZXggYzY0Yzk3MTU3OGY5YzlkZDJmNzFkNTExYjcyOWI0 MGVlYjUyZGI3YS4uNjk3YWIwODVhMDY3NWM5ZTIxMmIyZDgzNDQ0MjcxMmIyODczNjgxYSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9X ZWJWaWV3L3RzdF9nZW9wZXJtaXNzaW9uLnFtbAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X2dlb3Blcm1pc3Npb24ucW1sCkBA IC00NSw3ICs0NSw2IEBAIFdlYlZpZXcgewogICAgICAgICB9CiAKICAgICAgICAgZnVuY3Rpb24g dGVzdF9wZXJtaXNzaW9uUmVxdWVzdCgpIHsKLSAgICAgICAgICAgIHNraXAoIldhaXRpbmcgZm9y IHF0bG9jYXRpb24gYmVpbmcgaW5jbHVkZWQgaW4gdGhlIGJvdCIpCiAgICAgICAgICAgICBjb21w YXJlKHNweS5jb3VudCwgMCkKICAgICAgICAgICAgIHdlYlZpZXcubG9hZChRdC5yZXNvbHZlZFVy bCgiLi4vY29tbW9uL2dlb2xvY2F0aW9uLmh0bWwiKSkKICAgICAgICAgICAgIHNweS53YWl0KCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVz dHMvV2ViVmlldy90c3RfamF2YVNjcmlwdERpYWxvZ3MucW1sIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9qYXZhU2NyaXB0RGlhbG9n cy5xbWwKaW5kZXggZDc5ZDRmNWUzNjRjZTY0NjViMGU0ZDc3MjJkMWFhNDIwN2FmMGFhZC4uNTZj MzRhYmNkYjY4YjNjYmNmY2ZiNWU0NmFkZmEwNDY5N2U4NWYyMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9qYXZh U2NyaXB0RGlhbG9ncy5xbWwKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90 ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9qYXZhU2NyaXB0RGlhbG9ncy5xbWwKQEAgLTgxLDcg KzgxLDYgQEAgV2ViVmlldyB7CiAgICAgICAgIH0KIAogICAgICAgICBmdW5jdGlvbiB0ZXN0X2Fs ZXJ0V2l0aG91dERpYWxvZygpIHsKLSAgICAgICAgICAgIHNraXAoIlNldHRpbmcgZXhwZXJpbWVu dGFsIHByb3BlcnRpZXMgZnJvbSBKUyBjb2RlIGlzbid0IHdvcmtpbmciKQogICAgICAgICAgICAg d2ViVmlldy5leHBlcmltZW50YWwuYWxlcnREaWFsb2cgPSBudWxsCiAgICAgICAgICAgICB3ZWJW aWV3LmxvYWQoUXQucmVzb2x2ZWRVcmwoIi4uL2NvbW1vbi9hbGVydC5odG1sIikpCiAgICAgICAg ICAgICBsb2FkU3B5LndhaXQoKQpAQCAtOTgsNyArOTcsNiBAQCBXZWJWaWV3IHsKICAgICAgICAg fQogCiAgICAgICAgIGZ1bmN0aW9uIHRlc3RfY29uZmlybVdpdGhvdXREaWFsb2coKSB7Ci0gICAg ICAgICAgICBza2lwKCJTZXR0aW5nIGV4cGVyaW1lbnRhbCBwcm9wZXJ0aWVzIGZyb20gSlMgY29k ZSBpc24ndCB3b3JraW5nIikKICAgICAgICAgICAgIHdlYlZpZXcuZXhwZXJpbWVudGFsLmNvbmZp cm1EaWFsb2cgPSBudWxsCiAgICAgICAgICAgICB3ZWJWaWV3LmxvYWQoUXQucmVzb2x2ZWRVcmwo Ii4uL2NvbW1vbi9jb25maXJtLmh0bWwiKSkKICAgICAgICAgICAgIGxvYWRTcHkud2FpdCgpCkBA IC0xMTYsNyArMTE0LDYgQEAgV2ViVmlldyB7CiAgICAgICAgIH0KIAogICAgICAgICBmdW5jdGlv biB0ZXN0X3Byb21wdFdpdGhvdXREaWFsb2coKSB7Ci0gICAgICAgICAgICBza2lwKCJTZXR0aW5n IGV4cGVyaW1lbnRhbCBwcm9wZXJ0aWVzIGZyb20gSlMgY29kZSBpc24ndCB3b3JraW5nIikKICAg ICAgICAgICAgIHdlYlZpZXcuZXhwZXJpbWVudGFsLnByb21wdERpYWxvZyA9IG51bGwKICAgICAg ICAgICAgIHdlYlZpZXcubG9hZChRdC5yZXNvbHZlZFVybCgiLi4vY29tbW9uL3Byb21wdC5odG1s IikpCiAgICAgICAgICAgICBsb2FkU3B5LndhaXQoKQo=