74171 2011-12-09 00:54:24 -0800 small style fix on DragDataBlackBerry.cpp 2011-12-09 17:01:21 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73144 0 mawu webkit-unassigned dbates tonikitoo webkit.review.bot oldest_to_newest 518166 0 mawu 2011-12-09 00:54:24 -0800 small style fix on DragDataBlackBerry.cpp 518167 1 118545 mawu 2011-12-09 00:59:48 -0800 Created attachment 118545 Patch 518181 2 118545 leo.yang 2011-12-09 01:41:16 -0800 Comment on attachment 118545 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118545&action=review Informal review. LGTM, only one nit. > Source/WebCore/ChangeLog:9 > + Style fix, no function impact, No new tests. > + No --> no 518196 3 118551 mawu 2011-12-09 02:25:00 -0800 Created attachment 118551 Patch 518218 4 118551 rwlbuis 2011-12-09 05:22:45 -0800 Comment on attachment 118551 Patch Looks good. 518649 5 118551 webkit.review.bot 2011-12-09 17:01:17 -0800 Comment on attachment 118551 Patch Clearing flags on attachment: 118551 Committed r102492: <http://trac.webkit.org/changeset/102492> 518650 6 webkit.review.bot 2011-12-09 17:01:21 -0800 All reviewed patches have been landed. Closing bug. 118545 2011-12-09 00:59:48 -0800 2011-12-09 02:24:48 -0800 Patch bug-74171-20111209165939.patch text/plain 2363 mawu U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWU4NzAzZTQ2NWQ2MDBk YWFmZmM0N2VkMGRlMzFmNTkzNmY4OTJkYy4uM2E4MDdlMTI3ZjNhNWIxYTg1YjY1ZDViZjQ5NDkz OTBhZjRlMTJmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTEyLTA5ICBNYXJ5 IFd1ICA8bWFyeS53dUB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgU21hbGwgc3R5bGUg Zml4IG9uIERyYWdEYXRhQmxhY2tCZXJyeS5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTc0MTcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU3R5bGUgZml4LCBubyBmdW5jdGlvbiBpbXBhY3QsIE5vIG5l dyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2JsYWNrYmVycnkvRHJhZ0RhdGFCbGFja0Jl cnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRyYWdEYXRhOjpjb250YWluc1VSTCk6CisgICAg ICAgIChXZWJDb3JlOjpEcmFnRGF0YTo6YXNGaWxlbmFtZXMpOgorICAgICAgICAoV2ViQ29yZTo6 RHJhZ0RhdGE6OmFzVVJMKToKKyAgICAgICAgKFdlYkNvcmU6OkRyYWdEYXRhOjphc0ZyYWdtZW50 KToKKwogMjAxMS0xMi0wNyAgTWFyeSBXdSAgPG1hcnkud3VAdG9yY2htb2JpbGUuY29tLmNuPgog CiAgICAgICAgIFVwc3RyZWFtIDQgZmlsZXMgaW50byBXZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVy cnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvRHJhZ0Rh dGFCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvRHJh Z0RhdGFCbGFja0JlcnJ5LmNwcAppbmRleCAyZDcwNjM0M2YwMWNjZTZhNjk3NmJjYThiODE4ZDBj ZDEzMGJjZjZiLi4zMjliYjgwMDIwMjlhNGMzNjM4NGFlN2M3OTdlMTFiOTc1MWE2ZTNmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0RyYWdEYXRhQmxhY2tC ZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9EcmFnRGF0 YUJsYWNrQmVycnkuY3BwCkBAIC01OCwxNSArNTgsMTQgQEAgYm9vbCBEcmFnRGF0YTo6Y29udGFp bnNQbGFpblRleHQoKSBjb25zdAogICAgIHJldHVybiBmYWxzZTsKIH0KIAotYm9vbCBEcmFnRGF0 YTo6Y29udGFpbnNVUkwoRnJhbWUqLCBGaWxlbmFtZUNvbnZlcnNpb25Qb2xpY3kgZmlsZW5hbWVQ b2xpY3kpIGNvbnN0Citib29sIERyYWdEYXRhOjpjb250YWluc1VSTChGcmFtZSosIEZpbGVuYW1l Q29udmVyc2lvblBvbGljeSkgY29uc3QKIHsKICAgICBub3RJbXBsZW1lbnRlZCgpOwogICAgIHJl dHVybiBmYWxzZTsKIH0KIAotdm9pZCBEcmFnRGF0YTo6YXNGaWxlbmFtZXMoV1RGOjpWZWN0b3I8 U3RyaW5nLCAwdT4mIHJlc3VsdCkgY29uc3QKK3ZvaWQgRHJhZ0RhdGE6OmFzRmlsZW5hbWVzKFZl Y3RvcjxTdHJpbmc+JikgY29uc3QKIHsKLSAgICAvLyBGSVhNRTogcmVtb3ZlIGV4cGxpY2l0IDAg c2l6ZSBpbiByZXN1bHQgdGVtcGxhdGUgb25jZSB0aGlzIGlzIGltcGxlbWVudGVkCiAgICAgbm90 SW1wbGVtZW50ZWQoKTsKIH0KIApAQCAtODIsMTQgKzgxLDEzIEBAIFN0cmluZyBEcmFnRGF0YTo6 YXNQbGFpblRleHQoRnJhbWUqKSBjb25zdAogICAgIHJldHVybiBTdHJpbmcoKTsKIH0KIAotU3Ry aW5nIERyYWdEYXRhOjphc1VSTChGcmFtZSosIEZpbGVuYW1lQ29udmVyc2lvblBvbGljeSBmaWxl bmFtZVBvbGljeSwgU3RyaW5nKiB0aXRsZSkgY29uc3QKK1N0cmluZyBEcmFnRGF0YTo6YXNVUkwo RnJhbWUqLCBGaWxlbmFtZUNvbnZlcnNpb25Qb2xpY3ksIFN0cmluZyopIGNvbnN0CiB7CiAgICAg bm90SW1wbGVtZW50ZWQoKTsKICAgICByZXR1cm4gU3RyaW5nKCk7CiB9CiAKLVdURjo6UGFzc1Jl ZlB0cjxEb2N1bWVudEZyYWdtZW50PiBEcmFnRGF0YTo6YXNGcmFnbWVudChGcmFtZSosIFBhc3NS ZWZQdHI8UmFuZ2U+IGNvbnRleHQsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGJvb2wgYWxsb3dQbGFpblRleHQsIGJvb2wmIGNob3NlUGxhaW5UZXh0KSBjb25z dAorUGFzc1JlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBEcmFnRGF0YTo6YXNGcmFnbWVudChGcmFt ZSosIFBhc3NSZWZQdHI8UmFuZ2U+LCBib29sLCBib29sJikgY29uc3QKIHsKICAgICBub3RJbXBs ZW1lbnRlZCgpOwogICAgIHJldHVybiAwOwo= 118551 2011-12-09 02:25:00 -0800 2011-12-09 17:01:17 -0800 Patch bug-74171-20111209182451.patch text/plain 2363 mawu U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWU4NzAzZTQ2NWQ2MDBk YWFmZmM0N2VkMGRlMzFmNTkzNmY4OTJkYy4uOTc2ZDM0ZWUwOWM4NzUxZGE4YTk0OTdiMzViNzFm NWYyNmI0YWM2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTEyLTA5ICBNYXJ5 IFd1ICA8bWFyeS53dUB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgU21hbGwgc3R5bGUg Zml4IG9uIERyYWdEYXRhQmxhY2tCZXJyeS5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTc0MTcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU3R5bGUgZml4LCBubyBmdW5jdGlvbiBpbXBhY3QsIG5vIG5l dyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2JsYWNrYmVycnkvRHJhZ0RhdGFCbGFja0Jl cnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRyYWdEYXRhOjpjb250YWluc1VSTCk6CisgICAg ICAgIChXZWJDb3JlOjpEcmFnRGF0YTo6YXNGaWxlbmFtZXMpOgorICAgICAgICAoV2ViQ29yZTo6 RHJhZ0RhdGE6OmFzVVJMKToKKyAgICAgICAgKFdlYkNvcmU6OkRyYWdEYXRhOjphc0ZyYWdtZW50 KToKKwogMjAxMS0xMi0wNyAgTWFyeSBXdSAgPG1hcnkud3VAdG9yY2htb2JpbGUuY29tLmNuPgog CiAgICAgICAgIFVwc3RyZWFtIDQgZmlsZXMgaW50byBXZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVy cnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvRHJhZ0Rh dGFCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvRHJh Z0RhdGFCbGFja0JlcnJ5LmNwcAppbmRleCAyZDcwNjM0M2YwMWNjZTZhNjk3NmJjYThiODE4ZDBj ZDEzMGJjZjZiLi4zMjliYjgwMDIwMjlhNGMzNjM4NGFlN2M3OTdlMTFiOTc1MWE2ZTNmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0RyYWdEYXRhQmxhY2tC ZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9EcmFnRGF0 YUJsYWNrQmVycnkuY3BwCkBAIC01OCwxNSArNTgsMTQgQEAgYm9vbCBEcmFnRGF0YTo6Y29udGFp bnNQbGFpblRleHQoKSBjb25zdAogICAgIHJldHVybiBmYWxzZTsKIH0KIAotYm9vbCBEcmFnRGF0 YTo6Y29udGFpbnNVUkwoRnJhbWUqLCBGaWxlbmFtZUNvbnZlcnNpb25Qb2xpY3kgZmlsZW5hbWVQ b2xpY3kpIGNvbnN0Citib29sIERyYWdEYXRhOjpjb250YWluc1VSTChGcmFtZSosIEZpbGVuYW1l Q29udmVyc2lvblBvbGljeSkgY29uc3QKIHsKICAgICBub3RJbXBsZW1lbnRlZCgpOwogICAgIHJl dHVybiBmYWxzZTsKIH0KIAotdm9pZCBEcmFnRGF0YTo6YXNGaWxlbmFtZXMoV1RGOjpWZWN0b3I8 U3RyaW5nLCAwdT4mIHJlc3VsdCkgY29uc3QKK3ZvaWQgRHJhZ0RhdGE6OmFzRmlsZW5hbWVzKFZl Y3RvcjxTdHJpbmc+JikgY29uc3QKIHsKLSAgICAvLyBGSVhNRTogcmVtb3ZlIGV4cGxpY2l0IDAg c2l6ZSBpbiByZXN1bHQgdGVtcGxhdGUgb25jZSB0aGlzIGlzIGltcGxlbWVudGVkCiAgICAgbm90 SW1wbGVtZW50ZWQoKTsKIH0KIApAQCAtODIsMTQgKzgxLDEzIEBAIFN0cmluZyBEcmFnRGF0YTo6 YXNQbGFpblRleHQoRnJhbWUqKSBjb25zdAogICAgIHJldHVybiBTdHJpbmcoKTsKIH0KIAotU3Ry aW5nIERyYWdEYXRhOjphc1VSTChGcmFtZSosIEZpbGVuYW1lQ29udmVyc2lvblBvbGljeSBmaWxl bmFtZVBvbGljeSwgU3RyaW5nKiB0aXRsZSkgY29uc3QKK1N0cmluZyBEcmFnRGF0YTo6YXNVUkwo RnJhbWUqLCBGaWxlbmFtZUNvbnZlcnNpb25Qb2xpY3ksIFN0cmluZyopIGNvbnN0CiB7CiAgICAg bm90SW1wbGVtZW50ZWQoKTsKICAgICByZXR1cm4gU3RyaW5nKCk7CiB9CiAKLVdURjo6UGFzc1Jl ZlB0cjxEb2N1bWVudEZyYWdtZW50PiBEcmFnRGF0YTo6YXNGcmFnbWVudChGcmFtZSosIFBhc3NS ZWZQdHI8UmFuZ2U+IGNvbnRleHQsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGJvb2wgYWxsb3dQbGFpblRleHQsIGJvb2wmIGNob3NlUGxhaW5UZXh0KSBjb25z dAorUGFzc1JlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBEcmFnRGF0YTo6YXNGcmFnbWVudChGcmFt ZSosIFBhc3NSZWZQdHI8UmFuZ2U+LCBib29sLCBib29sJikgY29uc3QKIHsKICAgICBub3RJbXBs ZW1lbnRlZCgpOwogICAgIHJldHVybiAwOwo=