<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>74160</bug_id>
          
          <creation_ts>2011-12-08 20:20:35 -0800</creation_ts>
          <short_desc>Use [Supplemental] IDL in WebSocket</short_desc>
          <delta_ts>2011-12-22 02:33:03 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>72138</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Kentaro Hara">haraken</reporter>
          <assigned_to name="Kentaro Hara">haraken</assigned_to>
          <cc>abarth</cc>
    
    <cc>dglazkov</cc>
    
    <cc>dominicc</cc>
    
    <cc>ojan</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>518069</commentid>
    <comment_count>0</comment_count>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2011-12-08 20:20:35 -0800</bug_when>
    <thetext>By using the [Supplemental] IDL, we can move declarations of WebSocket attributes from DOMWindow.idl to websocket/DOMWindowWebSocket.idl, which helps make WebSocket a self-contained module.

See bug 72138 for more details of our motivation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>518092</commentid>
    <comment_count>1</comment_count>
      <attachid>118526</attachid>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2011-12-08 21:12:48 -0800</bug_when>
    <thetext>Created attachment 118526
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>518102</commentid>
    <comment_count>2</comment_count>
      <attachid>118526</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-12-08 21:35:41 -0800</bug_when>
    <thetext>Comment on attachment 118526
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118526&amp;action=review

&gt; Source/WebCore/websockets/DOMWindowWebSocket.idl:37
&gt; +        attribute CloseEventConstructor CloseEvent;

Is CloseEvent specific to WebSockets?  I guess it is!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>518104</commentid>
    <comment_count>3</comment_count>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2011-12-08 21:37:09 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 118526 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=118526&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/websockets/DOMWindowWebSocket.idl:37
&gt; &gt; +        attribute CloseEventConstructor CloseEvent;
&gt; 
&gt; Is CloseEvent specific to WebSockets?  I guess it is!

Yes, it is!
http://dev.w3.org/html5/websockets/#closeevent</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>518105</commentid>
    <comment_count>4</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-12-08 21:38:52 -0800</bug_when>
    <thetext>We should do more build system integration.  I can help.  I&apos;ll try to do the Mac build tomorrow.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>518106</commentid>
    <comment_count>5</comment_count>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2011-12-08 21:44:39 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; We should do more build system integration.  I can help.  I&apos;ll try to do the Mac build tomorrow.

What do you mean by &quot;more build system integration&quot;?

After this patch is landed, I am planning to change build flows of all platforms as follows:

[1] Make a change on DerivedSources.make. (for Mac)
[2] Make a change on GNUmakefile.am and bindings/gobject/GNUmakefile.am. (for GTK)
[3] Make a change on DerivedSources.pri. (for Qt)
[4] Make a change on WebCore.vcproj/MigrateScripts and WebCore.vcproj/WebCore.vcproj. (for Win)
[5] Make a change on UseJSC.cmake, UseV8.cmake and PlatformBlackBerry.cmake. (for Efl, WinCE and BlackBerry)

Since ENABLE_WEBSOCKET is enabled on all platforms, I hope that now we can confirm if our build flow change is correct or not.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>518131</commentid>
    <comment_count>6</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-12-08 23:00:03 -0800</bug_when>
    <thetext>Sounds great.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>518585</commentid>
    <comment_count>7</comment_count>
      <attachid>118526</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-12-09 15:32:45 -0800</bug_when>
    <thetext>Comment on attachment 118526
Patch

Attachment 118526 did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10833373</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>518991</commentid>
    <comment_count>8</comment_count>
      <attachid>118726</attachid>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2011-12-11 20:48:37 -0800</bug_when>
    <thetext>Created attachment 118726
rebased patch for commit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>519028</commentid>
    <comment_count>9</comment_count>
      <attachid>118726</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-12-11 23:01:45 -0800</bug_when>
    <thetext>Comment on attachment 118726
rebased patch for commit

Clearing flags on attachment: 118726

Committed r102558: &lt;http://trac.webkit.org/changeset/102558&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>519150</commentid>
    <comment_count>10</comment_count>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2011-12-12 05:39:25 -0800</bug_when>
    <thetext>Reverted r102558 for reason:

clobber build failure

Committed r102571: &lt;http://trac.webkit.org/changeset/102571&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>520897</commentid>
    <comment_count>11</comment_count>
      <attachid>118726</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-12-14 06:13:48 -0800</bug_when>
    <thetext>Comment on attachment 118726
rebased patch for commit

Clearing flags on attachment: 118726

Committed r102774: &lt;http://trac.webkit.org/changeset/102774&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>118526</attachid>
            <date>2011-12-08 21:12:48 -0800</date>
            <delta_ts>2011-12-22 02:33:03 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-74160-20111209141246.patch</filename>
            <type>text/plain</type>
            <size>5619</size>
            <attacher name="Kentaro Hara">haraken</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjM4OTU4Y2MxOTNjMzg2
ZDQxYjNlNzIyMWM4M2UwZWU5ODg0MWEwOS4uYjE0ZTJhZDM3Y2UxZjZkZDQwYjBlMWZiYTJlYTkw
YWE2YTU2NTQ3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDExLTEyLTA4ICBLZW50
YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBVc2UgW1N1cHBsZW1l
bnRhbF0gSURMIGluIFdlYlNvY2tldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9NzQxNjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICBCeSB1c2luZyB0aGUgW1N1cHBsZW1lbnRhbF0gSURMLCB0aGlzIHBhdGNo
IG1vdmVzIGRlY2xhcmF0aW9ucyBvZiBXZWJTb2NrZXQKKyAgICAgICAgYXR0cmlidXRlcyBmcm9t
IERPTVdpbmRvdy5pZGwgdG8gd2Vic29ja2V0L0RPTVdpbmRvd1dlYlNvY2tldC5pZGwsCisgICAg
ICAgIHdoaWNoIGhlbHBzIG1ha2UgV2ViU29ja2V0IGEgc2VsZi1jb250YWluZWQgbW9kdWxlLgor
CisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdlIGluIGJlaGF2aW9yLgorICAgICAgICBD
b25maXJtIHRoYXQgaHR0cC90ZXN0cy93ZWJzb2NrZXQvKiBwYXNzLgorCisgICAgICAgICogV2Vi
Q29yZS5neXBpOiBBZGRlZCBET01XaW5kb3dXZWJTb2NrZXQuaWRsLgorICAgICAgICAqIHBhZ2Uv
RE9NV2luZG93LmlkbDogQWRkZWQgdGhlIFtTdXBwbGVtZW50ZWRdIElETCB0byBXZWJTb2NrZXQt
cmVsYXRlZCBhdHRyaWJ1dGVzLiBUaGlzIFtTdXBwbGVtZW50ZWRdIElETCB3aWxsIGJlIHJlbW92
ZWQgYWZ0ZXIgYWxsIHBsYXRmb3JtcyBzdXBwb3J0IHRoZSBbU3VwcGxlbWVudGFsXSBJREwgKFNl
ZSBidWcgNzMzOTQgZm9yIG1vcmUgZGV0YWlscykuCisgICAgICAgICogd2Vic29ja2V0cy9ET01X
aW5kb3dXZWJTb2NrZXQuaWRsOiBBZGRlZC4gVXNlZCB0aGUgW1N1cHBsZW1lbnRhbD1ET01XaW5k
b3ddIElETC4gVGhlIGF0dHJpYnV0ZXMgaW4gdGhpcyBJREwgZmlsZSBhcmUgdHJlYXRlZCBhcyBp
ZiB0aGV5IGFyZSBkZXNjcmliZWQgaW4gRE9NV2luZG93LmlkbC4KKwogMjAxMS0xMi0wOCAgS2Vu
dCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQnVpbGQgZml4IGZvciBy
MTAyNDE5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXBpIGIvU291cmNl
L1dlYkNvcmUvV2ViQ29yZS5neXBpCmluZGV4IGI4ZTM1N2FlOWE0ZDRjYzdlZmRhMGM1NjJiYzMx
ZjhkZWEwYTkyYjYuLjc2MDhjMzcwZTQ5MTM0YWUyNjdkZjdiN2I0ZmVkYWI1YmYzYTk1ZTIgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwaQorKysgYi9Tb3VyY2UvV2ViQ29y
ZS9XZWJDb3JlLmd5cGkKQEAgLTE1MDUsNiArMTUwNSw3IEBACiAgICAgICAgICAgICAnd2ViYXVk
aW8vUmVhbHRpbWVBbmFseXNlck5vZGUuaWRsJywKICAgICAgICAgICAgICd3ZWJhdWRpby9XYXZl
U2hhcGVyTm9kZS5pZGwnLAogICAgICAgICAgICAgJ3dlYnNvY2tldHMvQ2xvc2VFdmVudC5pZGwn
LAorICAgICAgICAgICAgJ3dlYnNvY2tldHMvRE9NV2luZG93V2ViU29ja2V0LmlkbCcsCiAgICAg
ICAgICAgICAnd2Vic29ja2V0cy9XZWJTb2NrZXQuaWRsJywKICAgICAgICAgICAgICd3b3JrZXJz
L0Fic3RyYWN0V29ya2VyLmlkbCcsCiAgICAgICAgICAgICAnd29ya2Vycy9EZWRpY2F0ZWRXb3Jr
ZXJDb250ZXh0LmlkbCcsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRv
dy5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwKaW5kZXggNWM4ZGUwZThl
OGRmZGE4YWM5NzA2NDFmZmJkZjhlMjlkNTYzYWIwOC4uZDk2NjQ5NzgxNzJhMWRkNzI4YzgzNzIy
OTI3Mjg5Y2ExMDllYzdlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5k
b3cuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbApAQCAtNTUwLDcg
KzU1MCw3IEBAIG1vZHVsZSB3aW5kb3cgewogICAgICAgICBhdHRyaWJ1dGUgW0NvbmRpdGlvbmFs
PURFVklDRV9PUklFTlRBVElPTiwgRW5hYmxlZEF0UnVudGltZV0gRGV2aWNlTW90aW9uRXZlbnRD
b25zdHJ1Y3RvciBEZXZpY2VNb3Rpb25FdmVudDsKICAgICAgICAgYXR0cmlidXRlIFtDb25kaXRp
b25hbD1ERVZJQ0VfT1JJRU5UQVRJT04sIEVuYWJsZWRBdFJ1bnRpbWVdIERldmljZU9yaWVudGF0
aW9uRXZlbnRDb25zdHJ1Y3RvciBEZXZpY2VPcmllbnRhdGlvbkV2ZW50OwogICAgICAgICBhdHRy
aWJ1dGUgW0NvbmRpdGlvbmFsPVRPVUNIX0VWRU5UU10gVG91Y2hFdmVudENvbnN0cnVjdG9yIFRv
dWNoRXZlbnQ7Ci0gICAgICAgIGF0dHJpYnV0ZSBbQ29uZGl0aW9uYWw9V0VCX1NPQ0tFVFNdIENs
b3NlRXZlbnRDb25zdHJ1Y3RvciBDbG9zZUV2ZW50OworICAgICAgICBhdHRyaWJ1dGUgW1N1cHBs
ZW1lbnRlZCwgQ29uZGl0aW9uYWw9V0VCX1NPQ0tFVFNdIENsb3NlRXZlbnRDb25zdHJ1Y3RvciBD
bG9zZUV2ZW50OwogICAgICAgICBhdHRyaWJ1dGUgU3RvcmFnZUV2ZW50Q29uc3RydWN0b3IgU3Rv
cmFnZUV2ZW50OwogICAgICAgICBhdHRyaWJ1dGUgW1N1cHBsZW1lbnRlZCwgQ29uZGl0aW9uYWw9
V0VCX0FVRElPXSBBdWRpb1Byb2Nlc3NpbmdFdmVudENvbnN0cnVjdG9yIEF1ZGlvUHJvY2Vzc2lu
Z0V2ZW50OwogICAgICAgICBhdHRyaWJ1dGUgW1N1cHBsZW1lbnRlZCwgQ29uZGl0aW9uYWw9V0VC
X0FVRElPXSBPZmZsaW5lQXVkaW9Db21wbGV0aW9uRXZlbnRDb25zdHJ1Y3RvciBPZmZsaW5lQXVk
aW9Db21wbGV0aW9uRXZlbnQ7CkBAIC02MDYsNyArNjA2LDcgQEAgbW9kdWxlIHdpbmRvdyB7CiAj
ZW5kaWYKIAogI2lmIGRlZmluZWQoRU5BQkxFX1dFQl9TT0NLRVRTKSAmJiBFTkFCTEVfV0VCX1NP
Q0tFVFMKLSAgICAgICAgYXR0cmlidXRlIFtKU0NDdXN0b21HZXR0ZXIsRW5hYmxlZEF0UnVudGlt
ZV0gV2ViU29ja2V0Q29uc3RydWN0b3IgV2ViU29ja2V0OyAvLyBVc2FibGUgd2l0aCB0aGUgbmV3
IG9wZXJhdG9yCisgICAgICAgIGF0dHJpYnV0ZSBbU3VwcGxlbWVudGVkLCBKU0NDdXN0b21HZXR0
ZXIsIEVuYWJsZWRBdFJ1bnRpbWVdIFdlYlNvY2tldENvbnN0cnVjdG9yIFdlYlNvY2tldDsgLy8g
VXNhYmxlIHdpdGggdGhlIG5ldyBvcGVyYXRvcgogI2VuZGlmCiAKICNpZiBkZWZpbmVkKEVOQUJM
RV9WSURFT19UUkFDSykgJiYgRU5BQkxFX1ZJREVPX1RSQUNLCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViQ29yZS93ZWJzb2NrZXRzL0RPTVdpbmRvd1dlYlNvY2tldC5pZGwgYi9Tb3VyY2UvV2ViQ29y
ZS93ZWJzb2NrZXRzL0RPTVdpbmRvd1dlYlNvY2tldC5pZGwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK
aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uM2E3NjQ3NGVk
ZjA0ZTA5Y2JmNWZlYTdjOTg0ZmI0YzIwMGM1MjFhNgotLS0gL2Rldi9udWxsCisrKyBiL1NvdXJj
ZS9XZWJDb3JlL3dlYnNvY2tldHMvRE9NV2luZG93V2ViU29ja2V0LmlkbApAQCAtMCwwICsxLDQx
IEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDExIEdvb2dsZSBJbmMuICBBbGwgcmlnaHRzIHJl
c2VydmVkLgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5h
cnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVk
IHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQorICogbWV0OgorICoK
KyAqICAgICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUg
YWJvdmUgY29weXJpZ2h0CisgKiBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0
aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisgKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmlu
YXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlCisgKiBjb3B5cmlnaHQgbm90aWNlLCB0
aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyCisgKiBp
biB0aGUgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGgg
dGhlCisgKiBkaXN0cmlidXRpb24uCisgKiAgICAgKiBOZWl0aGVyIHRoZSBuYW1lIG9mIEdvb2ds
ZSBJbmMuIG5vciB0aGUgbmFtZXMgb2YgaXRzCisgKiBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQg
dG8gZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQorICogdGhpcyBzb2Z0
d2FyZSB3aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4KKyAqCisgKiBU
SElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09O
VFJJQlVUT1JTCisgKiAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJ
RVMsIElOQ0xVRElORywgQlVUIE5PVAorICogTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FSUkFO
VElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCisgKiBBIFBBUlRJQ1VMQVIg
UFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlSSUdIVAor
ICogT1dORVIgT1IgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJF
Q1QsIElOQ0lERU5UQUwsCisgKiBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwg
REFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UCisgKiBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBP
RiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwKKyAqIERBVEEsIE9S
IFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9O
IEFOWQorICogVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNU
IExJQUJJTElUWSwgT1IgVE9SVAorICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lT
RSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisgKiBPRiBUSElTIFNPRlRXQVJF
LCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICov
CisKK21vZHVsZSB3aW5kb3cgeworCisgICAgaW50ZXJmYWNlIFsKKyAgICAgICAgQ29uZGl0aW9u
YWw9V0VCX1NPQ0tFVFMsCisgICAgICAgIFN1cHBsZW1lbnRhbD1ET01XaW5kb3cKKyAgICBdIERP
TVdpbmRvd1dlYlNvY2tldCB7CisgICAgICAgIGF0dHJpYnV0ZSBDbG9zZUV2ZW50Q29uc3RydWN0
b3IgQ2xvc2VFdmVudDsKKyAgICAgICAgYXR0cmlidXRlIFtKU0NDdXN0b21HZXR0ZXIsIEVuYWJs
ZWRBdFJ1bnRpbWVdIFdlYlNvY2tldENvbnN0cnVjdG9yIFdlYlNvY2tldDsgLy8gVXNhYmxlIHdp
dGggdGhlIG5ldyBvcGVyYXRvcgorICAgIH07CisKK30K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>118726</attachid>
            <date>2011-12-11 20:48:37 -0800</date>
            <delta_ts>2011-12-14 06:13:48 -0800</delta_ts>
            <desc>rebased patch for commit</desc>
            <filename>bug-74160-20111212134836.patch</filename>
            <type>text/plain</type>
            <size>5696</size>
            <attacher name="Kentaro Hara">haraken</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGNiNGVmNzVlZDIyMzNk
ZTBhOTcwODE4Y2RiM2JkZDFlMjAzODU4Ny4uMzhlZWZiYmVhMzlhYzczZWRmZWRiZTU3YzU1NjJj
YzE5MDdkMDNjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDExLTEyLTExICBLZW50
YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBVc2UgW1N1cHBsZW1l
bnRhbF0gSURMIGluIFdlYlNvY2tldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9NzQxNjAKKworICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgor
CisgICAgICAgIEJ5IHVzaW5nIHRoZSBbU3VwcGxlbWVudGFsXSBJREwsIHRoaXMgcGF0Y2ggbW92
ZXMgZGVjbGFyYXRpb25zIG9mIFdlYlNvY2tldAorICAgICAgICBhdHRyaWJ1dGVzIGZyb20gRE9N
V2luZG93LmlkbCB0byB3ZWJzb2NrZXQvRE9NV2luZG93V2ViU29ja2V0LmlkbCwKKyAgICAgICAg
d2hpY2ggaGVscHMgbWFrZSBXZWJTb2NrZXQgYSBzZWxmLWNvbnRhaW5lZCBtb2R1bGUuCisKKyAg
ICAgICAgTm8gbmV3IHRlc3RzLCBubyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisgICAgICAgIENvbmZp
cm0gdGhhdCBodHRwL3Rlc3RzL3dlYnNvY2tldC8qIHBhc3MuCisKKyAgICAgICAgKiBXZWJDb3Jl
Lmd5cGk6IEFkZGVkIERPTVdpbmRvd1dlYlNvY2tldC5pZGwuCisgICAgICAgICogcGFnZS9ET01X
aW5kb3cuaWRsOiBBZGRlZCB0aGUgW1N1cHBsZW1lbnRlZF0gSURMIHRvIFdlYlNvY2tldC1yZWxh
dGVkIGF0dHJpYnV0ZXMuIFRoaXMgW1N1cHBsZW1lbnRlZF0gSURMIHdpbGwgYmUgcmVtb3ZlZCBh
ZnRlciBhbGwgcGxhdGZvcm1zIHN1cHBvcnQgdGhlIFtTdXBwbGVtZW50YWxdIElETCAoU2VlIGJ1
ZyA3MzM5NCBmb3IgbW9yZSBkZXRhaWxzKS4KKyAgICAgICAgKiB3ZWJzb2NrZXRzL0RPTVdpbmRv
d1dlYlNvY2tldC5pZGw6IEFkZGVkLiBVc2VkIHRoZSBbU3VwcGxlbWVudGFsPURPTVdpbmRvd10g
SURMLiBUaGUgYXR0cmlidXRlcyBpbiB0aGlzIElETCBmaWxlIGFyZSB0cmVhdGVkIGFzIGlmIHRo
ZXkgYXJlIGRlc2NyaWJlZCBpbiBET01XaW5kb3cuaWRsLgorCiAyMDExLTEyLTExICBMdWtlIE1h
Y3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW1wbGVtZW50
IHdlYmtpdC1saW5lLWdyaWQgYW5kIHdlYmtpdC1saW5lLWdyaWQtc25hcCBDU1MgcHJvcGVydGll
cyBpbiBDU1NTdHlsZUFwcGx5UHJvcGVydHkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9X
ZWJDb3JlLmd5cGkgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cGkKaW5kZXggMTU4YTIwNGFi
NTUyNDMzYzMxNzlhMGFkYTcyYWFjYzU1NWY5ZDhhYi4uZTZiOGI0MmVjNGExMTU0MWU5MDUwZTEw
NmIwMjM1MTU5NWUzM2M2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXBp
CisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwaQpAQCAtMTUwNiw2ICsxNTA2LDcgQEAK
ICAgICAgICAgICAgICd3ZWJhdWRpby9SZWFsdGltZUFuYWx5c2VyTm9kZS5pZGwnLAogICAgICAg
ICAgICAgJ3dlYmF1ZGlvL1dhdmVTaGFwZXJOb2RlLmlkbCcsCiAgICAgICAgICAgICAnd2Vic29j
a2V0cy9DbG9zZUV2ZW50LmlkbCcsCisgICAgICAgICAgICAnd2Vic29ja2V0cy9ET01XaW5kb3dX
ZWJTb2NrZXQuaWRsJywKICAgICAgICAgICAgICd3ZWJzb2NrZXRzL1dlYlNvY2tldC5pZGwnLAog
ICAgICAgICAgICAgJ3dvcmtlcnMvQWJzdHJhY3RXb3JrZXIuaWRsJywKICAgICAgICAgICAgICd3
b3JrZXJzL0RlZGljYXRlZFdvcmtlckNvbnRleHQuaWRsJywKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93
LmlkbAppbmRleCA1YzhkZTBlOGU4ZGZkYThhYzk3MDY0MWZmYmRmOGUyOWQ1NjNhYjA4Li5kOTY2
NDk3ODE3MmExZGQ3MjhjODM3MjI5MjcyODljYTEwOWVjN2ViIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01X
aW5kb3cuaWRsCkBAIC01NTAsNyArNTUwLDcgQEAgbW9kdWxlIHdpbmRvdyB7CiAgICAgICAgIGF0
dHJpYnV0ZSBbQ29uZGl0aW9uYWw9REVWSUNFX09SSUVOVEFUSU9OLCBFbmFibGVkQXRSdW50aW1l
XSBEZXZpY2VNb3Rpb25FdmVudENvbnN0cnVjdG9yIERldmljZU1vdGlvbkV2ZW50OwogICAgICAg
ICBhdHRyaWJ1dGUgW0NvbmRpdGlvbmFsPURFVklDRV9PUklFTlRBVElPTiwgRW5hYmxlZEF0UnVu
dGltZV0gRGV2aWNlT3JpZW50YXRpb25FdmVudENvbnN0cnVjdG9yIERldmljZU9yaWVudGF0aW9u
RXZlbnQ7CiAgICAgICAgIGF0dHJpYnV0ZSBbQ29uZGl0aW9uYWw9VE9VQ0hfRVZFTlRTXSBUb3Vj
aEV2ZW50Q29uc3RydWN0b3IgVG91Y2hFdmVudDsKLSAgICAgICAgYXR0cmlidXRlIFtDb25kaXRp
b25hbD1XRUJfU09DS0VUU10gQ2xvc2VFdmVudENvbnN0cnVjdG9yIENsb3NlRXZlbnQ7CisgICAg
ICAgIGF0dHJpYnV0ZSBbU3VwcGxlbWVudGVkLCBDb25kaXRpb25hbD1XRUJfU09DS0VUU10gQ2xv
c2VFdmVudENvbnN0cnVjdG9yIENsb3NlRXZlbnQ7CiAgICAgICAgIGF0dHJpYnV0ZSBTdG9yYWdl
RXZlbnRDb25zdHJ1Y3RvciBTdG9yYWdlRXZlbnQ7CiAgICAgICAgIGF0dHJpYnV0ZSBbU3VwcGxl
bWVudGVkLCBDb25kaXRpb25hbD1XRUJfQVVESU9dIEF1ZGlvUHJvY2Vzc2luZ0V2ZW50Q29uc3Ry
dWN0b3IgQXVkaW9Qcm9jZXNzaW5nRXZlbnQ7CiAgICAgICAgIGF0dHJpYnV0ZSBbU3VwcGxlbWVu
dGVkLCBDb25kaXRpb25hbD1XRUJfQVVESU9dIE9mZmxpbmVBdWRpb0NvbXBsZXRpb25FdmVudENv
bnN0cnVjdG9yIE9mZmxpbmVBdWRpb0NvbXBsZXRpb25FdmVudDsKQEAgLTYwNiw3ICs2MDYsNyBA
QCBtb2R1bGUgd2luZG93IHsKICNlbmRpZgogCiAjaWYgZGVmaW5lZChFTkFCTEVfV0VCX1NPQ0tF
VFMpICYmIEVOQUJMRV9XRUJfU09DS0VUUwotICAgICAgICBhdHRyaWJ1dGUgW0pTQ0N1c3RvbUdl
dHRlcixFbmFibGVkQXRSdW50aW1lXSBXZWJTb2NrZXRDb25zdHJ1Y3RvciBXZWJTb2NrZXQ7IC8v
IFVzYWJsZSB3aXRoIHRoZSBuZXcgb3BlcmF0b3IKKyAgICAgICAgYXR0cmlidXRlIFtTdXBwbGVt
ZW50ZWQsIEpTQ0N1c3RvbUdldHRlciwgRW5hYmxlZEF0UnVudGltZV0gV2ViU29ja2V0Q29uc3Ry
dWN0b3IgV2ViU29ja2V0OyAvLyBVc2FibGUgd2l0aCB0aGUgbmV3IG9wZXJhdG9yCiAjZW5kaWYK
IAogI2lmIGRlZmluZWQoRU5BQkxFX1ZJREVPX1RSQUNLKSAmJiBFTkFCTEVfVklERU9fVFJBQ0sK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvRE9NV2luZG93V2ViU29ja2V0
LmlkbCBiL1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvRE9NV2luZG93V2ViU29ja2V0LmlkbApu
ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwLi4zYTc2NDc0ZWRmMDRlMDljYmY1ZmVhN2M5ODRmYjRjMjAwYzUyMWE2Ci0tLSAv
ZGV2L251bGwKKysrIGIvU291cmNlL1dlYkNvcmUvd2Vic29ja2V0cy9ET01XaW5kb3dXZWJTb2Nr
ZXQuaWRsCkBAIC0wLDAgKzEsNDEgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTEgR29vZ2xl
IEluYy4gIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVz
ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmlj
YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv
bnMgYXJlCisgKiBtZXQ6CisgKgorICogICAgICogUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBj
b2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqIG5vdGljZSwgdGhpcyBsaXN0
IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyAqICAgICAqIFJl
ZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUKKyAq
IGNvcHlyaWdodCBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93
aW5nIGRpc2NsYWltZXIKKyAqIGluIHRoZSBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRl
cmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUKKyAqIGRpc3RyaWJ1dGlvbi4KKyAqICAgICAqIE5laXRo
ZXIgdGhlIG5hbWUgb2YgR29vZ2xlIEluYy4gbm9yIHRoZSBuYW1lcyBvZiBpdHMKKyAqIGNvbnRy
aWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJvZHVjdHMgZGVyaXZl
ZCBmcm9tCisgKiB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBw
ZXJtaXNzaW9uLgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlS
SUdIVCBIT0xERVJTIEFORCBDT05UUklCVVRPUlMKKyAqICJBUyBJUyIgQU5EIEFOWSBFWFBSRVNT
IE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UCisgKiBMSU1JVEVEIFRP
LCBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBG
T1IKKyAqIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBT
SEFMTCBUSEUgQ09QWVJJR0hUCisgKiBPV05FUiBPUiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZP
UiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwKKyAqIFNQRUNJQUwsIEVYRU1QTEFS
WSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QKKyAqIExJTUlU
RUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1Mg
T0YgVVNFLAorICogREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBI
T1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZCisgKiBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVS
IElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5F
R0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UK
KyAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkg
T0YgU1VDSCBEQU1BR0UuCisgKi8KKworbW9kdWxlIHdpbmRvdyB7CisKKyAgICBpbnRlcmZhY2Ug
WworICAgICAgICBDb25kaXRpb25hbD1XRUJfU09DS0VUUywKKyAgICAgICAgU3VwcGxlbWVudGFs
PURPTVdpbmRvdworICAgIF0gRE9NV2luZG93V2ViU29ja2V0IHsKKyAgICAgICAgYXR0cmlidXRl
IENsb3NlRXZlbnRDb25zdHJ1Y3RvciBDbG9zZUV2ZW50OworICAgICAgICBhdHRyaWJ1dGUgW0pT
Q0N1c3RvbUdldHRlciwgRW5hYmxlZEF0UnVudGltZV0gV2ViU29ja2V0Q29uc3RydWN0b3IgV2Vi
U29ja2V0OyAvLyBVc2FibGUgd2l0aCB0aGUgbmV3IG9wZXJhdG9yCisgICAgfTsKKworfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>