74038 2011-12-07 16:43:53 -0800 [V8][Chromium] Support legacy argument order in window.postMessage/window.webkitPostMessage 2011-12-07 22:59:32 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 74045 1 dslomov dslomov abarth caseq dslomov japhet levin webkit.review.bot oldest_to_newest 516993 0 dslomov 2011-12-07 16:43:53 -0800 Current spec for window.postMessage states the following argument list for postMessage: postMessage(msg, targetOrigin [, transferables]) However, legacy implementation in WebKit used a different order: postMessage(msg [, transferables], targetOrigin). Changing this in https://bugs.webkit.org/show_bug.cgi?id=73589 was a backwards-incompatible change. 517004 1 dslomov 2011-12-07 17:09:31 -0800 Link to the current (editor's draft) spec: http://dev.w3.org/html5/postmsg/#posting-messages 517017 2 118292 dslomov 2011-12-07 17:35:15 -0800 Created attachment 118292 Fix This fix accepts legacy argument order (postMessage(msg, transferables, targetOrigin)) when third argument is a string. This is not 100% backward-compatible (previous version was also working for objects whose toString returned a valid target origin), but I think it is close enough so as not to break the Internet. 517045 3 118292 caseq 2011-12-07 18:00:10 -0800 Comment on attachment 118292 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=118292&action=review Why are we doing this for V8 bindings only? > Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp:318 > + if (isLegacyTargetOriginDesignation(args[2])) { It might be worth issuing a deprecation warning message to the console when the compatibility logic kicks in. 517050 4 dslomov 2011-12-07 18:03:06 -0800 (In reply to comment #3) > (From update of attachment 118292 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=118292&action=review > > Why are we doing this for V8 bindings only? JSC patch will follow (https://bugs.webkit.org/show_bug.cgi?id=73691). > > > Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp:318 > > + if (isLegacyTargetOriginDesignation(args[2])) { > > It might be worth issuing a deprecation warning message to the console when the compatibility logic kicks in. How to do that? Any examples? Will issuing message to the console cause perf regression? 517067 5 caseq 2011-12-07 18:14:09 -0800 > > Why are we doing this for V8 bindings only? > > JSC patch will follow (https://bugs.webkit.org/show_bug.cgi?id=73691). I think it logically belongs to a single patch, along with DOMWindow.idl change. > > It might be worth issuing a deprecation warning message to the console when the compatibility logic kicks in. > > How to do that? Any examples? Check out this: http://www.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/dom/UIEvent.cpp&exact_package=chromium&l=108 Or this: http://www.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/webaudio/AudioContext.cpp&exact_package=chromium&ct=rc&cd=4&l=392 > Will issuing message to the console cause perf regression? Not sure if this is critical, but if it is, we could limit the number of time we issue the message. 517068 6 dslomov 2011-12-07 18:16:38 -0800 (In reply to comment #5) > > > Why are we doing this for V8 bindings only? > > > > JSC patch will follow (https://bugs.webkit.org/show_bug.cgi?id=73691). > > I think it logically belongs to a single patch, along with DOMWindow.idl change. > > > > It might be worth issuing a deprecation warning message to the console when the compatibility logic kicks in. > > > > How to do that? Any examples? > > Check out this: > > http://www.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/dom/UIEvent.cpp&exact_package=chromium&l=108 Thank you - looks really simple. Will add. 517088 7 dslomov 2011-12-07 18:34:06 -0800 (In reply to comment #6) > (In reply to comment #5) > > > > Why are we doing this for V8 bindings only? > > > > > > JSC patch will follow (https://bugs.webkit.org/show_bug.cgi?id=73691). > > > > I think it logically belongs to a single patch, along with DOMWindow.idl change. > > > > > > It might be worth issuing a deprecation warning message to the console when the compatibility logic kicks in. > > > > > > How to do that? Any examples? > > > > Check out this: > > > > http://www.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/dom/UIEvent.cpp&exact_package=chromium&l=108 > > Thank you - looks really simple. Will add. On second thoughts, this will cause deprecation warnings in (shipping) chrome extensions, so coordinated changes in them will be required. In the interest of making this patch as small as possible, this will be done in a separate patch: https://bugs.webkit.org/show_bug.cgi?id=74045 517109 8 dslomov 2011-12-07 19:05:34 -0800 (In reply to comment #6) > (In reply to comment #5) > > > > Why are we doing this for V8 bindings only? > > > > > > JSC patch will follow (https://bugs.webkit.org/show_bug.cgi?id=73691). > > > > I think it logically belongs to a single patch, along with DOMWindow.idl change. > > I do not think this is necessary. JSC bindings as in the tree today implement legacy behavior, following DOMWindow.idl. Let us keep patches small. 517200 9 118292 webkit.review.bot 2011-12-07 22:59:27 -0800 Comment on attachment 118292 Fix Clearing flags on attachment: 118292 Committed r102317: <http://trac.webkit.org/changeset/102317> 517201 10 webkit.review.bot 2011-12-07 22:59:32 -0800 All reviewed patches have been landed. Closing bug. 118292 2011-12-07 17:35:15 -0800 2011-12-07 22:59:27 -0800 Fix 74038.patch text/plain 9205 dslomov ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwYWNjYjQ2Li4yMDU0NzYxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMTIt MDcgIERtaXRyeSBMb21vdiAgPGRzbG9tb3ZAZ29vZ2xlLmNvbT4KKworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQwMzgKKyAgICAgICAgW1Y4XVtDaHJv bWl1bV0gU3VwcG9ydCBsZWdhY3kgYXJndW1lbnQgb3JkZXIgaW4gd2luZG93LnBvc3RNZXNzYWdl L3dpbmRvdy53ZWJraXRQb3N0TWVzc2FnZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9zdG1lc3NhZ2Ut YXJncy1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9kb20vV2luZG93L3dpbmRvdy1wb3N0 bWVzc2FnZS1hcmdzLmh0bWw6IE5ldyB0ZXN0cyBmb3IgbGVnYWN5IGFyZ3VtZW50IG9yZGVyLgor ICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9zdG1l c3NhZ2UtYXJncy1leHBlY3RlZC50eHQ6CisKIDIwMTEtMTItMDcgIEJhbGF6cyBLZWxlbWVuICA8 a2JhbGF6c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF1bV0syXSBSRUdSRVNTSU9OKDEwMjIy OCk6IGxvdCBvZiB0ZXN0IGZhaWx1cmVzIGFmdGVyIGVuYWJsZWQgcGFnZSBjYWNoZQpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy1wb3N0bWVzc2FnZS1hcmdz LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9zdG1l c3NhZ2UtYXJncy1leHBlY3RlZC50eHQKaW5kZXggZmM3ZGYxNC4uODYwZTU1ZCAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy1wb3N0bWVzc2FnZS1hcmdzLWV4 cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXBvc3Rt ZXNzYWdlLWFyZ3MtZXhwZWN0ZWQudHh0CkBAIC04LDExICs4LDE0IEBAIFBBU1M6IFBvc3Rpbmcg bWVzc2FnZSAoJzMnLCBbb2JqZWN0IE9iamVjdF0pOiB0aHJldyBleGNlcHRpb24gVHlwZUVycm9y OiBUeXBlIGVyCiBQQVNTOiBQb3N0aW5nIG1lc3NhZ2UgKCczJywgW29iamVjdCBPYmplY3RdKTog dGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogVHlwZSBlcnJvcgogRkFJTDogUG9zdGluZyBtZXNz YWdlICgnNCcsIFtvYmplY3QgRE9NV2luZG93XSk6IHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6 IFR5cGUgZXJyb3IKIEZBSUw6IFBvc3RpbmcgbWVzc2FnZSAoJzQnLCBbb2JqZWN0IERPTVdpbmRv d10pOiB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBUeXBlIGVycm9yCitQQVNTOiBQb3N0aW5n IG1lc3NhZ2UgKCc0YScsICopIGRpZCBub3QgdGhyb3cgYW4gZXhjZXB0aW9uCitQQVNTOiBQb3N0 aW5nIG1lc3NhZ2UgKCc0YScsICopIGRpZCBub3QgdGhyb3cgYW4gZXhjZXB0aW9uCiBQQVNTOiBQ b3N0aW5nIG1lc3NhZ2UgKCc1JywgbnVsbCkgZGlkIG5vdCB0aHJvdyBhbiBleGNlcHRpb24KIFBB U1M6IFBvc3RpbmcgbWVzc2FnZSAoJzUnLCBudWxsKSBkaWQgbm90IHRocm93IGFuIGV4Y2VwdGlv bgogUEFTUzogUG9zdGluZyBtZXNzYWdlICgnNicsIHVuZGVmaW5lZCkgZGlkIG5vdCB0aHJvdyBh biBleGNlcHRpb24KIFBBU1M6IFBvc3RpbmcgbWVzc2FnZSAoJzYnLCB1bmRlZmluZWQpIGRpZCBu b3QgdGhyb3cgYW4gZXhjZXB0aW9uCiBGQUlMOiBQb3N0aW5nIG1lc3NhZ2UgKCc3JywgW29iamVj dCBNZXNzYWdlUG9ydF0sW29iamVjdCBNZXNzYWdlUG9ydF0pOiB0aHJldyBleGNlcHRpb24gVHlw ZUVycm9yOiBUeXBlIGVycm9yCitQQVNTOiBQb3N0aW5nIG1lc3NhZ2UgKCc3YScsICopIGRpZCBu b3QgdGhyb3cgYW4gZXhjZXB0aW9uCiBGQUlMOiBQb3N0aW5nIG1lc3NhZ2UgKCc3JywgW29iamVj dCBNZXNzYWdlUG9ydF0sW29iamVjdCBNZXNzYWdlUG9ydF0pOiB0aHJldyBleGNlcHRpb24gVHlw ZUVycm9yOiBUeXBlIGVycm9yCiBQQVNTOiBQb3N0aW5nIG1lc3NhZ2UgKCcyMTQ3NDgzNjQ4Jywg bnVsbCkgZGlkIG5vdCB0aHJvdyBhbiBleGNlcHRpb24KIFBBU1M6IFBvc3RpbmcgbWVzc2FnZSAo JzIxNDc0ODM2NDgnLCBudWxsKSBkaWQgbm90IHRocm93IGFuIGV4Y2VwdGlvbgpAQCAtMjMsMTAg KzI2LDEzIEBAIEZBSUw6IFBvc3RpbmcgbWVzc2FnZSAoJ1tvYmplY3QgQXJyYXlCdWZmZXJdJywg W29iamVjdCBBcnJheUJ1ZmZlcl0pOiB0aHJldyBleGNlCiBGQUlMOiBhcnJheUJ1ZmZlciBub3Qg bmV1dGVyZWQ7IGJ5dGVMZW5ndGggPSAzMAogRkFJTDogdmlldyB3YXMgbm90IG5ldXRlcmVkOyBs ZW5ndGggPSAxMAogUEFTUzogUG9zdGluZyBtZXNzYWdlICgnZG9uZScsIHVuZGVmaW5lZCkgZGlk IG5vdCB0aHJvdyBhbiBleGNlcHRpb24KK1JlY2VpdmVkIG1lc3NhZ2UgJzRhJyB3aXRoIDAgcG9y dHMuCitSZWNlaXZlZCBtZXNzYWdlICc0YScgd2l0aCAwIHBvcnRzLgogUmVjZWl2ZWQgbWVzc2Fn ZSAnNScgd2l0aCAwIHBvcnRzLgogUmVjZWl2ZWQgbWVzc2FnZSAnNScgd2l0aCAwIHBvcnRzLgog UmVjZWl2ZWQgbWVzc2FnZSAnNicgd2l0aCAwIHBvcnRzLgogUmVjZWl2ZWQgbWVzc2FnZSAnNicg d2l0aCAwIHBvcnRzLgorUmVjZWl2ZWQgbWVzc2FnZSAnN2EnIHdpdGggMiBwb3J0cy4KIFJlY2Vp dmVkIG1lc3NhZ2UgJzIxNDc0ODM2NDgnIHdpdGggMCBwb3J0cy4KIFJlY2VpdmVkIG1lc3NhZ2Ug JzIxNDc0ODM2NDgnIHdpdGggMCBwb3J0cy4KIFJlY2VpdmVkIG1lc3NhZ2UgJ2RvbmUnIHdpdGgg MCBwb3J0cy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ct cG9zdG1lc3NhZ2UtYXJncy5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRv dy1wb3N0bWVzc2FnZS1hcmdzLmh0bWwKaW5kZXggNWU0MjRmNC4uNDU5NDFkNiAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy1wb3N0bWVzc2FnZS1hcmdzLmh0 bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy1wb3N0bWVzc2FnZS1h cmdzLmh0bWwKQEAgLTQ2LDEwICs0NiwxMyBAQCB0cnlQb3N0TWVzc2FnZSgnMScsICcqJywgMSwg dHJ1ZSk7CiB0cnlQb3N0TWVzc2FnZSgnMicsICcqJywgJ2MnLCB0cnVlKTsKIHRyeVBvc3RNZXNz YWdlKCczJywgJyonLCB7IHg6IDEgfSwgdHJ1ZSk7CiB0cnlQb3N0TWVzc2FnZSgnNCcsICcqJywg d2luZG93KTsgIC8vIFBhc3NlcyBiZWNhdXNlIHdpbmRvdyBoYXMgYSAibGVuZ3RoIiBhdHRyaWJ1 dGUgb2YgdmFsdWUgJzAnLCBzbyBpdCBsb29rcyBsaWtlIGFuIGFycmF5Cit0cnlQb3N0TWVzc2Fn ZSgnNGEnLCB3aW5kb3csICcqJyk7IC8vIExlZ2FjeSBhcmd1bWVudCBvcmRlci4KIHRyeVBvc3RN ZXNzYWdlKCc1JywgJyonLCBudWxsKTsKIHRyeVBvc3RNZXNzYWdlKCc2JywgJyonLCB2b2lkIDAp OwogdmFyIGNoYW5uZWwxID0gbmV3IE1lc3NhZ2VDaGFubmVsOwogdHJ5UG9zdE1lc3NhZ2VGdW5j dGlvbih3aW5kb3cucG9zdE1lc3NhZ2UsICc3JywgJyonLCBbY2hhbm5lbDEucG9ydDEsIGNoYW5u ZWwxLnBvcnQyXSk7Cit2YXIgY2hhbm5lbDFhID0gbmV3IE1lc3NhZ2VDaGFubmVsOwordHJ5UG9z dE1lc3NhZ2VGdW5jdGlvbih3aW5kb3cucG9zdE1lc3NhZ2UsICc3YScsIFtjaGFubmVsMWEucG9y dDEsIGNoYW5uZWwxYS5wb3J0Ml0sICcqJyk7CiB2YXIgY2hhbm5lbDIgPSBuZXcgTWVzc2FnZUNo YW5uZWw7CiB0cnlQb3N0TWVzc2FnZUZ1bmN0aW9uKHdpbmRvdy53ZWJraXRQb3N0TWVzc2FnZSwg JzcnLCAnKicsIFtjaGFubmVsMi5wb3J0MSwgY2hhbm5lbDIucG9ydDJdKTsKIHZhciBjaGFubmVs MyA9IG5ldyBNZXNzYWdlQ2hhbm5lbDsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L2Nocm9taXVtL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9zdG1lc3NhZ2UtYXJncy1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L2RvbS9XaW5kb3cvd2lu ZG93LXBvc3RtZXNzYWdlLWFyZ3MtZXhwZWN0ZWQudHh0CmluZGV4IDhmMmE1NjkuLmNkNmYyNDgg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2Zhc3QvZG9tL1dpbmRv dy93aW5kb3ctcG9zdG1lc3NhZ2UtYXJncy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vY2hyb21pdW0vZmFzdC9kb20vV2luZG93L3dpbmRvdy1wb3N0bWVzc2FnZS1hcmdz LWV4cGVjdGVkLnR4dApAQCAtOCwxMSArOCwxNCBAQCBQQVNTOiBQb3N0aW5nIG1lc3NhZ2UgKCcz JywgW29iamVjdCBPYmplY3RdKTogdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogVHJhbnNmZQog UEFTUzogUG9zdGluZyBtZXNzYWdlICgnMycsIFtvYmplY3QgT2JqZWN0XSk6IHRocmV3IGV4Y2Vw dGlvbiBUeXBlRXJyb3I6IFRyYW5zZmVyQXJyYXkgYXJndW1lbnQgaGFzIG5vIGxlbmd0aCBhdHRy aWJ1dGUKIFBBU1M6IFBvc3RpbmcgbWVzc2FnZSAoJzQnLCBbb2JqZWN0IERPTVdpbmRvd10pIGRp ZCBub3QgdGhyb3cgYW4gZXhjZXB0aW9uCiBQQVNTOiBQb3N0aW5nIG1lc3NhZ2UgKCc0JywgW29i amVjdCBET01XaW5kb3ddKSBkaWQgbm90IHRocm93IGFuIGV4Y2VwdGlvbgorUEFTUzogUG9zdGlu ZyBtZXNzYWdlICgnNGEnLCAqKSBkaWQgbm90IHRocm93IGFuIGV4Y2VwdGlvbgorUEFTUzogUG9z dGluZyBtZXNzYWdlICgnNGEnLCAqKSBkaWQgbm90IHRocm93IGFuIGV4Y2VwdGlvbgogUEFTUzog UG9zdGluZyBtZXNzYWdlICgnNScsIG51bGwpIGRpZCBub3QgdGhyb3cgYW4gZXhjZXB0aW9uCiBQ QVNTOiBQb3N0aW5nIG1lc3NhZ2UgKCc1JywgbnVsbCkgZGlkIG5vdCB0aHJvdyBhbiBleGNlcHRp b24KIFBBU1M6IFBvc3RpbmcgbWVzc2FnZSAoJzYnLCB1bmRlZmluZWQpIGRpZCBub3QgdGhyb3cg YW4gZXhjZXB0aW9uCiBQQVNTOiBQb3N0aW5nIG1lc3NhZ2UgKCc2JywgdW5kZWZpbmVkKSBkaWQg bm90IHRocm93IGFuIGV4Y2VwdGlvbgogUEFTUzogUG9zdGluZyBtZXNzYWdlICgnNycsIFtvYmpl Y3QgTWVzc2FnZVBvcnRdLFtvYmplY3QgTWVzc2FnZVBvcnRdKSBkaWQgbm90IHRocm93IGFuIGV4 Y2VwdGlvbgorUEFTUzogUG9zdGluZyBtZXNzYWdlICgnN2EnLCAqKSBkaWQgbm90IHRocm93IGFu IGV4Y2VwdGlvbgogUEFTUzogUG9zdGluZyBtZXNzYWdlICgnNycsIFtvYmplY3QgTWVzc2FnZVBv cnRdLFtvYmplY3QgTWVzc2FnZVBvcnRdKSBkaWQgbm90IHRocm93IGFuIGV4Y2VwdGlvbgogUEFT UzogUG9zdGluZyBtZXNzYWdlICgnMjE0NzQ4MzY0OCcsIG51bGwpIGRpZCBub3QgdGhyb3cgYW4g ZXhjZXB0aW9uCiBQQVNTOiBQb3N0aW5nIG1lc3NhZ2UgKCcyMTQ3NDgzNjQ4JywgbnVsbCkgZGlk IG5vdCB0aHJvdyBhbiBleGNlcHRpb24KQEAgLTI1LDExICsyOCwxNCBAQCBQQVNTOiB2aWV3IG5l dXRlcmVkCiBQQVNTOiBQb3N0aW5nIG1lc3NhZ2UgKCdkb25lJywgdW5kZWZpbmVkKSBkaWQgbm90 IHRocm93IGFuIGV4Y2VwdGlvbgogUmVjZWl2ZWQgbWVzc2FnZSAnNCcgd2l0aCAwIHBvcnRzLgog UmVjZWl2ZWQgbWVzc2FnZSAnNCcgd2l0aCAwIHBvcnRzLgorUmVjZWl2ZWQgbWVzc2FnZSAnNGEn IHdpdGggMCBwb3J0cy4KK1JlY2VpdmVkIG1lc3NhZ2UgJzRhJyB3aXRoIDAgcG9ydHMuCiBSZWNl aXZlZCBtZXNzYWdlICc1JyB3aXRoIDAgcG9ydHMuCiBSZWNlaXZlZCBtZXNzYWdlICc1JyB3aXRo IDAgcG9ydHMuCiBSZWNlaXZlZCBtZXNzYWdlICc2JyB3aXRoIDAgcG9ydHMuCiBSZWNlaXZlZCBt ZXNzYWdlICc2JyB3aXRoIDAgcG9ydHMuCiBSZWNlaXZlZCBtZXNzYWdlICc3JyB3aXRoIDIgcG9y dHMuCitSZWNlaXZlZCBtZXNzYWdlICc3YScgd2l0aCAyIHBvcnRzLgogUmVjZWl2ZWQgbWVzc2Fn ZSAnNycgd2l0aCAyIHBvcnRzLgogUmVjZWl2ZWQgbWVzc2FnZSAnMjE0NzQ4MzY0OCcgd2l0aCAw IHBvcnRzLgogUmVjZWl2ZWQgbWVzc2FnZSAnMjE0NzQ4MzY0OCcgd2l0aCAwIHBvcnRzLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IDQ3NWM5YWQuLjI2NTM1NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAxMS0xMi0wNyAgRG1pdHJ5IExvbW92ICA8ZHNsb21vdkBnb29nbGUuY29tPgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDAzOAorICAgICAgICBb VjhdW0Nocm9taXVtXSBTdXBwb3J0IGxlZ2FjeSBhcmd1bWVudCBvcmRlciBpbiB3aW5kb3cucG9z dE1lc3NhZ2Uvd2luZG93LndlYmtpdFBvc3RNZXNzYWdlLgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2lu ZG93Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmlzTGVnYWN5VGFyZ2V0T3JpZ2luRGVz aWduYXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6aGFuZGxlUG9zdE1lc3NhZ2VDYWxsYmFjayk6 CisKIDIwMTEtMTEtMzAgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29t PgogCiAgICAgICAgIFtRdF0gVjggYnVpbGQgZml4ZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0b20uY3BwIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93Q3VzdG9tLmNwcAppbmRleCBmNzVj NTEyLi41YmRmZjE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0 b20vVjhET01XaW5kb3dDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L2N1c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHAKQEAgLTI4Niw2ICsyODYsMTQgQEAgdjg6Okhh bmRsZTx2ODo6VmFsdWU+IFY4RE9NV2luZG93OjpyZW1vdmVFdmVudExpc3RlbmVyQ2FsbGJhY2so Y29uc3Qgdjg6OkFyZ3VtZW4KICAgICByZXR1cm4gdjg6OlVuZGVmaW5lZCgpOwogfQogCitzdGF0 aWMgYm9vbCBpc0xlZ2FjeVRhcmdldE9yaWdpbkRlc2lnbmF0aW9uKHY4OjpIYW5kbGU8djg6OlZh bHVlPiB2YWx1ZSkKK3sKKyAgICBpZiAodmFsdWUtPklzU3RyaW5nKCkgfHwgdmFsdWUtPklzU3Ry aW5nT2JqZWN0KCkpCisgICAgICAgIHJldHVybiB0cnVlOworICAgIHJldHVybiBmYWxzZTsKK30K KworCiBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGhhbmRsZVBvc3RNZXNzYWdlQ2FsbGJh Y2soY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJncywgYm9vbCBleHRlbmRlZFRyYW5zZmVyKQogewog ICAgIERPTVdpbmRvdyogd2luZG93ID0gVjhET01XaW5kb3c6OnRvTmF0aXZlKGFyZ3MuSG9sZGVy KCkpOwpAQCAtMjkzLDIwICszMDEsMjggQEAgc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBo YW5kbGVQb3N0TWVzc2FnZUNhbGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MKICAgICBE T01XaW5kb3cqIHNvdXJjZSA9IFY4UHJveHk6OnJldHJpZXZlRnJhbWVGb3JDYWxsaW5nQ29udGV4 dCgpLT5kb21XaW5kb3coKTsKICAgICBBU1NFUlQoc291cmNlLT5mcmFtZSgpKTsKIAotICAgIC8v IFRoaXMgZnVuY3Rpb24gaGFzIHZhcmlhYmxlIGFyZ3VtZW50cyBhbmQgY2FuIGVpdGhlciBiZToK LSAgICAvLyAgIHBvc3RNZXNzYWdlKG1lc3NhZ2UsIHBvcnQsIHRhcmdldE9yaWdpbik7Ci0gICAg Ly8gb3IKLSAgICAvLyAgIHBvc3RNZXNzYWdlKG1lc3NhZ2UsIHRhcmdldE9yaWdpbik7CisgICAg Ly8gVGhpcyBmdW5jdGlvbiBoYXMgdmFyaWFibGUgYXJndW1lbnRzIGFuZCBjYW4gYmU6CisgICAg Ly8gUGVyIGN1cnJlbnQgc3BlYzoKKyAgICAvLyAgIHBvc3RNZXNzYWdlKG1lc3NhZ2UsIHRhcmdl dE9yaWdpbikKKyAgICAvLyAgIHBvc3RNZXNzYWdlKG1lc3NhZ2UsIHRhcmdldE9yaWdpbiwge3Nl cXVlbmNlIG9mIHRyYW5zZmVycmFibGVzfSkKKyAgICAvLyBMZWdhY3kgbm9uLXN0YW5kYXJkIGlt cGxlbWVudGF0aW9ucyBpbiB3ZWJraXQgYWxsb3dlZDoKKyAgICAvLyAgIHBvc3RNZXNzYWdlKG1l c3NhZ2UsIHtzZXF1ZW5jZSBvZiB0cmFuc2ZlcnJhYmxlc30sIHRhcmdldE9yaWdpbik7CiAgICAg TWVzc2FnZVBvcnRBcnJheSBwb3J0QXJyYXk7CiAgICAgQXJyYXlCdWZmZXJBcnJheSBhcnJheUJ1 ZmZlckFycmF5OwogICAgIFN0cmluZyB0YXJnZXRPcmlnaW47CiAgICAgewogICAgICAgICB2ODo6 VHJ5Q2F0Y2ggdHJ5Q2F0Y2g7CisgICAgICAgIGludCB0YXJnZXRPcmlnaW5BcmdJbmRleCA9IDE7 CiAgICAgICAgIGlmIChhcmdzLkxlbmd0aCgpID4gMikgewotICAgICAgICAgICAgaWYgKCFleHRy YWN0VHJhbnNmZXJhYmxlcyhhcmdzWzJdLCBwb3J0QXJyYXksIGFycmF5QnVmZmVyQXJyYXkpKQor ICAgICAgICAgICAgaW50IHRyYW5zZmVyYWJsZXNBcmdJbmRleCA9IDI7CisgICAgICAgICAgICBp ZiAoaXNMZWdhY3lUYXJnZXRPcmlnaW5EZXNpZ25hdGlvbihhcmdzWzJdKSkgeworICAgICAgICAg ICAgICAgIHRhcmdldE9yaWdpbkFyZ0luZGV4ID0gMjsKKyAgICAgICAgICAgICAgICB0cmFuc2Zl cmFibGVzQXJnSW5kZXggPSAxOworICAgICAgICAgICAgfQorICAgICAgICAgICAgaWYgKCFleHRy YWN0VHJhbnNmZXJhYmxlcyhhcmdzW3RyYW5zZmVyYWJsZXNBcmdJbmRleF0sIHBvcnRBcnJheSwg YXJyYXlCdWZmZXJBcnJheSkpCiAgICAgICAgICAgICAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQo KTsKICAgICAgICAgfSAKLSAgICAgICAgdGFyZ2V0T3JpZ2luID0gdG9XZWJDb3JlU3RyaW5nV2l0 aE51bGxPclVuZGVmaW5lZENoZWNrKGFyZ3NbMV0pOworICAgICAgICB0YXJnZXRPcmlnaW4gPSB0 b1dlYkNvcmVTdHJpbmdXaXRoTnVsbE9yVW5kZWZpbmVkQ2hlY2soYXJnc1t0YXJnZXRPcmlnaW5B cmdJbmRleF0pOwogCiAgICAgICAgIGlmICh0cnlDYXRjaC5IYXNDYXVnaHQoKSkKICAgICAgICAg ICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKCk7Cg==