73997 2011-12-07 06:05:06 -0800 [Chromium] Exclude the four RenderTableCellDeathTest death tests for Android 2011-12-08 12:16:50 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66689 1 peter peter abarth jchaffraix webkit.review.bot oldest_to_newest 516605 0 peter 2011-12-07 06:05:06 -0800 [Chromium] Exclude the four RenderTableCellDeathTest death tests for Android 516606 1 118201 peter 2011-12-07 06:08:14 -0800 Created attachment 118201 Patch 516607 2 peter 2011-12-07 06:11:14 -0800 Julien, could you have a look? Alternative would be to exclude the file from the build, but having some (in this case, 4 out of 8) tests is still better than none. 516646 3 118201 jchaffraix 2011-12-07 08:10:03 -0800 Comment on attachment 118201 Patch Those tests are more FYI than anything however disabling tests like that would need more explanations. Why is ASSERT_DEATH not available? Not implemented? Not possible to support on the Android platform? Do we have something tracking re-adding them? (skipping / disabling tests is easy but then we forget about them and that's what I fear here) 516698 4 peter 2011-12-07 10:06:52 -0800 Google Test has not been updated to recognize and support Android yet, and this is a requirement in order to enable the ASSERT_DEATH (or EXPECT_DEATH) macros as these are guarded per platform. http://code.google.com/p/googletest/source/browse/trunk/include/gtest/internal/gtest-port.h#545 Would it work if I file a bug here to track this, and refer to that in the comment? 516705 5 jchaffraix 2011-12-07 10:13:56 -0800 (In reply to comment #4) > Google Test has not been updated to recognize and support Android yet, and this is a requirement in order to enable the ASSERT_DEATH (or EXPECT_DEATH) macros as these are guarded per platform. > > http://code.google.com/p/googletest/source/browse/trunk/include/gtest/internal/gtest-port.h#545 > > Would it work if I file a bug here to track this, and refer to that in the comment? Totally, it's just to make sure that we don't forget about the tests. Would be nice to refer to a Google Test bug too so that we can easily determine when to toggle the test on. 517418 6 118390 peter 2011-12-08 07:50:45 -0800 Created attachment 118390 Updated patch (In reply to comment #5) > Totally, it's just to make sure that we don't forget about the tests. Would be nice to refer to a Google Test bug too so that we can easily determine when to toggle the test on. I filed a WebKit Bug 74089. Upstream CL is http://codereview.appspot.com/5464048, but it may take quite a while before the updated GTest becomes available in Source/WebKit/chromium/, while this currently is a compile error. 517529 7 118390 jchaffraix 2011-12-08 10:33:45 -0800 Comment on attachment 118390 Updated patch Thanks for filing the different bugs! 517669 8 118390 webkit.review.bot 2011-12-08 12:16:45 -0800 Comment on attachment 118390 Updated patch Clearing flags on attachment: 118390 Committed r102362: <http://trac.webkit.org/changeset/102362> 517670 9 webkit.review.bot 2011-12-08 12:16:50 -0800 All reviewed patches have been landed. Closing bug. 118201 2011-12-07 06:08:14 -0800 2011-12-08 07:50:45 -0800 Patch bug-73997-20111207140812.patch text/plain 1821 peter U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMjMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDEyNGRiMDFiZGFkYTUxNWI4NGNiNjFhOWFiZTZjMjNmZTJmOTE2ZGYuLjBhOWNhOTYxMDJmMjg2 NmU2N2RlNDMzMWI1YTFlMDViN2MwNjVmY2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMTItMDcgIFBldGVyIEJldmVybG9vICA8cGV0ZXJAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gRXhjbHVkZSB0aGUgZm91ciBSZW5kZXJUYWJs ZUNlbGxEZWF0aFRlc3QgZGVhdGggdGVzdHMgZm9yIEFuZHJvaWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczOTk3CisKKyAgICAgICAgVGhlIEFTU0VS VF9ERUFUSCBtYWNybyBpcyBub3QgYXZhaWxhYmxlIGluIEdvb2dsZSBUZXN0IHdoZW4KKyAgICAg ICAgYnVpbGRpbmcgZm9yIEFuZHJvaWQsIGNhdXNpbmcgZm91ciBvZiB0aGUgdGVzdHMgaW4gdGhl CisgICAgICAgIFJlbmRlclRhYmxlQ2VsbFRlc3QgY2xhc3MgdG8gdGhyb3cgY29tcGlsYXRpb24g ZXJyb3JzLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogdGVzdHMvUmVuZGVyVGFibGVDZWxsVGVzdC5jcHA6CisKIDIwMTEtMTItMDYgIERpcmsgUHJh bmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRml4IHR5cG8gaW4gV2ViS2l0 Lmd5cCBpbnRyb2R1Y2VkIGluIHByZXZpb3VzIGNoYW5nZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vdGVzdHMvUmVuZGVyVGFibGVDZWxsVGVzdC5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3Rlc3RzL1JlbmRlclRhYmxlQ2VsbFRlc3QuY3BwCmluZGV4IDVkNTM2Yzhi NWY5ZDdkZTNkNWIxOTRkZmRmMDc1ZjJjM2U5Zjk5NzEuLjA5YzYzNDVmMzFiZTliYjI4NjQ0MWIz OTJmYTJkMjg5M2E0MzUyMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVz dHMvUmVuZGVyVGFibGVDZWxsVGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90 ZXN0cy9SZW5kZXJUYWJsZUNlbGxUZXN0LmNwcApAQCAtMTEwLDYgKzExMCwxMCBAQCBURVNUX0Yo UmVuZGVyVGFibGVDZWxsRGVhdGhUZXN0LCBDYW5TZXRSb3dUb01heFJvd0luZGV4KQogICAgIEVY UEVDVF9FUShtYXhSb3dJbmRleCwgbV9jZWxsLT5yb3coKSk7CiB9CiAKKy8vIEdvb2dsZSBUZXN0 IGRvZXMgbm90IHN1cHBvcnQgdGhlIEFTU0VSVF9ERUFUSCBtYWNybyBmb3IgQW5kcm9pZCB5ZXQs CisvLyB0aHVzIGlzIG5vdCBhYmxlIHRvIGJ1aWxkIG9yIGV4ZWN1dGUgdGhlIGZvbGxvd2luZyBm b3VyIHRlc3RzLgorI2lmICFPUyhBTkRST0lEKQorCiBURVNUX0YoUmVuZGVyVGFibGVDZWxsRGVh dGhUZXN0LCBDcmFzaElmQ29sdW1uT3ZlcmZsb3dPblNldHRpbmcpCiB7CiAgICAgQVNTRVJUX0RF QVRIKG1fY2VsbC0+c2V0Q29sKG1heENvbHVtbkluZGV4ICsgMSksICIiKTsKQEAgLTEzMCw2ICsx MzQsOCBAQCBURVNUX0YoUmVuZGVyVGFibGVDZWxsRGVhdGhUZXN0LCBDcmFzaElmU2V0dGluZ1Vu c2V0Um93SW5kZXgpCiAgICAgQVNTRVJUX0RFQVRIKG1fY2VsbC0+c2V0Um93KHVuc2V0Um93SW5k ZXgpLCAiIik7CiB9CiAKKyNlbmRpZgorCiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK 118390 2011-12-08 07:50:45 -0800 2011-12-08 12:16:45 -0800 Updated patch rtct-2.patch text/plain 1749 peter ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggNTY5YmJiOC4uNzQ2NmQ3YyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0xMi0wOCAgUGV0ZXIgQmV2 ZXJsb28gIDxwZXRlckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBFeGNsdWRl IHRoZSBmb3VyIFJlbmRlclRhYmxlQ2VsbERlYXRoVGVzdCBkZWF0aCB0ZXN0cyBmb3IgQW5kcm9p ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM5OTcK KworICAgICAgICBUaGUgQVNTRVJUX0RFQVRIIG1hY3JvIGlzIG5vdCB5ZXQgYXZhaWxhYmxlIGlu IEdvb2dsZSBUZXN0IHdoZW4KKyAgICAgICAgYnVpbGRpbmcgZm9yIEFuZHJvaWQsIHdoaWNoIGNh dXNlcyBjb21waWxhdGlvbiBlcnJvcnMuIFRoaXMgY29kZQorICAgICAgICB3aWxsIGJlIHJlbW92 ZWQgb25jZSBzdXBwb3J0IGxhbmRzIGluIHRoZSBHVGVzdCB2ZXJzaW9uIENocm9taXVtCisgICAg ICAgIHVzZXMuIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQw ODkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0 ZXN0cy9SZW5kZXJUYWJsZUNlbGxUZXN0LmNwcDoKKwogMjAxMS0xMi0wNyAgQWxleGFuZHJlIEVs aWFzICA8YWVsaWFzQGdvb2dsZS5jb20+CiAKICAgICAgICAgW2Nocm9taXVtXSBBZGQgcGFnZS1z Y2FsZSBhbmltYXRpb24gc3VwcG9ydCB0byBJbXBsIHRocmVhZApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS90ZXN0cy9SZW5kZXJUYWJsZUNlbGxUZXN0LmNwcCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vdGVzdHMvUmVuZGVyVGFibGVDZWxsVGVzdC5jcHAKaW5kZXggNWQ1MzZj OC4uMDQ5YjUzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9SZW5k ZXJUYWJsZUNlbGxUZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1Jl bmRlclRhYmxlQ2VsbFRlc3QuY3BwCkBAIC0xMTAsNiArMTEwLDEwIEBAIFRFU1RfRihSZW5kZXJU YWJsZUNlbGxEZWF0aFRlc3QsIENhblNldFJvd1RvTWF4Um93SW5kZXgpCiAgICAgRVhQRUNUX0VR KG1heFJvd0luZGV4LCBtX2NlbGwtPnJvdygpKTsKIH0KIAorLy8gRklYTUU6IFJlLWVuYWJsZSB0 aGVzZSB0ZXN0cyBvbmNlIEFTU0VSVF9ERUFUSCBpcyBzdXBwb3J0ZWQgZm9yIEFuZHJvaWQuCisv LyBTZWU6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDA4OQorI2lm ICFPUyhBTkRST0lEKQorCiBURVNUX0YoUmVuZGVyVGFibGVDZWxsRGVhdGhUZXN0LCBDcmFzaElm Q29sdW1uT3ZlcmZsb3dPblNldHRpbmcpCiB7CiAgICAgQVNTRVJUX0RFQVRIKG1fY2VsbC0+c2V0 Q29sKG1heENvbHVtbkluZGV4ICsgMSksICIiKTsKQEAgLTEzMCw2ICsxMzQsOCBAQCBURVNUX0Yo UmVuZGVyVGFibGVDZWxsRGVhdGhUZXN0LCBDcmFzaElmU2V0dGluZ1Vuc2V0Um93SW5kZXgpCiAg ICAgQVNTRVJUX0RFQVRIKG1fY2VsbC0+c2V0Um93KHVuc2V0Um93SW5kZXgpLCAiIik7CiB9CiAK KyNlbmRpZgorCiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK