<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>73843</bug_id>
          
          <creation_ts>2011-12-05 10:41:04 -0800</creation_ts>
          <short_desc>nrwt exits early too frequently</short_desc>
          <delta_ts>2012-06-11 14:18:21 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>88680</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryosuke Niwa">rniwa</reporter>
          <assigned_to name="Dirk Pranke">dpranke</assigned_to>
          <cc>abarth</cc>
    
    <cc>aroben</cc>
    
    <cc>dpranke</cc>
    
    <cc>eric</cc>
    
    <cc>jberlin</cc>
    
    <cc>lforschler</cc>
    
    <cc>ojan</cc>
    
    <cc>ossy</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>515184</commentid>
    <comment_count>0</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-12-05 10:41:04 -0800</bug_when>
    <thetext>Exiting early after a mere 20+ tests timed out or crashed seems too disruptive. This has happened very frequently on Mac port for example:
http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29?numbuilds=100

We probably need to tolerate more tests to time out / crash.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>515193</commentid>
    <comment_count>1</comment_count>
      <attachid>117899</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-12-05 10:47:33 -0800</bug_when>
    <thetext>Created attachment 117899
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>515206</commentid>
    <comment_count>2</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2011-12-05 11:02:07 -0800</bug_when>
    <thetext>Part of the point of this policy was to avoid slowing down the bots too much when some low-level crash is introduced in WebKit. In many cases, all 20 tests will have crashed for the same reason, and any other tests that would have been run would also have crashed for the same reason, so running more tests doesn&apos;t give more diagnostic information. And since we have to wait for Crash Reporter for each crashed test, running more tests can significantly slow down the bots.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>515209</commentid>
    <comment_count>3</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-12-05 11:03:57 -0800</bug_when>
    <thetext>I don&apos;t think you want to change this.  At least not unless you fix https://bugs.webkit.org/show_bug.cgi?id=37797.  But I don&apos;t think we want that behavior on the bots anyway.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>515211</commentid>
    <comment_count>4</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-12-05 11:05:00 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; Part of the point of this policy was to avoid slowing down the bots too much when some low-level crash is introduced in WebKit. In many cases, all 20 tests will have crashed for the same reason, and any other tests that would have been run would also have crashed for the same reason, so running more tests doesn&apos;t give more diagnostic information. And since we have to wait for Crash Reporter for each crashed test, running more tests can significantly slow down the bots.

Right. However, in the world where we have multiple worker processes, 20 might be unrealistically low since many tests that get paged out temporarily will end up taking much longer time to run. This problem might go away once you add more RAM to Mac bots.

For example, I haven&apos;t had this issue on my MacPro (has 12GB of RAM).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>515214</commentid>
    <comment_count>5</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-12-05 11:07:04 -0800</bug_when>
    <thetext>It is possible we should re-evaluate this for the multi-proesss world.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>515280</commentid>
    <comment_count>6</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2011-12-05 12:22:17 -0800</bug_when>
    <thetext>I don&apos;t think we need to re-evaluate this. I think we need to fix the bugs that are causing these timeouts.

For comparison, we don&apos;t have these issues on the chromium bots, and no one has found the exit-early behavior to be a problem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>644979</commentid>
    <comment_count>7</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2012-06-08 13:23:08 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; I don&apos;t think we need to re-evaluate this. I think we need to fix the bugs that are causing these timeouts.

If we can fix the underlying issues, that&apos;s clearly the best resolution.

&gt; For comparison, we don&apos;t have these issues on the chromium bots, and no one has found the exit-early behavior to be a problem.

Is this just because we have a lot of tests listed as expected to timeout/crash flakily so they don&apos;t contribute to the count?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>645158</commentid>
    <comment_count>8</comment_count>
      <attachid>146669</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-06-08 17:52:30 -0700</bug_when>
    <thetext>Created attachment 146669
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>645159</commentid>
    <comment_count>9</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-06-08 17:53:03 -0700</bug_when>
    <thetext>rniwa / ojan, please take a look?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>645169</commentid>
    <comment_count>10</comment_count>
      <attachid>146673</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-06-08 18:14:53 -0700</bug_when>
    <thetext>Created attachment 146673
change 0 to None</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>645180</commentid>
    <comment_count>11</comment_count>
      <attachid>146673</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-06-08 18:26:24 -0700</bug_when>
    <thetext>Comment on attachment 146673
change 0 to None

setting cq- because we should update the chromium bots to pass these flags first.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>645217</commentid>
    <comment_count>12</comment_count>
      <attachid>146673</attachid>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2012-06-08 19:42:15 -0700</bug_when>
    <thetext>Comment on attachment 146673
change 0 to None

I&apos;d prefer a test showing that None does what we think it does.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>645442</commentid>
    <comment_count>13</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-06-09 20:17:37 -0700</bug_when>
    <thetext>(In reply to comment #12)
&gt; (From update of attachment 146673 [details])
&gt; I&apos;d prefer a test showing that None does what we think it does.

I&apos;m not entirely sure what you&apos;re looking for? It&apos;s the default argument, so the code path is being executed. However, I&apos;m not sure how we would demonstrate that we never exit early? Given that there are many tests that include failures, is that sufficient? E.g., run_webkit_tests_integrationtest.MainTest.test_all shows that we run all of the tests and that N of them fail ...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>645544</commentid>
    <comment_count>14</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2012-06-10 09:09:11 -0700</bug_when>
    <thetext>(In reply to comment #13)
&gt; (In reply to comment #12)
&gt; &gt; (From update of attachment 146673 [details] [details])
&gt; &gt; I&apos;d prefer a test showing that None does what we think it does.
&gt; 
&gt; I&apos;m not entirely sure what you&apos;re looking for? It&apos;s the default argument, so the code path is being executed. However, I&apos;m not sure how we would demonstrate that we never exit early? Given that there are many tests that include failures, is that sufficient? E.g., run_webkit_tests_integrationtest.MainTest.test_all shows that we run all of the tests and that N of them fail ...

You&apos;re right. I didn&apos;t think it through very well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>646253</commentid>
    <comment_count>15</comment_count>
      <attachid>146673</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-06-11 14:18:15 -0700</bug_when>
    <thetext>Comment on attachment 146673
change 0 to None

Clearing flags on attachment: 146673

Committed r120007: &lt;http://trac.webkit.org/changeset/120007&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>646254</commentid>
    <comment_count>16</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-06-11 14:18:21 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>117899</attachid>
            <date>2011-12-05 10:47:33 -0800</date>
            <delta_ts>2012-06-08 17:52:26 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-73843-20111205104732.patch</filename>
            <type>text/plain</type>
            <size>1400</size>
            <attacher name="Ryosuke Niwa">rniwa</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDEwMjAxNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE0IEBACisyMDExLTEyLTA1ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor
CisgICAgICAgIG5yd3QgZXhpdHMgZWFybHkgdG9vIGZyZXF1ZW50bHkKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczODQzCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5jcmVhc2UgdGhlIG51bWJlciBvZiBj
cmFzaGVzIGFuZCB0aW1lb3V0cyB0byB0b2xlcmFuY2UgZnJvbSAyMCB0byAxMDAuCisKKyAgICAg
ICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2Zn
OgorCiAyMDExLTEyLTA1ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAg
ICAgIFRlbXBvcmFyaWx5IHNldCAtLWNoaWxkLXByb2Nlc3M9MSBvbiBNYWMgYmVjYXVzZSAyMCsg
dGVzdHMgYXJlIHRpbWluZyBvdXQKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxk
LndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRT
bGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZwkocmV2aXNpb24g
MTAyMDA2KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m
aWcvbWFzdGVyLmNmZwkod29ya2luZyBjb3B5KQpAQCAtMzEzLDcgKzMxMyw3IEBAIGNsYXNzIFJ1
bldlYktpdFRlc3RzKHNoZWxsLlRlc3QpOgogICAgICAgICAgICAgICAgIi0tbWFzdGVyLW5hbWUi
LCAid2Via2l0Lm9yZyIsCiAgICAgICAgICAgICAgICAiLS10ZXN0LXJlc3VsdHMtc2VydmVyIiwg
InRlc3QtcmVzdWx0cy5hcHBzcG90LmNvbSIsCiAgICAgICAgICAgICAgICBXaXRoUHJvcGVydGll
cygiLS0lKGNvbmZpZ3VyYXRpb24pcyIpLAotICAgICAgICAgICAgICAgIi0tZXhpdC1hZnRlci1u
LWNyYXNoZXMtb3ItdGltZW91dHMiLCAiMjAiLAorICAgICAgICAgICAgICAgIi0tZXhpdC1hZnRl
ci1uLWNyYXNoZXMtb3ItdGltZW91dHMiLCAiMTAwIiwKICAgICAgICAgICAgICAgICItLWV4aXQt
YWZ0ZXItbi1mYWlsdXJlcyIsICI1MDAiXQogCiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIGJ1aWxk
SlNDVG9vbD1UcnVlLCAqYXJncywgKiprd2FyZ3MpOgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>146669</attachid>
            <date>2012-06-08 17:52:30 -0700</date>
            <delta_ts>2012-06-08 18:14:48 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-73843-20120608175238.patch</filename>
            <type>text/plain</type>
            <size>2927</size>
            <attacher name="Dirk Pranke">dpranke</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5ODcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjE4ZGZiNDQzM2RmNWEwM2Q3OTMxZDA5YTRhZGEwYmVi
YmEwNTgzMy4uYTgyMGQzMmFmNGExODkyZThmYWE4MDI1N2Q3YTI3NmI0MWRmMTY5OSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMx
IEBACisyMDEyLTA2LTA4ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg
ICAgICAgIG5yd3QgZXhpdHMgZWFybHkgdG9vIGZyZXF1ZW50bHkKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczODQzCisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlIHRoZSBkZWZhdWx0cyBmb3IgbmV3
LXJ1bi13ZWJraXQtdGVzdHMgZm9yIGJvdGgKKyAgICAgICAgLS1leGl0LWFmdGVyLW4tZmFpbHVy
ZXMgYW5kIC0tZXhpdC1hZnRlci1uLWNyYXNoZXMtb3ItdGltZW91dHMKKyAgICAgICAgdG8gemVy
byAoaS5lLiwgd2Ugd2lsbCBuZXZlciBleGl0IGVhcmx5IGJ5IGRlZmF1bHQpLgorCisgICAgICAg
IElmIHBlb3BsZSB3YW50IHRoZWlyIGJ1aWxkYm90cyB0byBleGl0IGVhcmx5IGl0IGlzIHRoZWly
CisgICAgICAgIHJlc3BvbnNpYmlsaXR5IHRvIHVwZGF0ZSB0aGVpciBidWlsZGJvdCBjb25maWdz
IGFwcHJvcHJpYXRlbHkuCisKKyAgICAgICAgTm90ZSB0aGF0IHdlIGhhdmUgdGVzdHMgdGhhdCBl
bnN1cmUgdGhhdCB0aGVzZSBmbGFncyB3b3JrIGZvcgorICAgICAgICBub24temVybyBudW1iZXJz
LCBidXQgd2UgZG9uJ3QgaGF2ZSB0ZXN0cyB0aGF0IGVpdGhlciB0ZXN0IHRoZQorICAgICAgICBk
ZWZhdWx0IG9yIGVuc3VyZSB0aGF0IHplcm8gbWVhbnMgInJ1biBhbGwgb2YgdGhlIHRlc3RzIi4g
SQorICAgICAgICB0aGluayB0aGF0J3Mgb2theSBidXQgY2FuIGFkZCB0ZXN0cyBpZiBvdGhlcnMg
ZGlzYWdyZWUuCisKKyAgICAgICAgQWxzbyBub3RlIHRoYXQgaXQgbG9va3MgbGlrZSBubyBjaGFu
Z2VzIG9uIHRoZSBidWlsZC53ZWJraXQub3JnCisgICAgICAgIG1hc3Rlci5jZmcgYXJlIG5lY2Vz
c2FyeTsgYWxsIG9mIHRoZSBib3RzIHNlZW0gdG8gYmUgdXNpbmcgdGhlCisgICAgICAgIFJ1bldl
YktpdFRlc3RzIHdyYXBwZXIgd2hpY2ggaXMgYWxyZWFkeSBzZXR0aW5nIHRoZSBmbGFncy4gVGhl
cmUKKyAgICAgICAgaXMgYSBOZXdSdW5XZWJLaXRUZXN0cyB3cmFwcGVyLCBidXQgdGhhdCBsb29r
cyB0byBiZSB1bnVzZWQ7IEkKKyAgICAgICAgd2lsbCBkZWxldGUgdGhhdCBpbiBhIHNlcGFyYXRl
IHBhdGNoLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dl
YmtpdF90ZXN0cy5weToKKyAgICAgICAgKHBhcnNlX2FyZ3MpOgorCiAyMDEyLTA2LTA4ICBXZWkg
SmFtZXMgIDxqYW1lcy53ZWlAaW50ZWwuY29tPgogCiAgICAgICAgIEFkZCBhcHBfYWJpIG9wdGlv
biBmb3IgRHVtcFJlbmRlclRyZWVfYXBrCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp
dHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr
aXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQppbmRleCBkNGVjY2IwZmFmYjk3
MTg0MGVlYmViM2FlY2I5ODI5MGE0ZjgyZGM3Li42MDk2NTRmZTY5ZjQ4MDMxYWU3NWY1YWQ0YWYw
YTdmMTJjODQzOWY3IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90
ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5
b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKQEAgLTM4MywxMSArMzgzLDExIEBAIGRlZiBw
YXJzZV9hcmdzKGFyZ3M9Tm9uZSk6CiAgICAgICAgICMgRklYTUU6IERpc3BsYXkgZGVmYXVsdCBu
dW1iZXIgb2YgY2hpbGQgcHJvY2Vzc2VzIHRoYXQgd2lsbCBydW4uCiAgICAgICAgIG9wdHBhcnNl
Lm1ha2Vfb3B0aW9uKCItZiIsICItLWZ1bGx5LXBhcmFsbGVsIiwgYWN0aW9uPSJzdG9yZV90cnVl
IiwKICAgICAgICAgICAgIGhlbHA9InJ1biBhbGwgdGVzdHMgaW4gcGFyYWxsZWwiKSwKLSAgICAg
ICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tZXhpdC1hZnRlci1uLWZhaWx1cmVzIiwgdHlwZT0i
aW50IiwgZGVmYXVsdD01MDAsCisgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLWV4aXQt
YWZ0ZXItbi1mYWlsdXJlcyIsIHR5cGU9ImludCIsIGRlZmF1bHQ9MCwKICAgICAgICAgICAgIGhl
bHA9IkV4aXQgYWZ0ZXIgdGhlIGZpcnN0IE4gZmFpbHVyZXMgaW5zdGVhZCBvZiBydW5uaW5nIGFs
bCAiCiAgICAgICAgICAgICAidGVzdHMiKSwKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24o
Ii0tZXhpdC1hZnRlci1uLWNyYXNoZXMtb3ItdGltZW91dHMiLCB0eXBlPSJpbnQiLAotICAgICAg
ICAgICAgZGVmYXVsdD0yMCwgaGVscD0iRXhpdCBhZnRlciB0aGUgZmlyc3QgTiBjcmFzaGVzIGlu
c3RlYWQgb2YgIgorICAgICAgICAgICAgZGVmYXVsdD0wLCBoZWxwPSJFeGl0IGFmdGVyIHRoZSBm
aXJzdCBOIGNyYXNoZXMgaW5zdGVhZCBvZiAiCiAgICAgICAgICAgICAicnVubmluZyBhbGwgdGVz
dHMiKSwKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0taXRlcmF0aW9ucyIsIHR5cGU9
ImludCIsIGhlbHA9Ik51bWJlciBvZiB0aW1lcyB0byBydW4gdGhlIHNldCBvZiB0ZXN0cyAoZS5n
LiBBQkNBQkNBQkMpIiksCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLXJlcGVhdC1l
YWNoIiwgdHlwZT0iaW50IiwgaGVscD0iTnVtYmVyIG9mIHRpbWVzIHRvIHJ1biBlYWNoIHRlc3Qg
KGUuZy4gQUFBQkJCQ0NDKSIpLAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>146673</attachid>
            <date>2012-06-08 18:14:53 -0700</date>
            <delta_ts>2012-06-11 14:18:15 -0700</delta_ts>
            <desc>change 0 to None</desc>
            <filename>bug-73843-20120608181500.patch</filename>
            <type>text/plain</type>
            <size>2933</size>
            <attacher name="Dirk Pranke">dpranke</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5ODcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjE4ZGZiNDQzM2RmNWEwM2Q3OTMxZDA5YTRhZGEwYmVi
YmEwNTgzMy4uYTgyMGQzMmFmNGExODkyZThmYWE4MDI1N2Q3YTI3NmI0MWRmMTY5OSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMx
IEBACisyMDEyLTA2LTA4ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg
ICAgICAgIG5yd3QgZXhpdHMgZWFybHkgdG9vIGZyZXF1ZW50bHkKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczODQzCisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlIHRoZSBkZWZhdWx0cyBmb3IgbmV3
LXJ1bi13ZWJraXQtdGVzdHMgZm9yIGJvdGgKKyAgICAgICAgLS1leGl0LWFmdGVyLW4tZmFpbHVy
ZXMgYW5kIC0tZXhpdC1hZnRlci1uLWNyYXNoZXMtb3ItdGltZW91dHMKKyAgICAgICAgdG8gemVy
byAoaS5lLiwgd2Ugd2lsbCBuZXZlciBleGl0IGVhcmx5IGJ5IGRlZmF1bHQpLgorCisgICAgICAg
IElmIHBlb3BsZSB3YW50IHRoZWlyIGJ1aWxkYm90cyB0byBleGl0IGVhcmx5IGl0IGlzIHRoZWly
CisgICAgICAgIHJlc3BvbnNpYmlsaXR5IHRvIHVwZGF0ZSB0aGVpciBidWlsZGJvdCBjb25maWdz
IGFwcHJvcHJpYXRlbHkuCisKKyAgICAgICAgTm90ZSB0aGF0IHdlIGhhdmUgdGVzdHMgdGhhdCBl
bnN1cmUgdGhhdCB0aGVzZSBmbGFncyB3b3JrIGZvcgorICAgICAgICBub24temVybyBudW1iZXJz
LCBidXQgd2UgZG9uJ3QgaGF2ZSB0ZXN0cyB0aGF0IGVpdGhlciB0ZXN0IHRoZQorICAgICAgICBk
ZWZhdWx0IG9yIGVuc3VyZSB0aGF0IHplcm8gbWVhbnMgInJ1biBhbGwgb2YgdGhlIHRlc3RzIi4g
SQorICAgICAgICB0aGluayB0aGF0J3Mgb2theSBidXQgY2FuIGFkZCB0ZXN0cyBpZiBvdGhlcnMg
ZGlzYWdyZWUuCisKKyAgICAgICAgQWxzbyBub3RlIHRoYXQgaXQgbG9va3MgbGlrZSBubyBjaGFu
Z2VzIG9uIHRoZSBidWlsZC53ZWJraXQub3JnCisgICAgICAgIG1hc3Rlci5jZmcgYXJlIG5lY2Vz
c2FyeTsgYWxsIG9mIHRoZSBib3RzIHNlZW0gdG8gYmUgdXNpbmcgdGhlCisgICAgICAgIFJ1bldl
YktpdFRlc3RzIHdyYXBwZXIgd2hpY2ggaXMgYWxyZWFkeSBzZXR0aW5nIHRoZSBmbGFncy4gVGhl
cmUKKyAgICAgICAgaXMgYSBOZXdSdW5XZWJLaXRUZXN0cyB3cmFwcGVyLCBidXQgdGhhdCBsb29r
cyB0byBiZSB1bnVzZWQ7IEkKKyAgICAgICAgd2lsbCBkZWxldGUgdGhhdCBpbiBhIHNlcGFyYXRl
IHBhdGNoLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dl
YmtpdF90ZXN0cy5weToKKyAgICAgICAgKHBhcnNlX2FyZ3MpOgorCiAyMDEyLTA2LTA4ICBXZWkg
SmFtZXMgIDxqYW1lcy53ZWlAaW50ZWwuY29tPgogCiAgICAgICAgIEFkZCBhcHBfYWJpIG9wdGlv
biBmb3IgRHVtcFJlbmRlclRyZWVfYXBrCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp
dHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr
aXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQppbmRleCBkNGVjY2IwZmFmYjk3
MTg0MGVlYmViM2FlY2I5ODI5MGE0ZjgyZGM3Li40OGZiNDNmZjAxZmE1ZjM2YjQ0Mjk3ODVjNGEx
OWU1ODRhYWE1Y2VlIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90
ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5
b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKQEAgLTM4MywxMSArMzgzLDExIEBAIGRlZiBw
YXJzZV9hcmdzKGFyZ3M9Tm9uZSk6CiAgICAgICAgICMgRklYTUU6IERpc3BsYXkgZGVmYXVsdCBu
dW1iZXIgb2YgY2hpbGQgcHJvY2Vzc2VzIHRoYXQgd2lsbCBydW4uCiAgICAgICAgIG9wdHBhcnNl
Lm1ha2Vfb3B0aW9uKCItZiIsICItLWZ1bGx5LXBhcmFsbGVsIiwgYWN0aW9uPSJzdG9yZV90cnVl
IiwKICAgICAgICAgICAgIGhlbHA9InJ1biBhbGwgdGVzdHMgaW4gcGFyYWxsZWwiKSwKLSAgICAg
ICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tZXhpdC1hZnRlci1uLWZhaWx1cmVzIiwgdHlwZT0i
aW50IiwgZGVmYXVsdD01MDAsCisgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLWV4aXQt
YWZ0ZXItbi1mYWlsdXJlcyIsIHR5cGU9ImludCIsIGRlZmF1bHQ9Tm9uZSwKICAgICAgICAgICAg
IGhlbHA9IkV4aXQgYWZ0ZXIgdGhlIGZpcnN0IE4gZmFpbHVyZXMgaW5zdGVhZCBvZiBydW5uaW5n
IGFsbCAiCiAgICAgICAgICAgICAidGVzdHMiKSwKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRp
b24oIi0tZXhpdC1hZnRlci1uLWNyYXNoZXMtb3ItdGltZW91dHMiLCB0eXBlPSJpbnQiLAotICAg
ICAgICAgICAgZGVmYXVsdD0yMCwgaGVscD0iRXhpdCBhZnRlciB0aGUgZmlyc3QgTiBjcmFzaGVz
IGluc3RlYWQgb2YgIgorICAgICAgICAgICAgZGVmYXVsdD1Ob25lLCBoZWxwPSJFeGl0IGFmdGVy
IHRoZSBmaXJzdCBOIGNyYXNoZXMgaW5zdGVhZCBvZiAiCiAgICAgICAgICAgICAicnVubmluZyBh
bGwgdGVzdHMiKSwKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0taXRlcmF0aW9ucyIs
IHR5cGU9ImludCIsIGhlbHA9Ik51bWJlciBvZiB0aW1lcyB0byBydW4gdGhlIHNldCBvZiB0ZXN0
cyAoZS5nLiBBQkNBQkNBQkMpIiksCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLXJl
cGVhdC1lYWNoIiwgdHlwZT0iaW50IiwgaGVscD0iTnVtYmVyIG9mIHRpbWVzIHRvIHJ1biBlYWNo
IHRlc3QgKGUuZy4gQUFBQkJCQ0NDKSIpLAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>