7319 2006-02-16 20:29:47 -0800 Can't see caret at the end of a contenteditable div with overflow:hidden 2006-03-07 11:51:46 -0800 1 1 1 Unclassified WebKit HTML Editing 420+ Mac OS X 10.4 RESOLVED FIXED InRadar P2 Normal --- 6986 1 adele adele harrison hyatt justin.garcia oldest_to_newest 33088 0 adele 2006-02-16 20:29:47 -0800 See test case. In the new text fields, the caret stops blinking when you arrow over to the right edge. 33089 1 6555 adele 2006-02-16 20:31:58 -0800 Created attachment 6555 test case 33099 2 6559 adele 2006-02-17 01:03:26 -0800 Created attachment 6559 patch I'm not sure this is the right approach for the long term, but it solves this specific problem. Maybe we want a render class for any renderer that has an anonymous DOM tree. 33136 3 harrison 2006-02-17 10:51:07 -0800 Agreed that this patch does not seem right. Reason is that the loop you're changing is trying to skip what I'd call "intermediate" nodes, but I would not a call a text field intermediate. Please elaborate on what is going wrong to cause this bug (apparently something to do with anon DOM?), then I'll try to help with longer term solution. Thanks. 33138 4 adele 2006-02-17 11:19:23 -0800 When the caret is at the end, and RenderBlock::paintCaret is called for the RenderTextField, the containing block for the text node is its parent div (which is anonymous), and not the RenderTextField, which is preventing paintCaret from actually painting. At other caret positions, paintCaret isn't called for the RenderTextField-- only for the div, so the containingBlock matches the caller. So maybe we should never be getting to the point where the RenderTextField is trying to draw the caret? 34685 5 adele 2006-03-01 17:02:34 -0800 <rdar://problem/4463504> caret stops blinking when it reaches the end of the new text field (7319) 35311 6 adele 2006-03-06 11:26:50 -0800 justin and i discussed the possibility that the div just needed more padding, but after experimenting, that doesn't seem to have any effect. I was also able to reproduce the problem with a normal div. I'll attach the test case. 35312 7 6900 adele 2006-03-06 11:27:30 -0800 Created attachment 6900 test case w/ editable div 35329 8 adele 2006-03-06 14:38:33 -0800 One explanation is that the div's overflow layer is not large enough for the caret at the end. RenderLayer::computeScrollDimensions uses the rightmostPosition to compute the scrollWidth. rightmostPosition will compute a position based on the text nodes in the block. If we add code to account for the possibility of a cursor, then the rightmostPosition would increase by 1 in this case. Something like this in RenderBlock::rightmostPosition... // If this node is a root editable element, then the rightmostPosition should account for a caret at the end. if (node()->isContentEditable() && node() == node()->rootEditableElement()) right += 1; This does the trick, but I'm not sure its the right thing to do. 35441 9 6921 adele 2006-03-07 11:02:42 -0800 Created attachment 6921 patch I don't think this addresses the rtl case- but my testing showed that there are other serious problems with the caret displaying correctly for rtl editable areas, which makes it difficult to test this specific case. 35443 10 6921 hyatt 2006-03-07 11:47:20 -0800 Comment on attachment 6921 patch You should add style()->direction() == LTR as well. r=me 6555 2006-02-16 20:31:58 -0800 2006-02-16 20:31:58 -0800 test case scroll2.html text/html 121 adele PGlucHV0IHN0eWxlPSIta2h0bWwtYXBwZWFyYW5jZTp0ZXh0ZmllbGQiIHZhbHVlPSJNb3ZlIGN1 cnNvciB0byB0aGUgcmlnaHQuLi4uc2VlIGl0IHN0b3AgYmxpbmtpbmcgYXQgdGhlIGVkZ2UiPjwv aW5wdXQ+Cg== 6559 2006-02-17 01:03:26 -0800 2006-03-07 11:02:42 -0800 patch caret.txt text/plain 1702 adele SW5kZXg6IHJlbmRlcmluZy9SZW5kZXJUZXh0RmllbGQuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSByZW5kZXJp bmcvUmVuZGVyVGV4dEZpZWxkLmgJKHJldmlzaW9uIDEyODY1KQorKysgcmVuZGVyaW5nL1JlbmRl clRleHRGaWVsZC5oCSh3b3JraW5nIGNvcHkpCkBAIC01NCw2ICs1NCw3IEBACiAgICAgdmlydHVh bCB2b2lkIHJlbW92ZUxlZnRvdmVyQW5vbnltb3VzQm94ZXMoKSB7fTsKICAgICB2aXJ0dWFsIHZv aWQgc2V0U3R5bGUoUmVuZGVyU3R5bGUqIHN0eWxlKTsKICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRl RnJvbUVsZW1lbnQoKTsKKyAgICB2aXJ0dWFsIGJvb2wgaXNSZW5kZXJUZXh0RmllbGQoKSBjb25z dCB7IHJldHVybiB0cnVlOyB9CiAgICAgCiAgICAgUmVuZGVyU3R5bGUqIGNyZWF0ZURpdlN0eWxl KFJlbmRlclN0eWxlKiBzdGFydFN0eWxlKTsKIApJbmRleDogcmVuZGVyaW5nL3JlbmRlcl9vYmpl Y3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSByZW5kZXJpbmcvcmVuZGVyX29iamVjdC5oCShyZXZpc2lvbiAx Mjg2NSkKKysrIHJlbmRlcmluZy9yZW5kZXJfb2JqZWN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTIz OSw2ICsyMzksNyBAQAogICAgIHZpcnR1YWwgYm9vbCBpc1JlbmRlcklubGluZSgpIGNvbnN0IHsg cmV0dXJuIGZhbHNlOyB9CiAgICAgdmlydHVhbCBib29sIGlzSW5saW5lRmxvdygpIGNvbnN0IHsg cmV0dXJuIGZhbHNlOyB9CiAgICAgdmlydHVhbCBib29sIGlzQmxvY2tGbG93KCkgY29uc3QgeyBy ZXR1cm4gZmFsc2U7IH0KKyAgICB2aXJ0dWFsIGJvb2wgaXNSZW5kZXJUZXh0RmllbGQoKSBjb25z dCB7IHJldHVybiBmYWxzZTsgfQogICAgIHZpcnR1YWwgYm9vbCBpc0lubGluZUJsb2NrT3JJbmxp bmVUYWJsZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgdmlydHVhbCBib29sIGNoaWxk cmVuSW5saW5lKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICAgICB2aXJ0dWFsIHZvaWQgc2V0 Q2hpbGRyZW5JbmxpbmUoYm9vbCBiKSB7IH07CkluZGV4OiByZW5kZXJpbmcvcmVuZGVyX29iamVj dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gcmVuZGVyaW5nL3JlbmRlcl9vYmplY3QuY3BwCShyZXZpc2lv biAxMjg2NSkKKysrIHJlbmRlcmluZy9yZW5kZXJfb2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtNzMyLDcgKzczMiw3IEBACiAgICAgICAgIH0KICAgICB9IGVsc2UgewogICAgICAgICB3aGls ZSAobyAmJiAoKG8tPmlzSW5saW5lKCkgJiYgIW8tPmlzUmVwbGFjZWQoKSkgfHwgby0+aXNUYWJs ZVJvdygpIHx8IG8tPmlzVGFibGVTZWN0aW9uKCkKLSAgICAgICAgICAgICAgICAgICAgIHx8IG8t PmlzVGFibGVDb2woKSB8fCBvLT5pc0ZyYW1lU2V0KCkKKyAgICAgICAgICAgICAgICAgICAgIHx8 IG8tPmlzVGFibGVDb2woKSB8fCBvLT5pc0ZyYW1lU2V0KCkgfHwgKG8tPnBhcmVudCgpICYmIG8t PnBhcmVudCgpLT5pc1JlbmRlclRleHRGaWVsZCgpKQogI2lmIFNWR19TVVBQT1JUCiAgICAgICAg ICAgICAgICAgICAgICB8fCBvLT5pc0tDYW52YXNDb250YWluZXIoKQogI2VuZGlmCg== 6900 2006-03-06 11:27:30 -0800 2006-03-06 11:27:30 -0800 test case w/ editable div cursor.html text/html 123 adele PGRpdiBzdHlsZT0id2lkdGg6MTAwcHg7IGRpc3BsYXk6YmxvY2s7IHdoaXRlLXNwYWNlOm5vd3Jh cDsgb3ZlcmZsb3c6aGlkZGVuOyIgY29udGVudGVkaXRhYmxlPjEyMzQ1IDY3ODkgYWJjZGUgZmdo aWprPC9kaXY+ 6921 2006-03-07 11:02:42 -0800 2006-03-07 11:47:20 -0800 patch cursor.txt text/plain 1408 adele SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEzMTkx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDYtMDMt MDcgIEFkZWxlIFBldGVyc29uICA8YWRlbGVAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpCisKKyAgICAgICAgLSBGaXggZm9yIGh0dHA6Ly9idWd6aWxsYS5v cGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzMxOQorICAgICAgICBDYW4ndCBzZWUgY2Fy ZXQgYXQgdGhlIGVuZCBvZiBhIGNvbnRlbnRlZGl0YWJsZSBkaXYgd2l0aCBvdmVyZmxvdzpoaWRk ZW4KKworICAgICAgICBObyB0ZXN0cyBhZGRlZCBzaW5jZSBJIGRvbid0IHRoaW5rIHRoZSBibGlu a2luZyBjYXJldCB3aWxsIHNob3cgdXAgaW4gb3VyIHRlc3RzLgorCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpyaWdo dG1vc3RQb3NpdGlvbik6IFdoZW4gY2FsY3VsYXRpbmcgdGhlIHJpZ2h0bW9zdFBvc2l0aW9uIGZv ciBlZGl0YWJsZSBibG9ja3MsIAorICAgICAgICB3ZSBuZWVkIHRvIGFjY291bnQgZm9yIHRoZSBj YXJldCB0aGF0IGNhbiBiZSBkcmF3biAxIHB4IHBhc3QgdGhlIGxhc3QgY2hpbGQgaW5saW5lIGJv eC4KKwogMjAwNi0wMy0wNyAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAa2lsemVyLm5ldD4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYXJpbi4KSW5kZXg6IHJlbmRlcmluZy9SZW5kZXJCbG9jay5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkocmV2aXNpb24gMTMx ODIpCisrKyByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTYx LDYgKzIxNjEsOSBAQAogICAgICAgICAgICAgaW50IHJwID0gY3VyckJveC0+eFBvcygpICsgY3Vy ckJveC0+d2lkdGgoKTsKICAgICAgICAgICAgIHJpZ2h0ID0ga01heChyaWdodCwgcnApOwogICAg ICAgICB9CisgICAgICAgIC8vIElmIHRoaXMgbm9kZSBpcyBhIHJvb3QgZWRpdGFibGUgZWxlbWVu dCwgdGhlbiB0aGUgcmlnaHRtb3N0UG9zaXRpb24gc2hvdWxkIGFjY291bnQgZm9yIGEgY2FyZXQg YXQgdGhlIGVuZC4KKyAgICAgICAgaWYgKG5vZGUoKS0+aXNDb250ZW50RWRpdGFibGUoKSAmJiBu b2RlKCkgPT0gbm9kZSgpLT5yb290RWRpdGFibGVFbGVtZW50KCkpCisgICAgICAgICAgICByaWdo dCArPSAxOwogICAgIH0KICAgICAKICAgICByZXR1cm4gcmlnaHQ7Cg==