73179 2011-11-27 18:15:59 -0800 run-bindings-tests shows diff error for a newly added binding test 2011-11-28 02:23:22 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72138 1 haraken haraken abarth dominicc webkit.review.bot oldest_to_newest 509528 0 haraken 2011-11-27 18:15:59 -0800 When we add a new binding test, say bindings/scripts/test/TestSupplemental.idl, run-bindings-tests just shows diff error because reference files (i.e. {V8,JS,...}TestSupplemental.h and {V8,JS,...}TestSupplemental.cpp) do not yet exist: FAIL: (V8) V8TestSupplemental.h diff: WebCore/bindings/scripts/test/V8/V8TestSupplemental.h: No such file or directory FAIL: (V8) V8TestSupplemental.cpp diff: WebCore/bindings/scripts/test/V8/V8TestSupplemental.cpp: No such file or directory That way there is no way to check the result of the newly added binding test, unless we run run-bindings-tests with --reset-results and in fact update the reference files. However, --reset-results updates other reference files that we do not yet want to update in order to check diff. This is not user-friendly. Instead, we should treat a non-existent reference file as an empty file and show the result of the newly added binding test, like this: FAIL: (V8) V8TestSupplemental.h --- WebCore/bindings/scripts/test/V8/V8TestSupplemental.h 1970-01-01 09:00:00.000000000 +0900 +++ /tmp/tmpmX2i2F/V8TestSupplemental.h 2011-11-28 11:08:34.150707677 +0900 @@ -0,0 +1,84 @@ +/* + This file is part of the WebKit open source project. + This file has been generated by generate-bindings.pl. DO NOT MODIFY! + (omitted) FAIL: (V8) V8TestSupplemental.cpp --- WebCore/bindings/scripts/test/V8/V8TestSupplemental.cpp 1970-01-01 09:00:00.000000000 +0900 +++ /tmp/tmpmX2i2F/V8TestSupplemental.cpp 2011-11-28 11:08:34.150707677 +0900 @@ -0,0 +1,159 @@ +/* + This file is part of the WebKit open source project. + This file has been generated by generate-bindings.pl. DO NOT MODIFY! (omitted) 509530 1 116690 haraken 2011-11-27 18:22:23 -0800 Created attachment 116690 Patch 509682 2 116690 webkit.review.bot 2011-11-28 02:23:18 -0800 Comment on attachment 116690 Patch Clearing flags on attachment: 116690 Committed r101240: <http://trac.webkit.org/changeset/101240> 509683 3 webkit.review.bot 2011-11-28 02:23:22 -0800 All reviewed patches have been landed. Closing bug. 116690 2011-11-27 18:22:23 -0800 2011-11-28 02:23:18 -0800 Patch bug-73179-20111128112221.patch text/plain 2329 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMTk3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGYxOWFlOGJlMzc5ZTNmYTFiNWM4MDk3NDA5N2FhMDBl NjU0ZDQ2MC4uYzVjZmQ1YWRjMDllMTA5MzA1MzA4MWE1MThkMWQ3MTNmMjNmZmZkMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMz IEBACisyMDExLTExLTI3ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBydW4tYmluZGluZ3MtdGVzdHMgc2hvd3MgZGlmZiBlcnJvciBmb3IgYSBuZXdseSBh ZGRlZCBiaW5kaW5nIHRlc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTczMTc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ3VycmVudGx5LCB3aGVuIHdlIGFkZCBhIG5ldyBiaW5kaW5nIHRlc3QsIHNheSBi aW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVzdFN1cHBsZW1lbnRhbC5pZGwsCisgICAgICAgIHJ1bi1i aW5kaW5ncy10ZXN0cyBqdXN0IHNob3dzIGRpZmYgZXJyb3IgYmVjYXVzZSByZWZlcmVuY2UgZmls ZXMKKyAgICAgICAgKGkuZS4ge1Y4LEpTLC4uLn1UZXN0U3VwcGxlbWVudGFsLmggYW5kIHtWOCxK UywuLi59VGVzdFN1cHBsZW1lbnRhbC5jcHApIGRvIG5vdCB5ZXQgZXhpc3Q6CisKKyAgICAgICAg ICAgIEZBSUw6IChWOCkgVjhUZXN0U3VwcGxlbWVudGFsLmgKKyAgICAgICAgICAgIGRpZmY6IFdl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdFN1cHBsZW1lbnRhbC5oOiBObyBz dWNoIGZpbGUgb3IgZGlyZWN0b3J5CisKKyAgICAgICAgSW5zdGVhZCwgdGhpcyBwYXRjaCB0cmVh dHMgYSBub24tZXhpc3RlbnQgcmVmZXJlbmNlIGZpbGUgYXMgYW4gZW1wdHkgZmlsZSBhbmQKKyAg ICAgICAgc2hvd3MgdGhlIHJlc3VsdCBvZiB0aGUgbmV3bHkgYWRkZWQgYmluZGluZyB0ZXN0LCBs aWtlIHRoaXM6CisKKyAgICAgICAgICAgIEZBSUw6IChWOCkgVjhUZXN0U3VwcGxlbWVudGFsLmgK KyAgICAgICAgICAgIC0tLSBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3RT dXBwbGVtZW50YWwuaCAgICAgICAxOTcwLTAxLTAxIDA5OjAwOjAwLjAwMDAwMDAwMCArMDkwMAor ICAgICAgICAgICAgKysrIC90bXAvdG1wbVgyaTJGL1Y4VGVzdFN1cHBsZW1lbnRhbC5oIDIwMTEt MTEtMjggMTE6MDg6MzQuMTUwNzA3Njc3ICswOTAwCisgICAgICAgICAgICBAQCAtMCwwICsxLDg0 IEBACisgICAgICAgICAgICArLyoKKyAgICAgICAgICAgICsgICAgVGhpcyBmaWxlIGlzIHBhcnQg b2YgdGhlIFdlYktpdCBvcGVuIHNvdXJjZSBwcm9qZWN0LgorICAgICAgICAgICAgKyAgICBUaGlz IGZpbGUgaGFzIGJlZW4gZ2VuZXJhdGVkIGJ5IGdlbmVyYXRlLWJpbmRpbmdzLnBsLiBETyBOT1Qg TU9ESUZZIQorICAgICAgICAgICAgKworICAgICAgICAgICAgKG9taXR0ZWQpCisKKyAgICAgICAg KiBTY3JpcHRzL3J1bi1iaW5kaW5ncy10ZXN0czoKKyAgICAgICAgKGRldGVjdF9jaGFuZ2VzKTog SnVzdCBhZGRlZCBhbiAtTiBvcHRpb24gdG8gdGhlIGRpZmYgY29tbWFuZC4KKwogMjAxMS0xMS0y NiAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgVHJ5 IHRvIGZpeCB0aGUgYnVpbGQgYWZ0ZXIgcjEwMTE3NC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvcnVuLWJpbmRpbmdzLXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tYmluZGluZ3MtdGVzdHMK aW5kZXggNDA5ZmExZjE0YzliY2UyNTEwNzYxYmY1MTc0N2FlM2UxNjYxZGMwMS4uOWJlN2I0MWU2 OWEyMzE0ZTBiNGMxNmIwYWZhNjEwNDA3YmU2YzAzMiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0 cy9ydW4tYmluZGluZ3MtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tYmluZGluZ3MtdGVz dHMKQEAgLTYyLDYgKzYyLDcgQEAgZGVmIGRldGVjdF9jaGFuZ2VzKGdlbmVyYXRvciwgd29ya19k aXJlY3RvcnksIHJlZmVyZW5jZV9kaXJlY3RvcnkpOgogICAgIGZvciBvdXRwdXRfZmlsZSBpbiBv cy5saXN0ZGlyKHdvcmtfZGlyZWN0b3J5KToKICAgICAgICAgY21kID0gWydkaWZmJywKICAgICAg ICAgICAgICAgICctdScsCisgICAgICAgICAgICAgICAnLU4nLAogICAgICAgICAgICAgICAgb3Mu cGF0aC5qb2luKHJlZmVyZW5jZV9kaXJlY3RvcnksIG91dHB1dF9maWxlKSwKICAgICAgICAgICAg ICAgIG9zLnBhdGguam9pbih3b3JrX2RpcmVjdG9yeSwgb3V0cHV0X2ZpbGUpXQogCg==