73115 2011-11-24 23:50:38 -0800 Refactoring CodeGenerator*.pm for bug 72138 2011-11-25 16:34:54 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72138 1 haraken haraken abarth dominicc japhet webkit.review.bot oldest_to_newest 508992 0 haraken 2011-11-24 23:50:38 -0800 Fixing bug 72138 requires some trivial refactoring on CodeGenerator. 508996 1 116571 haraken 2011-11-25 00:02:58 -0800 Created attachment 116571 Patch 509293 2 116571 webkit.review.bot 2011-11-25 16:34:49 -0800 Comment on attachment 116571 Patch Clearing flags on attachment: 116571 Committed r101184: <http://trac.webkit.org/changeset/101184> 509294 3 webkit.review.bot 2011-11-25 16:34:54 -0800 All reviewed patches have been landed. Closing bug. 116571 2011-11-25 00:02:58 -0800 2011-11-25 16:34:49 -0800 Patch bug-73115-20111125170257.patch text/plain 5933 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTZjMzAwMGJkODc2ODFk NGMzZDY1NmNjMWYxMzBiMThjOTEzYTM2NS4uYmIxZGFiMmM4YjViZjVlNjhkY2NiODViMDRhZjQx OGM3ZmNlMGJlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDExLTExLTI0ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZWZhY3RvcmluZyBD b2RlR2VuZXJhdG9yKi5wbSBmb3IgYnVnIDcyMTM4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzExNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRlc3RzOiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVzdE9i ai5pZGwKKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3Qu cG06IEFkZGVkICIxOyIgYXQgdGhlIGVuZCBzaW5jZSB0aGlzIHBlcmwgc2NyaXB0IGlzIGxvYWRl ZCBhcyBhIHBhY2thZ2UuCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y VjgucG06IERpdHRvLiBSZW1vdmVkIHVubmVjZXNzYXJ5IHZhcmlhYmxlIG5hbWVzIGZyb20gbWV0 aG9kIGRlY2xhcmF0aW9ucyBpbiBvcmRlciB0byBzdXByZXNzIHN0eWxlIGNoZWNrIGVycm9ycyB3 aGVuIGEgbmV3IHJ1bi1iaW5kaW5ncy10ZXN0cyBJREwgaXMgYWRkZWQuCisgICAgICAgIChHZW5l cmF0ZUhlYWRlckN1c3RvbUNhbGwpOgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9W OC9WOFRlc3RPYmouaDogVXBkYXRlZCBhIHJ1bi1iaW5kaW5ncy10ZXN0cyByZXN1bHQuCisKKzIw MTEtMTEtMjQgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAg IEluaXRpYWxpemUgZ2xvYmFsIHZhcmlhYmxlcyBkdXJpbmcgSURMUGFyc2VyIG9iamVjdCBjcmVh dGlvbgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzMx MDgKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9yR09iamVjdC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdl bmVyYXRvckdPYmplY3QucG0KaW5kZXggZDVjNzFhMThhNTk1NmI3ZmVlMWIyMzhhYzcwMThmMmVm OTIyZjY1Yy4uN2FiODlkZWE5YjRiNDE0MTEwMzc3M2IzYTMwZmY5ZjQzYzhmM2NhOSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVj dC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JH T2JqZWN0LnBtCkBAIC0xMzgwLDMgKzEzODAsNSBAQCBzdWIgR2VuZXJhdGVJbnRlcmZhY2Ugewog ICAgICRmbmFtZSA9fiBzL18vL2c7CiAgICAgJG9iamVjdC0+V3JpdGVEYXRhKCRmbmFtZSk7CiB9 CisKKzE7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVH ZW5lcmF0b3JWOC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvclY4LnBtCmluZGV4IDdhYmU2M2IwNzgxNTkyYzg4ZDFkNzVjZTQzMmQ1MmM2OTI1NmVhZjMu LjVlMzNlYjJlOWIzMTU2NDFiMGNmYzY5MjRhNDYyMTkwNGM4MDRiZTkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0zOTUs MTMgKzM5NSwxMyBAQCBFTkQKICAgICAgICAgaWYgKCRhdHRyRXh0LT57IlY4Q3VzdG9tR2V0dGVy In0gfHwgJGF0dHJFeHQtPnsiQ3VzdG9tR2V0dGVyIn0KICAgICAgICAgICAgIHx8ICRhdHRyRXh0 LT57IlY4Q3VzdG9tIn0gfHwgJGF0dHJFeHQtPnsiQ3VzdG9tIn0pIHsKICAgICAgICAgICAgIHB1 c2goQGhlYWRlckNvbnRlbnQsIDw8RU5EKTsKLSAgICBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFs dWU+ICR7bmFtZX1BY2Nlc3NvckdldHRlcih2ODo6TG9jYWw8djg6OlN0cmluZz4gbmFtZSwgY29u c3Qgdjg6OkFjY2Vzc29ySW5mbyYgaW5mbyk7CisgICAgc3RhdGljIHY4OjpIYW5kbGU8djg6OlZh bHVlPiAke25hbWV9QWNjZXNzb3JHZXR0ZXIodjg6OkxvY2FsPHY4OjpTdHJpbmc+IG5hbWUsIGNv bnN0IHY4OjpBY2Nlc3NvckluZm8mKTsKIEVORAogICAgICAgICB9CiAgICAgICAgIGlmICgkYXR0 ckV4dC0+eyJWOEN1c3RvbVNldHRlciJ9IHx8ICRhdHRyRXh0LT57IkN1c3RvbVNldHRlciJ9CiAg ICAgICAgICAgICB8fCAkYXR0ckV4dC0+eyJWOEN1c3RvbSJ9IHx8ICRhdHRyRXh0LT57IkN1c3Rv bSJ9KSB7CiAgICAgICAgICAgICBwdXNoKEBoZWFkZXJDb250ZW50LCA8PEVORCk7Ci0gICAgc3Rh dGljIHZvaWQgJHtuYW1lfUFjY2Vzc29yU2V0dGVyKHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuYW1l LCB2ODo6TG9jYWw8djg6OlZhbHVlPiB2YWx1ZSwgY29uc3Qgdjg6OkFjY2Vzc29ySW5mbyYgaW5m byk7CisgICAgc3RhdGljIHZvaWQgJHtuYW1lfUFjY2Vzc29yU2V0dGVyKHY4OjpMb2NhbDx2ODo6 U3RyaW5nPiBuYW1lLCB2ODo6TG9jYWw8djg6OlZhbHVlPiwgY29uc3Qgdjg6OkFjY2Vzc29ySW5m byYpOwogRU5ECiAgICAgICAgIH0KICAgICAgICAgaWYgKCRhdHRyRXh0LT57IkVuYWJsZWRBdFJ1 bnRpbWUifSkgewpAQCAtNjM5LDEzICs2MzksMTMgQEAgc3ViIEdlbmVyYXRlSGVhZGVyQ3VzdG9t Q2FsbAogICAgICAgICBwdXNoKEBoZWFkZXJDb250ZW50LCAiICAgIHN0YXRpYyB2ODo6SGFuZGxl PHY4OjpWYWx1ZT4gY2FsbEFzRnVuY3Rpb25DYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJik7 XG4iKTsKICAgICB9CiAgICAgaWYgKCRkYXRhTm9kZS0+bmFtZSBlcSAiRXZlbnQiKSB7Ci0gICAg ICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICIgICAgc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVl PiBkYXRhVHJhbnNmZXJBY2Nlc3NvckdldHRlcih2ODo6TG9jYWw8djg6OlN0cmluZz4gbmFtZSwg Y29uc3Qgdjg6OkFjY2Vzc29ySW5mbyYgaW5mbyk7XG4iKTsKLSAgICAgICAgcHVzaChAaGVhZGVy Q29udGVudCwgIiAgICBzdGF0aWMgdm9pZCB2YWx1ZUFjY2Vzc29yU2V0dGVyKHY4OjpMb2NhbDx2 ODo6U3RyaW5nPiBuYW1lLCB2ODo6TG9jYWw8djg6OlZhbHVlPiB2YWx1ZSwgY29uc3Qgdjg6OkFj Y2Vzc29ySW5mbyYgaW5mbyk7XG4iKTsKKyAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiAg ICBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGRhdGFUcmFuc2ZlckFjY2Vzc29yR2V0dGVy KHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuYW1lLCBjb25zdCB2ODo6QWNjZXNzb3JJbmZvJik7XG4i KTsKKyAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiAgICBzdGF0aWMgdm9pZCB2YWx1ZUFj Y2Vzc29yU2V0dGVyKHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuYW1lLCB2ODo6TG9jYWw8djg6OlZh bHVlPiwgY29uc3Qgdjg6OkFjY2Vzc29ySW5mbyYpO1xuIik7CiAgICAgfQogICAgIGlmICgkZGF0 YU5vZGUtPm5hbWUgZXEgIkxvY2F0aW9uIikgewotICAgICAgICBwdXNoKEBoZWFkZXJDb250ZW50 LCAiICAgIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gYXNzaWduQWNjZXNzb3JHZXR0ZXIo djg6OkxvY2FsPHY4OjpTdHJpbmc+IG5hbWUsIGNvbnN0IHY4OjpBY2Nlc3NvckluZm8mIGluZm8p O1xuIik7Ci0gICAgICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICIgICAgc3RhdGljIHY4OjpIYW5k bGU8djg6OlZhbHVlPiByZWxvYWRBY2Nlc3NvckdldHRlcih2ODo6TG9jYWw8djg6OlN0cmluZz4g bmFtZSwgY29uc3Qgdjg6OkFjY2Vzc29ySW5mbyYgaW5mbyk7XG4iKTsKLSAgICAgICAgcHVzaChA aGVhZGVyQ29udGVudCwgIiAgICBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHJlcGxhY2VB Y2Nlc3NvckdldHRlcih2ODo6TG9jYWw8djg6OlN0cmluZz4gbmFtZSwgY29uc3Qgdjg6OkFjY2Vz c29ySW5mbyYgaW5mbyk7XG4iKTsKKyAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiAgICBz dGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGFzc2lnbkFjY2Vzc29yR2V0dGVyKHY4OjpMb2Nh bDx2ODo6U3RyaW5nPiBuYW1lLCBjb25zdCB2ODo6QWNjZXNzb3JJbmZvJik7XG4iKTsKKyAgICAg ICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiAgICBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+ IHJlbG9hZEFjY2Vzc29yR2V0dGVyKHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuYW1lLCBjb25zdCB2 ODo6QWNjZXNzb3JJbmZvJik7XG4iKTsKKyAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiAg ICBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHJlcGxhY2VBY2Nlc3NvckdldHRlcih2ODo6 TG9jYWw8djg6OlN0cmluZz4gbmFtZSwgY29uc3Qgdjg6OkFjY2Vzc29ySW5mbyYpO1xuIik7CiAg ICAgfQogfQogCkBAIC0zODIzLDMgKzM4MjMsNSBAQCBzdWIgRGVidWdQcmludAogICAgIHByaW50 ICRvdXRwdXQ7CiAgICAgcHJpbnQgIlxuIjsKIH0KKworMTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3RPYmouaCBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3RPYmouaAppbmRleCA4ZjUyMTkxMDUz M2RmNzI3NjcyN2VkZmE4NDU0ZWY4Yjc3NzI3M2U0Li5jZGVhZTNlZDM3ZWI2NDM5ZDZmM2I2ZTU4 YTAyM2E5ZWVjNDFmZDAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3Jp cHRzL3Rlc3QvVjgvVjhUZXN0T2JqLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy90ZXN0L1Y4L1Y4VGVzdE9iai5oCkBAIC00Niw4ICs0Niw4IEBAIHB1YmxpYzoKICAgICBz dGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGN1c3RvbU1ldGhvZENhbGxiYWNrKGNvbnN0IHY4 OjpBcmd1bWVudHMmKTsKICAgICBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGN1c3RvbU1l dGhvZFdpdGhBcmdzQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYpOwogICAgIHN0YXRpYyB2 ODo6SGFuZGxlPHY4OjpWYWx1ZT4gY29uc3RydWN0b3JDYWxsYmFjayhjb25zdCB2ODo6QXJndW1l bnRzJik7Ci0gICAgc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBjdXN0b21BdHRyQWNjZXNz b3JHZXR0ZXIodjg6OkxvY2FsPHY4OjpTdHJpbmc+IG5hbWUsIGNvbnN0IHY4OjpBY2Nlc3Nvcklu Zm8mIGluZm8pOwotICAgIHN0YXRpYyB2b2lkIGN1c3RvbUF0dHJBY2Nlc3NvclNldHRlcih2ODo6 TG9jYWw8djg6OlN0cmluZz4gbmFtZSwgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gdmFsdWUsIGNvbnN0 IHY4OjpBY2Nlc3NvckluZm8mIGluZm8pOworICAgIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1 ZT4gY3VzdG9tQXR0ckFjY2Vzc29yR2V0dGVyKHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuYW1lLCBj b25zdCB2ODo6QWNjZXNzb3JJbmZvJik7CisgICAgc3RhdGljIHZvaWQgY3VzdG9tQXR0ckFjY2Vz c29yU2V0dGVyKHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuYW1lLCB2ODo6TG9jYWw8djg6OlZhbHVl PiwgY29uc3Qgdjg6OkFjY2Vzc29ySW5mbyYpOwogICAgIHN0YXRpYyBjb25zdCBpbnQgaW50ZXJu YWxGaWVsZENvdW50ID0gdjhEZWZhdWx0V3JhcHBlckludGVybmFsRmllbGRDb3VudCArIDA7CiAg ICAgc3RhdGljIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gZXhpc3RpbmdXcmFwcGVyKFRlc3RPYmoq KTsKIAo=