73108 2011-11-24 21:40:27 -0800 Initialize global variables during IDLParser object creation 2011-11-24 23:11:00 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72138 1 haraken haraken abarth dominicc japhet webkit.review.bot oldest_to_newest 508947 0 haraken 2011-11-24 21:40:27 -0800 Currently, IDLParser.pm initializes global variables in a global scope, which means that the global variables are initialized just once at the beginning. On the other hand, implementing [Supplemental] IDL (bug 72138) requires a change on generate-bindings.pl that initializes the global variables whenever a new IDLParser object is created. In summary, we need to initialize the global variables during the IDLParser object creation. 508949 1 116559 haraken 2011-11-24 21:46:44 -0800 Created attachment 116559 Patch 508981 2 116559 webkit.review.bot 2011-11-24 23:10:54 -0800 Comment on attachment 116559 Patch Clearing flags on attachment: 116559 Committed r101153: <http://trac.webkit.org/changeset/101153> 508982 3 webkit.review.bot 2011-11-24 23:11:00 -0800 All reviewed patches have been landed. Closing bug. 116559 2011-11-24 21:46:44 -0800 2011-11-24 23:10:54 -0800 Patch bug-73108-20111125144643.patch text/plain 2552 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzk3YjFiZjY5MDUxNTU3 ZWM0MmVlNTdjN2QzOWJjYWNhNjdjNTc2Yy4uNWI0MWFkMmZlYzJiYjcxMDE5ZjA1ODRlYjVhNzgw MWVjNzc4ODUwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDExLTExLTI0ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbml0aWFsaXplIGds b2JhbCB2YXJpYWJsZXMgZHVyaW5nIElETFBhcnNlciBvYmplY3QgY3JlYXRpb24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczMTA4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5LCBJRExQYXJz ZXIucG0gaW5pdGlhbGl6ZXMgZ2xvYmFsIHZhcmlhYmxlcyBpbiBhIGdsb2JhbCBzY29wZSwKKyAg ICAgICAgd2hpY2ggbWVhbnMgdGhhdCB0aGUgZ2xvYmFsIHZhcmlhYmxlcyBhcmUgaW5pdGlhbGl6 ZWQganVzdCBvbmNlIGF0IHRoZSBiZWdpbm5pbmcuCisgICAgICAgIE9uIHRoZSBvdGhlciBoYW5k LCBpbXBsZW1lbnRpbmcgW1N1cHBsZW1lbnRhbF0gSURMIChidWcgNzIxMzgpIHJlcXVpcmVzIGEg Y2hhbmdlCisgICAgICAgIG9uIGdlbmVyYXRlLWJpbmRpbmdzLnBsIHRoYXQgaW5pdGlhbGl6ZXMg dGhlIGdsb2JhbCB2YXJpYWJsZXMgd2hlbmV2ZXIgYSBuZXcgSURMUGFyc2VyCisgICAgICAgIG9i amVjdCBpcyBjcmVhdGVkLiBUaHVzLCB0aGlzIHBhdGNoIGluaXRpYWxpemVzIHRoZSBnbG9iYWwg dmFyaWFibGVzIGR1cmluZworICAgICAgICB0aGUgSURMUGFyc2VyIG9iamVjdCBjcmVhdGlvbi4K KworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAg ICAqIGJpbmRpbmdzL3NjcmlwdHMvSURMUGFyc2VyLnBtOgorICAgICAgICAoSW5pdGlhbGl6ZUds b2JhbERhdGEpOgorICAgICAgICAobmV3KToKKwogMjAxMS0xMS0yNCAgUGF0cmljayBHYW5zdGVy ZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBbQ01ha2VdIEJ1aWxkIGZpeCBmb3Ig Tk9UIEVOQUJMRV9XRUJfU09DS0VUUy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvSURMUGFyc2VyLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9JRExQYXJzZXIucG0KaW5kZXggNjYxMTgzMmMzNTg4ZGZlZThjNjY1NTYwMDU0NDBjZGY1MTg4 NTcwNC4uOTM1YmEyMmY0MmRlYjc4OTM0OGQxNDk4YWE0M2RjMjlkMzI5MDlkNSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9JRExQYXJzZXIucG0KKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9JRExQYXJzZXIucG0KQEAgLTM0LDE0ICszNCwy NSBAQCB1c2UgY29uc3RhbnQgTU9ERV9NT0RVTEUgID0+IDEwOyAjICdtb2R1bGUnIHNlY3Rpb24K IHVzZSBjb25zdGFudCBNT0RFX0lOVEVSRkFDRSAgPT4gMTE7ICMgJ2ludGVyZmFjZScgc2VjdGlv bgogCiAjIEhlbHBlciB2YXJpYWJsZXMKLW15IEB0ZW1wb3JhcnlDb250ZW50ID0gIiI7CitteSBA dGVtcG9yYXJ5Q29udGVudDsKIAotbXkgJHBhcnNlTW9kZSA9IE1PREVfVU5ERUY7Ci1teSAkcHJl c2VydmVkUGFyc2VNb2RlID0gTU9ERV9VTkRFRjsKK215ICRwYXJzZU1vZGU7CitteSAkcHJlc2Vy dmVkUGFyc2VNb2RlOwogCiBteSAkYmVRdWlldDsgIyBTaG91bGQgbm90IGRpc3BsYXkgYW55dGhp bmcgb24gU1RET1VUPwotbXkgJGRvY3VtZW50ID0gMDsgIyBXaWxsIGhvbGQgdGhlIHJlc3VsdGlu ZyAnaWRsRG9jdW1lbnQnCi1teSAkcGFyZW50c09ubHkgPSAwOyAjIElmIDEsIHBhcnNlIG9ubHkg ZW5vdWdoIHRvIHBvcHVsYXRlIHBhcmVudHMgbGlzdAorbXkgJGRvY3VtZW50OyAjIFdpbGwgaG9s ZCB0aGUgcmVzdWx0aW5nICdpZGxEb2N1bWVudCcKK215ICRwYXJlbnRzT25seTsgIyBJZiAxLCBw YXJzZSBvbmx5IGVub3VnaCB0byBwb3B1bGF0ZSBwYXJlbnRzIGxpc3QKKworc3ViIEluaXRpYWxp emVHbG9iYWxEYXRhCit7CisgICAgQHRlbXBvcmFyeUNvbnRlbnQgPSAiIjsKKworICAgICRwYXJz ZU1vZGUgPSBNT0RFX1VOREVGOworICAgICRwcmVzZXJ2ZWRQYXJzZU1vZGUgPSBNT0RFX1VOREVG OworCisgICAgJGRvY3VtZW50ID0gMDsKKyAgICAkcGFyZW50c09ubHkgPSAwOworfQogCiAjIERl ZmF1bHQgQ29uc3RydWN0b3IKIHN1YiBuZXcKQEAgLTQ5LDcgKzYwLDggQEAgc3ViIG5ldwogICAg IG15ICRvYmplY3QgPSBzaGlmdDsKICAgICBteSAkcmVmZXJlbmNlID0geyB9OwogCi0gICAgJGRv Y3VtZW50ID0gMDsKKyAgICBJbml0aWFsaXplR2xvYmFsRGF0YSgpOworCiAgICAgJGJlUXVpZXQg PSBzaGlmdDsKIAogICAgIGJsZXNzKCRyZWZlcmVuY2UsICRvYmplY3QpOwo=