73106 2011-11-24 21:20:18 -0800 Fix the current working directory of run-bindings-tests 2011-11-24 22:36:50 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72138 1 haraken haraken abarth dominicc webkit.review.bot oldest_to_newest 508939 0 haraken 2011-11-24 21:20:18 -0800 Currently, run-bindings-tests outputs the following error (although it outputs "all tests passed!" in the end): Testing the ObjC generator on TestObj.idl gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory gcc: warning: '-x objective-c' after last input file has no effect gcc: no input files This is because CodeGeneratorObjC.pm assumes that the current working directory is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/. We should change it to WebKit/Source/. Incidentally, fixing run-bindings-tests are more reasonable than fixing CodeGeneratorObjC.pm, since real build scripts (e.g. WebCore.gyp) run with the assumption that the current working directory is WebKit/Source/. 508941 1 abarth 2011-11-24 21:23:17 -0800 I see. 508942 2 116557 haraken 2011-11-24 21:24:16 -0800 Created attachment 116557 Patch 508963 3 116557 webkit.review.bot 2011-11-24 22:36:45 -0800 Comment on attachment 116557 Patch Clearing flags on attachment: 116557 Committed r101149: <http://trac.webkit.org/changeset/101149> 508964 4 webkit.review.bot 2011-11-24 22:36:50 -0800 All reviewed patches have been landed. Closing bug. 116557 2011-11-24 21:24:16 -0800 2011-11-24 22:36:45 -0800 Patch bug-73106-20111125142415.patch text/plain 2980 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMTQ2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjVhYmY5ZGFkNzIwMmQwYWNmZmU1YzRlZDFiZmUzYzcy ZTUwNWMzOS4uZjZkMDlhYjhiNjMwM2IxMzZlOTY2NzA1YWFhNjA3NTI5NmUxYjJjZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2 IEBACisyMDExLTExLTI0ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBGaXggdGhlIGN1cnJlbnQgd29ya2luZyBkaXJlY3Rvcnkgb2YgcnVuLWJpbmRpbmdz LXRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 MzEwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1 cnJlbnRseSwgcnVuLWJpbmRpbmdzLXRlc3RzIG91dHB1dHMgdGhlIGZvbGxvd2luZyBlcnJvcgor ICAgICAgICAoYWx0aG91Z2ggaXQgb3V0cHV0cyAiYWxsIHRlc3RzIHBhc3NlZCEiIGluIHRoZSBl bmQpOgorCisgICAgICAgICAgICBUZXN0aW5nIHRoZSBPYmpDIGdlbmVyYXRvciBvbiBUZXN0T2Jq LmlkbAorICAgICAgICAgICAgZ2NjOiBXZWJDb3JlL2JpbmRpbmdzL29iamMvUHVibGljRE9NSW50 ZXJmYWNlcy5oOiBObyBzdWNoIGZpbGUgb3IgZGlyZWN0b3J5CisgICAgICAgICAgICBnY2M6IHdh cm5pbmc6ICcteCBvYmplY3RpdmUtYycgYWZ0ZXIgbGFzdCBpbnB1dCBmaWxlIGhhcyBubyBlZmZl Y3QKKyAgICAgICAgICAgIGdjYzogbm8gaW5wdXQgZmlsZXMKKworICAgICAgICBUaGlzIGlzIGJl Y2F1c2UgQ29kZUdlbmVyYXRvck9iakMucG0gYXNzdW1lcyB0aGF0IHRoZSBjdXJyZW50IHdvcmtp bmcgZGlyZWN0b3J5CisgICAgICAgIGlzIFdlYktpdC9Tb3VyY2UvLCBidXQgcnVuLWJpbmRpbmdz LXRlc3RzIHNldHMgdGhlIGN1cnJlbnQgd29ya2luZyBkaXJlY3RvcnkgdG8gV2ViS2l0Ly4KKyAg ICAgICAgVGh1cywgdGhpcyBwYXRjaCBjaGFuZ2VzIGl0IHRvIFdlYktpdC9Tb3VyY2UvLgorCisg ICAgICAgICogU2NyaXB0cy9ydW4tYmluZGluZ3MtdGVzdHM6CisgICAgICAgIChnZW5lcmF0ZV9m cm9tX2lkbCk6CisgICAgICAgIChtYWluKToKKwogMjAxMS0xMS0yNCAgVG9yIEFybmUgVmVzdGLD uCAgPHRvci5hcm5lLnZlc3Rib0Bub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBHZXQgcmlkIG9m IHRoZSBidWlsZERpckZvclNvdXJjZSgpIGZ1bmN0aW9uIGluIHRoZSBidWlsZCBzeXN0ZW0KZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWJpbmRpbmdzLXRlc3RzIGIvVG9vbHMvU2NyaXB0 cy9ydW4tYmluZGluZ3MtdGVzdHMKaW5kZXggOTg4MjI3NTlhYjQ5NDllNTY5OWFjZWYyMDUxZGUy ZjZlM2ViOTQyMS4uNmYxNTk5OWM4YWE3YzYzOWM1NDI1NWVlODdlMTE5YWM4OTEzZmU0MCAxMDA3 NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tYmluZGluZ3MtdGVzdHMKKysrIGIvVG9vbHMvU2Ny aXB0cy9ydW4tYmluZGluZ3MtdGVzdHMKQEAgLTQwLDggKzQwLDggQEAgZnJvbSB3ZWJraXRweS5j b21tb24uY2hlY2tvdXQuc2NtLmRldGVjdGlvbiBpbXBvcnQgZGV0ZWN0X3NjbV9zeXN0ZW0KIAog ZGVmIGdlbmVyYXRlX2Zyb21faWRsKGdlbmVyYXRvciwgaWRsX2ZpbGUsIG91dHB1dF9kaXJlY3Rv cnkpOgogICAgIGNtZCA9IFsncGVybCcsICctdycsCi0gICAgICAgICAgICctSVNvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMnLAotICAgICAgICAgICAnU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9nZW5lcmF0ZS1iaW5kaW5ncy5wbCcsCisgICAgICAgICAgICctSVdlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cycsCisgICAgICAgICAgICdXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv Z2VuZXJhdGUtYmluZGluZ3MucGwnLAogICAgICAgICAgICAjIGlkbCBpbmNsdWRlIGRpcmVjdG9y aWVzIChwYXRoIHJlbGF0aXZlIHRvIGdlbmVyYXRlLWJpbmRpbmdzLnBsKQogICAgICAgICAgICAn LS1pbmNsdWRlJywgJy4nLAogICAgICAgICAgICAnLS1kZWZpbmVzJywgJ1RFU1RJTkdfJXMnICUg Z2VuZXJhdG9yLApAQCAtMTA5LDcgKzEwOSw3IEBAIGRlZiBtYWluKGFyZ3YpOgogICAgIHJlc2V0 X3Jlc3VsdHMgPSAiLS1yZXNldC1yZXN1bHRzIiBpbiBhcmd2CiAKICAgICBjdXJyZW50X3NjbSA9 IGRldGVjdF9zY21fc3lzdGVtKG9zLmN1cmRpcikKLSAgICBvcy5jaGRpcihjdXJyZW50X3NjbS5j aGVja291dF9yb290KQorICAgIG9zLmNoZGlyKG9zLnBhdGguam9pbihjdXJyZW50X3NjbS5jaGVj a291dF9yb290LCAnU291cmNlJykpCiAKICAgICBhbGxfdGVzdHNfcGFzc2VkID0gVHJ1ZQogCkBA IC0xMjIsOCArMTIyLDggQEAgZGVmIG1haW4oYXJndik6CiAgICAgXQogCiAgICAgZm9yIGdlbmVy YXRvciBpbiBnZW5lcmF0b3JzOgotICAgICAgICBpbnB1dF9kaXJlY3RvcnkgPSBvcy5wYXRoLmpv aW4oJ1NvdXJjZScsICdXZWJDb3JlJywgJ2JpbmRpbmdzJywgJ3NjcmlwdHMnLCAndGVzdCcpCi0g ICAgICAgIHJlZmVyZW5jZV9kaXJlY3RvcnkgPSBvcy5wYXRoLmpvaW4oJ1NvdXJjZScsICdXZWJD b3JlJywgJ2JpbmRpbmdzJywgJ3NjcmlwdHMnLCAndGVzdCcsIGdlbmVyYXRvcikKKyAgICAgICAg aW5wdXRfZGlyZWN0b3J5ID0gb3MucGF0aC5qb2luKCdXZWJDb3JlJywgJ2JpbmRpbmdzJywgJ3Nj cmlwdHMnLCAndGVzdCcpCisgICAgICAgIHJlZmVyZW5jZV9kaXJlY3RvcnkgPSBvcy5wYXRoLmpv aW4oJ1dlYkNvcmUnLCAnYmluZGluZ3MnLCAnc2NyaXB0cycsICd0ZXN0JywgZ2VuZXJhdG9yKQog ICAgICAgICBpZiBub3QgcnVuX3Rlc3RzKGdlbmVyYXRvciwgaW5wdXRfZGlyZWN0b3J5LCByZWZl cmVuY2VfZGlyZWN0b3J5LCByZXNldF9yZXN1bHRzKToKICAgICAgICAgICAgIGFsbF90ZXN0c19w YXNzZWQgPSBGYWxzZQogCg==