73105 2011-11-24 20:55:13 -0800 In run-bindings-tests, replace subprocess.call() with subprocess.Popen() 2011-12-01 22:37:28 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72138 1 haraken haraken abarth dominicc eric webkit.review.bot oldest_to_newest 508935 0 haraken 2011-11-24 20:55:13 -0800 Currently, the stdout and stderr of the child processes of run-bindings-tests are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself. This is the problem of subprocess.call(), which does not synchronize the stdout and stderr between a parent process and a child process. We should replace subprocess.call() with subprocess.Popen() and synchronize the stdout and stderr between them. This makes output messages of run-bindings-tests more readable. 508936 1 116556 haraken 2011-11-24 21:04:52 -0800 Created attachment 116556 Patch 508968 2 116556 webkit.review.bot 2011-11-24 22:44:35 -0800 Comment on attachment 116556 Patch Clearing flags on attachment: 116556 Committed r101150: <http://trac.webkit.org/changeset/101150> 508969 3 webkit.review.bot 2011-11-24 22:44:40 -0800 All reviewed patches have been landed. Closing bug. 509221 4 116556 eric 2011-11-25 11:13:07 -0800 Comment on attachment 116556 Patch As this script grows it should probably move to integrate with the rest of webkitpy (move it's main function onto a new class stored in webkitpy/bindings/main.py, etc.) and use Executive instead of Popen directly for easier mocking/testing. 513473 5 haraken 2011-12-01 21:40:44 -0800 (In reply to comment #4) > (From update of attachment 116556 [details]) > As this script grows it should probably move to integrate with the rest of webkitpy (move it's main function onto a new class stored in webkitpy/bindings/main.py, etc.) and use Executive instead of Popen directly for easier mocking/testing. OK, I will move run_bindings_tests to webkitpy/ in bug 73619 and then replace Popen with Executive in another bug. 513511 6 eric 2011-12-01 22:37:28 -0800 Thanks! 116556 2011-11-24 21:04:52 -0800 2011-11-25 11:13:07 -0800 Patch bug-73105-20111125140451.patch text/plain 6415 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMTQ2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjVhYmY5ZGFkNzIwMmQwYWNmZmU1YzRlZDFiZmUzYzcy ZTUwNWMzOS4uMjBiNjQ3NjM0N2VjNGYzMTY5YzZlYTcxNDRjYjUzZTdhNGM2NjQ4YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDUw IEBACisyMDExLTExLTI0ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXBsYWNlIHN1YnByb2Nlc3MuY2FsbCgpIHdpdGggc3VicHJvY2Vzcy5Qb3Blbigp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzEwNQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnRs eSwgdGhlIHN0ZG91dCBhbmQgc3RkZXJyIG9mIHRoZSBjaGlsZCBwcm9jZXNzZXMgb2YgcnVuLWJp bmRpbmdzLXRlc3RzCisgICAgICAgIGFyZSBtaXhlZCAob3IgZXZlbiBnb25lIGF3YXkpIHdpdGgg dGhlIHN0ZG91dCBhbmQgc3RkZXJyIG9mIHJ1bi1iaW5kaW5ncy10ZXN0cyBpdHNlbGYuCisgICAg ICAgIFRoaXMgaXMgdGhlIHByb2JsZW0gb2Ygc3VicHJvY2Vzcy5jYWxsKCksIHdoaWNoIGRvZXMg bm90IHN5bmNocm9uaXplIHRoZSBzdGRvdXQgYW5kIHN0ZGVycgorICAgICAgICBiZXR3ZWVuIGEg cGFyZW50IHByb2Nlc3MgYW5kIGEgY2hpbGQgcHJvY2Vzcy4gVGhpcyBwYXRjaCByZXBsYWNlcyBz dWJwcm9jZXNzLmNhbGwoKSB3aXRoCisgICAgICAgIHN1YnByb2Nlc3MuUG9wZW4oKSBhbmQgc3lu Y2hyb25pemVzIHRoZSBzdGRvdXQgYW5kIHN0ZGVyciBiZXR3ZWVuIHRoZW0uCisgICAgICAgIFRo aXMgcGF0Y2ggYWxzbyBtYWtlcyBvdXRwdXQgbWVzc2FnZXMgb2YgcnVuLWJpbmRpbmdzLXRlc3Rz IG1vcmUgcmVhZGFibGUuCisKKyAgICAgICAgV2l0aCB0aGlzIHBhdGNoLCB0aGUgb3V0cHV0IG1l c3NhZ2VzIG9mIHJ1bi1iaW5kaW5ncy10ZXN0cyBsb29rIGxpa2UgYXMgZm9sbG93czoKKworICAg ICAgICAgICAgUEFTUzogKENQUCkgV2ViRE9NVGVzdE9iai5oCisgICAgICAgICAgICBQQVNTOiAo Q1BQKSBXZWJET01UZXN0T2JqLmNwcAorICAgICAgICAgICAgRkFJTDogKENQUCkgV2ViRE9NVGVz dEludGVyZmFjZS5oCisgICAgICAgICAgICAtLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy90ZXN0L0NQUC9XZWJET01UZXN0SW50ZXJmYWNlLmggICAgICAyMDExLTExLTI1IDEzOjM0 OjA5LjMxMzUxNjI2OCArMDkwMAorICAgICAgICAgICAgKysrIC90bXAvdG1wREFWODdHL1dlYkRP TVRlc3RJbnRlcmZhY2UuaCAgICAgICAgMjAxMS0xMS0yNSAxMzo0NDo0Mi43MTI5NDY4MTIgKzA5 MDAKKyAgICAgICAgICAgIEBAIC0yMyw3ICsyMyw3IEBACisgICAgICAgICAgICAgI2lmbmRlZiBX ZWJET01UZXN0SW50ZXJmYWNlX2gKKyAgICAgICAgICAgICAjZGVmaW5lIFdlYkRPTVRlc3RJbnRl cmZhY2VfaAorCisgICAgICAgICAgICAtI2lmIEVOQUJMRShDb25kaXRpb24xKSB8fCBFTkFCTEUo Q29uZGl0aW9uMikKKyAgICAgICAgICAgICsjaWYgRU5BQkxFKENvbmRpdGlvbjEpIHx8IEVOQUJM RShDb25kaXRpb24zKQorCisgICAgICAgICAgICAgI2luY2x1ZGUgPFdlYkRPTU9iamVjdC5oPgor ICAgICAgICAgICAgICNpbmNsdWRlIDxXZWJET01TdHJpbmcuaD4KKyAgICAgICAgICAgICBAQCAt NTMsNSArNTMsNSBAQAorICAgICAgICAgICAgIFdlYkRPTVRlc3RJbnRlcmZhY2UgdG9XZWJLaXQo V2ViQ29yZTo6VGVzdEludGVyZmFjZSopOworCisgICAgICAgICAgICAgI2VuZGlmCisgICAgICAg ICAgICAtI2VuZGlmIC8vIEVOQUJMRShDb25kaXRpb24xKSB8fCBFTkFCTEUoQ29uZGl0aW9uMikK KyAgICAgICAgICAgICsjZW5kaWYgLy8gRU5BQkxFKENvbmRpdGlvbjEpIHx8IEVOQUJMRShDb25k aXRpb24zKQorICAgICAgICAgICAgUEFTUzogKENQUCkgV2ViRE9NRmxvYXQ2NEFycmF5LmNwcAor ICAgICAgICAgICAgUEFTUzogKENQUCkgV2ViRE9NRmxvYXQ2NEFycmF5LmgKKworICAgICAgICAg ICAgU29tZSB0ZXN0cyBGQUlMISAoVG8gdXBkYXRlIHRoZSByZWZlcmVuY2UgZmlsZXMsIGV4ZWN1 dGUgInJ1bi1iaW5kaW5ncy10ZXN0cyAtLXJlc2V0LXJlc3VsdHMiKQorCisgICAgICAgICogU2Ny aXB0cy9ydW4tYmluZGluZ3MtdGVzdHM6CisgICAgICAgIChnZW5lcmF0ZV9mcm9tX2lkbCk6Cisg ICAgICAgIChkZXRlY3RfY2hhbmdlcyk6CisgICAgICAgIChydW5fdGVzdHMpOgorICAgICAgICAo bWFpbik6CisKIDIwMTEtMTEtMjQgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9A bm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gR2V0IHJpZCBvZiB0aGUgYnVpbGREaXJGb3JTb3Vy Y2UoKSBmdW5jdGlvbiBpbiB0aGUgYnVpbGQgc3lzdGVtCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3J1bi1iaW5kaW5ncy10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWJpbmRpbmdzLXRlc3Rz CmluZGV4IDk4ODIyNzU5YWI0OTQ5ZTU2OTlhY2VmMjA1MWRlMmY2ZTNlYjk0MjEuLmY4MzMzZWJm Y2ZjMTdjNGUwNGZjYmUwNGJhMDgzMzk1OWVkNjEzODQgMTAwNzU1Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvcnVuLWJpbmRpbmdzLXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWJpbmRpbmdzLXRl c3RzCkBAIC00OCwyMiArNDgsMzIgQEAgZGVmIGdlbmVyYXRlX2Zyb21faWRsKGdlbmVyYXRvciwg aWRsX2ZpbGUsIG91dHB1dF9kaXJlY3RvcnkpOgogICAgICAgICAgICAnLS1nZW5lcmF0b3InLCBn ZW5lcmF0b3IsCiAgICAgICAgICAgICctLW91dHB1dERpcicsIG91dHB1dF9kaXJlY3RvcnksCiAg ICAgICAgICAgIGlkbF9maWxlXQotICAgIHJldHVybiBzdWJwcm9jZXNzLmNhbGwoY21kKSA9PSAw CiAKKyAgICBwcm9jZXNzID0gc3VicHJvY2Vzcy5Qb3BlbihjbWQsIHN0ZG91dCA9IHN1YnByb2Nl c3MuUElQRSwgc3RkZXJyID0gc3VicHJvY2Vzcy5TVERPVVQpCisgICAgZXhpdF9jb2RlID0gcHJv Y2Vzcy53YWl0KCkKKyAgICBvdXRwdXQgPSBwcm9jZXNzLmNvbW11bmljYXRlKClbMF0KKyAgICBp ZiBvdXRwdXQ6CisgICAgICAgIHByaW50IG91dHB1dAorICAgIHJldHVybiBleGl0X2NvZGUKIAot ZGVmIGRldGVjdF9jaGFuZ2VzKHdvcmtfZGlyZWN0b3J5LCByZWZlcmVuY2VfZGlyZWN0b3J5KToK KworZGVmIGRldGVjdF9jaGFuZ2VzKGdlbmVyYXRvciwgd29ya19kaXJlY3RvcnksIHJlZmVyZW5j ZV9kaXJlY3RvcnkpOgogICAgIGNoYW5nZXNfZm91bmQgPSBGYWxzZQogICAgIGZvciBvdXRwdXRf ZmlsZSBpbiBvcy5saXN0ZGlyKHdvcmtfZGlyZWN0b3J5KToKLSAgICAgICAgcHJpbnQgJ0RldGVj dGluZyBjaGFuZ2VzIGluICVzLi4uJyAlIG91dHB1dF9maWxlCiAgICAgICAgIGNtZCA9IFsnZGlm ZicsCiAgICAgICAgICAgICAgICAnLXUnLAogICAgICAgICAgICAgICAgb3MucGF0aC5qb2luKHJl ZmVyZW5jZV9kaXJlY3RvcnksIG91dHB1dF9maWxlKSwKICAgICAgICAgICAgICAgIG9zLnBhdGgu am9pbih3b3JrX2RpcmVjdG9yeSwgb3V0cHV0X2ZpbGUpXQotICAgICAgICBpZiBzdWJwcm9jZXNz LmNhbGwoY21kKSAhPSAwOgotICAgICAgICAgICAgcHJpbnQgJ0RldGVjdGVkIGNoYW5nZXMgaW4g JXMgKHNlZSBhYm92ZSknICUgb3V0cHV0X2ZpbGUKKworICAgICAgICBwcm9jZXNzID0gc3VicHJv Y2Vzcy5Qb3BlbihjbWQsIHN0ZG91dCA9IHN1YnByb2Nlc3MuUElQRSwgc3RkZXJyID0gc3VicHJv Y2Vzcy5TVERPVVQpCisgICAgICAgIHByb2Nlc3Mud2FpdCgpCisgICAgICAgIG91dHB1dCA9IHBy b2Nlc3MuY29tbXVuaWNhdGUoKVswXQorICAgICAgICBpZiBvdXRwdXQ6CisgICAgICAgICAgICBw cmludCAnRkFJTDogKCVzKSAlcycgJSAoZ2VuZXJhdG9yLCBvdXRwdXRfZmlsZSkKKyAgICAgICAg ICAgIHByaW50IG91dHB1dAogICAgICAgICAgICAgY2hhbmdlc19mb3VuZCA9IFRydWUKICAgICAg ICAgZWxzZToKLSAgICAgICAgICAgIHByaW50ICdObyBjaGFuZ2VzIGZvdW5kLicKKyAgICAgICAg ICAgIHByaW50ICdQQVNTOiAoJXMpICVzJyAlIChnZW5lcmF0b3IsIG91dHB1dF9maWxlKQogCiAg ICAgcmV0dXJuIGNoYW5nZXNfZm91bmQKIApAQCAtNzYsMzAgKzg2LDMwIEBAIGRlZiBydW5fdGVz dHMoZ2VuZXJhdG9yLCBpbnB1dF9kaXJlY3RvcnksIHJlZmVyZW5jZV9kaXJlY3RvcnksIHJlc2V0 X3Jlc3VsdHMpOgogICAgICAgICAobmFtZSwgZXh0ZW5zaW9uKSA9IG9zLnBhdGguc3BsaXRleHQo aW5wdXRfZmlsZSkKICAgICAgICAgaWYgZXh0ZW5zaW9uICE9ICcuaWRsJzoKICAgICAgICAgICAg IGNvbnRpbnVlCi0gICAgICAgIHByaW50ICdUZXN0aW5nIHRoZSAlcyBnZW5lcmF0b3Igb24gJXMn ICUgKGdlbmVyYXRvciwgaW5wdXRfZmlsZSkKLSAgICAgICAgIyBHZW5lcmF0ZSBvdXRwdXQgaW50 byB0aGUgd29yayBkaXJlY3RvcnkgKGVpdGhlciB0aGUgZ2l2ZW4gb25lIG9yIGEgCisgICAgICAg ICMgR2VuZXJhdGUgb3V0cHV0IGludG8gdGhlIHdvcmsgZGlyZWN0b3J5IChlaXRoZXIgdGhlIGdp dmVuIG9uZSBvciBhCiAgICAgICAgICMgdGVtcCBvbmUgaWYgbm90IHJlc2V0X3Jlc3VsdHMgaXMg cGVyZm9ybWVkKQogICAgICAgICBpZiBub3QgcmVzZXRfcmVzdWx0czoKICAgICAgICAgICAgIHdv cmtfZGlyZWN0b3J5ID0gdGVtcGZpbGUubWtkdGVtcCgpCi0gICAgICAgIGlmIG5vdCBnZW5lcmF0 ZV9mcm9tX2lkbChnZW5lcmF0b3IsIG9zLnBhdGguam9pbihpbnB1dF9kaXJlY3RvcnksCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnB1 dF9maWxlKSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHdvcmtfZGlyZWN0b3J5 KToKKworICAgICAgICBpZiBnZW5lcmF0ZV9mcm9tX2lkbChnZW5lcmF0b3IsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIG9zLnBhdGguam9pbihpbnB1dF9kaXJlY3RvcnksIGlucHV0X2Zp bGUpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICB3b3JrX2RpcmVjdG9yeSk6CiAgICAg ICAgICAgICBwYXNzZWQgPSBGYWxzZQorCiAgICAgICAgIGlmIHJlc2V0X3Jlc3VsdHM6Ci0gICAg ICAgICAgICBwcmludCAiT3Zlcndyb3RlIHJlZmVyZW5jZSBmaWxlcyIKKyAgICAgICAgICAgIHBy aW50ICJSZXNldCByZXN1bHRzOiAoJXMpICVzIiAlIChnZW5lcmF0b3IsIGlucHV0X2ZpbGUpCiAg ICAgICAgICAgICBjb250aW51ZQorCiAgICAgICAgICMgRGV0ZWN0IGNoYW5nZXMKLSAgICAgICAg aWYgZGV0ZWN0X2NoYW5nZXMod29ya19kaXJlY3RvcnksIHJlZmVyZW5jZV9kaXJlY3RvcnkpOgor ICAgICAgICBpZiBkZXRlY3RfY2hhbmdlcyhnZW5lcmF0b3IsIHdvcmtfZGlyZWN0b3J5LCByZWZl cmVuY2VfZGlyZWN0b3J5KToKICAgICAgICAgICAgIHBhc3NlZCA9IEZhbHNlCiAgICAgICAgIHNo dXRpbC5ybXRyZWUod29ya19kaXJlY3RvcnkpCiAKLSAgICBpZiBub3QgcGFzc2VkOgotICAgICAg ICBwcmludCAnJXMgZ2VuZXJhdG9yIGZhaWxlZC4nICUgZ2VuZXJhdG9yCiAgICAgcmV0dXJuIHBh c3NlZAogCiAKIGRlZiBtYWluKGFyZ3YpOgotICAgICIiIlJ1bnMgV2ViQ29yZSBiaW5kaW5ncyBj b2RlIGdlbmVyYXRvcnMgb24gdGVzdCBJREwgZmlsZXMgYW5kIGNvbXBhcmVzIAorICAgICIiIlJ1 bnMgV2ViQ29yZSBiaW5kaW5ncyBjb2RlIGdlbmVyYXRvcnMgb24gdGVzdCBJREwgZmlsZXMgYW5k IGNvbXBhcmVzCiAgICAgdGhlIHJlc3VsdHMgd2l0aCByZWZlcmVuY2UgZmlsZXMuCiAKICAgICBP cHRpb25zOgpAQCAtMTI3LDExICsxMzcsMTIgQEAgZGVmIG1haW4oYXJndik6CiAgICAgICAgIGlm IG5vdCBydW5fdGVzdHMoZ2VuZXJhdG9yLCBpbnB1dF9kaXJlY3RvcnksIHJlZmVyZW5jZV9kaXJl Y3RvcnksIHJlc2V0X3Jlc3VsdHMpOgogICAgICAgICAgICAgYWxsX3Rlc3RzX3Bhc3NlZCA9IEZh bHNlCiAKKyAgICBwcmludCAnJwogICAgIGlmIGFsbF90ZXN0c19wYXNzZWQ6Ci0gICAgICAgIHBy aW50ICdBbGwgdGVzdHMgcGFzc2VkIScKKyAgICAgICAgcHJpbnQgJ0FsbCB0ZXN0cyBQQVNTIScK ICAgICAgICAgcmV0dXJuIDAKICAgICBlbHNlOgotICAgICAgICBwcmludCAnKFRvIHVwZGF0ZSB0 aGUgcmVmZXJlbmNlIGZpbGVzLCBleGVjdXRlICJydW4tYmluZGluZ3MtdGVzdHMgLS1yZXNldC1y ZXN1bHRzIiknCisgICAgICAgIHByaW50ICdTb21lIHRlc3RzIEZBSUwhIChUbyB1cGRhdGUgdGhl IHJlZmVyZW5jZSBmaWxlcywgZXhlY3V0ZSAicnVuLWJpbmRpbmdzLXRlc3RzIC0tcmVzZXQtcmVz dWx0cyIpJwogICAgICAgICByZXR1cm4gLTEKIAogCg==