73056 2011-11-23 16:03:25 -0800 Cannot select RTL text inside LTR text from right to left by a mouse drag 2011-11-30 15:27:16 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 59435 1 rniwa rniwa eric mitz playmobil xji oldest_to_newest 508474 0 rniwa 2011-11-23 16:03:25 -0800 If we have: aאבגb and select "אבג" from the right to the left by a mouse drag, then "בג" will be selected first instead of "א". 508487 1 116450 rniwa 2011-11-23 16:29:26 -0800 Created attachment 116450 fixes the bug 510156 2 rniwa 2011-11-28 14:05:07 -0800 Ping reviewers. This is a no-brainer fix (of my bug :( ). 510399 3 116450 eric 2011-11-28 18:54:06 -0800 Comment on attachment 116450 fixes the bug LGTM. You might want mitz or justin's stamp, but this looks right. 512183 4 116450 rniwa 2011-11-30 15:27:11 -0800 Comment on attachment 116450 fixes the bug Clearing flags on attachment: 116450 Committed r101561: <http://trac.webkit.org/changeset/101561> 512184 5 rniwa 2011-11-30 15:27:16 -0800 All reviewed patches have been landed. Closing bug. 116450 2011-11-23 16:29:26 -0800 2011-11-30 15:27:11 -0800 fixes the bug bug-73056-20111123162925.patch text/plain 5567 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMTExMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDExLTExLTIzICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENhbm5vdCBzZWxlY3QgUlRMIHRl eHQgaW5zaWRlIExUUiB0ZXh0IGZyb20gcmlnaHQgdG8gbGVmdCBieSBhIG1vdXNlIGRyYWcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczMDU2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGJ1ZyB3YXMg Y2F1c2VkIGJ5IHBvc2l0aW9uQXRSaWdodEJvdW5kYXJ5T2ZCaURpUnVuIHVzaW5nIGN1cnJlbnQg aW5saW5lIGJveCdzIG9mZnNldAorICAgICAgICBldmVuIHdoZW4gY3JlYXRpbmcgYSBwb3NpdGlv biB3aXRoIHByZXZpb3VzIGlubGluZSBib3guIEZpeGVkIHRoZSBidWcgYnkgdXNpbmcgdGhlIGNv cnJlY3Qgb2Zmc2V0LgorCisgICAgICAgICogZWRpdGluZy9SZW5kZXJlZFBvc2l0aW9uLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlcmVkUG9zaXRpb246OnBvc2l0aW9uQXRMZWZ0Qm91bmRh cnlPZkJpRGlSdW4pOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyZWRQb3NpdGlvbjo6cG9zaXRp b25BdFJpZ2h0Qm91bmRhcnlPZkJpRGlSdW4pOgorCiAyMDExLTExLTIzICBOaWNvIFdlYmVyICA8 dGhha2lzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZW1vdmUgb25lIHN0YXRpYyBpbml0aWFs aXplciAoZm9yIGtUaWNrVGltZSkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvUmVuZGVy ZWRQb3NpdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9SZW5k ZXJlZFBvc2l0aW9uLmNwcAkocmV2aXNpb24gMTAxMDk0KQorKysgU291cmNlL1dlYkNvcmUvZWRp dGluZy9SZW5kZXJlZFBvc2l0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjExLDcgKzIxMSw3 IEBAIFBvc2l0aW9uIFJlbmRlcmVkUG9zaXRpb246OnBvc2l0aW9uQXRMZWYKICAgICBpZiAoYXRM ZWZ0bW9zdE9mZnNldEluQm94KCkpCiAgICAgICAgIHJldHVybiBjcmVhdGVMZWdhY3lFZGl0aW5n UG9zaXRpb24obV9yZW5kZXJlci0+bm9kZSgpLCBtX29mZnNldCk7CiAKLSAgICByZXR1cm4gY3Jl YXRlTGVnYWN5RWRpdGluZ1Bvc2l0aW9uKG5leHRMZWFmQ2hpbGQoKS0+cmVuZGVyZXIoKS0+bm9k ZSgpLCBtX29mZnNldCk7CisgICAgcmV0dXJuIGNyZWF0ZUxlZ2FjeUVkaXRpbmdQb3NpdGlvbihu ZXh0TGVhZkNoaWxkKCktPnJlbmRlcmVyKCktPm5vZGUoKSwgbmV4dExlYWZDaGlsZCgpLT5jYXJl dExlZnRtb3N0T2Zmc2V0KCkpOwogfQogCiBQb3NpdGlvbiBSZW5kZXJlZFBvc2l0aW9uOjpwb3Np dGlvbkF0UmlnaHRCb3VuZGFyeU9mQmlEaVJ1bigpIGNvbnN0CkBAIC0yMjEsNyArMjIxLDcgQEAg UG9zaXRpb24gUmVuZGVyZWRQb3NpdGlvbjo6cG9zaXRpb25BdFJpZwogICAgIGlmIChhdFJpZ2h0 bW9zdE9mZnNldEluQm94KCkpCiAgICAgICAgIHJldHVybiBjcmVhdGVMZWdhY3lFZGl0aW5nUG9z aXRpb24obV9yZW5kZXJlci0+bm9kZSgpLCBtX29mZnNldCk7CiAKLSAgICByZXR1cm4gY3JlYXRl TGVnYWN5RWRpdGluZ1Bvc2l0aW9uKHByZXZMZWFmQ2hpbGQoKS0+cmVuZGVyZXIoKS0+bm9kZSgp LCBtX29mZnNldCk7CisgICAgcmV0dXJuIGNyZWF0ZUxlZ2FjeUVkaXRpbmdQb3NpdGlvbihwcmV2 TGVhZkNoaWxkKCktPnJlbmRlcmVyKCktPm5vZGUoKSwgcHJldkxlYWZDaGlsZCgpLT5jYXJldFJp Z2h0bW9zdE9mZnNldCgpKTsKIH0KIAogTGF5b3V0UmVjdCBSZW5kZXJlZFBvc2l0aW9uOjphYnNv bHV0ZVJlY3QoaW50KiBleHRyYVdpZHRoVG9FbmRPZkxpbmUpIGNvbnN0CkluZGV4OiBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZp c2lvbiAxMDExMTApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxNiBAQAorMjAxMS0xMS0yMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9y Zz4KKworICAgICAgICBDYW5ub3Qgc2VsZWN0IFJUTCB0ZXh0IGluc2lkZSBMVFIgdGV4dCBmcm9t IHJpZ2h0IHRvIGxlZnQgYnkgYSBtb3VzZSBkcmFnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzA1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGEgdGVzdCBjYXNlIHRvIGVuc3VyZSBXZWJLaXQg Y2FuIHNlbGVjdCAiQSIgaW4gImFDQkFiIiB3aGVuIHNlbGVjdGluZyB0ZXh0IGJ5IGEgbW91c2Ug ZHJhZworICAgICAgICBmcm9tIHRoZSBwb3NpdGlvbiBiZXR3ZWVuICJBIiBhbmQgImIiIHRvIHRo ZSBwb3NpdGlvbiBiZXR3ZWVuICJCIiBhbmQgIkEiLgorCisgICAgICAgICogZWRpdGluZy9zZWxl Y3Rpb24vc2VsZWN0LWJpZGktcnVuLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBlZGl0aW5nL3Nl bGVjdGlvbi9zZWxlY3QtYmlkaS1ydW4uaHRtbDoKKwogMjAxMS0xMS0yMyAgQWRhbSBLbGVpbiAg PGFkYW1rQGNocm9taXVtLm9yZz4KIAogICAgICAgICBNb3JlIENocm9taXVtIHJlYmFzZWxpbmVz IGZvciByMTAxMDYyLiBVbnJldmlld2VkIGdhcmRlbmluZy4KSW5kZXg6IExheW91dFRlc3RzL2Vk aXRpbmcvc2VsZWN0aW9uL3NlbGVjdC1iaWRpLXJ1bi1leHBlY3RlZC50eHQKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vc2VsZWN0LWJpZGktcnVuLWV4cGVjdGVk LnR4dAkocmV2aXNpb24gMTAxMDk0KQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24v c2VsZWN0LWJpZGktcnVuLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMTEyLDYgKzEx MiwxNiBAQCBQQVNTIHNlbGVjdGVkICJBQkMgMTIiCiBQQVNTIHNlbGVjdGVkICJBQkMgMSIKIEZB SUwgc2VsZWN0ZWQgIjEyMyIgYnV0IGV4cGVjdGVkICJBQkMgMTIzIgogCitUZXN0ICJBQkMiIGlu ICJhQUJDYiI6CitTZWxlY3RpbmcgZnJvbSBsZWZ0IHRvIHJpZ2h0CitQQVNTIHNlbGVjdGVkICJD IgorUEFTUyBzZWxlY3RlZCAiQkMiCitQQVNTIHNlbGVjdGVkICJBQkMiCitTZWxlY3RpbmcgZnJv bSByaWdodCB0byBsZWZ0CitQQVNTIHNlbGVjdGVkICJBIgorUEFTUyBzZWxlY3RlZCAiQUIiCitQ QVNTIHNlbGVjdGVkICJBQkMiCisKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAog VEVTVCBDT01QTEVURQpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vc2VsZWN0 LWJpZGktcnVuLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rp b24vc2VsZWN0LWJpZGktcnVuLmh0bWwJKHJldmlzaW9uIDEwMTA5NCkKKysrIExheW91dFRlc3Rz L2VkaXRpbmcvc2VsZWN0aW9uL3NlbGVjdC1iaWRpLXJ1bi5odG1sCSh3b3JraW5nIGNvcHkpCkBA IC04LDYgKzgsNyBAQAogZHQgeyB3aWR0aDogMTVleDsgcGFkZGluZzogMHB4IDEwcHg7IG1hcmdp bjogMHB4OyB9CiBkZCB7IGZvbnQtc2l6ZTogMC42ZW07IG1hcmdpbjogMHB4OyBwYWRkaW5nOiAw cHggMTBweDsgfQogLnRhcmdldCB7IGJhY2tncm91bmQtY29sb3I6ICNiYmVlZmY7IH0KKy50YXJn ZXRDb250YWluZXIgeyBwb3NpdGlvbjogYWJzb2x1dGU7IGxlZnQ6IDEwcHg7IHRvcDogMHB4OyB6 LWluZGV4OiAtNTsgfQogPC9zdHlsZT4KIDwvaGVhZD4KIDxib2R5PgpAQCAtNDQsNiArNDUsOSBA QCBEbyB0aGUgc2FtZSBieSBhIG1vdXNlIGRyYWcgZnJvbSByaWdodCB0CiA8ZHQgY29udGVudGVk aXRhYmxlPjxzcGFuIGNsYXNzPSJ0YXJnZXQiPteQ15HXkiAxMjM8L3NwYW4+PC9kdD4KIDxkZD4x LDEyLCAxMjMsQyAxMjMsQkMgMTIzLEFCQyAxMjN8QSxBQixBQkMsQUJDICxBQkMgMTIsQUJDIDEs QUJDIDEyMzwvZGQ+CiAKKzxkdCBjb250ZW50ZWRpdGFibGUgc3R5bGU9InBvc2l0aW9uOiByZWxh dGl2ZTsiPmHXkNeR15JiPGRpdiBjbGFzcz0idGFyZ2V0Q29udGFpbmVyIj5hPHNwYW4gY2xhc3M9 InRhcmdldCI+15DXkdeSPC9zcGFuPmI8L2Rpdj48L2R0PgorPGRkPkMsQkMsQUJDfEEsQUIsQUJD PC9kZD4KKwogPCEtLTxkdCBjb250ZW50ZWRpdGFibGU+PHNwYW4gY2xhc3M9InRhcmdldCI+15DX kdeSIDEyMyAtIDQ1Njwvc3Bhbj48L2R0PgogPGRkPjEsMTIsIDEyMyxDIDEyMyxCQyAxMjMsQUJD IDEyM3xBLEFCLEFCQyxBQkMgLEFCQyAxMixBQkMgMSxBQkMgMTIzPC9kZD4tLT4KIApAQCAtNzEs NiArNzUsMTMgQEAgZnVuY3Rpb24gc2VsZWN0QnlNb3VzZURyYWdBbmRWZXJpZnlSZXN1bAogICAg IHZhciB5ID0gdGFyZ2V0Lm9mZnNldFRvcCArIHRhcmdldC5vZmZzZXRIZWlnaHQgLyAyOwogICAg IHZhciBsZWZ0ID0gdGFyZ2V0Lm9mZnNldExlZnQ7CiAKKyAgICBvZmZzZXRQYXJlbnQgPSB0YXJn ZXQub2Zmc2V0UGFyZW50OworICAgIHdoaWxlIChvZmZzZXRQYXJlbnQpIHsKKyAgICAgICAgeSAr PSBvZmZzZXRQYXJlbnQub2Zmc2V0VG9wOworICAgICAgICBsZWZ0ICs9IG9mZnNldFBhcmVudC5v ZmZzZXRMZWZ0OworICAgICAgICBvZmZzZXRQYXJlbnQgPSBvZmZzZXRQYXJlbnQub2Zmc2V0UGFy ZW50OworICAgIH0KKwogICAgIHZhciBzdGFydFggPSBsZWZ0ICsgKGxlZnRUb1JpZ2h0ID8gMCA6 IHRhcmdldC5vZmZzZXRXaWR0aCk7CiAgICAgZXZlbnRTZW5kZXIuZHJhZ01vZGUgPSBmYWxzZTsK IApAQCAtMTE0LDYgKzEyNSw3IEBAIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsK ICAgICAgICAgdGVzdEV4cGVjdGF0aW9uc1tpXS5zdHlsZS5kaXNwbGF5ID0gbnVsbDsKIAogICAg ICAgICB2YXIgdGFyZ2V0ID0gdGVzdHNbaV0uZ2V0RWxlbWVudHNCeUNsYXNzTmFtZSgndGFyZ2V0 JylbMF07CisgICAgICAgIHZhciByZWxhdGl2ZVRhcmdldHMgPSB0ZXN0c1tpXS5nZXRFbGVtZW50 c0J5Q2xhc3NOYW1lKCdyZWxhdGl2ZVRhcmdldCcpOwogICAgICAgICB2YXIgdGVzdEV4cGVjdGF0 aW9uID0gdGVzdEV4cGVjdGF0aW9uc1tpXS50ZXh0Q29udGVudDsKIAogICAgICAgICBkZWJ1Zygn VGVzdCAiJyArIHRhcmdldC50ZXh0Q29udGVudC5mb2xkKCkgKyAnIiBpbiAiJyArIHRhcmdldC5w YXJlbnROb2RlLnRleHRDb250ZW50LmZvbGQoKSArICciOicpOwo=