72805 2011-11-19 11:49:36 -0800 [GTK] gtk_widget_size_allocate for plugin widgets should happen in the WebView size-allocate method 2012-02-03 15:46:10 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68757 1 mrobinson mrobinson cgarcia webkit.review.bot zuh oldest_to_newest 506426 0 mrobinson 2011-11-19 11:49:36 -0800 Currently gtk_widget_size_allocate is called while rendering the WebView. Ideally this would happen in the size-allocate method of the WebView. This will help illiminate artifacts around plugins will scrolling. 506487 1 115974 mrobinson 2011-11-19 20:23:56 -0800 Created attachment 115974 Patch 511701 2 115974 cgarcia 2011-11-30 06:20:54 -0800 Comment on attachment 115974 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115974&action=review > Source/WebCore/plugins/gtk/PluginViewGtk.cpp:595 > + g_object_set_data(G_OBJECT(widget), "delayed-allocation", &m_delayedAllocation); We might use a HashMap instead of a HashSet and store the allocation as the value instead of using g_object_set_data(), see the new windowed plugins patch > Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:571 > + if (static_cast<GtkAllocation*>(g_object_get_data(G_OBJECT(*current), "delayed-allocation"))) { using a hash map here you simply would do: if (!current->second.isEmpty()) 512097 3 mrobinson 2011-11-30 13:48:24 -0800 (In reply to comment #2) > We might use a HashMap instead of a HashSet and store the allocation as the value instead of using g_object_set_data(), see the new windowed plugins patch I think we have to use g_object_set_data here because the WebKit layer cannot expose any interface to WebCore. 519300 4 115974 gustavo 2011-12-12 10:14:57 -0800 Comment on attachment 115974 Patch Good idea =) 519332 5 115974 webkit.review.bot 2011-12-12 10:44:25 -0800 Comment on attachment 115974 Patch Clearing flags on attachment: 115974 Committed r102604: <http://trac.webkit.org/changeset/102604> 519334 6 webkit.review.bot 2011-12-12 10:44:33 -0800 All reviewed patches have been landed. Closing bug. 549176 7 mrobinson 2012-02-03 15:46:10 -0800 *** Bug 26040 has been marked as a duplicate of this bug. *** 115974 2011-11-19 20:23:56 -0800 2011-12-12 10:44:25 -0800 Patch bug-72805-20111119202355.patch text/plain 6726 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjUxNTg0MzIxMDc3Yzdh M2ZhYTI3NTIwNDM5ZjNjMWIwZWIwZTAxZC4uYjZhOTNhNDA4ODdmMmJkMWY1ZjEwNzc1MzA0YTgy NzE4YmIzMzA4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTExLTE5ICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBndGtf d2lkZ2V0X3NpemVfYWxsb2NhdGUgZm9yIHBsdWdpbiB3aWRnZXRzIHNob3VsZCBoYXBwZW4gaW4g dGhlIFdlYlZpZXcgc2l6ZS1hbGxvY2F0ZSBtZXRob2QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyODA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIGlzIG9ubHkgYSBwZXJm b3JtYW5jZSB0d2Vhay4KKworICAgICAgICBJbnN0ZWFkIG9mIGltbWVkaWF0ZWx5IGNhbGxpbmcg Z3RrX3dpZGdldF9zaXplIGR1cmluZyBwYWludGluZywgZGVmZXIKKyAgICAgICAgdGhpcyB1bnRp bCB0aGUgc2l6ZS1hbGxvY2F0ZSBtZXRob2Qgb2YgdGhlIFdlYlZpZXcuCisKKyAgICAgICAgKiBw bHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZp ZXc6OnVwZGF0ZVdpZGdldEFsbG9jYXRpb25BbmRDbGlwKTogSW5zdGVhZCBvZiBpbW1lZGlhdGVs eSBjaGFuZ2luZworICAgICAgICB0aGUgd2lkZ2V0IGFsbG9jYXRpb24sIGp1c3QgcmVjb3JkIGl0 IGluIGEgR09iamVjdCBkYXRhIGF0dGFjaG1lbnQuCisKIDIwMTEtMTEtMTkgIFZzZXZvbG9kIFZs YXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjpbcHJv dG9jb2xdIGFjdHVhbCBKU09OIG1lc3NhZ2VzIGRvIG5vdCBjb25mb3JtIHRvIEluc3BlY3Rvci5q c29uIGluIEluc3BlY3RvckFwcGxpY2F0aW9uQ2FjaGVBZ2VudC5jcHAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpp bmRleCA2YzA3YzdjZmQxNjdlNGI3Nzg5NmE0OTZkZWQ3OGJiZmRjY2YxMGNlLi4wN2VlNzQ5MDY0 M2IwNjQzNjc3NDg4OTBmZDk0Y2YzMjJmNzNiNTdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjAgQEAKKzIwMTEtMTEtMTkgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEu Y29tPgorCisgICAgICAgIFtHVEtdIGd0a193aWRnZXRfc2l6ZV9hbGxvY2F0ZSBmb3IgcGx1Z2lu IHdpZGdldHMgc2hvdWxkIGhhcHBlbiBpbiB0aGUgV2ViVmlldyBzaXplLWFsbG9jYXRlIG1ldGhv ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI4MDUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnN0ZWFk IG9mIGltbWVkaWF0ZWx5IGNhbGxpbmcgZ3RrX3dpZGdldF9zaXplIGR1cmluZyBwYWludGluZywg ZGVmZXIKKyAgICAgICAgdGhpcyB1bnRpbCB0aGUgc2l6ZS1hbGxvY2F0ZSBtZXRob2Qgb2YgdGhl IFdlYlZpZXcuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3Bw OgorICAgICAgICAoV2ViS2l0OjpDaHJvbWVDbGllbnQ6OnBhaW50KTogSWYgYW55IGNoaWxkIHdp ZGdldHMgaGF2ZSBhIHBlbmRpbmcgYWxsb2NhdGlvbgorICAgICAgICBjYWxsIGd0a193aWRnZXRf c2l6ZV9hbGxvY2F0ZS4KKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6CisgICAg ICAgICh1cGRhdGVDaGlsZEFsbG9jYXRpb25Gcm9tUGVuZGluZ0FsbG9jYXRpb24pOiBBZGRlZCB0 aGlzIGhlbHBlci4KKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19zaXplX2FsbG9jYXRlKTogQ2Fs bCB0aGUgaGVscGVyIG9uIGFsbCBjaGlsZCB3aWRnZXRzLgorCiAyMDExLTExLTE4ICBNYXJ0aW4g Um9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChy OTk5MjQpOiBicm9rZSAyIHBhc3RlYm9hcmQgdGVzdHMgb24gR1RLCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCmluZGV4IDQ5MWNiYjZkZmVkM2Q5YTE4Mzlj MmIwNWZjYjczNGM0YjU1ZDUyOTUuLjcwYTE5ZTA2YWJkODg2NzgzYTViZGNmMWIxMjQyMDFiZjIy ZTY4MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdH dGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3Bw CkBAIC01NzYsMTcgKzU3NiwxNCBAQCB2b2lkIFBsdWdpblZpZXc6OnVwZGF0ZVdpZGdldEFsbG9j YXRpb25BbmRDbGlwKCkKICNlbmRpZgogICAgIH0KIAotICAgIEd0a0FsbG9jYXRpb24gYWxsb2Nh dGlvbihtX2RlbGF5ZWRBbGxvY2F0aW9uKTsKLSAgICBtX2RlbGF5ZWRBbGxvY2F0aW9uID0gSW50 UmVjdCgpOwotCi0gICAgLy8gVGhlIGdvYWwgaXMgdG8gYXZvaWQgY2FsbGluZyBndGtfd2lkZ2V0 X3NpemVfYWxsb2NhdGUgd2hlbiBuZWNlc3NhcnkuCi0gICAgLy8gSXQgYmxvY2tzIHRoZSBtYWlu IGxvb3AgYW5kIGlmIHRoZSB3aWRnZXQgaXMgb2Zmc2NyZWVuIG9yIGhhc24ndCBtb3ZlZAotICAg IC8vIGl0IGlzbid0IHJlcXVpcmVkLgorICAgIC8vIFRoZSBnb2FsIGlzIHRvIHRyeSB0byBhdm9p ZCBjYWxsaW5nIGd0a193aWRnZXRfc2l6ZV9hbGxvY2F0ZSBpbiB0aGUgV2ViVmlldydzCisgICAg Ly8gc2l6ZS1hbGxvY2F0ZSBtZXRob2QuIEl0IGJsb2NrcyB0aGUgbWFpbiBsb29wIGFuZCBpZiB0 aGUgd2lkZ2V0IGlzIG9mZnNjcmVlbgorICAgIC8vIG9yIGhhc24ndCBtb3ZlZCBpdCBpc24ndCBy ZXF1aXJlZC4KIAogICAgIC8vIERvbid0IGRvIGFueXRoaW5nIGlmIHRoZSBhbGxvY2F0aW9uIGhh cyBub3QgY2hhbmdlZC4KICAgICBHdGtBbGxvY2F0aW9uIGN1cnJlbnRBbGxvY2F0aW9uOwogICAg IGd0a193aWRnZXRfZ2V0X2FsbG9jYXRpb24od2lkZ2V0LCAmY3VycmVudEFsbG9jYXRpb24pOwot ICAgIGlmIChjdXJyZW50QWxsb2NhdGlvbiA9PSBhbGxvY2F0aW9uKQorICAgIGlmIChjdXJyZW50 QWxsb2NhdGlvbiA9PSBtX2RlbGF5ZWRBbGxvY2F0aW9uKQogICAgICAgICByZXR1cm47CiAKICAg ICAvLyBEb24ndCBkbyBhbnl0aGluZyBpZiBib3RoIHRoZSBvbGQgYW5kIHRoZSBuZXcgYWxsb2Nh dGlvbnMgYXJlIG91dHNpZGUgdGhlIGZyYW1lLgpAQCAtNTk1LDcgKzU5Miw3IEBAIHZvaWQgUGx1 Z2luVmlldzo6dXBkYXRlV2lkZ2V0QWxsb2NhdGlvbkFuZENsaXAoKQogICAgIGlmIChjdXJyZW50 QWxsb2NhdGlvblJlY3QuaXNFbXB0eSgpICYmIG1fY2xpcFJlY3QuaXNFbXB0eSgpKQogICAgICAg ICByZXR1cm47CiAKLSAgICBndGtfd2lkZ2V0X3NpemVfYWxsb2NhdGUod2lkZ2V0LCAmYWxsb2Nh dGlvbik7CisgICAgZ19vYmplY3Rfc2V0X2RhdGEoR19PQkpFQ1Qod2lkZ2V0KSwgImRlbGF5ZWQt YWxsb2NhdGlvbiIsICZtX2RlbGF5ZWRBbGxvY2F0aW9uKTsKIH0KIAogdm9pZCBQbHVnaW5WaWV3 OjpzZXRQYXJlbnRWaXNpYmxlKGJvb2wgdmlzaWJsZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0 L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwCmluZGV4IDMyMzkzZTlmYjc4 M2Q2ZTAxYzQwMjE1MDI4Y2U2NjI2YmJlNzBjOGYuLjI3ODUzZDEzZjQxZDQ4NWY3NzU2YTk1OGZh NWM5MWZjZmQ2ZjQ2NDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBw b3J0L0Nocm9tZUNsaWVudEd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1 cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcApAQCAtNTY1LDYgKzU2NSwxNSBAQCB2b2lkIENocm9t ZUNsaWVudDo6cGFpbnQoV2ViQ29yZTo6VGltZXI8Q2hyb21lQ2xpZW50PiopCiAgICAgY29uc3Qg SW50UmVjdCYgcmVjdCA9IG1fZGlydHlSZWdpb24uYm91bmRzKCk7CiAgICAgZ3RrX3dpZGdldF9x dWV1ZV9kcmF3X2FyZWEoR1RLX1dJREdFVChtX3dlYlZpZXcpLCByZWN0LngoKSwgcmVjdC55KCks IHJlY3Qud2lkdGgoKSwgcmVjdC5oZWlnaHQoKSk7CiAKKyAgICBIYXNoU2V0PEd0a1dpZGdldCo+ IGNoaWxkcmVuID0gbV93ZWJWaWV3LT5wcml2LT5jaGlsZHJlbjsKKyAgICBIYXNoU2V0PEd0a1dp ZGdldCo+Ojpjb25zdF9pdGVyYXRvciBlbmQgPSBjaGlsZHJlbi5lbmQoKTsKKyAgICBmb3IgKEhh c2hTZXQ8R3RrV2lkZ2V0Kj46OmNvbnN0X2l0ZXJhdG9yIGN1cnJlbnQgPSBjaGlsZHJlbi5iZWdp bigpOyBjdXJyZW50ICE9IGVuZDsgKytjdXJyZW50KSB7CisgICAgICAgIGlmIChzdGF0aWNfY2Fz dDxHdGtBbGxvY2F0aW9uKj4oZ19vYmplY3RfZ2V0X2RhdGEoR19PQkpFQ1QoKmN1cnJlbnQpLCAi ZGVsYXllZC1hbGxvY2F0aW9uIikpKSB7CisgICAgICAgICAgICBndGtfd2lkZ2V0X3F1ZXVlX3Jl c2l6ZV9ub19yZWRyYXcoR1RLX1dJREdFVChtX3dlYlZpZXcpKTsKKyAgICAgICAgICAgIGJyZWFr OworICAgICAgICB9CisgICAgfQorCiAgICAgbV9kaXJ0eVJlZ2lvbiA9IFJlZ2lvbigpOwogICAg IG1fbGFzdERpc3BsYXlUaW1lID0gY3VycmVudFRpbWUoKTsKICAgICBtX3JlcGFpbnRTb29uU291 cmNlSWQgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdl YnZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmlu ZGV4IDQ2YWJjNjA0MTM3ZTk2ZWRiYWJkZmVkZTgxMzRmMzkxYTk0ZGI1ZTIuLjhmYzY4NjI2NDgw OGYyNmU5OThlYTdhNjU4MWM3NWFmMWMyMTlhOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Z3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTg0MSwxOCArODQxLDMzIEBAIHN0YXRpYyB2b2lkIHdl YmtpdF93ZWJfdmlld19nZXRfcHJlZmVycmVkX2hlaWdodChHdGtXaWRnZXQqIHdpZGdldCwgZ2lu dCogbWluaW11CiB9CiAjZW5kaWYKIAorc3RhdGljIHZvaWQgdXBkYXRlQ2hpbGRBbGxvY2F0aW9u RnJvbVBlbmRpbmdBbGxvY2F0aW9uKEd0a1dpZGdldCogY2hpbGQsIHZvaWQqKQoreworICAgIGlm ICghZ3RrX3dpZGdldF9nZXRfdmlzaWJsZShjaGlsZCkpCisgICAgICAgIHJldHVybjsKKworICAg IEd0a0FsbG9jYXRpb24qIGFsbG9jYXRpb24gPSBzdGF0aWNfY2FzdDxHdGtBbGxvY2F0aW9uKj4o Z19vYmplY3RfZ2V0X2RhdGEoR19PQkpFQ1QoY2hpbGQpLCAiZGVsYXllZC1hbGxvY2F0aW9uIikp OworICAgIGlmICghYWxsb2NhdGlvbikKKyAgICAgICAgcmV0dXJuOworCisgICAgZ19vYmplY3Rf c2V0X2RhdGEoR19PQkpFQ1QoY2hpbGQpLCAiZGVsYXllZC1hbGxvY2F0aW9uIiwgMCk7CisgICAg Z3RrX3dpZGdldF9zaXplX2FsbG9jYXRlKGNoaWxkLCBhbGxvY2F0aW9uKTsKKyAgICAqYWxsb2Nh dGlvbiA9IEludFJlY3QoKTsKK30KKwogc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X3NpemVf YWxsb2NhdGUoR3RrV2lkZ2V0KiB3aWRnZXQsIEd0a0FsbG9jYXRpb24qIGFsbG9jYXRpb24pCiB7 CiAgICAgR1RLX1dJREdFVF9DTEFTUyh3ZWJraXRfd2ViX3ZpZXdfcGFyZW50X2NsYXNzKS0+c2l6 ZV9hbGxvY2F0ZSh3aWRnZXQsIGFsbG9jYXRpb24pOwogCi0gICAgV2ViS2l0V2ViVmlldyogd2Vi VmlldyA9IFdFQktJVF9XRUJfVklFVyh3aWRnZXQpOwotICAgIFBhZ2UqIHBhZ2UgPSBjb3JlKHdl YlZpZXcpOworICAgIFBhZ2UqIHBhZ2UgPSBjb3JlKFdFQktJVF9XRUJfVklFVyh3aWRnZXQpKTsK ICAgICBJbnRTaXplIG9sZFNpemU7CiAgICAgaWYgKEZyYW1lVmlldyogZnJhbWVWaWV3ID0gcGFn ZS0+bWFpbkZyYW1lKCktPnZpZXcoKSkgewogICAgICAgICBvbGRTaXplID0gZnJhbWVWaWV3LT5z aXplKCk7CiAgICAgICAgIGZyYW1lVmlldy0+cmVzaXplKGFsbG9jYXRpb24tPndpZHRoLCBhbGxv Y2F0aW9uLT5oZWlnaHQpOwogICAgIH0KIAorICAgIGd0a19jb250YWluZXJfZm9yYWxsKEdUS19D T05UQUlORVIod2lkZ2V0KSwgdXBkYXRlQ2hpbGRBbGxvY2F0aW9uRnJvbVBlbmRpbmdBbGxvY2F0 aW9uLCAwKTsKKwogICAgIFdlYktpdDo6Q2hyb21lQ2xpZW50KiBjaHJvbWVDbGllbnQgPSBzdGF0 aWNfY2FzdDxXZWJLaXQ6OkNocm9tZUNsaWVudCo+KHBhZ2UtPmNocm9tZSgpLT5jbGllbnQoKSk7 CiAgICAgY2hyb21lQ2xpZW50LT53aWRnZXRTaXplQ2hhbmdlZChvbGRTaXplLCBJbnRTaXplKGFs bG9jYXRpb24tPndpZHRoLCBhbGxvY2F0aW9uLT5oZWlnaHQpKTsKICAgICBjaHJvbWVDbGllbnQt PmFkanVzdG1lbnRXYXRjaGVyKCktPnVwZGF0ZUFkanVzdG1lbnRzRnJvbVNjcm9sbGJhcnMoKTsK