72669 2011-11-17 15:15:11 -0800 [chromium] Disable incremental uploading in threaded compositing path 2011-11-17 20:09:26 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr cc-bugs enne nduca reveman shawnsingh vangelis webkit.review.bot oldest_to_newest 505268 0 jamesr 2011-11-17 15:15:11 -0800 [chromium] Disable incremental uploading in threaded compositing path 505272 1 115696 jamesr 2011-11-17 15:16:38 -0800 Created attachment 115696 Patch 505277 2 115696 nduca 2011-11-17 15:20:57 -0800 Comment on attachment 115696 Patch LGTM but lets get someone working on fixing this. When the prerenderer patch lands, we're gonna need this I fear. 505280 3 115696 enne 2011-11-17 15:23:30 -0800 Comment on attachment 115696 Patch Looks good to me. I had intended this to be something we could play with for performance, and disabling it until we can make it correct seems like the right choice. 505282 4 115696 kbr 2011-11-17 15:25:20 -0800 Comment on attachment 115696 Patch rs=me 505283 5 shawnsingh 2011-11-17 15:26:56 -0800 (In reply to comment #2) > (From update of attachment 115696 [details]) > LGTM but lets get someone working on fixing this. When the prerenderer patch lands, we're gonna need this I fear. Just for completeness, can you please point to our so-called "prerenderer patch"? Or are you just referring to intended design that we're working towards? 505289 6 enne 2011-11-17 15:33:34 -0800 (In reply to comment #5) > Just for completeness, can you please point to our so-called "prerenderer patch"? Or are you just referring to intended design that we're working towards? Eric Penner sounded like he'd have a patch up soon. 505442 7 115696 webkit.review.bot 2011-11-17 20:09:21 -0800 Comment on attachment 115696 Patch Clearing flags on attachment: 115696 Committed r100710: <http://trac.webkit.org/changeset/100710> 505443 8 webkit.review.bot 2011-11-17 20:09:26 -0800 All reviewed patches have been landed. Closing bug. 115696 2011-11-17 15:16:38 -0800 2011-11-17 20:09:21 -0800 Patch bug-72669-20111117151637.patch text/plain 1956 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwNTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjU2ZjQyNzhmZjljYzY3 MDI4YWM0NGJlZTFlZWUzM2QzNTE4YjQ2YS4uYzg1Mjg0ZjFmZDBmMWNhYjNiNmIyNjc2ZDQ0YWJl ZmY1ZTE4ODk4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTExLTE3ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBE aXNhYmxlIGluY3JlbWVudGFsIHVwbG9hZGluZyBpbiB0aHJlYWRlZCBjb21wb3NpdGluZyBwYXRo CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjY2OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIHdl IGRvbid0IGN1cnJlbnRseSBzdXBwb3J0IGF0b21pYyBpbmNyZW1lbnRhbCB1cGxvYWRzLCBpbmNy ZW1lbnRhbCB1cGxvYWRzIGluIHRoZSB0aHJlYWRlZCBwYXRoIHJlc3VsdCBpbgorICAgICAgICB2 ZXJ5IHN0cmFuZ2UtbG9va2luZyB0ZXh0dXJlIHBvcHBpbmcgYXMgdGlsZXMgY29tZSBpbiBvbiBw YWdlcyB0aGF0IHJlcXVpcmUgbW9yZSB0aGFuIDE2IHRpbGUgdXBsb2FkcyBwZXIgZnJhbWUuCisg ICAgICAgIFRoaXMgZGlzYWJsZXMgdGhhdCBsb2dpYyAoYnkgc2V0dGluZyB0aGUgdXBsb2FkIGxp bWl0IHBlciBmcmFtZSB0byA5OTk5OSkgdW50aWwgd2UgaGFuZGxlIHRoZSBpbmNyZW1lbnRhbAor ICAgICAgICB1cGRhdGVzIGluIGFuIGF0b21pYyBmYXNoaW9uLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NUaHJlYWRQcm94eS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpDQ1RocmVhZFByb3h5OjpzY2hlZHVsZWRBY3Rpb25VcGRhdGVNb3JlUmVzb3VyY2VzKToK KwogMjAxMS0xMS0xNiAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4K IAogICAgICAgICBVcGRhdGUgc3VwcG9ydGVkIGRpc3BsYXkgbGlzdCBhZnRlciAtd2Via2l0LWdy aWQgYW5kIC13ZWJraXQtaW5saW5lLWdyaWQgYWRkaXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGhyZWFkUHJveHkuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NUaHJlYWRQcm94 eS5jcHAKaW5kZXggNzQ3YzhkZjEyY2UyYTkxODY4OWExNmFkNzcyZWZlZWFlZmU3NzBlYy4uNzk0 NTU0YjAzNjlkNjliMzdkNzI4MzA3Mzk3MDkwYmQwYjRlMThkMyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NUaHJlYWRQcm94eS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NUaHJl YWRQcm94eS5jcHAKQEAgLTQxNyw3ICs0MTcsNyBAQCB2b2lkIENDVGhyZWFkUHJveHk6OnNjaGVk dWxlZEFjdGlvblVwZGF0ZU1vcmVSZXNvdXJjZXMoKQogewogICAgIFRSQUNFX0VWRU5UKCJDQ1Ro cmVhZFByb3h5OjpzY2hlZHVsZWRBY3Rpb25VcGRhdGVNb3JlUmVzb3VyY2VzIiwgdGhpcywgMCk7 CiAgICAgQVNTRVJUKG1fY3VycmVudFRleHR1cmVVcGRhdGVyT25JbXBsVGhyZWFkKTsKLSAgICBz dGF0aWMgY29uc3QgaW50IFVwZGF0ZXNQZXJGcmFtZSA9IDE2OworICAgIHN0YXRpYyBjb25zdCBp bnQgVXBkYXRlc1BlckZyYW1lID0gOTk5OTk7CiAgICAgbV9jdXJyZW50VGV4dHVyZVVwZGF0ZXJP bkltcGxUaHJlYWQtPnVwZGF0ZShtX2xheWVyVHJlZUhvc3RJbXBsLT5jb250ZXh0KCksIFVwZGF0 ZXNQZXJGcmFtZSk7CiB9CiAK