72540 2011-11-16 13:20:12 -0800 contributors_by_fuzzy_match is super slow 2011-11-16 17:56:50 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72243 1 rniwa rniwa abarth eric ojan webkit.review.bot oldest_to_newest 504185 0 rniwa 2011-11-16 13:20:12 -0800 contributors_by_fuzzy_match is super slow because it's calling self.contributor_by_name(string) where string is name in lowercase yet contributor_by_name doesn't do case-insensitive comparison 504194 1 115436 rniwa 2011-11-16 13:28:41 -0800 Created attachment 115436 Makes contributors_name do case insensitive comparison 504197 2 115436 eric 2011-11-16 13:31:02 -0800 Comment on attachment 115436 Makes contributors_name do case insensitive comparison OK. We could probably also just use @memoized and not need our own custom cache here, but this is fine. 504251 3 rniwa 2011-11-16 14:24:05 -0800 Committed r100505: <http://trac.webkit.org/changeset/100505> 115436 2011-11-16 13:28:41 -0800 2011-11-16 13:31:02 -0800 Makes contributors_name do case insensitive comparison bug-72540-20111116132840.patch text/plain 4561 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwMDQ5OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDExLTExLTE2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIGNvbnRyaWJ1dG9yc19ieV9mdXp6eV9tYXRjaCBpcyBzdXBlciBzbG93CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjU0MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgY29udHJpYnV0 b3JzX2J5X25hbWUgZG8gY2FzZSBpbnNlbnNpdGl2ZSBzZWFyY2ggdXNpbmcgYSBkaWN0aW9uYXJ5 LgorCisgICAgICAgIEFsc28gY2FsbCBjb250cmlidXRvcnNfYnlfbmFtZSBmaXJzdCBpbiBjb250 cmlidXRvcnNfYnlfZnV6enlfbWF0Y2ggbm93IHRoYXQgaXQncyBmYXN0CisgICAgICAgIGJlY2F1 c2UgdGhhdCdzIHRoZSBtb3N0IGNvbW1vbiBjYXNlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRlcnMucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRlcnNfdW5pdHRlc3QucHk6CisKIDIwMTEtMTEtMTYg IFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbTlJXVF0gcmVmYWN0 b3IgZHJpdmVycyB0byByZXF1aXJlIHBpeGVsX3Rlc3RzIHBhcmFtCkluZGV4OiBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVycy5weQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVycy5weQkocmV2aXNp b24gMTAwNDIzKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1p dHRlcnMucHkJKHdvcmtpbmcgY29weSkKQEAgLTQ2Miw2ICs0NjIsNyBAQCBjbGFzcyBDb21taXR0 ZXJMaXN0KG9iamVjdCk6CiAgICAgICAgIHNlbGYuX2NvbnRyaWJ1dG9ycyA9IGNvbnRyaWJ1dG9y cyArIGNvbW1pdHRlcnMgKyByZXZpZXdlcnMKICAgICAgICAgc2VsZi5fY29tbWl0dGVycyA9IGNv bW1pdHRlcnMgKyByZXZpZXdlcnMKICAgICAgICAgc2VsZi5fcmV2aWV3ZXJzID0gcmV2aWV3ZXJz CisgICAgICAgIHNlbGYuX2NvbnRyaWJ1dG9yc19ieV9uYW1lID0ge30KICAgICAgICAgc2VsZi5f YWNjb3VudHNfYnlfZW1haWwgPSB7fQogICAgICAgICBzZWxmLl9hY2NvdW50c19ieV9sb2dpbiA9 IHt9CiAKQEAgLTQ3Nyw2ICs0NzgsMTQgQEAgY2xhc3MgQ29tbWl0dGVyTGlzdChvYmplY3QpOgog ICAgIGRlZiByZXZpZXdlcnMoc2VsZik6CiAgICAgICAgIHJldHVybiBzZWxmLl9yZXZpZXdlcnMK IAorICAgIGRlZiBfbmFtZV90b19jb250cmlidXRvcl9tYXAoc2VsZik6CisgICAgICAgIGlmIG5v dCBsZW4oc2VsZi5fY29udHJpYnV0b3JzX2J5X25hbWUpOgorICAgICAgICAgICAgZm9yIGNvbnRy aWJ1dG9yIGluIHNlbGYuX2NvbnRyaWJ1dG9yczoKKyAgICAgICAgICAgICAgICBhc3NlcnQoY29u dHJpYnV0b3IuZnVsbF9uYW1lKQorICAgICAgICAgICAgICAgIGFzc2VydChjb250cmlidXRvci5m dWxsX25hbWUubG93ZXIoKSBub3QgaW4gc2VsZi5fY29udHJpYnV0b3JzX2J5X25hbWUpICAjIFdl IHNob3VsZCBuZXZlciBoYXZlIGR1cGxpY2F0ZSBuYW1lcy4KKyAgICAgICAgICAgICAgICBzZWxm Ll9jb250cmlidXRvcnNfYnlfbmFtZVtjb250cmlidXRvci5mdWxsX25hbWUubG93ZXIoKV0gPSBj b250cmlidXRvcgorICAgICAgICByZXR1cm4gc2VsZi5fY29udHJpYnV0b3JzX2J5X25hbWUKKwog ICAgIGRlZiBfZW1haWxfdG9fYWNjb3VudF9tYXAoc2VsZik6CiAgICAgICAgIGlmIG5vdCBsZW4o c2VsZi5fYWNjb3VudHNfYnlfZW1haWwpOgogICAgICAgICAgICAgZm9yIGFjY291bnQgaW4gc2Vs Zi5fYWNjb3VudHM6CkBAIC01MDksMTMgKzUxOCw2IEBAIGNsYXNzIENvbW1pdHRlckxpc3Qob2Jq ZWN0KToKICAgICAgICAgICAgIHJldHVybiBOb25lCiAgICAgICAgIHJldHVybiByZWNvcmQKIAot ICAgIGRlZiBjb250cmlidXRvcl9ieV9uYW1lKHNlbGYsIG5hbWUpOgotICAgICAgICAjIFRoaXMg Y291bGQgYmUgbWFkZSBpbnRvIGEgaGFzaCBsb29rdXAgaWYgY2FsbGVycyBuZWVkIGl0IHRvIGJl IGZhc3QuCi0gICAgICAgIGZvciBjb250cmlidXRvciBpbiBzZWxmLmNvbnRyaWJ1dG9ycygpOgot ICAgICAgICAgICAgaWYgY29udHJpYnV0b3IuZnVsbF9uYW1lIGFuZCBjb250cmlidXRvci5mdWxs X25hbWUgPT0gbmFtZToKLSAgICAgICAgICAgICAgICByZXR1cm4gY29udHJpYnV0b3IKLSAgICAg ICAgcmV0dXJuIE5vbmUKLQogICAgIGRlZiBjb21taXR0ZXJfYnlfbmFtZShzZWxmLCBuYW1lKToK ICAgICAgICAgcmV0dXJuIHNlbGYuX2NvbW1pdHRlcl9vbmx5KHNlbGYuY29udHJpYnV0b3JfYnlf bmFtZShuYW1lKSkKIApAQCAtNTQwLDcgKzU0Miw3IEBAIGNsYXNzIENvbW1pdHRlckxpc3Qob2Jq ZWN0KToKICAgICAgICAgc3RyaW5nID0gc3RyaW5nLmxvd2VyKCkKIAogICAgICAgICAjIEZpcnN0 IHBhdGgsIG9wdGltaXRpY2FsbHkgbWF0Y2ggZm9yIGZ1bGxuYW1lLCBlbWFpbCBhbmQgaXJjX25p Y2tuYW1lcwotICAgICAgICBhY2NvdW50ID0gc2VsZi5hY2NvdW50X2J5X2VtYWlsKHN0cmluZykg b3Igc2VsZi5jb250cmlidXRvcl9ieV9pcmNfbmlja25hbWUoc3RyaW5nKSBvciBzZWxmLmNvbnRy aWJ1dG9yX2J5X25hbWUoc3RyaW5nKQorICAgICAgICBhY2NvdW50ID0gc2VsZi5jb250cmlidXRv cl9ieV9uYW1lKHN0cmluZykgb3Igc2VsZi5hY2NvdW50X2J5X2VtYWlsKHN0cmluZykgb3Igc2Vs Zi5jb250cmlidXRvcl9ieV9pcmNfbmlja25hbWUoc3RyaW5nKQogICAgICAgICBpZiBhY2NvdW50 OgogICAgICAgICAgICAgcmV0dXJuIFthY2NvdW50XSwgMAogCkBAIC01NjgsNiArNTcwLDkgQEAg Y2xhc3MgQ29tbWl0dGVyTGlzdChvYmplY3QpOgogICAgIGRlZiBhY2NvdW50X2J5X2VtYWlsKHNl bGYsIGVtYWlsKToKICAgICAgICAgcmV0dXJuIHNlbGYuX2VtYWlsX3RvX2FjY291bnRfbWFwKCku Z2V0KGVtYWlsLmxvd2VyKCkpCiAKKyAgICBkZWYgY29udHJpYnV0b3JfYnlfbmFtZShzZWxmLCBu YW1lKToKKyAgICAgICAgcmV0dXJuIHNlbGYuX25hbWVfdG9fY29udHJpYnV0b3JfbWFwKCkuZ2V0 KG5hbWUubG93ZXIoKSkKKwogICAgIGRlZiBjb250cmlidXRvcl9ieV9lbWFpbChzZWxmLCBlbWFp bCk6CiAgICAgICAgIHJldHVybiBzZWxmLl9jb250cmlidXRvcl9vbmx5KHNlbGYuYWNjb3VudF9i eV9lbWFpbChlbWFpbCkpCiAKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2Nv bmZpZy9jb21taXR0ZXJzX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0ZXJzX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAx MDA0MjMpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVy c191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtNTIsNiArNTIsOSBAQCBjbGFzcyBDb21t aXR0ZXJzVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwo Y29tbWl0dGVyX2xpc3QuY29tbWl0dGVyX2J5X25hbWUoIlRlc3QgVHdvIiksIHJldmlld2VyKQog ICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGNvbW1pdHRlcl9saXN0LmNvbW1pdHRlcl9ieV9uYW1l KCJUZXN0IFRocmVlIiksIE5vbmUpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoY29tbWl0dGVy X2xpc3QuY29udHJpYnV0b3JfYnlfbmFtZSgiVGVzdCBUaHJlZSIpLCBjb250cmlidXRvcikKKyAg ICAgICAgc2VsZi5hc3NlcnRFcXVhbChjb21taXR0ZXJfbGlzdC5jb250cmlidXRvcl9ieV9uYW1l KCJ0ZXN0IG9uZSIpLCBjb21taXR0ZXIpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoY29tbWl0 dGVyX2xpc3QuY29udHJpYnV0b3JfYnlfbmFtZSgidGVzdCB0d28iKSwgcmV2aWV3ZXIpCisgICAg ICAgIHNlbGYuYXNzZXJ0RXF1YWwoY29tbWl0dGVyX2xpc3QuY29udHJpYnV0b3JfYnlfbmFtZSgi dGVzdCB0aHJlZSIpLCBjb250cmlidXRvcikKIAogICAgICAgICAjIFRlc3QgdGhhdCB0aGUgZmly c3QgZW1haWwgaXMgYXNzdW1lZCB0byBiZSB0aGUgQnVnemlsbGEgZW1haWwgYWRkcmVzcyAoZm9y IG5vdykKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChjb21taXR0ZXJfbGlzdC5jb21taXR0ZXJf YnlfZW1haWwoJ3R3b0ByYWQuY29tJykuYnVnemlsbGFfZW1haWwoKSwgJ3R3b0B0ZXN0LmNvbScp Cg==