72440 2011-11-15 16:23:10 -0800 Removing <ul>, <li> inside shadow DOM triggers assertion in updateListMarkerNumbers 2012-02-27 16:18:35 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 59802 1 dominicc morrita hyatt inferno jchaffraix mitz morrita rniwa shinyak simon.fraser oldest_to_newest 503405 0 dominicc 2011-11-15 16:23:10 -0800 ASSERTION FAILED: listNode && listNode->renderer() /Volumes/HD2/chromium/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../rendering/RenderListItem.cpp(431) : void WebCore::RenderListItem::updateListMarkerNumbers() 514947 1 morrita 2011-12-05 00:08:23 -0800 Tree reforming pushing down this to 59802 515011 2 morrita 2011-12-05 03:34:01 -0800 Hi Dominic, Could you provide any repro for this? I'm trying to reproduce this, but I have had none. Thanks in advance, 515731 3 dominicc 2011-12-06 01:51:07 -0800 I will work on a repro. 517011 4 118291 dominicc 2011-12-07 17:29:59 -0800 Created attachment 118291 Repro layout test 525092 5 shinyak 2011-12-20 21:48:38 -0800 I was investigating this. UL seems destroyed twice...? 525203 6 shinyak 2011-12-21 02:36:15 -0800 (In reply to comment #5) > I was investigating this. > UL seems destroyed twice...? RenderObjectChildList::destroyLeftoverChildren() destroys shadow objects, and it removes a renderer. The renderer of UL is deleted here, then LI is being deleted after that. I'm not sure setting renderer 0 in the function is necessary. 525210 7 120166 shinyak 2011-12-21 03:35:58 -0800 Created attachment 120166 Patch 525211 8 shinyak 2011-12-21 03:36:39 -0800 (In reply to comment #7) > Created an attachment (id=120166) [details] > Patch I'm not sure this is the right way, but this patch fixes the issue. 545264 9 120166 rniwa 2012-01-30 12:03:15 -0800 Comment on attachment 120166 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120166&action=review > Source/WebCore/rendering/RenderObjectChildList.cpp:62 > - if (firstChild()->node()) > - firstChild()->node()->setRenderer(0); > + Node* node = firstChild()->node(); > firstChild()->destroy(); > + if (node) > + node->setRenderer(0); This doesn't look like a right fix. 545266 10 rniwa 2012-01-30 12:04:05 -0800 This is renderer related so should belong "Layout and Rendering". 552199 11 120166 dglazkov 2012-02-08 09:22:39 -0800 Comment on attachment 120166 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120166&action=review > Source/WebCore/ChangeLog:9 > + This patch postpones removing renderers just after children are destroyed. Can you explain a bit more as to why this is the right solution? Why does this behave differently in a shadow DOM subtree? 556199 12 shinyak 2012-02-14 04:00:00 -0800 (In reply to comment #11) > (From update of attachment 120166 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120166&action=review > > > Source/WebCore/ChangeLog:9 > > + This patch postpones removing renderers just after children are destroyed. > > Can you explain a bit more as to why this is the right solution? Why does this behave differently in a shadow DOM subtree? Actually that code was written when I was a (very) newbie of rendering tree... Let me consider more right solution (or confirm this is the right solution) later. 565312 13 128949 morrita 2012-02-26 21:53:53 -0800 Created attachment 128949 Patch 565314 14 morrita 2012-02-26 21:56:30 -0800 Dimitri, could you take a look? It looks making code consistent just fixes the problem. 565336 15 128949 rniwa 2012-02-26 22:30:50 -0800 Comment on attachment 128949 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128949&action=review > Source/WebCore/dom/Element.cpp:971 > + for (Node* child = firstChild(); child; child = child->nextSibling()) { > + if (child->attached()) > + child->detach(); > + } Can we call ContainerNode::detach() here instead? 565374 16 128949 shinyak 2012-02-26 23:25:50 -0800 Comment on attachment 128949 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128949&action=review >> Source/WebCore/dom/Element.cpp:971 >> + } > > Can we call ContainerNode::detach() here instead? I don't think so, because ContainerNode::detach() will call Node::detach(). Having ContainerNode::detachChildren() might be useful, because we have a lot of similar code. > Source/WebCore/dom/Element.cpp:973 > + shadowRootList()->detach(); Now that shadowRootList() has been renamed to shadowTree(). 565382 17 128949 rniwa 2012-02-26 23:33:46 -0800 Comment on attachment 128949 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128949&action=review Okay, I think I understand what's happening on my second look. >>> Source/WebCore/dom/Element.cpp:971 >>> + } >> >> Can we call ContainerNode::detach() here instead? > > I don't think so, because ContainerNode::detach() will call Node::detach(). > Having ContainerNode::detachChildren() might be useful, because we have a lot of similar code. Oh I see what you're saying. Yeah, adding ContainerNode::detachChildren seems like a valuable refactoring of its own. I wonder it should be inlined or not. > LayoutTests/fast/dom/shadow/shadow-ul-li.html:8 > + return; // needs ShadowRoot Can we output some message about needing shadowRoot? Presumably, we should be able to modify test to be able to run without DRT once shadow DOM API becomes available to DOM? 565466 18 morrita 2012-02-27 01:34:26 -0800 (In reply to comment #17) > > LayoutTests/fast/dom/shadow/shadow-ul-li.html:8 > > + return; // needs ShadowRoot > > Can we output some message about needing shadowRoot? Presumably, we should be able to modify test to be able to run without DRT once shadow DOM API becomes available to DOM? Oops. This has been there when it was an attached repro. I'll remove it and add Skipped lines. (In reply to comment #16) > (From update of attachment 128949 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=128949&action=review > > Source/WebCore/dom/Element.cpp:973 > > + shadowRootList()->detach(); > > Now that shadowRootList() has been renamed to shadowTree(). God catch! I'll followup shortly. 565643 19 jchaffraix 2012-02-27 07:38:02 -0800 It looks like the change was landed in http://trac.webkit.org/changeset/108980. Because the ChangeLog contained the wrong bug number, the final patch ended up in bug 79630. Morrita, could you update the ChangeLog bug URL and close this bug if I haven't missed anything? 566080 20 morrita 2012-02-27 16:18:35 -0800 Good catch! Fixed http://trac.webkit.org/changeset/109037. Thank you for pointing it out. 118291 2011-12-07 17:29:59 -0800 2011-12-07 17:29:59 -0800 Repro layout test 0001-Repro.patch text/plain 1690 dominicc RnJvbSA4OWIxYjhlMTQ2YTUyMmJkMjg2NWRiNTY4ZjBkNzFiZTIwMWYxMWJjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEb21pbmljIENvb25leSA8ZG9taW5pY2NAY2hyb21pdW0ub3Jn PgpEYXRlOiBUaHUsIDggRGVjIDIwMTEgMTA6Mjg6MDYgKzA5MDAKU3ViamVjdDogW1BBVENIXSBS ZXBybwoKLS0tCiAuLi4vZmFzdC9kb20vc2hhZG93L3NoYWRvdy1yb290LXVsLWV4cGVjdGVkLnR4 dCAgICB8ICAgIDEgKwogTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3NoYWRvdy1yb290LXVs Lmh0bWwgICAgfCAgIDI4ICsrKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDI5 IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0 VGVzdHMvZmFzdC9kb20vc2hhZG93L3NoYWRvdy1yb290LXVsLWV4cGVjdGVkLnR4dAogY3JlYXRl IG1vZGUgMTAwNjQ0IExheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9zaGFkb3ctcm9vdC11bC5o dG1sCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3NoYWRvdy1yb290 LXVsLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9zaGFkb3ctcm9v dC11bC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uN2Vm MjJlOQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9zaGFk b3ctcm9vdC11bC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAorUEFTUwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3NoYWRvdy1yb290LXVsLmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L2RvbS9zaGFkb3cvc2hhZG93LXJvb3QtdWwuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwLi5mM2IwZjA0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9kb20vc2hhZG93L3NoYWRvdy1yb290LXVsLmh0bWwKQEAgLTAsMCArMSwyOCBAQAor PCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KK2Z1bmN0aW9uIHRlc3Qo KQoreworICAgIGlmICghd2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICByZXR1 cm47ICAvLyBuZWVkcyBTaGFkb3dSb290CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFz VGV4dCgpOworCisgICAgdmFyIGhvc3QgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKTsK KyAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGhvc3QpOworICAgIHZhciBzaGFkb3cgPSBp bnRlcm5hbHMuZW5zdXJlU2hhZG93Um9vdChob3N0KTsKKworICAgIHZhciB1bCA9IGRvY3VtZW50 LmNyZWF0ZUVsZW1lbnQoJ3VsJyk7CisgICAgdmFyIGxpID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgnbGknKTsKKyAgICB1bC5hcHBlbmRDaGlsZChsaSk7CisgICAgc2hhZG93LmFwcGVuZENoaWxk KHVsKTsKKyAgICBkb2N1bWVudC5ib2R5Lm9mZnNldExlZnQ7CisKKyAgICAvLyBDcmFzaCBoYXBw ZW5zIGF0IHRoaXMgcG9pbnQgcmVtb3ZpbmcgdGhlIHVsCisgICAgZG9jdW1lbnQuYm9keS5pbm5l ckhUTUwgPSAnUEFTUyc7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0idGVz dCgpIj4KKzwvYm9keT4KKzwvaHRtbD4KLS0gCjEuNy43LjIKCg== 120166 2011-12-21 03:35:58 -0800 2012-02-26 21:53:47 -0800 Patch bug-72440-20111221203556.patch text/plain 3895 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmZlM2YyNzJlODc1NTE0 NjI3NTZmNGYyMGE0Y2MwMTA2OTUxODE0Ny4uYWUxNDdiOTBjYWJjNmJkMjExYTE4NTA1M2RlMDJj NDMzN2E4ZmVlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTEyLTIxICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmVtb3ZpbmcgPHVs PiwgPGxpPiBpbnNpZGUgc2hhZG93IERPTSB0cmlnZ2VycyBhc3NlcnRpb24gaW4gdXBkYXRlTGlz dE1hcmtlck51bWJlcnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03MjQ0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSByZW5kZXJlciBvZiA8dWw+IHdhcyByZW1vdmVkIHdoZW4gPGxpPiBpcyBiZWlu ZyByZW1vdmVkLgorICAgICAgICBUaGlzIHBhdGNoIHBvc3Rwb25lcyByZW1vdmluZyByZW5kZXJl cnMganVzdCBhZnRlciBjaGlsZHJlbiBhcmUgZGVzdHJveWVkLgorCisgICAgICAgIFRlc3Q6IGZh c3QvZG9tL3NoYWRvdy9zaGFkb3ctcm9vdC11bC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyT2JqZWN0Q2hpbGRMaXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVj dENoaWxkTGlzdDo6ZGVzdHJveUxlZnRvdmVyQ2hpbGRyZW4pOgorICAgICAgICAgIENoYW5nZWQg dGhlIG9yZGVyIG9mIG1ldGhvZCBjYWxscy4KKwogMjAxMS0xMi0yMCAgQW5kcmVhcyBLbGluZyAg PGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSFRNTE9wdGlvbnNDb2xsZWN0aW9uOiBSZW1v dmUgaW5jb3JyZWN0IEZJWE1FIGFib3V0IGhhdmluZyBhIGJhc2UgY2xhc3MuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0Q2hpbGRMaXN0LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3RDaGlsZExpc3QuY3BwCmluZGV4IDFm MTc2YjU4NDUyNjhmNGY1YjcxZWEyZmRiYmZjZWY3MDNiZDA1ZWYuLjE5YTYwZjFlYjQyZGQ3MmUx ZjFhMDllMjgzYzBmZGE1ZWZiZWU2MzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJPYmplY3RDaGlsZExpc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJPYmplY3RDaGlsZExpc3QuY3BwCkBAIC01Niw5ICs1NiwxMCBAQCB2b2lkIFJl bmRlck9iamVjdENoaWxkTGlzdDo6ZGVzdHJveUxlZnRvdmVyQ2hpbGRyZW4oKQogICAgICAgICAg ICAgZmlyc3RDaGlsZCgpLT5kZXN0cm95KCk7CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAg ICAvLyBEZXN0cm95IGFueSBhbm9ueW1vdXMgY2hpbGRyZW4gcmVtYWluaW5nIGluIHRoZSByZW5k ZXIgdHJlZSwgYXMgd2VsbCBhcyBpbXBsaWNpdCAoc2hhZG93KSBET00gZWxlbWVudHMgbGlrZSB0 aG9zZSB1c2VkIGluIHRoZSBlbmdpbmUtYmFzZWQgdGV4dCBmaWVsZHMuCi0gICAgICAgICAgICBp ZiAoZmlyc3RDaGlsZCgpLT5ub2RlKCkpCi0gICAgICAgICAgICAgICAgZmlyc3RDaGlsZCgpLT5u b2RlKCktPnNldFJlbmRlcmVyKDApOworICAgICAgICAgICAgTm9kZSogbm9kZSA9IGZpcnN0Q2hp bGQoKS0+bm9kZSgpOwogICAgICAgICAgICAgZmlyc3RDaGlsZCgpLT5kZXN0cm95KCk7CisgICAg ICAgICAgICBpZiAobm9kZSkKKyAgICAgICAgICAgICAgICBub2RlLT5zZXRSZW5kZXJlcigwKTsK ICAgICAgICAgfQogICAgIH0KIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmMzdhYWUzYWNjMzMyZDRkNGVhNzJhNTllMDE1 YTNkNWZkMmNkYzQ0Li5kODc2ZDc2OTg5ZTMyYWU2NWE3ZTc2Mzc3ZmU0MTJmZjRjMjhiZDMxIDEw MDc1NQotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTItMjEgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55 YWtAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZW1vdmluZyA8dWxMLCA8bGk+IGluc2lkZSBzaGFk b3cgRE9NIHRyaWdnZXJzIGFzc2VydGlvbiBpbiB1cGRhdGVMaXN0TWFya2VyTnVtYmVycy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyNDQwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2RvbS9z aGFkb3cvc2hhZG93LXJvb3QtdWwtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0 L2RvbS9zaGFkb3cvc2hhZG93LXJvb3QtdWwuaHRtbDogQWRkZWQuCisKIDIwMTEtMTItMjAgIEZs b3JpbiBNYWxpdGEgIDxmbWFsaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgdGQgZWxlbWVudCBp Z25vcmVzIHplcm8gd2lkdGgvaGVpZ2h0IGlucHV0IGVsZW1lbnQKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9zaGFkb3ctcm9vdC11bC1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvc2hhZG93LXJvb3QtdWwtZXhwZWN0ZWQudHh0Cm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLjdlZjIyZTlhNDMxYWQwMjcyNzEzYjcxZmRjODc5NDAxNmM4ZWYxMmYKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvc2hhZG93LXJvb3QtdWwtZXhw ZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1BBU1MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvZG9tL3NoYWRvdy9zaGFkb3ctcm9vdC11bC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20v c2hhZG93L3NoYWRvdy1yb290LXVsLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZjNiMGYwNGUzZTEzYjU3NGU0 YzgwZDdlZDlmMDJmNjBmM2Q2Y2QxZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvZG9tL3NoYWRvdy9zaGFkb3ctcm9vdC11bC5odG1sCkBAIC0wLDAgKzEsMjggQEAKKzwhRE9D VFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQ+CitmdW5jdGlvbiB0ZXN0KCkKK3sK KyAgICBpZiAoIXdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgcmV0dXJuOyAg Ly8gbmVlZHMgU2hhZG93Um9vdAorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQo KTsKKworICAgIHZhciBob3N0ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7CisgICAg ZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChob3N0KTsKKyAgICB2YXIgc2hhZG93ID0gaW50ZXJu YWxzLmVuc3VyZVNoYWRvd1Jvb3QoaG9zdCk7CisKKyAgICB2YXIgdWwgPSBkb2N1bWVudC5jcmVh dGVFbGVtZW50KCd1bCcpOworICAgIHZhciBsaSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2xp Jyk7CisgICAgdWwuYXBwZW5kQ2hpbGQobGkpOworICAgIHNoYWRvdy5hcHBlbmRDaGlsZCh1bCk7 CisgICAgZG9jdW1lbnQuYm9keS5vZmZzZXRMZWZ0OworCisgICAgLy8gQ3Jhc2ggaGFwcGVucyBh dCB0aGlzIHBvaW50IHJlbW92aW5nIHRoZSB1bAorICAgIGRvY3VtZW50LmJvZHkuaW5uZXJIVE1M ID0gJ1BBU1MnOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InRlc3QoKSI+ Cis8L2JvZHk+Cis8L2h0bWw+Cg== 128949 2012-02-26 21:53:53 -0800 2012-02-27 16:21:23 -0800 Patch bug-72440-20120227145351.patch text/plain 4167 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTA4OTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmE0OWUwYjJhZmVhNjI0 MmQzYzc0ODg3YTQ5YTI2YmZiMWE2NjM3Ni4uNzUwM2E0NzMwOWIwZGQzMTlhNjMyZDllMWRhZmRl OGMxYjk5ZmM0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTAyLTI2ICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIFJlbW92aW5nIDx1bD4s IDxsaT4gaW5zaWRlIHNoYWRvdyBET00gdHJpZ2dlcnMgYXNzZXJ0aW9uIGluIHVwZGF0ZUxpc3RN YXJrZXJOdW1iZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MjQ0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoaXMgcHJvYmxlbSB3YXMgY2F1c2VkIGJ5IHRoZSBpbmNvbnNpc3RlbnQgZGV0YWNoIG9y ZGVyIG9mIERPTSB0cmVlIHdoZXJlCisgICAgICAgIEVsZW1lbnQ6OmRldGFjaCgpIGNhbGxlZCBD b250YWluZXJOb2RlOjpkZXRhY2goKSBiZWZvcmUgc2hhZG93IHRyZWUgaXMgZGV0YWNoZWQuCisg ICAgICAgIFRoaXMgcmVzdWx0ZWQgdGhlIHJlbmRlcmVyIG9mIHRoZSBlbGVtZW50IGJlaW5nIGRl c3Ryb3llZCBldmVuIGlmIGl0cyBjaGlsZHJlbiwKKyAgICAgICAgZWFjaCBvZiB3aGljaCBjYW1l IGZyb20gYW4gZWxlbWVudCBpbiB0aGUgc2hhZG93IHRyZWUsIGFyZSBhbGl2ZS4KKyAgICAgICAg SW4gcHJpbmNpcGxlLCBjaGlsZCByZW5kZXJlcnMgc2hvdWxkIGJlIGRlc3Ryb3llZCBiZWZvcmUg aXRzIHBhcmVudC4KKworICAgICAgICBUaGlzIGNoYW5nZSBhbGlnbnMgdGhlIGRldGFjaCBvcmRl ciB3aXRoIHRoZSBhdHRhY2ggb3JkZXIuIFRoZSBzaGFkb3cgdHJlZSBpcworICAgICAgICBub3cg ZGVhdGNoZWQgYmVmb3JlIHBhcmVudCdzIENvbnRhaW5lck5vZGU6OmRldGFjaCgpIGlzIGNhbGxl ZC4KKworICAgICAgICBUZXN0OiBmYXN0L2RvbS9zaGFkb3cvc2hhZG93LXVsLWxpLmh0bWwKKwor ICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OmRl dGFjaCk6CisKIDIwMTItMDItMjYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAog ICAgICAgICBDb250ZXh0RGVzdHJ1Y3Rpb25PYnNlcnZlciBzaG91bGQgbGl2ZSBpbiBpdHMgb3du IGZpbGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCAxYjRkODM5ZGIyZWVkZjdhZTIwOTYwYWEy NjNmNGI5ZjBiMmQwMWIzLi5jYmY3NWNmNTZhNTk3NDdlNjc0YWJkZGRkMDYyMWY0MWI4YjMzNzBk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC05NjQsOSArOTY0LDE2IEBAIHZvaWQgRWxlbWVu dDo6ZGV0YWNoKCkKICAgICBjYW5jZWxGb2N1c0FwcGVhcmFuY2VVcGRhdGUoKTsKICAgICBpZiAo aGFzUmFyZURhdGEoKSkKICAgICAgICAgcmFyZURhdGEoKS0+cmVzZXRDb21wdXRlZFN0eWxlKCk7 Ci0gICAgQ29udGFpbmVyTm9kZTo6ZGV0YWNoKCk7Ci0gICAgaWYgKFNoYWRvd1Jvb3RMaXN0KiBz aGFkb3dSb290cyA9IHNoYWRvd1Jvb3RMaXN0KCkpCi0gICAgICAgIHNoYWRvd1Jvb3RzLT5kZXRh Y2goKTsKKyAgICBpZiAoaGFzU2hhZG93Um9vdCgpKSB7CisgICAgICAgIGZvciAoTm9kZSogY2hp bGQgPSBmaXJzdENoaWxkKCk7IGNoaWxkOyBjaGlsZCA9IGNoaWxkLT5uZXh0U2libGluZygpKSB7 CisgICAgICAgICAgICBpZiAoY2hpbGQtPmF0dGFjaGVkKCkpCisgICAgICAgICAgICAgICAgY2hp bGQtPmRldGFjaCgpOworICAgICAgICB9CisKKyAgICAgICAgc2hhZG93Um9vdExpc3QoKS0+ZGV0 YWNoKCk7CisgICAgICAgIE5vZGU6OmRldGFjaCgpOworICAgIH0gZWxzZQorICAgICAgICBDb250 YWluZXJOb2RlOjpkZXRhY2goKTsKIAogICAgIFJlbmRlcldpZGdldDo6cmVzdW1lV2lkZ2V0SGll cmFyY2h5VXBkYXRlcygpOwogfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGEzYzgwZmM2NzY1Mjg1ZjE3M2M3NzZiM2RlMjBi M2RmNWMyODcyMjIuLjU0ZTkyZGNlYjAwYjRhODQwOTM1NjA5ZWFlOTcxYjkwZjQ2OGRjNjMgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wMi0yNiAgTU9SSVRBIEhhamltZSAgPG1vcnJpdGFA Z29vZ2xlLmNvbT4KKworICAgICAgICBSZW1vdmluZyA8dWw+LCA8bGk+IGluc2lkZSBzaGFkb3cg RE9NIHRyaWdnZXJzIGFzc2VydGlvbiBpbiB1cGRhdGVMaXN0TWFya2VyTnVtYmVycworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI0NDAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZG9tL3NoYWRv dy9zaGFkb3ctdWwtbGktZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9z aGFkb3cvc2hhZG93LXVsLWxpLmh0bWw6IEFkZGVkLgorCiAyMDEyLTAyLTI2ICBZb3NoaWZ1bWkg SW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9udW1iZXIvaW5wdXQtbnVtYmVyLWV2ZW50cy5odG1sIGlzIGZhaWxpbmcgc2luY2UgcjEw ODIyOApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3NoYWRvdy11bC1s aS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvc2hhZG93LXVsLWxp LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40NmNjODUwYzFjZjExZGY5OThiYmUyZDU4ZTJkMDY5 OTgxNjFmZmQ1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93 L3NoYWRvdy11bC1saS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAorUEFTUyB1bmxlc3MgY3Jh c2guCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvc2hhZG93LXVsLWxp Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvc2hhZG93LXVsLWxpLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uZGE3ZmY0MDg2MjI4MmRjMTg4MzE4OTI4OWIzMmFlMDg0MzZkZjEyOQotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9zaGFkb3ctdWwtbGkuaHRt bApAQCAtMCwwICsxLDI3IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2Ny aXB0PgorZnVuY3Rpb24gdGVzdCgpCit7CisgICAgaWYgKCF3aW5kb3cubGF5b3V0VGVzdENvbnRy b2xsZXIpCisgICAgICAgIHJldHVybjsgIC8vIG5lZWRzIFNoYWRvd1Jvb3QKKyAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKKyAgICB2YXIgaG9zdCA9IGRvY3VtZW50LmNy ZWF0ZUVsZW1lbnQoJ2RpdicpOworICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoaG9zdCk7 CisgICAgdmFyIHNoYWRvdyA9IGludGVybmFscy5lbnN1cmVTaGFkb3dSb290KGhvc3QpOworCisg ICAgdmFyIHVsID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgndWwnKTsKKyAgICB2YXIgbGkgPSBk b2N1bWVudC5jcmVhdGVFbGVtZW50KCdsaScpOworICAgIHVsLmFwcGVuZENoaWxkKGxpKTsKKyAg ICBzaGFkb3cuYXBwZW5kQ2hpbGQodWwpOworICAgIGRvY3VtZW50LmJvZHkub2Zmc2V0TGVmdDsK KworICAgIGRvY3VtZW50LmJvZHkuaW5uZXJIVE1MID0gJ1BBU1MgdW5sZXNzIGNyYXNoLic7Cit9 Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0idGVzdCgpIj4KKzwvYm9keT4KKzwv aHRtbD4K