72385 2011-11-15 07:14:38 -0800 Explicitly include unistd.h in TestNetscapePlugIn 2011-11-16 04:52:25 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66689 1 peter peter abarth steveblock webkit.review.bot oldest_to_newest 502891 0 peter 2011-11-15 07:14:38 -0800 Minor change; this is needed for the sleep() call in the indicateTestFailure method, which seems to be implicitly available for other platforms. This is not the case on Android. 502892 1 115162 peter 2011-11-15 07:15:16 -0800 Created attachment 115162 Patch 502972 2 115162 steveblock 2011-11-15 09:31:48 -0800 Comment on attachment 115162 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115162&action=review > Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:32 > +#if defined(OS_ANDROID) #if OS(ANDROID) 502979 3 peter 2011-11-15 09:42:44 -0800 (In reply to comment #2) > (From update of attachment 115162 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=115162&action=review > > > Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:32 > > +#if defined(OS_ANDROID) > > #if OS(ANDROID) WTF is not available in TestNetscapePlugIn, including Platform.h which defines the OS() shorthand. In fact, I think we should be checking for defined(ANDROID) as even OS_ANDROID may not be available. 502987 4 peter 2011-11-15 09:48:32 -0800 To emphasize, the patch works just fine, but I'm not sure why OS_ANDROID is available. I'll investigate that prior to uploading a second patch (if needed). 503761 5 115357 peter 2011-11-16 04:36:03 -0800 Created attachment 115357 Patch Updated patch. OS_ANDROID is being defined in Source/WebKit/chromium/build/build_config.h whereas ANDROID is defined for all projects, so I prefer the latter. 503771 6 115357 webkit.review.bot 2011-11-16 04:52:21 -0800 Comment on attachment 115357 Patch Clearing flags on attachment: 115357 Committed r100432: <http://trac.webkit.org/changeset/100432> 503772 7 webkit.review.bot 2011-11-16 04:52:25 -0800 All reviewed patches have been landed. Closing bug. 115162 2011-11-15 07:15:16 -0800 2011-11-16 04:36:03 -0800 Patch 11-webkit-testnetscapeplugin.patch text/plain 1159 peter ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwOTBi ZGZmLi44MDE3ZjczIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTEtMTUgIFBldGVyIEJldmVybG9vICA8cGV0 ZXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEV4cGxpY2l0bHkgaW5jbHVkZSB1bmlzdGQuaCBp biBUZXN0TmV0c2NhcGVQbHVnSW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTcyMzg1CisKKyAgICAgICAgVGhpcyBpcyBuZWVkZWQgZm9yIHRoZSBzbGVl cCgpIGNhbGwgaW4gdGhlIGluZGljYXRlVGVzdEZhaWx1cmUgbWV0aG9kLAorICAgICAgICB3aGlj aCBzZWVtcyB0byBiZSBpbXBsaWNpdGx5IGF2YWlsYWJsZSBmb3Igb3RoZXIgcGxhdGZvcm1zLiBU aGlzIGlzIG5vdAorICAgICAgICB0aGUgY2FzZSBvbiBBbmRyb2lkLgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvVGVzdE5l dHNjYXBlUGx1Z0luL1BsdWdpblRlc3QuY3BwOgorCiAyMDExLTExLTE1ICBTaW1vbiBIYXVzbWFu biAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIFVucmV2aWV3ZWQg LS1taW5pbWFsIGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1Rl c3ROZXRzY2FwZVBsdWdJbi9QbHVnaW5UZXN0LmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1Rl c3ROZXRzY2FwZVBsdWdJbi9QbHVnaW5UZXN0LmNwcAppbmRleCBhMzgxNmM2Li4xNGQ1Mjk5IDEw MDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2lu VGVzdC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL1Bs dWdpblRlc3QuY3BwCkBAIC0yOSw2ICsyOSwxMCBAQAogI2luY2x1ZGUgPGFzc2VydC5oPgogI2lu Y2x1ZGUgPHN0cmluZy5oPgogCisjaWYgZGVmaW5lZChPU19BTkRST0lEKQorI2luY2x1ZGUgPHVu aXN0ZC5oPgorI2VuZGlmCisKIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CiBleHRlcm4gTlBOZXRzY2Fw ZUZ1bmNzICpicm93c2VyOwogCg== 115357 2011-11-16 04:36:03 -0800 2011-11-16 04:52:21 -0800 Patch 11-webkit-testnetscapeplugin-2.patch text/plain 1254 peter ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1ODE2 MjYxLi42OTRkMWRlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTEtMTEtMTYgIFBldGVyIEJldmVybG9vICA8cGV0 ZXJAY2hyb21pdW0ub3JnPgogCisgICAgICAgIEV4cGxpY2l0bHkgaW5jbHVkZSB1bmlzdGQuaCBp biBUZXN0TmV0c2NhcGVQbHVnSW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTcyMzg1CisKKyAgICAgICAgVGhpcyBpcyBuZWVkZWQgZm9yIHRoZSBzbGVl cCgpIGNhbGwgaW4gdGhlIGluZGljYXRlVGVzdEZhaWx1cmUgbWV0aG9kLAorICAgICAgICB3aGlj aCBzZWVtcyB0byBiZSBpbXBsaWNpdGx5IGF2YWlsYWJsZSBmb3Igb3RoZXIgcGxhdGZvcm1zLiBU aGlzIGlzIG5vdAorICAgICAgICB0aGUgY2FzZSBvbiBBbmRyb2lkLgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvVGVzdE5l dHNjYXBlUGx1Z0luL1BsdWdpblRlc3QuY3BwOgorCisyMDExLTExLTE2ICBQZXRlciBCZXZlcmxv byAgPHBldGVyQGNocm9taXVtLm9yZz4KKwogICAgICAgICBbQ2hyb21pdW1dIFVwZGF0ZSB0aGUg QW5kcm9pZCBOREsgdmVyc2lvbiBiZWluZyBwdWxsZWQgaW4gYnkgdXBkYXRlLXdlYmtpdC1jaHJv bWl1bQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIz ODQKIApkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0lu L1BsdWdpblRlc3QuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0lu L1BsdWdpblRlc3QuY3BwCmluZGV4IGEzODE2YzYuLjkzZTE0NTYgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9QbHVnaW5UZXN0LmNwcAorKysgYi9U b29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luVGVzdC5jcHAKQEAg LTI5LDYgKzI5LDEwIEBACiAjaW5jbHVkZSA8YXNzZXJ0Lmg+CiAjaW5jbHVkZSA8c3RyaW5nLmg+ CiAKKyNpZiBkZWZpbmVkKEFORFJPSUQpCisjaW5jbHVkZSA8dW5pc3RkLmg+CisjZW5kaWYKKwog dXNpbmcgbmFtZXNwYWNlIHN0ZDsKIGV4dGVybiBOUE5ldHNjYXBlRnVuY3MgKmJyb3dzZXI7CiAK