72369 2011-11-15 02:33:09 -0800 media/track/track-webvtt-tc003-newlines.html is flaky 2011-11-15 11:30:11 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72215 1 tonyg annacc eric.carlson webkit.review.bot oldest_to_newest 502753 0 tonyg 2011-11-15 02:33:09 -0800 media/track/track-webvtt-tc003-newlines.html has been flaky since it was introduced by r100085. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Ftrack%2Ftrack-webvtt-tc003-newlines.html I'm marking it flaky for now. 502755 1 115131 tonyg 2011-11-15 02:35:20 -0800 Created attachment 115131 Patch 502756 2 tonyg 2011-11-15 02:37:20 -0800 Committed r100257: <http://trac.webkit.org/changeset/100257> 503012 3 115191 annacc 2011-11-15 10:16:58 -0800 Created attachment 115191 Patch change guarantees tests will run in order 503024 4 115191 tonyg 2011-11-15 10:23:21 -0800 Comment on attachment 115191 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115191&action=review Thanks again for jumping on this flakiness so quickly. A couple of minor suggestions inline. > LayoutTests/media/track/track-webvtt-tc003-newlines.html:14 > + numberOfTracksLoaded++; Probably best to "var numberOfTracksLoaded = 0" up on line 9 or 10. > LayoutTests/media/track/track-webvtt-tc003-newlines.html:17 > + testTrack(1); This is a bit more future proof and the same number of lines: for (var i = 0; i < numberOfTrackTests; i++) testTrack(i); 503025 5 115193 annacc 2011-11-15 10:24:33 -0800 Created attachment 115193 Patch for landing 503092 6 115193 webkit.review.bot 2011-11-15 11:30:06 -0800 Comment on attachment 115193 Patch for landing Clearing flags on attachment: 115193 Committed r100299: <http://trac.webkit.org/changeset/100299> 503093 7 webkit.review.bot 2011-11-15 11:30:11 -0800 All reviewed patches have been landed. Closing bug. 115131 2011-11-15 02:35:20 -0800 2011-11-15 10:16:54 -0800 Patch bug-72369-20111115103519.patch text/plain 1351 tonyg U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMjU1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGI1ODdhZjcwYjZhOWRmYTU1YzE1 ODhhMWQ3ZWYyMDdjMjNhMzE2NS4uMDA5YzRhNDhiNzMwYTA4NzBhYTY4OTE0MjQ4MWQ3ODMzZWI1 ZWRkMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEwIEBACisyMDExLTExLTE1ICBUb255IEdlbnRpbGNvcmUg IDx0b255Z0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgbWVkaWEvdHJhY2svdHJhY2std2VidnR0 LXRjMDAzLW5ld2xpbmVzLmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcyMzY5CisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1 bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6IE1hcmtlZCB0ZXN0IGZsYWt5LgorCiAyMDExLTExLTE1 ICBPbGl2ZXIgVmFyZ2EgIDx2b2xpdmVyQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBVbnZp ZXdlZCBnYXJkZW5pbmcgYWZ0ZXIgcjEwMDE1OS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCBiMDQ4N2JjZDIwZDA5NDFh NWVhMWI5YjBkNTVlY2ViMmFjMDdmZDZjLi43MTBhZWNmOTY0M2NmM2FkZDE2NWY0YzU3ZWFkZmI2 OWYyMDk4N2Y2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVz dF9leHBlY3RhdGlvbnMudHh0CkBAIC0zODcwLDUgKzM4NzAsNiBAQCBCVUdXSzcyMjcxIE1BQyBE RUJVRyA6IGZhc3QvbG9hZGVyL2phdmFzY3JpcHQtdXJsLWluLWVtYmVkLmh0bWwgPSBQQVNTIENS QVNICiBCVUdXSzcyMjcyIFdJTiA6IHNlY3VyaXR5L2NyeXB0by1yYW5kb20tdmFsdWVzLXR5cGVz Lmh0bWwgPSBURVhUIFBBU1MKIAogQlVHV0s3MjI3OSA6IG1lZGlhL3RyYWNrL3RyYWNrLXdlYnZ0 dC10YzAwNC1tYWdpYy1oZWFkZXIuaHRtbCA9IFRJTUVPVVQgUEFTUworQlVHV0s3MjM2OSA6IG1l ZGlhL3RyYWNrL3RyYWNrLXdlYnZ0dC10YzAwMy1uZXdsaW5lcy5odG1sID0gVEVYVCBQQVNTCiAK IEJVR1dLNTk3NzEgV0lOIDogaHR0cC90ZXN0cy9pbnNwZWN0b3IvcmVzb3VyY2UtdHJlZS9yZXNv dXJjZS10cmVlLWZyYW1lLWFkZC5odG1sID0gVElNRU9VVCBQQVNTCg== 115191 2011-11-15 10:16:58 -0800 2011-11-15 10:24:28 -0800 Patch bug-72369-20111115101657.patch text/plain 2836 annacc U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMjg4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDNkODY5ZjAzZWU5Zjc2NjQxYTli MDlhOTFkNzA1OTk4Mzg4ZTYyMi4uMDlkMzhmMTM1NDMzNjkxNWM1NTI2MzBkMDc3MGZkYzBlZWUz ZWVhZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTExLTE1ICBBbm5hIENhdmVuZGVyICA8 YW5uYWNjQGNocm9taXVtLm9yZz4KKworICAgICAgICBHdWFyYW50ZWUgdGVzdHMgcnVuIGluIG9y ZGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIz NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG1l ZGlhL3RyYWNrL3RyYWNrLXdlYnZ0dC10YzAwMy1uZXdsaW5lcy5odG1sOgorICAgICAgICAqIHBs YXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMS0xMS0xNSAgUGhp bGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgR1RLIHJlYmFzZWxpbmUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90 cmFjay13ZWJ2dHQtdGMwMDMtbmV3bGluZXMuaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL3RyYWNr L3RyYWNrLXdlYnZ0dC10YzAwMy1uZXdsaW5lcy5odG1sCmluZGV4IDdjZGRkODBmMjQwOWY5YzQ0 YzE4MDcxYjVmZjVlNmZjZDk3MmNkNzMuLmFlMDQzNGZkMmU4MDhiMjYwOWU4ODY5N2MyODM4YTA3 NGM0NzAxYzEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLXdlYnZ0 dC10YzAwMy1uZXdsaW5lcy5odG1sCisrKyBiL0xheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNr LXdlYnZ0dC10YzAwMy1uZXdsaW5lcy5odG1sCkBAIC05LDcgKzksMTYgQEAKICAgICAgICAgICAg IAogICAgICAgICAgICAgbnVtYmVyT2ZUcmFja1Rlc3RzID0gMjsKIAotICAgICAgICAgICAgZnVu Y3Rpb24gdHJhY2tMb2FkZWQoaSkKKyAgICAgICAgICAgIGZ1bmN0aW9uIHRyYWNrTG9hZGVkKCkK KyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBudW1iZXJPZlRyYWNrc0xvYWRlZCsrOwor ICAgICAgICAgICAgICAgIGlmIChudW1iZXJPZlRyYWNrc0xvYWRlZCA9PSBudW1iZXJPZlRyYWNr VGVzdHMpIHsKKyAgICAgICAgICAgICAgICAgICAgdGVzdFRyYWNrKDApOworICAgICAgICAgICAg ICAgICAgICB0ZXN0VHJhY2soMSk7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQor CisgICAgICAgICAgICBmdW5jdGlvbiB0ZXN0VHJhY2soaSkKICAgICAgICAgICAgIHsKICAgICAg ICAgICAgICAgICBmaW5kTWVkaWFFbGVtZW50KCk7CiAgICAgICAgICAgICAgICAgdmFyIGV4cGVj dGVkID0gCkBAIC00NCw4ICs1Myw4IEBACiAgICAgPGJvZHk+CiAgICAgICAgIDxwPlRlc3RzIHRo YXQgbGluZSB0ZXJtaW5hdG9ycyBcciwgXG4sIG9yIFxyXG4gYXJlIHByb3Blcmx5IHBhcnNlZCwg ZXZlbiB3aGVuIHRoZXJlIGlzIG5vIG5ld2xpbmUgYXQgZW9mLjwvcD4KICAgICAgICAgPHZpZGVv PgotICAgICAgICAgICAgPHRyYWNrIHNyYz0iY2FwdGlvbnMtd2VidnR0L3RjMDAzLW5ld2xpbmVz LnZ0dCIgb25sb2FkPSJ0cmFja0xvYWRlZCgwKSI+Ci0gICAgICAgICAgICA8dHJhY2sgc3JjPSJj YXB0aW9ucy13ZWJ2dHQvdGMwMDMtbm8tbmV3bGluZS1hdC1lb2YudnR0IiBvbmxvYWQ9InRyYWNr TG9hZGVkKDEpIj4KKyAgICAgICAgICAgIDx0cmFjayBzcmM9ImNhcHRpb25zLXdlYnZ0dC90YzAw My1uZXdsaW5lcy52dHQiIG9ubG9hZD0idHJhY2tMb2FkZWQoKSI+CisgICAgICAgICAgICA8dHJh Y2sgc3JjPSJjYXB0aW9ucy13ZWJ2dHQvdGMwMDMtbm8tbmV3bGluZS1hdC1lb2YudnR0IiBvbmxv YWQ9InRyYWNrTG9hZGVkKCkiPgogICAgICAgICA8L3ZpZGVvPgogICAgIDwvYm9keT4KIDwvaHRt bD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKaW5kZXggNjMwNGE3Mjk4ZWUyZWNm M2RlOWZhOGZjZDE2M2VlZWU1OTZjYmE0YS4uZDcyNzY5YWVmNGFhMzc0NTExYWM2ZWY3NTc0MjI0 NjQyODQ2ZDllMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVz dF9leHBlY3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rl c3RfZXhwZWN0YXRpb25zLnR4dApAQCAtMzkyMSw3ICszOTIxLDYgQEAgQlVHV0s3MjI3MSBNQUMg REVCVUcgOiBmYXN0L2xvYWRlci9qYXZhc2NyaXB0LXVybC1pbi1lbWJlZC5odG1sID0gUEFTUyBD UkFTSAogQlVHV0s3MjI3MiBXSU4gOiBzZWN1cml0eS9jcnlwdG8tcmFuZG9tLXZhbHVlcy10eXBl cy5odG1sID0gVEVYVCBQQVNTCiAKIEJVR1dLNzIyNzkgOiBtZWRpYS90cmFjay90cmFjay13ZWJ2 dHQtdGMwMDQtbWFnaWMtaGVhZGVyLmh0bWwgPSBUSU1FT1VUIFBBU1MKLUJVR1dLNzIzNjkgOiBt ZWRpYS90cmFjay90cmFjay13ZWJ2dHQtdGMwMDMtbmV3bGluZXMuaHRtbCA9IFRFWFQgUEFTUwog CiBCVUdXSzU5NzcxIFdJTiA6IGh0dHAvdGVzdHMvaW5zcGVjdG9yL3Jlc291cmNlLXRyZWUvcmVz b3VyY2UtdHJlZS1mcmFtZS1hZGQuaHRtbCA9IFRJTUVPVVQgUEFTUwogCg== 115193 2011-11-15 10:24:33 -0800 2011-11-15 11:30:06 -0800 Patch for landing bug-72369-20111115102432.patch text/plain 2834 annacc U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMjg4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDNkODY5ZjAzZWU5Zjc2NjQxYTli MDlhOTFkNzA1OTk4Mzg4ZTYyMi4uMjNiMmQ2ZGY5NGYxZTdhZGNkOTI1NmQ2MzZhYmVjOTA3Yjky YjY2YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTExLTE1ICBBbm5hIENhdmVuZGVyICA8 YW5uYWNjQGNocm9taXVtLm9yZz4KKworICAgICAgICBHdWFyYW50ZWUgdGVzdHMgcnVuIGluIG9y ZGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIz NjkKKworICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCisKKyAgICAgICAgKiBtZWRp YS90cmFjay90cmFjay13ZWJ2dHQtdGMwMDMtbmV3bGluZXMuaHRtbDoKKyAgICAgICAgKiBwbGF0 Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTEtMTEtMTUgIFBoaWxp cHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IEdUSyByZWJhc2VsaW5lLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJh Y2std2VidnR0LXRjMDAzLW5ld2xpbmVzLmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90 cmFjay13ZWJ2dHQtdGMwMDMtbmV3bGluZXMuaHRtbAppbmRleCA3Y2RkZDgwZjI0MDlmOWM0NGMx ODA3MWI1ZmY1ZTZmY2Q5NzJjZDczLi5hZTA0MzRmZDJlODA4YjI2MDllODg2OTdjMjgzOGEwNzRj NDcwMWMxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay13ZWJ2dHQt dGMwMDMtbmV3bGluZXMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay13 ZWJ2dHQtdGMwMDMtbmV3bGluZXMuaHRtbApAQCAtOSw3ICs5LDE2IEBACiAgICAgICAgICAgICAK ICAgICAgICAgICAgIG51bWJlck9mVHJhY2tUZXN0cyA9IDI7CiAKLSAgICAgICAgICAgIGZ1bmN0 aW9uIHRyYWNrTG9hZGVkKGkpCisgICAgICAgICAgICBmdW5jdGlvbiB0cmFja0xvYWRlZCgpCisg ICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgbnVtYmVyT2ZUcmFja3NMb2FkZWQrKzsKKyAg ICAgICAgICAgICAgICBpZiAobnVtYmVyT2ZUcmFja3NMb2FkZWQgPT0gbnVtYmVyT2ZUcmFja1Rl c3RzKSB7CisgICAgICAgICAgICAgICAgICAgIHRlc3RUcmFjaygwKTsKKyAgICAgICAgICAgICAg ICAgICAgdGVzdFRyYWNrKDEpOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIH0KKwor ICAgICAgICAgICAgZnVuY3Rpb24gdGVzdFRyYWNrKGkpCiAgICAgICAgICAgICB7CiAgICAgICAg ICAgICAgICAgZmluZE1lZGlhRWxlbWVudCgpOwogICAgICAgICAgICAgICAgIHZhciBleHBlY3Rl ZCA9IApAQCAtNDQsOCArNTMsOCBAQAogICAgIDxib2R5PgogICAgICAgICA8cD5UZXN0cyB0aGF0 IGxpbmUgdGVybWluYXRvcnMgXHIsIFxuLCBvciBcclxuIGFyZSBwcm9wZXJseSBwYXJzZWQsIGV2 ZW4gd2hlbiB0aGVyZSBpcyBubyBuZXdsaW5lIGF0IGVvZi48L3A+CiAgICAgICAgIDx2aWRlbz4K LSAgICAgICAgICAgIDx0cmFjayBzcmM9ImNhcHRpb25zLXdlYnZ0dC90YzAwMy1uZXdsaW5lcy52 dHQiIG9ubG9hZD0idHJhY2tMb2FkZWQoMCkiPgotICAgICAgICAgICAgPHRyYWNrIHNyYz0iY2Fw dGlvbnMtd2VidnR0L3RjMDAzLW5vLW5ld2xpbmUtYXQtZW9mLnZ0dCIgb25sb2FkPSJ0cmFja0xv YWRlZCgxKSI+CisgICAgICAgICAgICA8dHJhY2sgc3JjPSJjYXB0aW9ucy13ZWJ2dHQvdGMwMDMt bmV3bGluZXMudnR0IiBvbmxvYWQ9InRyYWNrTG9hZGVkKCkiPgorICAgICAgICAgICAgPHRyYWNr IHNyYz0iY2FwdGlvbnMtd2VidnR0L3RjMDAzLW5vLW5ld2xpbmUtYXQtZW9mLnZ0dCIgb25sb2Fk PSJ0cmFja0xvYWRlZCgpIj4KICAgICAgICAgPC92aWRlbz4KICAgICA8L2JvZHk+CiA8L2h0bWw+ ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CmluZGV4IDYzMDRhNzI5OGVlMmVjZjNk ZTlmYThmY2QxNjNlZWVlNTk2Y2JhNGEuLmQ3Mjc2OWFlZjRhYTM3NDUxMWFjNmVmNzU3NDIyNDY0 Mjg0NmQ5ZTMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3Rf ZXhwZWN0YXRpb25zLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQKQEAgLTM5MjEsNyArMzkyMSw2IEBAIEJVR1dLNzIyNzEgTUFDIERF QlVHIDogZmFzdC9sb2FkZXIvamF2YXNjcmlwdC11cmwtaW4tZW1iZWQuaHRtbCA9IFBBU1MgQ1JB U0gKIEJVR1dLNzIyNzIgV0lOIDogc2VjdXJpdHkvY3J5cHRvLXJhbmRvbS12YWx1ZXMtdHlwZXMu aHRtbCA9IFRFWFQgUEFTUwogCiBCVUdXSzcyMjc5IDogbWVkaWEvdHJhY2svdHJhY2std2VidnR0 LXRjMDA0LW1hZ2ljLWhlYWRlci5odG1sID0gVElNRU9VVCBQQVNTCi1CVUdXSzcyMzY5IDogbWVk aWEvdHJhY2svdHJhY2std2VidnR0LXRjMDAzLW5ld2xpbmVzLmh0bWwgPSBURVhUIFBBU1MKIAog QlVHV0s1OTc3MSBXSU4gOiBodHRwL3Rlc3RzL2luc3BlY3Rvci9yZXNvdXJjZS10cmVlL3Jlc291 cmNlLXRyZWUtZnJhbWUtYWRkLmh0bWwgPSBUSU1FT1VUIFBBU1MKIAo=